aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/adapters
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Remove unneccessary special case for money in quotingSean Griffin2014-07-031-0/+24
| | | |
* | | | Merge pull request #16036 from sgrif/sg-datetime-infinityRafael Mendonça França2014-07-031-0/+44
|\ \ \ \ | | | | | | | | | | Do not rely on the column type when quoting infinity
| * | | | Do not rely on the column type when quoting infinitySean Griffin2014-07-031-0/+44
| |/ / /
* / / / Use the type object for type casting HStore columnsSean Griffin2014-07-031-11/+5
|/ / /
* | | Quote range strings when quoting PG rangesSean Griffin2014-07-022-1/+18
| | | | | | | | | | | | | | | The test case for CVE-2014-3483 doesn't actually send the generated SQL to the database. The generated SQL is actually invalid for real inputs.
* | | Fix SQL injection when querying against ranges and bitstringsRafael Mendonça França2014-07-021-0/+11
|/ / | | | | | | Fix CVE-2014-3483 and protect against CVE-2014-3482.
* | Use the type object for sending JSON to the databaseSean Griffin2014-06-291-1/+1
| |
* | Always pass a column with a type object to quoteSean Griffin2014-06-281-2/+2
| | | | | | | | | | | | | | | | The only case where we got a column that was not `nil`, but did not respond to `cast_type` was when type casting the default value during schema creation. We can look up the cast type, and add that object to the column definition. Will allow us to consistently rely on the type objects for type casting in all directions.
* | [Postgresql tests] remove duplicate helperAbdelkader Boudih2014-06-281-12/+3
| |
* | Consolidate testing of update_all type castingSean Griffin2014-06-263-30/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We have several test cases on "tricky" types that are essentially testing that `update_all` goes through the same type casting behavior as a normal assignment + save. We recently had another case to add this test for another type in https://github.com/rails/rails/pull/12742. Rather than testing this separately for every type which is "tricky" when round tripping, let's instead have a fairly exhaustive test that ensures we're getting the correct values at every step for `update_all`. Given the structure of the code now, we can be confident that if the type is correct, and `update_all` is type casting correctly, we're going to get the right behavior for all types.
* | Reconnect after possibly enabling hstoreMatthew Draper2014-06-181-0/+2
| |
* | Merge pull request #15782 from sgrif/sg-column-defaultsMatthew Draper2014-06-188-24/+13
|\ \ | | | | | | Don't type cast the default on the column
| * | Don't type cast the default on the columnSean Griffin2014-06-178-24/+13
| | | | | | | | | | | | | | | | | | | | | If we want to have type decorators mess with the attribute, but not the column, we need to stop type casting on the column. Where possible, we changed the tests to test the value of `column_defaults`, which is public API. `Column#default` is not.
* | | Detect in-place changes on point typesSean Griffin2014-06-171-0/+11
| | |
* | | Enable hstore in array testsSean Griffin2014-06-171-0/+6
| | |
* | | Detect mutations of arrays and array membersSean Griffin2014-06-171-0/+23
| | |
* | | Ensure `OID::Array#type_cast_for_database` matches PG's quoting behaviorSean Griffin2014-06-172-0/+33
|/ / | | | | | | | | | | Also takes a step towards supporting types which use a character other than ',' for the delimiter (`box` is the only built in type for which this is the case)
* | Don't assume that Hstore columns have always changedSean Griffin2014-06-172-1/+3
| | | | | | | | | | | | | | | | | | HStore columns come back from the database separated by a comma and a space, not just a comma. We need to mirror that behavior since we compare the two values. Also adds a regression test against JSON to ensure we don't have the same bug there.
* | Merge pull request #15674 from sgrif/sg-mutable-attributesMatthew Draper2014-06-142-0/+29
|\ \ | | | | | | Detect in-place changes on mutable AR attributes
| * | Detect in-place changes on mutable AR attributesSean Griffin2014-06-132-0/+29
| | | | | | | | | | | | | | | | | | We have several mutable types on Active Record now. (Serialized, JSON, HStore). We need to be able to detect if these have been modified in place.
* | | Merge pull request #15593 from sgrif/sg-attributeRafael Mendonça França2014-06-131-1/+1
|\ \ \ | | | | | | | | Introduce an Attribute object to handle the type casting dance
| * | | Introduce an Attribute object to handle the type casting danceSean Griffin2014-06-131-1/+1
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's a lot more that can be moved to these, but this felt like a good place to introduce the object. Plans are: - Remove all knowledge of type casting from the columns, beyond a reference to the cast_type - Move type_cast_for_database to these objects - Potentially make them mutable, introduce a state machine, and have dirty checking handled here as well - Move `attribute`, `decorate_attribute`, and anything else that modifies types to mess with this object, not the columns hash - Introduce a collection object to manage these, reduce allocations, and not require serializing the types
* / / PG arrays should type cast user inputSean Griffin2014-06-131-2/+7
|/ / | | | | | | | | | | We guarantee that `model.value` does not change after `model.save && model.reload`. This requires type casting user input for non-string types.
* | Silence warnings in tests.Sean Griffin2014-06-101-1/+1
| | | | | | | | | | | | | | | | ``` activerecord/test/cases/adapters/postgresql/range_test.rb:159: warning: (...) interpreted as grouped expression activerecord/test/cases/finder_test.rb:38: warning: shadowing outer local variable - e activerecord/test/cases/finder_test.rb:43: warning: shadowing outer local variable - e ```
* | Rename `type_cast` to `type_cast_from_database`Sean Griffin2014-06-097-27/+27
| | | | | | | | | | | | | | | | In some cases there is a difference between the two, we should always be doing one or the other. For convenience, `type_cast` is still a private method on type, so new types that do not need different behavior don't need to implement two methods, but it has been moved to private so it cannot be used accidentally.
* | Merge pull request #15587 from sgrif/sg-remove-workaroundRafael Mendonça França2014-06-091-15/+8
|\ \ | | | | | | Remove workaround for non-lazy serialize in tests
| * | Remove workaround for non-lazy serialize in testsSean Griffin2014-06-091-15/+8
| | | | | | | | | | | | `serialize` is now lazy, so the workaround is no longer needed.
* | | Make `_before_type_cast` actually be before type castSean Griffin2014-06-093-1/+7
|/ / | | | | | | | | | | | | | | | | | | | | | | | | - The following is now true for all types, all the time - `model.attribute_before_type_cast == given_value` - `model.attribute == model.save_and_reload.attribute` - `model.attribute == model.dup.attribute` - `model.attribute == YAML.load(YAML.dump(model)).attribute` - Removes the remaining types implementing `type_cast_for_write` - Simplifies the implementation of time zone aware attributes - Brings tz aware attributes closer to being implemented as an attribute decorator - Adds additional point of control for custom types
* | Ensure time zones don't change after round trip with array columnsSean Griffin2014-06-071-0/+2
| | | | | | | | | | The times would be equivalent, even if they were in different time zones. E.g. 12:00 UTC == 5:00 PDT
* | Don't rely on `Time.current` in testsSean Griffin2014-06-071-5/+10
| | | | | | | | Millisecond inequality causes failures on Travis
* | Add array support when time zone aware attributes are enabledSean Griffin2014-06-071-0/+16
| |
* | serialized Type should delegate `type_cast_for_write` to underlying TypeYves Senn2014-06-061-0/+35
| | | | | | | | | | | | | | This adds a regression test for #14411, which was fixed by #15503. Closes #14411 Closes #14595
* | Merge pull request #15503 from sgrif/sg-json-hstore-storageYves Senn2014-06-062-0/+18
|\ \ | | | | | | Bring type casting behavior of hstore/json in line with serialized
| * | Bring type casting behavior of hstore/json in line with serializedSean Griffin2014-06-042-0/+18
| | | | | | | | | | | | | | | `@raw_attributes` should not contain the type-cast, mutable version of the value.
* | | Fix behavior of handling BC era dates.edogawaconan2014-06-051-0/+12
|/ / | | | | | | BC era year is (astronomical year + 1) and starts from 1 BC.
* | force table creationAaron Patterson2014-06-031-2/+3
| |
* | Revert "test pg, we don't care about the internal state of `column#default`."Yves Senn2014-06-037-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "test pg, remove unused column assignments. Follow up to 254cdf47" Related to #15492 This reverts commit 254cdf4728291277f3fbaa854f34495030e476b4. This reverts commit 4bcf9029452e0c760af04faab6b549710401e8cf. There are public methods that assume `Column#default` is type casted. The return value of `Column#default` is publicly relevant and should not change. /cc @sgrif
* | test pg, remove unused column assignments. Follow up to 254cdf47Yves Senn2014-06-035-12/+0
| |
* | pg, preserve money type when dumping schema and extract money default.Yves Senn2014-06-032-9/+25
| |
* | test pg, rm unused requires.Yves Senn2014-06-0311-27/+0
| |
* | Respect limit for PG bit stringsSean Griffin2014-06-031-8/+8
| |
* | pg, preserve type when schema dumping bit and bit varying columns.Yves Senn2014-06-031-8/+8
| |
* | test pg, move bit string type tests into `bit_string_test.rb`.Yves Senn2014-06-032-34/+80
| |
* | test pg, we don't care about the internal state of `column#default`.Yves Senn2014-06-035-9/+0
| | | | | | | | | | That data is internal to Active Record. What we care about is that new records have the right default value.
* | pg, preserve point type when schema dumping.Yves Senn2014-06-031-8/+8
| |
* | pg test, examples for default values and schema dumping of point types.Yves Senn2014-06-031-0/+21
| | | | | | | | /cc @sgrif
* | test pg, add basic test cases for point datatype.Yves Senn2014-06-021-0/+45
| |
* | Remove most code related to serialized propertiesSean Griffin2014-06-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | Nearly completely implemented in terms of custom properties. `_before_type_cast` now stores the raw serialized string consistently, which removes the need to keep track of "state". The following is now consistently true: - `model.serialized == model.reload.serialized` - A model can be dumped and loaded infinitely without changing - A model can be saved and reloaded infinitely without changing
* | pg, support default values for enum types. Closes #7814.Yves Senn2014-05-301-0/+11
| | | | | | | | | | This is an intermediate solution. It is related to the refactoring @sgrif is making and will change in the future.
* | pg, `default_sequence_name` respects schema. Closes #7516.Yves Senn2014-05-301-8/+6
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-23 11:57:57 +0000