aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/adapters
Commit message (Collapse)AuthorAgeFilesLines
* Fix typo in test name and documentationVipul A M2013-05-201-1/+1
|
* Merge pull request #10619 from alno/top_level_array_in_postgres_jsonAaron Patterson2013-05-161-0/+14
|\ | | | | Support array as root element in Postgresql JSON columns
| * Support array as root element in JSONAlexey Noskov2013-05-141-0/+14
| |
* | add failing test exposing mysql adapter tinyint bugphinze2013-05-151-3/+16
|/ | | | | | in myself, a column with type TINYINT(N) where N > 1 can be used to represent an integer, but the rails mysql adapter refuses to interpret as anything but a boolean.
* Merge pull request #10556 from Empact/deprecate-schema-statements-distinctRafael Mendonça França2013-05-121-12/+24
| | | | | | Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc. Conflicts: activerecord/CHANGELOG.md
* Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT"Ben Woosley2013-05-101-0/+34
| | | | | | | | | | | | The combination of a :uniq => true association and the #distinct call in #construct_limited_ids_condition combine to create invalid SQL, because we're explicitly selecting DISTINCT, and also sending #distinct on to AREL, via the relation#distinct_value. Rather than build a select distinct clause in #construct_limited_ids_condition, I set #distinct! and pass just the columns into the select statement. This requires introducing a #columns_for_distinct method to return the select columns but not the statement itself.
* fix to remove warning on postgres adapter test.Akshay Khole2013-05-051-1/+1
| | | | | Warning was: "/vagrant/rails/activerecord/test/cases/adapters/postgresql/uuid_test.rb:63: warning: ambiguous first argument; put parentheses or even spaces"
* Merge pull request #10458 from bwbuchanan/issue-10451Rafael Mendonça França2013-05-041-0/+12
|\ | | | | Make SchemaDumper emit "id: :uuid" when using UUID primary keys
| * Make SchemaDumper emit "id: :uuid" when appropriate. Fixes #10451.Brian Buchanan2013-05-031-0/+12
| |
* | Squashed commit of the following:Aaron Patterson2013-05-031-2/+0
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | commit 2683de5da85135e8d9fe48593ff6167db9d64b18 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri May 3 11:29:20 2013 -0700 cannot support infinite ranges right now commit cebb6acef2c3957f975f6db4afd849e535126253 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri May 3 11:26:12 2013 -0700 reverting infinity comparison commit 385f7e6b4efd1bf9b89e8d607fcb13e5b03737ea Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri May 3 11:23:28 2013 -0700 Revert "Added ability to compare date/time with infinity" This reverts commit 38f28dca3aa16efd6cc3af6453f2e6b9e9655ec1. Conflicts: activesupport/CHANGELOG.md activesupport/lib/active_support/core_ext/numeric/infinite_comparable.rb activesupport/test/core_ext/date_ext_test.rb activesupport/test/core_ext/date_time_ext_test.rb activesupport/test/core_ext/numeric_ext_test.rb activesupport/test/core_ext/time_ext_test.rb activesupport/test/core_ext/time_with_zone_test.rb commit 0d799a188dc12b18267fc8421675729917610047 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri May 3 11:18:53 2013 -0700 Revert "Refactor infinite comparable definition a bit" This reverts commit dd3360e05e4909f2f0c74a624cccc2def688f828. commit 42dec90e49745bbfae546f0560b8783f6b48b074 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri May 3 11:18:47 2013 -0700 Revert "Require 'active_support/core_ext/module/aliasing' in the infinite_comparable module" This reverts commit 7003e71c13c53ec3d34250560fbf80b8381df693.
* Fix broken mysql testJon Leighton2013-05-032-32/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | test_mysql_integer_not_null_defaults in test/cases/defaults_test.rb was failing. This test relies on the connection being in strict mode. By default a new connection is not in strict mode, but Active Record automatically places it in strict mode. ActiveSchemaTest overwrites the connection's #execute method in order to prevent SQL statements from actually being executed. One of the operations which is performed in ActiveSchema test is a #recreate_database. Since 2088bf27981137a2c6c8b2f718f33b417b4045af, recreate_database on mysql or mysql2 will trigger a reconnect. Due to the implementation of the hacking of #execute in ActiveSchemaTest, this reconnect would take place, but the connection would *not* be placed in strict mode because #execute had been overridden to prevent SQL queries hitting the database. Therefore, after ActiveSchemaTest, the connection would no longer be in strict mode, causing test_mysql_integer_not_null_defaults to fail. I don't think that the way that ActiveSchemaTest is implemented is particularly nice or clean, but I have taken steps to make its hacks more isolated - it now create a separate connection object which is thrown away after the test, and the hacks are applied on the singleton class of this object.
* Improve docs for postgresql with uuid primary keys [ci skip]Carlos Antonio da Silva2013-05-011-1/+0
| | | | Introduced in 09ac1776abc0d3482f491f2d49f47bcb3d9a4ad7.
* allow override of uuid_generate_v4() default by passing default: nilChad Moone2013-05-011-0/+31
| | | | without this, it's not possible to use UUID primary keys without uuid-ossp installed and activated
* Fix loading of fixtures when the column type is a postgres array of strings.Chris Constantine2013-04-181-0/+6
| | | | - A string in an array of strings that has a quote char (') needs to have that quote char escaped if the array is getting wrapped in quote chars.
* Revert "Merge pull request #10043 from cconstantine/master"Rafael Mendonça França2013-04-181-6/+0
| | | | | | | This reverts commit 521035af530482d6d9ad2dae568eaeb0ab188e1c, reversing changes made to 222011dbee842bbc60d3aaaa3145356b90a30fd1. Reason: This broke the tests
* Merge pull request #10043 from cconstantine/masterRafael Mendonça França2013-04-181-0/+6
|\ | | | | DB with postgres string array column doesn't load fixtures well
| * Fix loading of string arrays in postgresChris Constantine2013-04-081-0/+6
| |
* | let EXPLAIN use a thread locals registry [John J. Wang & Xavier Noria]Xavier Noria2013-04-161-7/+0
| | | | | | | | Closes #10198.
* | Fix #7619. 0x prefix must be added when assigning hexadecimal string into ↵kennyj2013-04-171-1/+7
| | | | | | | | bit column in Postgresql, because solving ambiguity.
* | Revert "fixing bit string test"kennyj2013-04-161-3/+3
| | | | | | | | | | | | This reverts commit cdd293cb963b895ff580eb20d10f5d56ecb3d447. Reason: This wasn't properly fix.
* | fix for the bytea/binary nil value bugMatt Aimonetti2013-04-141-1/+1
| |
* | added a test suite for the postgres binary typeMatt Aimonetti2013-04-141-0/+87
|/ | | | this shows a problem with nil values
* each to each_value; remove unused varsVipul A M2013-04-071-2/+2
|
* fix detect column type of enummasarakki2013-04-012-2/+2
| | | | enum includes text or blob or ... hooked by wrong regex
* added comments to test_invalid_type in sqlite3 adapter test and added ↵Ranjay Krishna2013-03-281-0/+4
| | | | valid_type? method to abstract_adapter.rb and removed unnecessary method from sqlite3 adapter
* Add support for FULLTEXT and SPATIAL indexes using the :type flag for MySQL.Ken Mazaika2013-03-274-30/+46
|
* Merge pull request #9876 from macksmind/restore_cols_dropped_by_hstore_testRafael Mendonça França2013-03-261-15/+5
|\ | | | | Restore columns dropped by hstore test
| * Combine tests and restore columns dropped by hstore testingMack Earnhardt2013-03-261-15/+5
| | | | | | | | | | Disabling the hstore extension during testing created order dependent test failures.
* | Checks :algorithm argument for valid valuesDan McClain2013-03-263-0/+11
| |
* | Adds support for concurrent indexing in PostgreSQL adapterDan McClain2013-03-253-21/+33
| | | | | | | | | | | | | | | | Adds support for algorithm option in MySQL indexes Moves USING and algorithm options upstream The syntax is still specific to the Adapter, so the actual executed string happens in the corresponding adapter
* | Created a layer of abstraction for the valid type checking in schema dumper. ↵Ranjay Krishna2013-03-253-0/+27
| | | | | | | | Now, connection handles the check for valid types so that each database can handle the changes individually.
* | Merge branch 'jlxw-patch-2'Rafael Mendonça França2013-03-231-0/+4
|\ \ | | | | | | | | | Closes #9184
| * | Fix regex to strip quotations from hstore valuesjlxw2013-03-231-0/+4
| | | | | | | | | | | | Previously regex did not strip quotation marks where hstore values were multi-line strings.
* | | Custom index type support with :using.doabit2013-03-246-5/+87
|/ /
* | add uuid primary key supportAaron Patterson2013-03-221-0/+10
| |
* | Merge pull request #9866 from choudhuryanupam/fix_connection_testCarlos Antonio da Silva2013-03-221-1/+1
|\ \ | | | | | | Removed unused loop variable
| * | Removed unused loop variableAnupam Choudhury2013-03-221-1/+1
| | |
* | | Removed unnecessary blockAnupam Choudhury2013-03-221-2/+1
| |/ |/|
* | Delete failing testJon Leighton2013-03-221-36/+0
|/ | | | | | | | | | | | I don't think this is testing anything useful, and the test code is exceedingly brittle. It is broken since 34c7e73c1def1312e59ef1f334586ff2f668246e because the test code makes assumptions about the implementation of PostgreSQLAdapter#active? which are incorrect after the commit. I could fix this test but it would be even more brittle (by stubbing the underlying @connection.connect_poll) and it doesn't test any complex logic. I conclude that it's not worth it.
* Fix copy table index test; Change == to ! on false in travis.rbVipul A M2013-03-211-1/+1
|
* Removed unnecessary blockAnupam Choudhury2013-03-201-2/+1
|
* sets limit 191 for schema_migrations#version in mysql2 if the encoding is ↵Xavier Noria2013-03-171-0/+26
| | | | | | "utf8mb4" Please, see rationale in the included CHANGELOG patch.
* Merge pull request #9686 from strzalek/cast_number_to_string_in_pgJon Leighton2013-03-151-0/+8
|\ | | | | Cast number to string in Postgres
| * Cast number to string in PostgresŁukasz Strzałkowski2013-03-121-0/+8
| | | | | | | | fixes #9170
* | you can provide uuid_generate_v4 as the default value for uuid columnsAaron Patterson2013-03-141-0/+43
| |
* | MOAR cleanups.Vipul A M2013-03-141-1/+0
|/
* Pass column to quote when copying a sqlite table.Matthew M. Boedicker2013-03-111-1/+5
| | | | To make quote escape binary data correctly it needs the column passed in.
* `Connection#structure_dump` is no longer used. #9518Yves Senn2013-03-063-16/+0
| | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base.
* Fix PostgreSQL TIMESTAMP WITH TIME ZONE to return ActiveSupport::TimeTroy Kruthoff2013-03-011-0/+2
| | | | | | | | | | In an AR model a timestamptz attribute would return a ruby string and AR tests did not check for any type casting. Previous tests would pass only because an assert_equal was being used on a Time.utc object, which will parse the right side of the eq to a valid Time instance for comparision. switch to test instance of Time instead of ActiveSupport::TimeWithZone
* Wrong exception is occured when raising no translatable exceptionkennyj2013-03-011-0/+6
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 19:37:46 +0000