Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use frozen-string-literal in ActiveRecord | Kir Shatrov | 2017-07-19 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Merge pull request #29540 from kirs/rubocop-frozen-string | Matthew Draper | 2017-07-02 | 1 | -0/+1 |
|\ | | | | | | | Enforce frozen string in Rubocop | ||||
| * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | | |||||
* | | Make ActiveRecord frozen string literal friendly. | Pat Allan | 2017-06-20 | 1 | -1/+1 |
|/ | |||||
* | Define path with __dir__ | bogdanvlviv | 2017-05-23 | 1 | -1/+1 |
| | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f | ||||
* | Suppress `WARNING: nonstandard use of \\ in a string literal` warning | Yasuo Honda | 2017-03-22 | 1 | -0/+1 |
| | | | | by setting `escape_string_warning = off` | ||||
* | Refactor `ColumnDefinition` to contain `options` hash | Ryuta Kamizono | 2017-02-09 | 1 | -2/+2 |
| | | | | | | Column options are passed as an hash args then used as `options` hash in `add_column_options!`. Converting args to attributes is inconvinient for using options as an hash. | ||||
* | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6." | Akira Matsuda | 2016-12-25 | 1 | -4/+4 |
| | |||||
* | applies new string literal convention in activerecord/test | Xavier Noria | 2016-08-06 | 1 | -12/+12 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | add test case for schema dumping of PG bytea columns. | Yves Senn | 2016-03-08 | 1 | -0/+9 |
| | |||||
* | make it possible to run AR tests with bin/test | Yves Senn | 2015-06-11 | 1 | -1/+1 |
| | |||||
* | prefer `drop_table if_exists: true` over raw SQL. | Yves Senn | 2015-02-18 | 1 | -1/+1 |
| | | | | | | | /cc @yahonda This makes it easier for third party adapters to run our tests, even if that database does not support IF EXISTS. | ||||
* | `Type#type_cast_from_database` -> `Type#deserialize` | Sean Griffin | 2015-02-17 | 1 | -3/+3 |
| | |||||
* | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵ | Vipul A M | 2015-02-03 | 1 | -1/+0 |
| | | | | onwards. | ||||
* | Remove most type related predicates from `Column` | Sean Griffin | 2015-01-30 | 1 | -3/+4 |
| | | | | | | Remaining are `limit`, `precision`, `scale`, and `type` (the symbol version). These will remain on the column, since they mirror the options to the `column` method in the schema definition DSL | ||||
* | pg tests, get rid of `sql_types_test.rb`. | Yves Senn | 2014-11-07 | 1 | -0/+7 |
| | |||||
* | pg tests, only execute what's necessary. | Yves Senn | 2014-11-07 | 1 | -1/+1 |
| | |||||
* | Rename `type_cast` to `type_cast_from_database` | Sean Griffin | 2014-06-09 | 1 | -3/+3 |
| | | | | | | | | In some cases there is a difference between the two, we should always be doing one or the other. For convenience, `type_cast` is still a private method on type, so new types that do not need different behavior don't need to implement two methods, but it has been moved to private so it cannot be used accidentally. | ||||
* | test pg, rm unused requires. | Yves Senn | 2014-06-03 | 1 | -3/+0 |
| | |||||
* | test, use `columns_hash[]` in place of `columns.find {}`. | Yves Senn | 2014-05-12 | 1 | -1/+1 |
| | |||||
* | Remove warning of unused variable | Rafael Mendonça França | 2014-04-10 | 1 | -1/+1 |
| | |||||
* | Use connection-specific bytea escaping | Matthew Draper | 2014-04-08 | 1 | -0/+17 |
| | | | | | | | | | | In our normal usage, it's rare for this to make a difference... but is more technically correct. As well as a spec that proves this is a good idea, let's also add a more sane-looking one that just covers basic to_sql functionality. There aren't many places where we actually use escape_bytea, but that's one that won't be going away. | ||||
* | Use teardown helper method. | Guo Xiang Tan | 2014-03-14 | 1 | -1/+1 |
| | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14348 Ensure that SQLCounter.clear_log is called after each test. This is a step to prevent side effects when running tests. This will allow us to run them in random order. | ||||
* | using assert_not instead of refute | Rajarshi Das | 2013-08-13 | 1 | -3/+3 |
| | |||||
* | the typecast value should be passed to the serializer. fixes #10830 | Aaron Patterson | 2013-06-05 | 1 | -1/+0 |
| | |||||
* | adding a test for #10830 | Aaron Patterson | 2013-06-05 | 1 | -0/+18 |
| | | | | | Conflicts: activerecord/test/cases/adapters/postgresql/bytea_test.rb | ||||
* | fix for the bytea/binary nil value bug | Matt Aimonetti | 2013-04-14 | 1 | -1/+1 |
| | |||||
* | added a test suite for the postgres binary type | Matt Aimonetti | 2013-04-14 | 1 | -0/+87 |
this shows a problem with nil values |