Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove unnecessary `respond_to?(:report_on_exception)` checking | yuuji.yaginuma | 2018-03-02 | 1 | -2/+2 |
| | | | | Since Rails 6 requires Ruby 2.4.1+. | ||||
* | Deprecate update_attributes and update_attributes! | Eddie Lebow | 2018-02-17 | 1 | -2/+2 |
| | | | | Closes #31998 | ||||
* | Suppress expected exceptions by `report_on_exception` = `false` | Yasuo Honda | 2017-12-14 | 1 | -0/+2 |
| | | | | Follow up #31428 to address similar exceptions with mysql2 adapter | ||||
* | Add new error class `QueryCanceled` which will be raised when canceling ↵ | Ryuta Kamizono | 2017-11-27 | 1 | -0/+27 |
| | | | | | | | | | | | | | | | statement due to user request (#31235) This changes `StatementTimeout` to `QueryCanceled` for PostgreSQL. In MySQL, errno 1317 (`ER_QUERY_INTERRUPTED`) is only used when the query is manually cancelled. But in PostgreSQL, `QUERY_CANCELED` error code (57014) which is used `StatementTimeout` is also used when the both case. And, we can not tell which reason happened. So I decided to introduce new error class `QueryCanceled` closer to the error code name. | ||||
* | Rename `TransactionTimeout` to more descriptive `LockWaitTimeout` (#31223) | Ryuta Kamizono | 2017-11-27 | 1 | -2/+2 |
| | | | | | | Since #31129, new error class `StatementTimeout` has been added. `TransactionTimeout` is caused by the timeout shorter than `StatementTimeout`, but its name is too generic. I think that it should be a name that understands the difference with `StatementTimeout`. | ||||
* | Add new error class `StatementTimeout` which will be raised when statement ↵ | Ryuta Kamizono | 2017-11-13 | 1 | -0/+29 |
| | | | | | | | | | | | | timeout exceeded (#31129) We are sometimes using The MAX_EXECUTION_TIME hint for MySQL depending on the situation. It will prevent catastrophic performance down by wrong performing queries. The new error class `StatementTimeout` will make to be easier to handle that case. https://dev.mysql.com/doc/refman/5.7/en/optimizer-hints.html#optimizer-hints-execution-time | ||||
* | Raise `TransactionTimeout` when lock wait timeout exceeded for PG adapter | Ryuta Kamizono | 2017-11-11 | 1 | -1/+1 |
| | | | | Follow up of #30360. | ||||
* | Should test actual error which is raised from the database | Ryuta Kamizono | 2017-11-11 | 1 | -1/+23 |
| | |||||
* | Add TransactionTimeout for MySQL error code 1205 | Gabriel Courtemanche | 2017-08-22 | 1 | -0/+6 |
| | |||||
* | Use frozen-string-literal in ActiveRecord | Kir Shatrov | 2017-07-19 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | abort_on_exception can't be disabled for a single thread | Matthew Draper | 2016-11-27 | 1 | -2/+4 |
| | | | | | If it's enabled globally, it's on regardless of how individual threads are set. | ||||
* | We expect exceptions; abort will just raise in the wrong place | Matthew Draper | 2016-11-27 | 1 | -9/+13 |
| | |||||
* | applies new string literal convention in activerecord/test | Xavier Noria | 2016-08-06 | 1 | -6/+6 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | The problem isn't the detection but the deadlock itself | David Heinemeier Hansson | 2016-08-04 | 1 | -2/+2 |
| | |||||
* | Introduce new ActiveRecord transaction error classes | Erol Fornoles | 2016-05-24 | 1 | -20/+13 |
| | |||||
* | Add AR::TransactionSerializationError for transaction serialization failures ↵ | Erol Fornoles | 2016-05-21 | 1 | -0/+62 |
or deadlocks |