Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | DRY up our regular expression | Aaron Patterson | 2010-09-27 | 1 | -3/+3 |
| | |||||
* | reduce method calls in the dynamic finder matcher | Aaron Patterson | 2010-09-27 | 1 | -4/+4 |
| | |||||
* | make sure we use the engine assigned to the table when quoting | Aaron Patterson | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Fix for nested_attributes with has_many association fails when a single ↵ | Neeraj Singh | 2010-09-27 | 1 | -1/+6 |
| | | | | | | | | record is being updated. [#5705 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-27 | 1 | -3/+3 |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb | ||||
| * | Prevent shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -3/+3 |
| | | |||||
* | | Three performance improvements: | Neeraj Singh | 2010-09-27 | 1 | -10/+9 |
|/ | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation | ||||
* | third parameter is not used | Aaron Patterson | 2010-09-26 | 1 | -1/+1 |
| | |||||
* | db:structure:dump should list current Rails.env adapter in errors, not ↵ | Nic Benders | 2010-09-26 | 1 | -1/+1 |
| | | | | | | | | always the test adapter [#5710 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Fix remove_index issue when provided :name is a symbol | Tim Connor | 2010-09-26 | 1 | -1/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add namespacing for observer generator | Piotr Sarnacki | 2010-09-25 | 1 | -0/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Generators fix: properly check if module should be created when creating a ↵ | Piotr Sarnacki | 2010-09-25 | 1 | -1/+1 |
| | | | | | | namespaced model Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Delegate ActiveRecord::Base.offset to scoped methods (analogous to limit) ↵ | Marcelo Giorgi | 2010-09-24 | 1 | -1/+1 |
| | | | | | | [#5688 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Fix warning message when db/schema.rb doesn't exist [#5625 state:resolved] | Brian Candler | 2010-09-24 | 1 | -1/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Refactor namespaced generators to use module_namespacing block helper | Piotr Sarnacki | 2010-09-24 | 3 | -2/+6 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Generators are not aware of namespace of isolated engines and applications | Piotr Sarnacki | 2010-09-24 | 1 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | restore behavior of touch for models without :updated_xx [#5439 state:resolved] | tnp | 2010-09-24 | 1 | -3/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | reject_id option should be respected while using nested_attributes | Neeraj Singh | 2010-09-24 | 1 | -3/+3 |
| | | | | | | [#5579 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | switch present in favor of empty | Aaron Patterson | 2010-09-22 | 1 | -1/+1 |
| | |||||
* | Refactor association_collection uniq method. | Emilio Tagua | 2010-09-22 | 1 | -4/+3 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | No need to use inject here. | Emilio Tagua | 2010-09-22 | 1 | -5/+5 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Perf: refactor method. | Emilio Tagua | 2010-09-22 | 1 | -11/+8 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | No need to use inject here, use map instead. | Emilio Tagua | 2010-09-22 | 1 | -4/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Goodbye inject, hello map. | Emilio Tagua | 2010-09-22 | 1 | -7/+5 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Use map instead inject. | Emilio Tagua | 2010-09-22 | 1 | -4/+3 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Missing the mysql2 gem here | Santiago Pastorino | 2010-09-22 | 1 | -1/+1 |
| | |||||
* | Error message should advice to use 'mysql2' gem. | Neeraj Singh | 2010-09-22 | 1 | -2/+2 |
| | | | | | | | | | | | | | If I create a new app using command rails new demo -d mysql then Gemfile contains 'mysql2' gem by default. However if mysql gem is missing then error message says raise "!!! Missing the mysql gem. Add it to your Gemfile: gem 'mysql', '2.8.1'" [#5569 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | avoid a proc object | Aaron Patterson | 2010-09-22 | 1 | -1/+1 |
| | |||||
* | avoid creating a range object | Aaron Patterson | 2010-09-22 | 1 | -1/+1 |
| | |||||
* | drying up construct_association | Aaron Patterson | 2010-09-21 | 1 | -15/+15 |
| | |||||
* | dry up some conditionals | Aaron Patterson | 2010-09-21 | 1 | -3/+4 |
| | |||||
* | fixing case / when indentation | Aaron Patterson | 2010-09-21 | 1 | -19/+19 |
| | |||||
* | fix case / when indentation | Aaron Patterson | 2010-09-21 | 1 | -18/+18 |
| | |||||
* | avoid a hash lookup | Aaron Patterson | 2010-09-21 | 1 | -2/+2 |
| | |||||
* | remove more codes | Aaron Patterson | 2010-09-21 | 1 | -6/+4 |
| | |||||
* | deleting more code | Aaron Patterson | 2010-09-21 | 1 | -4/+1 |
| | |||||
* | use each properly to avoid splatting a variable | Aaron Patterson | 2010-09-21 | 1 | -2/+1 |
| | |||||
* | deleting repeated codes | Aaron Patterson | 2010-09-21 | 1 | -13/+10 |
| | |||||
* | do not pass nil values to arel | Aaron Patterson | 2010-09-21 | 1 | -1/+1 |
| | |||||
* | refacoring duplicate code. <3 <3 <3 | Aaron Patterson | 2010-09-21 | 1 | -2/+3 |
| | |||||
* | this reject can be replaced with compact | Aaron Patterson | 2010-09-21 | 1 | -1/+1 |
| | |||||
* | removing unused code | Aaron Patterson | 2010-09-21 | 1 | -2/+1 |
| | |||||
* | remove some repeated code | Aaron Patterson | 2010-09-21 | 1 | -2/+2 |
| | |||||
* | break up giant method | Aaron Patterson | 2010-09-21 | 1 | -62/+72 |
| | |||||
* | removing lolinject | Aaron Patterson | 2010-09-21 | 1 | -1/+1 |
| | |||||
* | remove join table rows before removing owner row for habtm associations, ↵ | Hemant Kumar | 2010-09-21 | 1 | -1/+1 |
| | | | | fixes#5674 | ||||
* | providing arel with column information when possible [#5392 state:resolved] | Aaron Patterson | 2010-09-21 | 1 | -3/+10 |
| | |||||
* | un-nodocs AR::Batches | Xavier Noria | 2010-09-21 | 1 | -1/+1 |
| | |||||
* | use instance_eval, reduce method calls. | Stevie Graham | 2010-09-21 | 1 | -15/+7 |
| | | | | | | | | | | | | | | | | execution time in seconds for `rake test_sqlite3`: ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-darwin10.4.0] - before: 52.771426, 52.159505, 52.937056 - after: 51.452584, 51.897017, 51.584431 rubinius 1.0.1 (1.8.7 release 2010-06-03 JI) [x86_64-apple-darwin10.4.0] - before: 284.334076 - after: 285.753028 ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0] - before: 75.811548, 75.533153, 75.353122 - after: 75.244243, 75.19226, 75.256925 | ||||
* | Add helper for loading seed data for engine and application | Piotr Sarnacki | 2010-09-20 | 1 | -2/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |