Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | decouple JoinAssociation from JoinDependency | Aaron Patterson | 2013-10-08 | 2 | -10/+5 | |
| | | | ||||||
* | | | @associations can never have an array, so remove the dead code | Aaron Patterson | 2013-10-08 | 1 | -4/+0 | |
| | | | ||||||
* | | | typecast records returned from the db rather than to_sing everything | Aaron Patterson | 2013-10-08 | 2 | -12/+21 | |
|/ / | ||||||
* | | extract the string handling part to a method. | Aaron Patterson | 2013-10-07 | 1 | -15/+15 | |
| | | | | | | | | | | | | We know the structure passed in to the `construct` method will be a hash, so we don't need to test it all the time. The key value will be a symbol or string, so handle it with the special method | |||||
* | | remove more dead code | Aaron Patterson | 2013-10-07 | 1 | -2/+0 | |
| | | | | | | | | | | We control the inputs to `construct`, so the wrong type shouldn't be passed in ever. | |||||
* | | this code is never used, remove it | Aaron Patterson | 2013-10-07 | 1 | -4/+0 | |
| | | ||||||
* | | log the statement name along with the SQL | Aaron Patterson | 2013-10-04 | 2 | -6/+7 | |
| | | ||||||
* | | log every sql statement, even when they error | Aaron Patterson | 2013-10-04 | 1 | -25/+25 | |
| | | ||||||
* | | prepare the statement inside the begin / rescue block | Aaron Patterson | 2013-10-04 | 1 | -4/+4 | |
| | | ||||||
* | | wrap logging around the actual query call itself. | Aaron Patterson | 2013-10-04 | 2 | -50/+50 | |
| | | | | | | | | This is to be consistent with the way the mysql2 adapter times queries | |||||
* | | inject down the hash cache | Aaron Patterson | 2013-10-03 | 1 | -3/+2 | |
| | | ||||||
* | | hashes are ordered, so we do not need to sort | Aaron Patterson | 2013-10-03 | 1 | -3/+3 | |
| | | ||||||
* | | Always pass parameters to `build` | Aaron Patterson | 2013-10-03 | 1 | -2/+2 | |
| | | | | | | | | | | We always know the parameters in advance, so we don't need to build it in to the method signature | |||||
* | | Set the join type on construction | Aaron Patterson | 2013-10-03 | 2 | -6/+5 | |
| | | | | | | | | | | We always set the join type immediately after construction, just make it part of the constructor and we can skip that step | |||||
* | | simplify the JoinAssociation constructor, check validity *before* | Aaron Patterson | 2013-10-03 | 2 | -6/+6 | |
| | | ||||||
* | | parent is always passed in, so make it non-optional | Aaron Patterson | 2013-10-03 | 1 | -1/+1 | |
| | | ||||||
* | | require the files we need so the classes are stand-alone | Aaron Patterson | 2013-10-03 | 3 | -1/+4 | |
| | | ||||||
* | | map the association chain to table names | Aaron Patterson | 2013-10-03 | 1 | -4/+2 | |
| | | ||||||
* | | fix the variable name | Aaron Patterson | 2013-10-02 | 1 | -7/+7 | |
| | | ||||||
* | | remove some duplicate code | Aaron Patterson | 2013-10-02 | 1 | -8/+1 | |
| | | ||||||
* | | remove HABTM associations | Aaron Patterson | 2013-10-02 | 5 | -66/+0 | |
| | | ||||||
* | | remove HABTM special cases from reflections | Aaron Patterson | 2013-10-02 | 1 | -14/+2 | |
| | | ||||||
* | | remove the HABTM preloader | Aaron Patterson | 2013-10-02 | 2 | -74/+0 | |
| | | ||||||
* | | remove HABTM special cases from associations classes | Aaron Patterson | 2013-10-02 | 4 | -31/+1 | |
| | | ||||||
* | | remove HABTM special cases from the fixtures | Aaron Patterson | 2013-10-02 | 1 | -12/+0 | |
| | | ||||||
* | | repurpose the HABTM builder class | Aaron Patterson | 2013-10-02 | 2 | -29/+3 | |
| | | ||||||
* | | goodbye has_and_belongs_to_many1, we will miss you! | Aaron Patterson | 2013-10-02 | 1 | -4/+0 | |
| | | ||||||
* | | keep track of the left and right reflections and expose those | Aaron Patterson | 2013-10-02 | 2 | -6/+6 | |
| | | ||||||
* | | have the builder create the middle reflection | Aaron Patterson | 2013-10-02 | 2 | -13/+15 | |
| | | ||||||
* | | call the class method to define the callbacks | Aaron Patterson | 2013-10-02 | 1 | -1/+1 | |
| | | ||||||
* | | Merge branch 'master' into habtm | Aaron Patterson | 2013-10-02 | 9 | -53/+71 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: we can define callbacks without a builder instance push methods that don't depend on the instance to the class get the name from the reflection cache the name and options on the stack decouple belongs_to callback definition from the builder instance. add_before_destroy_callbacks doesn't depend on the instance, so push it to the class. valid_options doesn't depend on the instance, so push it to the class use the information on the reflection to determine whether callbacks should be added Running all isolated test for actionview association builder is no longer needed for counter cache, so remove it push constructable? on to the reflection Adds the Rails maintenance policy to the Guides name is on the reflection, so just use the reflection decouple define_callback from the instance Added activemodel as a explicit dependency unify `Fixes` notes in AR changelog. [ci skip]. improving `reload` doc wording. #12418 [ci skip] Update AR reload doc for the case of manually set primary key attribute [ci skip] | |||||
| * | | we can define callbacks without a builder instance | Aaron Patterson | 2013-10-02 | 4 | -9/+9 | |
| | | | ||||||
| * | | push methods that don't depend on the instance to the class | Aaron Patterson | 2013-10-02 | 2 | -6/+6 | |
| | | | ||||||
| * | | get the name from the reflection | Aaron Patterson | 2013-10-02 | 1 | -1/+1 | |
| | | | ||||||
| * | | cache the name and options on the stack | Aaron Patterson | 2013-10-02 | 1 | -1/+3 | |
| | | | ||||||
| * | | decouple belongs_to callback definition from the builder instance. | Aaron Patterson | 2013-10-02 | 1 | -4/+4 | |
| | | | | | | | | | | | | All the information is on the reflection, so just get it there. | |||||
| * | | add_before_destroy_callbacks doesn't depend on the instance, so push it | Aaron Patterson | 2013-10-02 | 2 | -5/+5 | |
| | | | | | | | | | | | | to the class. | |||||
| * | | valid_options doesn't depend on the instance, so push it to the class | Aaron Patterson | 2013-10-02 | 4 | -8/+8 | |
| | | | ||||||
| * | | use the information on the reflection to determine whether callbacks should ↵ | Aaron Patterson | 2013-10-02 | 1 | -4/+5 | |
| | | | | | | | | | | | | be added | |||||
| * | | association builder is no longer needed for counter cache, so remove it | Aaron Patterson | 2013-10-02 | 1 | -7/+6 | |
| | | | ||||||
| * | | push constructable? on to the reflection | Aaron Patterson | 2013-10-02 | 5 | -18/+22 | |
| | | | ||||||
| * | | name is on the reflection, so just use the reflection | Aaron Patterson | 2013-10-02 | 1 | -2/+2 | |
| | | | ||||||
| * | | decouple define_callback from the instance | Aaron Patterson | 2013-10-02 | 1 | -2/+4 | |
| | | | ||||||
| * | | improving `reload` doc wording. #12418 [ci skip] | Yves Senn | 2013-10-02 | 1 | -1/+2 | |
| | | | ||||||
| * | | Update AR reload doc for the case of manually set primary key attribute [ci ↵ | Anatoli Makarevich | 2013-10-02 | 1 | -2/+11 | |
| | | | | | | | | | | | | skip] | |||||
* | | | move habtm translation to a builder class | Aaron Patterson | 2013-10-02 | 2 | -89/+116 | |
| | | | ||||||
* | | | get the left and right association names from the join model | Aaron Patterson | 2013-10-02 | 1 | -8/+17 | |
| | | | ||||||
* | | | define the join model without using closures on the methods | Aaron Patterson | 2013-10-02 | 1 | -18/+31 | |
| | | | ||||||
* | | | decouple the HABTM builder | Aaron Patterson | 2013-10-01 | 1 | -2/+31 | |
| | | | ||||||
* | | | only pass options to the habtm builder | Aaron Patterson | 2013-10-01 | 1 | -1/+1 | |
| | | |