| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
use self instead of #read_attribute
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Sets the connection collation to the database collation configured
in database.yml. Otherwise, `SET NAMES utf8mb4` will use the default
collation for that charset (utf8mb4_general_ci) when you may have chosen
a different collation, like utf8mb4_unicode_ci.
This only applies to literal string comparisons, not column values, so
it is unlikely to affect you.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When we are loading a component and we want to know its version, we are
actually not speaking about the constant but the library itself.
[ci skip]
[Godfrey Chan & Xavier Noria]
|
| |
| |
| |
| | |
:bomb:
|
|\ \ |
|
| | |
| | |
| | |
| | | |
This fixes random test failure in migrator_test.rb
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using heredoc would enforce line wrapping to whatever column width we decided to
use in the code, making it difficult for the users to read on some consoles.
This does make the source code read slightly worse and a bit more error-prone,
but this seems like a fair price to pay since the primary purpose for these
messages are for the users to read and the code will not stick around for too
long.
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| |\ \
| | | |
| | | | |
Correctly detect mutation on serialized columns mapping to binary
|
| | | |
| | | |
| | | |
| | | | |
Fixes #16701
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
[ci skip] Updated documentation syntax of block parameter for rdoc
|
| | | | | |
|
| |/ / / |
|
| |/ / |
|
| | | |
|
| |\ \
| | | |
| | | | |
Cache the value of `changed_attributes` when calling `changes_applied`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`changes_applied` calles `changes`, which will call `changed_attributes`
multiple times in a loop. This method actually performs work now, so we
should cache the results while looping over it when we know it cannot
change.
|
| | | | |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Also duplicated find_by tests from relations_test.rb to finder_test.rb now
that we have a completely different implementation on the class (in core.rb
with AST caching stuff).
* Also removed a (failing) test that used mocks. Now that we have tests for the
behavior, there's no point having another test that tests the implementation
(that it delegates). Further, what the test was implying is nolonger true with
the current implementation, because Class.find_by is a real method now.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a reacon to https://github.com/rails/rails/commit/d6c1205584b1ba597db4071b168681678b1e9875#commitcomment-7502487
This backwards incompatibility was introduced with d6c12055 to fix #7516.
However both `connection.default_sequence_name` and `model.sequence_name` are public API.
The PostgreSQL adapter should honor the interface and return strings.
/cc @matthewd @chancancode
|
| | | |
|
| |\ \
| | | |
| | | | |
[ci skip] Added documentation for has_many extension parameter
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
* Require either FIRST or LAST qualifier for "NULLS ..."
* Require whitespace before "NULLS ..."
|
| | |/
| |/|
| | |
| | | |
Fixes #16623 introduced by https://github.com/rails/rails/commit/3d5a2019bcccc6fb01bee4811ca669f4383edb51
|
| |\ \
| | | |
| | | | |
adding the exception RecordNotFound to UUID find #11957
|
| | | | |
|
| | |/
| |/|
| | |
| | |
| | |
| | | |
Now that `changed_attributes` includes in place changes, we don't need
to override these methods in Active Record. Partially fixes the
performance regression caused by #16189
|
| | | |
|
| |\ \
| | | |
| | | | |
Fix minor typos and improve grammar and code formatting
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[ci skip]
Add improvements from @eileencodes [skip ci]
|
| | |/
| |/| |
|
| |\ \
| | | |
| | | | |
[ci skip] add doc for STEP in migration
|
| | | | |
|
| |\ \ \
| | |/ /
| |/| | |
[ci skip] Added documentation for has_many scope parameter
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
has_many :through with dynamic condition merging
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
with dynamic conditions.
Fixes #16128
This bug was introduced in https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d
so it's present from 4.1.2-rc1 and after.
https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d
merges any relation scopes passed as proc objects to the relation,
but does *not* take into account the arity of the lambda.
To reproduce: https://gist.github.com/Agis-/5f1f0d664d2cd08dfb9b
|
| |\ \ \ \
| | |_|/ /
| |/| | | |
don't log errors when all is fine
|
| | | | | |
|
| | |/ /
| |/| | |
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
[ci skip] Added documentation for belongs_to scope parameter
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Correctly determine if migration is needed.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This method would assume that if last migration in the migrations
directory matched the current schema version, that the database was up
to date, but this does not account for new migrations with older
timestamps that may be pending.
|