aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* speed up the collection proxy reader method, but slow down the constructorAaron Patterson2014-02-131-1/+5
|
* Merge pull request #14034 from ↵Yves Senn2014-02-131-1/+6
|\ | | | | | | | | hdabrows/drop-correct-index-when-reverting-migration Drop the correct index after reverting a migration
| * Drop the correct index after reverting a migrationHubert Dąbrowski2014-02-131-1/+6
| | | | | | | | | | | | Previously when reverting a migration which added a named index it would instead drop a corresponding index with matching columns but without a name.
* | Dont use Enumarator on join_associationArthur Neves2014-02-131-2/+4
| |
* | `execute` is a hotspot, so let's reduce branchesAaron Patterson2014-02-121-6/+2
|/
* adding missed changekayvan2014-02-111-1/+1
|
* adding connection parameter to check_pending for migrationskayvan2014-02-111-5/+5
|
* Avoid using deprecated arel constantsRafael Mendonça França2014-02-102-3/+3
|
* move alias method `sanitize_conditions` to a correct placeDmitry Polushkin2014-02-091-2/+1
|
* Merge pull request #13981 from Fortisque/kevin/postgresql_reaper_threadsafeAaron Patterson2014-02-083-2/+13
|\ | | | | Reaper has access to threadsafe active? call
| * Reaper has access to threadsafe active? callKevin Casey2014-02-083-2/+13
| |
* | context in validation goes through has many relationshipKevin Casey2014-02-081-1/+1
|/
* Merge branch 'dump-schema-after-migration-flag' of ↵Xavier Noria2014-02-062-1/+10
|\ | | | | | | | | | | | | git://github.com/emilsoman/rails into emilsoman-dump-schema-after-migration-flag Conflicts: activerecord/CHANGELOG.md
| * Add config to disable schema dump after migrationEmil Soman2014-02-062-1/+10
| | | | | | | | | | | | | | | | | | * Add a config on Active Record named `dump_schema_after_migration` * Schema dump doesn't happen if the config is set to false * Set default value of the config to true * Set config in generated production environment file to false * Update configuration guide * Update CHANGELOG
* | Return sized enumerator from Batches#find_eachMarc-Andre Lafortune2014-02-052-2/+4
| |
* | Return sized enumerator from Batches#find_in_batchesMarc-Andre Lafortune2014-02-051-4/+9
| |
* | docs, AR already auto-detects primary keys. Closes #13946. [ci skip]Yves Senn2014-02-051-3/+3
| | | | | | | | | | This behavior was introduced since Rails 3.1 (207f266ccaaa9cd04cd2a7513ae5598c4358b510) but the docs were still out of date.
* | Document that enum conditions must use the ordinal valueRafael Mendonça França2014-02-041-0/+2
|/ | | | [ci skip]
* Merge pull request #13935 from arthurnn/fix_12566Rafael Mendonça França2014-02-041-1/+1
|\ | | | | Make sure transaction state resets after commit
| * Make sure transaction state resets after commitArthur Neves2014-02-031-1/+1
| | | | | | | | [fixes #12566]
* | Merge pull request #13899 from ↵Rafael Mendonça França2014-02-041-1/+1
|\ \ | |/ |/| | | | | Fortisque/kevin/active_record_HABTM_with_belongs_to destruction errors out on HABTM w/out primary key
| * fix HABTM w/out primary key errors on destructionKevin Casey2014-02-021-1/+1
| |
* | some wording format changes. [ci skip]Yves Senn2014-02-031-1/+1
| |
* | pass `habtm :autosave` to underlying `hm:t` association. Closes #13923.Yves Senn2014-02-031-1/+1
| |
* | docs, revisit polymorphic associations with STI example. [ci skip]Yves Senn2014-02-031-2/+5
| | | | | | | | | | | | This is a follow up to #13926. /cc @fxn
* | Fixes the camelCase variable name in the docs [ci skip]Fred Wu2014-02-031-2/+2
| |
* | Make arel methods private APIRafael Mendonça França2014-02-012-6/+5
| | | | | | | | | | | | Since its conception arel was made to be private API of Active Record. If users want to use arel features directly we should provide a way using the Active Record API without exposing the arel implementation.
* | Merge pull request #13688 from jbaudanza/psql-index-existsRafael Mendonça França2014-02-011-0/+13
|\ \ | | | | | | | | | | | | | | | | | | PostgreSQL implementation of SchemaStatements#index_name_exists? Conflicts: activerecord/CHANGELOG.md
| * | psql implementation of #index_name_exists?Jonathan Baudanza2014-01-161-0/+13
| | |
* | | Fixes issue with parsing whitespace content back from database - fixes #13907Mauricio Linhares2014-02-011-2/+3
| | |
* | | this class depends on JoinHelper, so we should require itAaron Patterson2014-01-311-0/+2
| |/ |/|
* | Associations now raise `ArgumentError` on name conflicts.Lauro Caetano2014-01-311-0/+6
| | | | | | | | | | Dangerous association names conflicts include instance or class methods already defined by `ActiveRecord::Base`.
* | Merge pull request #13859 from huoxito/let-it-goRafael Mendonça França2014-01-301-2/+0
|\ \ | | | | | | Let `unscope` ignore non Arel scope.where_values
| * | Let `unscope` ignore non Arel scope.where_valuesWashington Luiz2014-01-301-2/+0
| | |
* | | Merge pull request #13886 from arthurnn/fix_relation_arelRafael Mendonça França2014-01-306-18/+21
|\ \ \ | |/ / |/| | Fix regression on .select method
| * | Fix regression on `.select_*` methods.Arthur Neves2014-01-306-18/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was a common pattern: ``` query = author.posts.select(:title) connection.select_one(query) ``` However `.select` returns a ActiveRecord::AssociationRelation, which has the bind information, so we can use that to get the right sql query. Also fix select_rows on postgress and sqlite3 that were not using the binds [fixes #7538] [fixes #12017] [related #13731] [related #12056]
* | | Merge pull request #13878 from marcandre/leave_my_options_aloneRafael Mendonça França2014-01-301-2/+2
|\ \ \ | | | | | | | | find_in_batches should not mutate its argument
| * | | find_in_batches should not mutate its argumentMarc-Andre Lafortune2014-01-291-2/+2
| | | |
* | | | docs, `references` is only used with `includes`. Closes #13727.Yves Senn2014-01-301-9/+14
| |/ / |/| | | | | | | | | | | | | | | | | There is no gain in `referencing` tables that are not used for preloading. Furthermore it will break if polymorphic associations are invloved. This is because `references_eager_loaded_tables?` uses all `reference_values` to decide wether to `eager_load` or `preload`.
* | | AestheticRafael Mendonça França2014-01-291-6/+5
| | |
* | | Fixing issue with activerecord serialization not being able to dump a record ↵Mauricio Linhares2014-01-293-1/+17
|/ / | | | | | | after loading it from YAML - fixes #13861
* | Merge pull request #13201 from marcandre/find_in_batch_enumeratorRafael Mendonça França2014-01-291-0/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | `find_in_batches` now returns an `Enumerator` Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/relation/batches.rb
| * | `find_in_batches` now returns an `Enumerator` when called without a block, ↵Marc-Andre Lafortune2013-12-061-0/+9
| | | | | | | | | | | | | | | | | | so that it can be chained with other `Enumerable` methods.
* | | Mention find_each in find_in_batches doc [ci skip]Marc-Andre Lafortune2014-01-291-0/+2
| | |
* | | `enum` now raises on "dangerous" name conflictsGodfrey Chan2014-01-291-3/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | Dangerous name conflicts includes instance or class method conflicts with methods defined within `ActiveRecord::Base` but not its ancestors, as well as conflicts with methods generated by other enums on the same class. Fixes #13389.
* | | `scope` now raises on "dangerous" name conflictsGodfrey Chan2014-01-292-4/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similar to dangerous attribute methods, a scope name conflict is dangerous if it conflicts with an existing class method defined within `ActiveRecord::Base` but not its ancestors. See also #13389. *Godfrey Chan*, *Philippe Creux*
* | | Fixed a bug in AR::Base#respond_to?Godfrey Chan2014-01-291-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: >> ActiveRecord::Base.respond_to?(:find_by_something) NoMethodError: undefined method `abstract_class?' for Object:Class After: >> ActiveRecord::Base.respond_to?(:find_by_something) => false
* | | Correctly send the string given to lock! and reload(:lock) to the lock scope ↵Mauricio Linhares2014-01-291-1/+1
| | | | | | | | | | | | | | | | | | - fixes #13788 As per the documentation at lock!, if the :lock option is a string it should use the given SQL to generate the lock statement.
* | | Handle aliased attributes in AR::Relation#select, #order, etc.Tsutomu Kuroda2014-01-291-1/+5
| | | | | | | | | | | | | | | | | | | | | With this we can write `Model#select(:aliased)`, `Model#order(:aliased)`, `Model#reoder(aliased: :desc)`, etc. Supplementary work to 54122067acaad39b277a5363c6d11d6804c7bf6b.
* | | Merge pull request #13838 from vipulnsward/13197-fix-has-one-documentationDamien Mathieu2014-01-281-1/+2
|\ \ \ | | | | | | | | Add docs about behaviour of replacing a has_one associate object.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 07:15:19 +0000