Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | | Revert "add missing methods supported by reversible migrations using the ↵ | Vijay Dev | 2011-06-25 | 1 | -4/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change method" This reverts commit 7f91eebae361f2f3a1558f6d899b372524509a2d. Reason: Incorrect documenting. The newly added methods to the list are not actually supported by reversible migrations. | |||||
| * | | | | | | add missing methods supported by reversible migrations using the change method | Vijay Dev | 2011-06-24 | 1 | -1/+4 | |
| | |_|_|/ / | |/| | | | | ||||||
* | | | | | | Only call set_owner_attributes for has_one association if target exists. | Dieter Komendera | 2011-07-04 | 1 | -1/+1 | |
| |/ / / / |/| | | | | ||||||
* | | | | | Use an instance variable to store the current masss assignment options | Andrew White | 2011-07-04 | 2 | -13/+18 | |
| |_|/ / |/| | | | ||||||
* | | | | Reversing the changes done in c278a2c while still resolving #1857. | Vijay Dev | 2011-07-02 | 1 | -9/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes broke bulk migration tests and were fixed in 4d256bc6; however that brought back the issue of #1857 and so this commit goes back to the original scenario and just adds change_table to the list of methods which are to be recorded in the CommandRecorder. The method_missing now delegates all calls to the underlying connection as before. | |||||
* | | | | a few minor performance improvements: fewer strings, fewer range objects, ↵ | Aaron Patterson | 2011-07-01 | 2 | -22/+13 | |
| | | | | | | | | | | | | | | | | fewer method calls | |||||
* | | | | calling super is super. if the other object is exactly equal, we can return ↵ | Aaron Patterson | 2011-07-01 | 1 | -1/+5 | |
| | | | | | | | | | | | | | | | | early | |||||
* | | | | remove unused codes | Aaron Patterson | 2011-07-01 | 1 | -4/+0 | |
| | | | | ||||||
* | | | | reduce calls to owners_by_key and to read_attribute, respond_to? etc | Aaron Patterson | 2011-07-01 | 1 | -2/+3 | |
| | | | | ||||||
* | | | | Remove AssociationReflection#create_association and ↵ | Jon Leighton | 2011-06-30 | 1 | -17/+0 | |
| | | | | | | | | | | | | | | | | AssociationReflection#create_association! - they are not called from anywhere. | |||||
* | | | | Assign the association attributes to the associated record before the ↵ | Jon Leighton | 2011-06-30 | 4 | -10/+12 | |
| | | | | | | | | | | | | | | | | before_initialize callback of the record runs. Fixes #1842. | |||||
* | | | | match method signature of the superclass | Aaron Patterson | 2011-06-30 | 2 | -4/+4 | |
| | | | | ||||||
* | | | | call super rather than delegating to the other objects equal? method | Aaron Patterson | 2011-06-30 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | just alias eql? to == for frewer method calls | Aaron Patterson | 2011-06-30 | 1 | -5/+1 | |
| | | | | ||||||
* | | | | only calculate method name once | Aaron Patterson | 2011-06-30 | 1 | -2/+3 | |
| | | | | ||||||
* | | | | cache the plural name on the reflection so we do not pay pluralize costs on ↵ | Aaron Patterson | 2011-06-30 | 2 | -7/+14 | |
| | | | | | | | | | | | | | | | | joins | |||||
* | | | | Master version is 3.2.0.beta | Santiago Pastorino | 2011-06-30 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | CommandRecorder should delegate in method_missing where possible. Fixes some ↵ | Jon Leighton | 2011-06-30 | 1 | -1/+5 | |
| | | | | | | | | | | | | | | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce. | |||||
* | | | | Define to_ary on ActiveRecord::Base to return nil. Improve performance of ↵ | Jon Leighton | 2011-06-30 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | | Array#flatten under 1.9, see comment for details. | |||||
* | | | | Fix case | Oriol Gual | 2011-06-28 | 1 | -2/+1 | |
| | | | | ||||||
* | | | | Update reverse order with new Arel Nodes | Oriol Gual | 2011-06-28 | 1 | -1/+2 | |
| | | | | ||||||
* | | | | Merge pull request #1857 from vijaydev/irreversible-migration | Aaron Patterson | 2011-06-28 | 1 | -4/+4 | |
|\ \ \ \ | | | | | | | | | | | IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration | |||||
| * | | | | record unsupported methods in CommandRecorder instead of letting the ↵ | Vijay Dev | 2011-06-25 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations | |||||
* | | | | | Merge pull request #1860 from dmathieu/comparison | Aaron Patterson | 2011-06-28 | 1 | -0/+9 | |
|\ \ \ \ \ | | | | | | | | | | | | | Allow comparison on model objects - Closes #1858 | |||||
| * | | | | | comparing different classes returns nil | Damien Mathieu | 2011-06-26 | 1 | -1/+5 | |
| | | | | | | ||||||
| * | | | | | allow comparison on model objects - Closes #1858 | Damien Mathieu | 2011-06-26 | 1 | -0/+5 | |
| |/ / / / | ||||||
* | | | | | remove useless assignment | Aaron Patterson | 2011-06-28 | 1 | -2/+1 | |
| | | | | | ||||||
* | | | | | lock_optimistically is typically true, so evaluate the common failure case first | Aaron Patterson | 2011-06-28 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | reduce object allocation during AR instantiation | Aaron Patterson | 2011-06-28 | 2 | -3/+8 | |
| | | | | | ||||||
* | | | | | remove the check for needs_type_condition? because ensure_proper_type will ↵ | Aaron Patterson | 2011-06-27 | 2 | -3/+4 | |
| | | | | | | | | | | | | | | | | | | | | pick up the type column | |||||
* | | | | | stop using && for the short circuit side effect | Aaron Patterson | 2011-06-27 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | let strings be converted to symbols inside the interpreter | Aaron Patterson | 2011-06-27 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | avoice paying hash cost if there are no serialized attributes | Aaron Patterson | 2011-06-27 | 1 | -3/+4 | |
| | | | | | ||||||
* | | | | | cache column defaults for AR object instantiation | Aaron Patterson | 2011-06-27 | 3 | -3/+16 | |
| | | | | | ||||||
* | | | | | AR object instantiation is ~30% faster in the simple case | Aaron Patterson | 2011-06-27 | 2 | -1/+17 | |
| | | | | | ||||||
* | | | | | initialize instance variables | Aaron Patterson | 2011-06-27 | 1 | -0/+2 | |
| | | | | | ||||||
* | | | | | default create_with_value to a hash so we can eliminate conditionals, add ↵ | Aaron Patterson | 2011-06-27 | 3 | -4/+5 | |
|/ / / / | | | | | | | | | | | | | test surrounding create_with(nil) behavior | |||||
* | | | | Merge pull request #1848 from raviolicode/postgresql_order_multiple_params | Santiago Pastorino | 2011-06-24 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | Fix for complex ordering of multiple columns on postgresql | |||||
| * | | | | Improve ordering of multiple columns on postgresql | Lucia Escanellas | 2011-06-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Only on postgresql, order("first asc, second asc") was invalid * Closes #1720 | |||||
* | | | | | Apply the default scope earlier when doing calculations. Fixes #1682. | Jon Leighton | 2011-06-23 | 1 | -5/+11 | |
|/ / / / | ||||||
* / / / | Update SQL Server db related rake tasks. | Ken Collins | 2011-06-23 | 1 | -6/+7 | |
|/ / / | | | | | | | | | | | | | | | | * Uses open source smoscript since scptxfr came out in 2000. * Uses sqlcmd which replaces osql. * Takes advantage of host/user/pass passed down by TinyTDS. | |||||
* | | | Merge pull request #1790 from ernie/reverse_sql_order_fix | Aaron Patterson | 2011-06-22 | 1 | -3/+12 | |
|\ \ \ | | | | | | | | | Support reversal of ARel orderings in reverse_sql_order | |||||
| * | | | Support reversal of ARel orderings in reverse_sql_order | Ernie Miller | 2011-06-20 | 1 | -3/+12 | |
| | | | | ||||||
* | | | | Merge pull request #1632 from tardate/pg_schema_fu | Aaron Patterson | 2011-06-21 | 1 | -47/+72 | |
|\ \ \ \ | |/ / / |/| | | | Improving PostgreSQL adapter schema-awareness | |||||
| * | | | Merge remote branch 'rails/master' into pg_schema_fu | Paul Gallagher | 2011-06-19 | 10 | -69/+99 | |
| |\ \ \ | ||||||
| * | | | | Make PostgreSQL adapter view-compatible | Paul Gallagher | 2011-06-19 | 1 | -3/+5 | |
| | | | | | | | | | | | | | | | * amongst other things, allows meta_search to run against view-backed models | |||||
| * | | | | make extract_schema_and_table a private method | Paul Gallagher | 2011-06-11 | 1 | -20/+17 | |
| | | | | | ||||||
| * | | | | remove table quoting in primary_key method | Paul Gallagher | 2011-06-11 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | * add/cleanup tests | |||||
| * | | | | apply private method indentation convention | Paul Gallagher | 2011-06-10 | 1 | -22/+22 | |
| | | | | | | | | | | | | | | | * tidy test code and fix my typo | |||||
| * | | | | Improve PostgreSQL adapter schema-awareness | Paul Gallagher | 2011-06-10 | 1 | -25/+51 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * table_exists? scoped by schema search path unless schema is explicitly named. Added tests and doc to clarify the behaviour * extract_schema_and_table tests and implementation extended to cover all cases * primary_key does not ignore schema information * add current_schema and schema_exists? methods * more robust table referencing in insert_sql and sql_for_insert methods |