aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* PostgreSQL and SQLite, remove varchar limit. [Vladimir Sazhin & Toms Mikoss ↵Yves Senn2014-04-042-2/+2
| | | | | | | | | | | | | | | | & Yves Senn] There is no reason for the PG adapter to have a default limit of 255 on :string columns. See this snippet from the PG docs: Tip: There is no performance difference among these three types, apart from increased storage space when using the blank-padded type, and a few extra CPU cycles to check the length when storing into a length-constrained column. While character(n) has performance advantages in some other database systems, there is no such advantage in PostgreSQL; in fact character(n) is usually the slowest of the three because of its additional storage costs. In most situations text or character varying should be used instead.
* Block a few default Class methods as scope name.Arthur Neves2014-04-031-1/+3
| | | | | | Add tests to make sure scopes cannot be create with names such as: private, protected, public. Make sure enum values don't collide with those methods too.
* Merge pull request #14569 from matthewd/sqlite_relative_deprecatedRafael Mendonça França2014-04-031-17/+30
|\ | | | | | | | | | | | | Revise 'sqlite3:' URL handling for smoother upgrades Conflicts: activerecord/CHANGELOG.md
| * Complete change of `sqlite3:///` path handlingMatthew Draper2014-04-031-15/+1
| | | | | | | | That which was now relative is now absolute.
| * Revise 'sqlite3:' URL handling for smoother upgradesMatthew Draper2014-04-031-18/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll change to the absolute-path interpretation in 4.2. The current "correct" spellings for in-memory, relative, and absolute URLs, respectively, are: sqlite3::memory: sqlite3:relative/path sqlite3:/full/path Substantially reverses/defers fbb79b517f3127ba620fedd01849f9628b78d6ce. Uncovered by @guilleiguaran while investigating #14495, though that sounds like a different issue.
* | Merge pull request #14570 from matthewd/uri_deprecation_warningRafael Mendonça França2014-04-031-24/+28
|\ \ | | | | | | Avoid a spurious deprecation warning for database URLs
| * | Avoid including DB details in exception messagesMatthew Draper2014-04-031-1/+1
| | | | | | | | | | | | | | | The keys are quite sufficient; we shouldn't be throwing passwords around.
| * | Avoid a spurious deprecation warning for database URLsMatthew Draper2014-04-031-23/+27
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is all about the case where we have a `DATABASE_URL`, and we have a `database.yml` present, but the latter doesn't contain the key we're looking for. If the key is a symbol, we'll always connect to `DATABASE_URL`, per the new behaviour in 283a2edec2f8ccdf90fb58025608f02a63948fa0. If the key is a string, on the other hand, it should always be a URL: the ability to specify a name not present in `database.yml` is new in this version of Rails, and that ability does not stretch to the deprecated use of a string in place of a symbol. Uncovered by @guilleiguaran while investigating #14495 -- this actually may be related to the original report, but we don't have enough info to confirm.
* / Treat blank UUID values as nilDmitry Lavrov2014-04-031-1/+8
|/
* PostgreSQL, Support for materialized views. [Dave Lee & Yves Senn]Dave Lee2014-04-022-4/+5
| | | | | Expand the query used in #table_exists? to include materialized views in the kinds of relations it searches.
* Clarify 'database does not exist' message and implementation.Jeremy Kemper2014-04-016-26/+23
| | | | | | | | | | | * Clarify what the situation is and what to do. * Advise loading schema using `rake db:setup` instead of migrating. * Use a rescue in the initializer rather than extending the error message in-place. * Preserve the original backtrace of other errors by using `raise` rather than raising again with `raise error`. References 0ec45cd15d0a2f5aebc75e23d841b6c12f3ba763
* fix, adjust OID query without range support to include required fields.Yves Senn2014-04-011-3/+4
| | | | | This is a follow-up fix to f7a6b115fea9f675190a79b701c7034214678f19 and 06082f66d541e581110406bbac3bc395bace3f86
* refactor, use `typtype` instead of `typinput` to segment PG types.Yves Senn2014-04-011-3/+3
|
* PostgreSQL, register custom domains. Closes #14305.Yves Senn2014-04-011-1/+11
| | | | | | | This patch registers custom domains in our OID-type_map. They will behave exactly as the type specified by `pg_type.typbasetype`. /cc @matthewd
* Merge pull request #14513 from senny/pg/responsible_oidRafael Mendonça França2014-04-012-101/+91
|\ | | | | PostgreSQL determine `Column#type` through corresponding OID. #7814
| * PostgreSQL determine `Column#type` through corresponding OID. #7814Yves Senn2014-04-012-101/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | I ran the whole test suite and compared the old to the new types. Following is the list of types that did change with this patch: ``` DIFFERENT TYPE FOR mood: NEW: enum, BEFORE: DIFFERENT TYPE FOR floatrange: NEW: floatrange, BEFORE: float ``` The `floatrange` is a custom type. The old type `float` was simply a coincidence form the name `floatrange` and our type-guessing.
* | Merge pull request #14546 from ↵Aaron Patterson2014-03-311-1/+1
|\ \ | | | | | | | | | | | | eileencodes/fix_delete_all_to_not_use_IN_statement Fix delete all to not produce sql in statement
| * | fix delete_all to remove records directlyeileencodes2014-03-311-1/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When delete_all is run on a CollectionProxy and has a dependency of delete_all the SQL that is produced has an IN statement. (DELETE FROM `associated_model` where `associated_model` .`parent_id` = 1 AND `associated_model`.`id` IN (1, 2, 3...)). This only happens if the association is not loaded (both loaded and non-loaded delete_all should behave the same. This is a huge problem when it comes to deleting many records because the query becomes very slow. Instead the SQL produced should be (DELETE FROM `assoicated_model` where `associated_model`.`parent_model_id`=1). I fixed this by making sure the check for loaded and destroy also makes sure that the dependent is not delete_all, so the conditional goes to the else and deletes the records directly without the IN statement.
* | Merge pull request #14532 from thedarkone/polymorphic-preload-fixAaron Patterson2014-03-312-30/+13
|\ \ | |/ |/| Fix polymorphic preloads on NOT NULL _type columns
| * Simplify Preloader#grouped_records code.thedarkone2014-03-302-21/+13
| | | | | | | | | | | | The new method relies on AR::Associations::Association knowing about both reflection and a model class. AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
| * Fix polymorphic preloads on NOT NULL _type columns.thedarkone2014-03-301-10/+1
| | | | | | | | Defer to Association#klass instead of having a custom/duplicate code.
* | refactor, put `PostgreSQLColumn` into `column.rb`.Yves Senn2014-03-312-218/+222
| | | | | | | | | | We have `connection_adapters/column.rb` so it's easier to remember that the column in in a separate file.
* | fix mysql buildsLuke Steensen2014-03-301-1/+1
| |
* | fix bug on non empty defaults for pg array columnsLuke Steensen2014-03-302-2/+8
| | | | | | | | fixes #10613
* | No need to call to_symRafael Mendonça França2014-03-301-2/+2
|/ | | | It is already called inside type_to_sql method.
* Merge pull request #14526 from chancancode/fix_ar_equalityXavier Noria2014-03-292-2/+2
|\ | | | | Ensure we are returning either `true` or `false` for `#==`
| * Ensure we are returning either `true` or `false` for `#==`Godfrey Chan2014-03-292-2/+2
| | | | | | | | | | | | 460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-03-291-1/+5
|\ \ | |/ |/|
| * Update documentation on group method to indicate it takes an arrayEarl St Sauver2014-03-171-0/+4
| | | | | | | | | | | | | | | | | | The group method also takes an array, however this isn't immediately clear by reading the source since it delegates this method. If you trace it back to the AREL building you can see that it does support an array. Shoutout to @betovelandia for pointing this out.
| * Fix misspelling in references docsSteven Harman2014-03-141-1/+1
| |
* | Replace trivial regexp with string or index, twice as fastKelley Reynolds2014-03-282-2/+2
| |
* | Merge pull request #14154 from al2o3cr/issue12770Aaron Patterson2014-03-272-4/+4
|\ \ | | | | | | Pass a base relation to build_default_scope when joining
| * | Pass a base relation to build_default_scope when joiningMatt Jones2014-02-212-4/+4
| | | | | | | | | | | | | | | This allows the default scope to be built using the current table alias. Resolves #12770
* | | Merge pull request #14469 from tiegz/timestamp_inheritance_fixRafael Mendonça França2014-03-271-1/+1
| | | | | | | | | | | | Swap Timestamp/Callbacks order in ActiveRecord::Base
* | | AR .persisted? throws SystemStackError for an unsaved model with achrisfinne2014-03-271-1/+1
| | | | | | | | | | | | custom primary_key that didn't save due to validation error
* | | ActiveRecord/ActiveModel '#validate' alias for 'valid?'Henrik Nyh2014-03-271-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
* | | Remove unused methodRafael Mendonça França2014-03-261-5/+0
| | | | | | | | | | | | | | | This method is not being called anywhere in our code and a GitHub search show it is not being used in any project.
* | | No need to gsub the stringRafael Mendonça França2014-03-261-1/+1
| | |
* | | Don't use send when we own the methodRafael Mendonça França2014-03-262-35/+35
| | |
* | | Make method privateRafael Mendonça França2014-03-261-5/+6
| | |
* | | Improve the methodRafael Mendonça França2014-03-261-5/+6
| | | | | | | | | | | | | | | | | | * cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call
* | | Remove unneeded comments about feature support on the adaptersRafael Mendonça França2014-03-261-20/+9
| | | | | | | | | | | | | | | These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters
* | | Invert the conditionals to make easier to readRafael Mendonça França2014-03-261-4/+4
| | | | | | | | | | | | Also improve some of the code conventions
* | | Fixes bugs for using indexes in CREATE TABLE by adding checks for table ↵Steve Rice2014-03-252-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | existence Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
* | | create indexes inline in CREATE TABLE for MySQLCody Cutrer2014-03-253-11/+36
| | | | | | | | | | | | | | | | | | | | | | | | This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
* | | Merge pull request #14390 from huoxito/true-touchRafael Mendonça França2014-03-251-0/+2
|\ \ \ | | | | | | | | | | | | Still touch associations when theres no timestamp
| * | | Still touch associations when theres no timestampWashington Luiz2014-03-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to Rails 4.0.4 when touching a object which doesn't have timestamp attributes (updated_at / updated_on) rails would still touch all associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates associations but rollsback because `touch` would return nil since there's no timestamp attribute
* | | | Revert "Merge pull request #8313 from alan/only_save_changed_has_one_objects"Rafael Mendonça França2014-03-251-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
* | | | Fix Generation of proper migration whenKuldeep Aggarwal2014-03-251-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Base.pluralize_table_names = false. Previously, generation a migration like this: rails g migration add_column_name_to_user name would not generating the correct table name. Fixes #13426.
* | | | Merge pull request #12955 from joshwilliams/masterYves Senn2014-03-201-0/+1
|\ \ \ \ | | | | | | | | | | Postgres schema: Constrain sequence search classid
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 01:26:29 +0000