aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Remove return guard and use code convetionsRafael Mendonça França2012-11-201-7/+11
|
* Postgresql doesn't accepts limits on text columns.Victor Costan2012-11-201-0/+7
|
* Be a bit less conservative with mysql in adapterCarlos Antonio da Silva2012-11-191-1/+1
|
* Remove not needed begin..end from AR#saveCarlos Antonio da Silva2012-11-191-5/+3
|
* Merge pull request #3023 from Tho85/preserve_sti_typeRafael Mendonça França2012-11-181-1/+12
|\ | | | | | | | | | | | | AR::Base.becomes should not change the STI type Conflicts: activerecord/CHANGELOG.md
| * AR::Base.becomes should not change the STI typeThomas Hollstegge2012-11-171-1/+12
| | | | | | | | If you want to change the STI type too, use AR::Base.becomes! instead
* | Add rename_index to change_table.Jarek Radosz2012-11-191-0/+8
| |
* | Remove not used require and some useless test commentsCarlos Antonio da Silva2012-11-171-2/+0
| |
* | Bump mysql gem version to the newly 2.9.0, fix build.Carlos Antonio da Silva2012-11-171-1/+1
| |
* | Remove return guardCarlos Antonio da Silva2012-11-171-2/+1
|/
* Add a deprecation before removing find_table_nameAlexey Muranov2012-11-171-0/+6
| | | The `ActiveRecord::Fixtures::find_table_name` method was removed from "master" almost a year ago, but it was never deprecated. Here it comes back, more dead than alive.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-11-1722-204/+204
|\ | | | | | | | | Conflicts: actionpack/lib/action_dispatch/routing/redirection.rb
| * 1.9 Syntax related changesAvnerCohen2012-11-1015-93/+93
| |
| * 1.9 hash syntax changesAvnerCohen2012-11-087-111/+111
| |
* | arel columns can be used for grouping so that "weird" column names are usableAaron Patterson2012-11-151-0/+4
| |
* | stop hardcoding FrontBase adapter conditionalsAaron Patterson2012-11-151-1/+1
| |
* | stop passing *args to generate aliasesAaron Patterson2012-11-151-4/+2
| |
* | create fewer relation objectsAaron Patterson2012-11-151-3/+6
| |
* | Merge pull request #8176 from senny/7551_pluck_with_selectRafael Mendonça França2012-11-131-1/+3
|\ \ | | | | | | `#pluck` can be used on a relation with `select` clause (#7551)
| * | `#pluck` can be used on a relation with `select` clause.Yves Senn2012-11-121-1/+3
| | | | | | | | | | | | Closes #7551
* | | only clear caches if we are actually connected to the databaseAaron Patterson2012-11-121-2/+4
|/ /
* | Remove duplicated ConnectionHandling extension in AR::BaseCarlos Antonio da Silva2012-11-111-1/+0
| | | | | | | | | | Thanks @toretore. https://github.com/rails/rails/commit/9e4c41c903e8e58721f2c41776a8c60ddba7a0a9#commitcomment-2134706
* | Make ActiveRecord::Delegation#method_missing threadsafeJon Leighton2012-11-101-3/+21
| | | | | | | | | | | | | | | | | | | | | | | | Two threads may be in method_missing at the same time. If so, they might both try to define the same delegator method. Such a situation probably wouldn't result in a particularly spectacular bug as one method would probably just be overridden by an identical method, but it could cause warnings to pop up. (It could be worse if method definition is non-atomic in a particular implementation.) (We will also need this mutex shortly anyway, see #8127.)
* | Do not create useless database transaction when building `has_one` association.Bogdan Gusiev2012-11-101-1/+9
| |
* | Keep the code related to serialization in Serialization module.Nikita Afanasenko2012-11-102-9/+13
| | | | | | | | We should not need any `serialized_attributes` checks outside `ActiveRecord::AttributeMethods::Serialization` module.
* | Gracefully handle upgrading apps with mass assigment configsAndrew White2012-11-091-0/+27
| | | | | | | | | | | | | | | | Most apps upgrading from 3.x will have options for mass assigment in their application.rb and environments/*.rb config files. Rather than just raising a NoMethodError when copying the config, this commit adds a warning message until either the protected_attributes gem is installed or the relevant config options are removed.
* | Remove not used load hooks for active_record_configCarlos Antonio da Silva2012-11-092-6/+0
| | | | | | | | | | These were removed with ActiveRecord::Model in https://github.com/rails/rails/commit/9e4c41c903e8e58721f2c41776a8c60ddba7a0a9#L15L156
* | fix warningsJon Leighton2012-11-091-1/+1
| |
* | Properly deprecate ConnectionHandler#connection_poolsJon Leighton2012-11-092-7/+15
| | | | | | | | | | | | | | | | Rather than just changing it and hoping for the best. Requested by @jeremy: https://github.com/rails/rails/commit/ba1544d71628abff2777c9c514142d7e9a159111#commitcomment-2106059
* | Merge pull request #8116 from senny/7993_configure_counter_cache_for_has_manyJon Leighton2012-11-093-2/+5
|\ \ | | | | | | :counter_cache option for to support custom named counter caches
| * | :counter_cache option for to support custom named counter caches. Closes #7993Yves Senn2012-11-043-2/+5
| | |
* | | Delegate all calculations to the scope.Jon Leighton2012-11-092-4/+6
| | | | | | | | | | | | | | | | | | | | | So that the scope may be a NullRelation and return a result without executing a query. Fixes #7928
* | | CollectionProxy#pluck issues no query for a new_record? ownerJon Leighton2012-11-091-0/+4
| | | | | | | | | | | | | | | | | | | | | Fixes #8102. I couldn't find a nicer way to deal with this than delegate the call to #scope, which will be a NullRelation when we want it to be.
* | | Nullify the relation at a more general level.Jon Leighton2012-11-093-7/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to avoid hacks like the "return 0 if owner.new_record?" in #count (which this commit removes). Also, the relevant foreign key may actually be present even on a new owner record, in which case we *don't* want a null relation. This logic is encapsulated in the #null_scope? method. We also need to make sure that the CollectionProxy is not 'infected' with the NullRelation module, or else the methods from there will override the definitions in CollectionProxy, leading to incorrect results. Hence the nullify: false option to CollectionAssociation#scope. (This feels a bit nasty but I can't think of a better way.)
* | | Relations built off collection associations with an unsaved owner should be ↵Jon Leighton2012-11-091-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | null relations For example, the following should not run any query on the database: Post.new.comments.where(body: 'omg').to_a # => [] Fixes #5215.
* | | Remove not used indifferent_access requires from Base and FinderMethodsCarlos Antonio da Silva2012-11-072-3/+0
| | |
* | | Use cached quoted_table_name instead of going through the connectionCarlos Antonio da Silva2012-11-071-1/+1
| | |
* | | Remove block given check from private find_with_idsCarlos Antonio da Silva2012-11-071-2/+0
| | | | | | | | | | | | | | | This is already handled by #find, it's a duplicate check, since find_with_ids is not called from anywhere else.
* | | stop raising so many exceptionsAaron Patterson2012-11-071-1/+5
| | |
* | | adding requires for constant dependenciesAaron Patterson2012-11-072-0/+6
| | |
* | | Use flat_map when building AR orderCarlos Antonio da Silva2012-11-041-6/+4
|/ /
* | Check if the options value is present before to send the deprecationRafael Mendonça França2012-11-031-4/+6
| | | | | | | | message
* | Remove old commentRafael Mendonça França2012-11-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This comment is not valid since that `if` is there to make possible to do: remove_index :users, :name Instead of: remove_index :users, column: :name What is a valid use case. [ci skip]
* | Deprecate passing a string as third argument of `add_index`Rafael Mendonça França2012-11-021-0/+6
| | | | | | | | | | | | | | This was there due historical reasons since 7dc45818dc43c163700efc9896a0f3feafa31138 to give the user the possibility to create unique indexes passing "UNIQUE" as the third argument
* | Raise an ArgumentError when passing an invalid option to add_indexRafael Mendonça França2012-11-021-1/+4
| | | | | | | | Closes #8104
* | Merge pull request #8106 from steveklabnik/fix_grammarCarlos Antonio da Silva2012-11-021-1/+1
|\ \ | |/ |/| Fixed grammar in migration pending error.
| * Fixed grammar in migration pending error.Steve Klabnik2012-11-021-1/+1
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-11-0319-103/+161
|\ \ | |/ |/| | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md
| * copy edits [ci skip]Vijay Dev2012-11-031-6/+3
| |
| * This is comment for singular association.kennyj2012-11-021-1/+1
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 10:58:56 +0000