Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | | Extract `casted_true`/`casted_false` for `Type::ImmutableString` | Ryuta Kamizono | 2017-01-01 | 1 | -14/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The only difference between `Type::ImmutableString` and its subclasses is the representation of the casted booleans. Prefer extracting `casted_true`/`casted_false` and override these by subclasses. | |||||
* | | | | | | | Refactor `CollectionAssociation#ids_reader` | Ryuta Kamizono | 2017-01-01 | 1 | -3/+1 | |
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Simply we can do `target.pluck(reflection.association_primary_key)` if `target` is loaded. | |||||
* / / / / / | Dump array subtype options correctly | Ryuta Kamizono | 2017-01-01 | 1 | -1/+1 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | Currently schema dumper does not dump array subtype `precision` and `scale` options. This commit fixes the issue. | |||||
* | | | | | Merge pull request #27441 from koic/quoted_insert_version_sql | Kasper Timm Hansen | 2016-12-31 | 1 | -4/+4 | |
|\ \ \ \ \ | | | | | | | | | | | | | Add a quote to an SQL insert statement of schema migration | |||||
| * | | | | | Add a quote to an SQL insert statement of schema migration | Koichi ITO | 2016-12-23 | 1 | -4/+4 | |
| | |/ / / | |/| | | | ||||||
* | | | | | [ci skip] Retouch some association wording. | Kasper Timm Hansen | 2016-12-31 | 1 | -3/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Trim some needless words off the lines and format the code sample like we'd write in the Rails source. | |||||
* | | | | | [ci skip] Remove mention of GeneratedAssociationMethods | Kasper Timm Hansen | 2016-12-31 | 1 | -4/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Marked as private in 2afe5a1 and doesn't seem worth it to mention the module name here. | |||||
* | | | | | Merge pull request #27521 from ↵ | Kasper Timm Hansen | 2016-12-31 | 1 | -0/+2 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/mark-one-more-constant-as-private Mark :GeneratedAssociationMethods also as private_constant | |||||
| * | | | | | Mark :GeneratedAssociationMethods also as private_constant | Prathamesh Sonpatki | 2016-12-31 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - After https://github.com/rails/rails/commit/64e5b897ac944a05a33275e3828a3d4047a6b457, only :GeneratedAssociationMethods was remaining to be marked as private constant, so marked it as well. - Before: >> User.constants(false) => [:GeneratedAssociationMethods] - After: >> User.constants(false) => [] | |||||
* | | | | | | Bump license years for 2017 | Jon Moss | 2016-12-31 | 1 | -1/+1 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip] | |||||
* | | | | | Mark internal cache constants as private | Matthew Draper | 2016-12-31 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | | | | | Closes #14640 | |||||
* | | | | | Remove deprecated `#uniq`, `#uniq!`, and `#uniq_value` | Ryuta Kamizono | 2016-12-30 | 2 | -13/+0 | |
| | | | | | ||||||
* | | | | | Remove deprecated `#insert_sql`, `#update_sql`, and `#delete_sql` | Ryuta Kamizono | 2016-12-30 | 1 | -6/+0 | |
| | | | | | ||||||
* | | | | | Remove deprecated #use_transactional_fixtures configuration | Rafael Mendonça França | 2016-12-29 | 1 | -13/+1 | |
| | | | | | ||||||
* | | | | | Remove deprecated `#raise_in_transactional_callbacks` configuration | Rafael Mendonça França | 2016-12-29 | 1 | -10/+0 | |
| | | | | | ||||||
* | | | | | Remove deprecated #load_schema_for | Rafael Mendonça França | 2016-12-29 | 1 | -8/+0 | |
| | | | | | ||||||
* | | | | | Remove deprecated conditions parameter from #delete_all | Rafael Mendonça França | 2016-12-29 | 1 | -19/+11 | |
| | | | | | ||||||
* | | | | | Remove deprecated conditions parameter from `#destroy_all` | Rafael Mendonça França | 2016-12-29 | 1 | -10/+2 | |
| | | | | | ||||||
* | | | | | Remove deprecated support to passing arguments to `#select` when a block is ↵ | Rafael Mendonça França | 2016-12-29 | 1 | -3/+1 | |
| | | | | | | | | | | | | | | | | | | | | provided. | |||||
* | | | | | Remove deprecated support to query using commas on LIMIT | Rafael Mendonça França | 2016-12-29 | 2 | -25/+3 | |
| | | | | | ||||||
* | | | | | Remove deprecated support to passing a class as a value in a query | Rafael Mendonça França | 2016-12-29 | 2 | -31/+0 | |
| | | | | | ||||||
* | | | | | Raises IrreversibleOrderError when using last with an irreversible order | Rafael Mendonça França | 2016-12-29 | 1 | -8/+0 | |
| | | | | | ||||||
* | | | | | Raise when a through association has an ambiguous reflection name | Rafael Mendonça França | 2016-12-29 | 2 | -9/+22 | |
| | | | | | ||||||
* | | | | | Raises when `ActiveRecord::Migration` is inherited directly. | Rafael Mendonça França | 2016-12-29 | 2 | -42/+25 | |
| | | | | | ||||||
* | | | | | Remove original_exception from ActiveRecord::StatementInvalid | Rafael Mendonça França | 2016-12-29 | 2 | -12/+2 | |
| | | | | | ||||||
* | | | | | `#tables` and `#table_exists?` and returns only tables and not views | Rafael Mendonça França | 2016-12-29 | 7 | -77/+61 | |
| | | | | | ||||||
* | | | | | Remove deprecated `name` argument from `#tables` | Rafael Mendonça França | 2016-12-29 | 4 | -22/+4 | |
| | | | | | ||||||
* | | | | | Remove deprecated support to passing a column to #quote | Rafael Mendonça França | 2016-12-29 | 1 | -11/+1 | |
| | | | | | ||||||
* | | | | | Set time as a timezone aware type and remove related deprecation | Rafael Mendonça França | 2016-12-29 | 1 | -23/+2 | |
| | | | | | ||||||
* | | | | | Remove deprecated force reload argument in association readers | Rafael Mendonça França | 2016-12-29 | 2 | -20/+4 | |
| | | | | | ||||||
* | | | | | Remove deprecated i18n scopes in Active Record | Rafael Mendonça França | 2016-12-29 | 2 | -16/+2 | |
| | | | | | ||||||
* | | | | | Merge pull request #27493 from kamipo/sync_visibility | Rafael França | 2016-12-29 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | Sync the visibility of `sql_for_insert` to private | |||||
| * | | | | | Sync the visibility of `sql_for_insert` to private | Ryuta Kamizono | 2016-12-29 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The visibility of all internal protected methods was changed to private since 5b14129. | |||||
* | | | | | | Remove try! usage in sqlite_database_tasks. | Kasper Timm Hansen | 2016-12-29 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | We try to not try! internally. | |||||
* | | | | | | Merge pull request #27437 from kirs/structure-load-dump-flags | Kasper Timm Hansen | 2016-12-29 | 4 | -11/+28 | |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Make ActiveRecord structure load/dump configurable | |||||
| * | | | | | Make ActiveRecord structure load/dump configurable | Kir Shatrov | 2016-12-22 | 4 | -11/+28 | |
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this patch it's impossible to pass extra flags to mysqldump/pg_dump when running `rake db:structure:dump` or `load` The following config variables (`structure_load_flags` and `structure_dump_flags`) make it better configurable. | |||||
* | | | | | Merge pull request #27490 from ↵ | Rafael França | 2016-12-29 | 1 | -4/+6 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | kamipo/should_not_update_children_when_parent_creation_with_no_reason Should not update children when the parent creation with no reason | |||||
| * | | | | Should not update children when the parent creation with no reason | Ryuta Kamizono | 2016-12-29 | 1 | -4/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This issue was introduced with d849f42 to solve #19782. However, we can solve #19782 without causing the issue. It is enough to save only when necessary. Fixes #27338. | |||||
* | | | | | Merge pull request #26376 from kamipo/remove_polymorphic_base_class_for_array | Rafael França | 2016-12-29 | 1 | -3/+0 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Remove extracting `polymorphic_base_class` for `Array` in `AssociationQueryValue` | |||||
| * | | | | Remove extracting `polymorphic_base_class` for `Array` in ↵ | Ryuta Kamizono | 2016-09-21 | 1 | -3/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `AssociationQueryValue` It is handled by `PolymorphicArrayValue`. | |||||
* | | | | | Merge pull request #27402 from yui-knk/execute | Rafael França | 2016-12-28 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | Use `#execute` instead of `@connection.query` | |||||
| * | | | | | Use `#execute` instead of `@connection.query` | yui-knk | 2016-12-19 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `@connection.query` bypasses instrumenting "sql.active_record". This behavior preventing us from debugging SQLs which Rails generates. | |||||
* | | | | | | Fix Rubocop violations and fix documentation visibility | Rafael Mendonça França | 2016-12-28 | 15 | -147/+147 | |
| |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API. | |||||
* | | | | | Merge pull request #27442 from kamipo/fix_27434 | Eileen M. Uchitelle | 2016-12-27 | 2 | -13/+16 | |
|\ \ \ \ \ | | | | | | | | | | | | | Add a record to target before any callbacks loads the record | |||||
| * | | | | | Add a record to target before any callbacks loads the record | Ryuta Kamizono | 2016-12-23 | 2 | -13/+16 | |
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `append_record` was added at 15ddd51 for not double adding the record. But adding `append_record` (checking `@target.include?(record)`) caused performance regression #27434. Instead of checking not double adding the record, add a record to target before any callbacks loads the record. Fixes #27434. | |||||
* | | | | | No need `:doc:` for `:nodoc:` classes [ci skip] | Ryuta Kamizono | 2016-12-25 | 5 | -15/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 5b14129d8d4ad302b4e11df6bd5c7891b75f393c. http://edgeapi.rubyonrails.org/classes/ActiveRecord/Attribute.html | |||||
* | | | | | AR::ConnectionAdapters::PostgreSQL::Name#parts is called from other instances | Akira Matsuda | 2016-12-25 | 1 | -4/+6 | |
| | | | | | ||||||
* | | | | | Privatize unneededly protected methods in Active Record | Akira Matsuda | 2016-12-24 | 26 | -158/+145 | |
| | | | | | ||||||
* | | | | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 11 | -31/+31 | |
| | | | | | ||||||
* | | | | | Describe what we are protecting | Akira Matsuda | 2016-12-23 | 24 | -0/+50 | |
|/ / / / |