Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | | remove klass delegator | Aaron Patterson | 2014-02-14 | 1 | -10/+11 | |
| | | | | | | ||||||
* | | | | | | remove chain delegate | Aaron Patterson | 2014-02-14 | 1 | -5/+6 | |
| | | | | | | ||||||
* | | | | | | remove scope_chain delegate | Aaron Patterson | 2014-02-14 | 1 | -3/+3 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #14048 from pcreux/better-error-message-db-migrate-down | Carlos Antonio da Silva | 2014-02-14 | 1 | -1/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Add hint to error message of task db:migrate:down | |||||
| * | | | | | | Add hint to error message of task db:migrate:down | Philippe Creux | 2014-02-13 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | remove more delegate methods | Aaron Patterson | 2014-02-13 | 1 | -7/+9 | |
| | | | | | | | ||||||
* | | | | | | | :scissors: whitespace | Aaron Patterson | 2014-02-13 | 1 | -1/+0 | |
| | | | | | | | ||||||
* | | | | | | | rm delegate methods that are not actually used | Aaron Patterson | 2014-02-13 | 1 | -2/+2 | |
| | | | | | | | ||||||
* | | | | | | | JoinHelper is never reused, so there is no need to separate | Aaron Patterson | 2014-02-13 | 3 | -42/+25 | |
| | | | | | | | ||||||
* | | | | | | | speed up the collection proxy reader method, but slow down the constructor | Aaron Patterson | 2014-02-13 | 1 | -1/+5 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #14034 from ↵ | Yves Senn | 2014-02-13 | 1 | -1/+6 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hdabrows/drop-correct-index-when-reverting-migration Drop the correct index after reverting a migration | |||||
| * | | | | | | | Drop the correct index after reverting a migration | Hubert Dąbrowski | 2014-02-13 | 1 | -1/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously when reverting a migration which added a named index it would instead drop a corresponding index with matching columns but without a name. | |||||
* | | | | | | | | Dont use Enumarator on join_association | Arthur Neves | 2014-02-13 | 1 | -2/+4 | |
| | | | | | | | | ||||||
* | | | | | | | | `execute` is a hotspot, so let's reduce branches | Aaron Patterson | 2014-02-12 | 1 | -6/+2 | |
|/ / / / / / / | ||||||
* | | | | | | | adding missed change | kayvan | 2014-02-11 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | adding connection parameter to check_pending for migrations | kayvan | 2014-02-11 | 1 | -5/+5 | |
| | | | | | | | ||||||
* | | | | | | | Avoid using deprecated arel constants | Rafael Mendonça França | 2014-02-10 | 2 | -3/+3 | |
| | | | | | | | ||||||
* | | | | | | | move alias method `sanitize_conditions` to a correct place | Dmitry Polushkin | 2014-02-09 | 1 | -2/+1 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #13981 from Fortisque/kevin/postgresql_reaper_threadsafe | Aaron Patterson | 2014-02-08 | 3 | -2/+13 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Reaper has access to threadsafe active? call | |||||
| * | | | | | | | Reaper has access to threadsafe active? call | Kevin Casey | 2014-02-08 | 3 | -2/+13 | |
| | |_|/ / / / | |/| | | | | | ||||||
* / | | | | | | context in validation goes through has many relationship | Kevin Casey | 2014-02-08 | 1 | -1/+1 | |
|/ / / / / / | ||||||
* | | | | | | Merge branch 'dump-schema-after-migration-flag' of ↵ | Xavier Noria | 2014-02-06 | 2 | -1/+10 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://github.com/emilsoman/rails into emilsoman-dump-schema-after-migration-flag Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | | | | Add config to disable schema dump after migration | Emil Soman | 2014-02-06 | 2 | -1/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add a config on Active Record named `dump_schema_after_migration` * Schema dump doesn't happen if the config is set to false * Set default value of the config to true * Set config in generated production environment file to false * Update configuration guide * Update CHANGELOG | |||||
* | | | | | | | Return sized enumerator from Batches#find_each | Marc-Andre Lafortune | 2014-02-05 | 2 | -2/+4 | |
| | | | | | | | ||||||
* | | | | | | | Return sized enumerator from Batches#find_in_batches | Marc-Andre Lafortune | 2014-02-05 | 1 | -4/+9 | |
| | | | | | | | ||||||
* | | | | | | | docs, AR already auto-detects primary keys. Closes #13946. [ci skip] | Yves Senn | 2014-02-05 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior was introduced since Rails 3.1 (207f266ccaaa9cd04cd2a7513ae5598c4358b510) but the docs were still out of date. | |||||
* | | | | | | | Document that enum conditions must use the ordinal value | Rafael Mendonça França | 2014-02-04 | 1 | -0/+2 | |
|/ / / / / / | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | | Merge pull request #13935 from arthurnn/fix_12566 | Rafael Mendonça França | 2014-02-04 | 1 | -1/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Make sure transaction state resets after commit | |||||
| * | | | | | | Make sure transaction state resets after commit | Arthur Neves | 2014-02-03 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [fixes #12566] | |||||
* | | | | | | | Merge pull request #13899 from ↵ | Rafael Mendonça França | 2014-02-04 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | Fortisque/kevin/active_record_HABTM_with_belongs_to destruction errors out on HABTM w/out primary key | |||||
| * | | | | | | fix HABTM w/out primary key errors on destruction | Kevin Casey | 2014-02-02 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | some wording format changes. [ci skip] | Yves Senn | 2014-02-03 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | pass `habtm :autosave` to underlying `hm:t` association. Closes #13923. | Yves Senn | 2014-02-03 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | docs, revisit polymorphic associations with STI example. [ci skip] | Yves Senn | 2014-02-03 | 1 | -2/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to #13926. /cc @fxn | |||||
* | | | | | | | Fixes the camelCase variable name in the docs [ci skip] | Fred Wu | 2014-02-03 | 1 | -2/+2 | |
| | | | | | | | ||||||
* | | | | | | | Make arel methods private API | Rafael Mendonça França | 2014-02-01 | 2 | -6/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since its conception arel was made to be private API of Active Record. If users want to use arel features directly we should provide a way using the Active Record API without exposing the arel implementation. | |||||
* | | | | | | | Merge pull request #13688 from jbaudanza/psql-index-exists | Rafael Mendonça França | 2014-02-01 | 1 | -0/+13 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PostgreSQL implementation of SchemaStatements#index_name_exists? Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | | | | | psql implementation of #index_name_exists? | Jonathan Baudanza | 2014-01-16 | 1 | -0/+13 | |
| | | | | | | | | ||||||
* | | | | | | | | Fixes issue with parsing whitespace content back from database - fixes #13907 | Mauricio Linhares | 2014-02-01 | 1 | -2/+3 | |
| | | | | | | | | ||||||
* | | | | | | | | this class depends on JoinHelper, so we should require it | Aaron Patterson | 2014-01-31 | 1 | -0/+2 | |
| |/ / / / / / |/| | | | | | | ||||||
* | | | | | | | Associations now raise `ArgumentError` on name conflicts. | Lauro Caetano | 2014-01-31 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Dangerous association names conflicts include instance or class methods already defined by `ActiveRecord::Base`. | |||||
* | | | | | | | Merge pull request #13859 from huoxito/let-it-go | Rafael Mendonça França | 2014-01-30 | 1 | -2/+0 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Let `unscope` ignore non Arel scope.where_values | |||||
| * | | | | | | | Let `unscope` ignore non Arel scope.where_values | Washington Luiz | 2014-01-30 | 1 | -2/+0 | |
| | | | | | | | | ||||||
* | | | | | | | | Merge pull request #13886 from arthurnn/fix_relation_arel | Rafael Mendonça França | 2014-01-30 | 6 | -18/+21 | |
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | Fix regression on .select method | |||||
| * | | | | | | | Fix regression on `.select_*` methods. | Arthur Neves | 2014-01-30 | 6 | -18/+21 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was a common pattern: ``` query = author.posts.select(:title) connection.select_one(query) ``` However `.select` returns a ActiveRecord::AssociationRelation, which has the bind information, so we can use that to get the right sql query. Also fix select_rows on postgress and sqlite3 that were not using the binds [fixes #7538] [fixes #12017] [related #13731] [related #12056] | |||||
* | | | | | | | | Merge pull request #13878 from marcandre/leave_my_options_alone | Rafael Mendonça França | 2014-01-30 | 1 | -2/+2 | |
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | find_in_batches should not mutate its argument | |||||
| * | | | | | | | | find_in_batches should not mutate its argument | Marc-Andre Lafortune | 2014-01-29 | 1 | -2/+2 | |
| | | | | | | | | | ||||||
* | | | | | | | | | docs, `references` is only used with `includes`. Closes #13727. | Yves Senn | 2014-01-30 | 1 | -9/+14 | |
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no gain in `referencing` tables that are not used for preloading. Furthermore it will break if polymorphic associations are invloved. This is because `references_eager_loaded_tables?` uses all `reference_values` to decide wether to `eager_load` or `preload`. | |||||
* | | | | | | | | Aesthetic | Rafael Mendonça França | 2014-01-29 | 1 | -6/+5 | |
| | | | | | | | | ||||||
* | | | | | | | | Fixing issue with activerecord serialization not being able to dump a record ↵ | Mauricio Linhares | 2014-01-29 | 3 | -1/+17 | |
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | after loading it from YAML - fixes #13861 |