aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Relation#inspect handles doesn't perform a new query on an already-loaded ↵Jon Leighton2012-07-071-1/+4
| | | | relation
* Simplify Relation#inspectJon Leighton2012-07-071-12/+3
|
* Merge pull request #6993 from morgoth/engine-table-name-prefix-generator-fixJosé Valim2012-07-071-1/+1
|\ | | | | Engine table name prefix generator fix
| * Fixed generating namespaced table_name_prefix in enginesWojciech Wnętrzak2012-07-061-1/+1
| |
* | Merge pull request #6997 from kennyj/fix_stored_attributesJosé Valim2012-07-072-2/+2
|\ \ | | | | | | Added *instance_writer: false* to stored/serialized attributes.
| * | Added *instance_writer: false* for stored/serialized attributes.kennyj2012-07-072-2/+2
| |/
* / Limit the number of records in Relation#inspectDamien Mathieu2012-07-061-1/+13
|/ | | | While it's interesting to have the results array, it can make a console or a webpage freeze if there are a lot of them. So this limits the number of records displayed in #inspect to 10 and tells how much were effectively found.
* Merge pull request #6985 from sidonath/disable-query-cache-for-locksRafael Mendonça França2012-07-061-1/+9
|\ | | | | Disable query cache for lock queries
| * Disable query cache for lock queriesDamir Zekic2012-07-061-1/+9
| | | | | | | | Fixes #867
* | Show the records in Relation#inspectJon Leighton2012-07-061-0/+4
|/ | | | | | | | | | | | | | | | | The reason for removing the previous implementation of `#inspect` was that it hid from you that you were dealing with a `Relation` rather than an `Array`. But it is still useful to be able to see the records, particularly if you're writing something like the following in tests: assert_equal [foo], Post.where(:bar) If the assertion fails, you want to see what records were actually loaded. So this implementation makes it clear that you've got a `Relation`, but also shows your records.
* Merge pull request #6927 from parndt/patch-3Carlos Antonio da Silva2012-07-051-2/+2
|\ | | | | Make ArgumentError message more consistent in nested attributes
| * Made ArgumentError messages consistent.Philip Arndt2012-07-061-2/+2
| |
* | Add documentation for inheritance_column methodVitor Balocco2012-07-051-1/+3
| |
* | fix quoting for ActiveSupport::Duration instancesFrancesco Rodriguez2012-07-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes quoting for ActiveSupport::Duration instances: # before >> ActiveRecord::Base.connection.quote 30.minutes => "'--- 1800\n...\n'" # after >> ActiveRecord::Base.connection.quote 30.minutes => "1800" Also, adds a test for type casting ActiveSupport::Duration instances. Related to #1119.
* | Don't need to use delete in the options hashRafael Mendonça França2012-07-032-3/+2
| |
* | Refactor references schema definitionsAleksey Magusev2012-07-031-18/+12
| |
* | Make references statements reversibleAleksey Magusev2012-07-031-1/+13
| |
* | Add references schema statementsAleksey Magusev2012-07-031-0/+37
| | | | | | | | | | | | | | | | | | | | Examples: add_reference :products, :supplier, polymorphic: true, index: true remove_reference :products, :user `add_belongs_to` and `remove_belongs_to` are acceptable.
* | Don't mark the store as changed if an attribute isn't changed.kennyj2012-07-031-2/+5
|/
* Unify the collation API for the database adptersRafael Mendonça França2012-07-012-5/+5
|
* Merge pull request #6913 from lexmag/column_exists_optionsCarlos Antonio da Silva2012-06-301-4/+6
|\ | | | | | | | | | | | | | | | | Add :default and :null options to column_exists? method Examples: column_exists?(:testings, :taggable_id, :integer, null: false) column_exists?(:testings, :taggable_type, :string, default: 'Photo')
| * Add more options to column_exists? methodAleksey Magusev2012-06-301-4/+6
| | | | | | | | Also fix failures in check options for nil
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-06-302-5/+15
|\ \ | | | | | | | | | | | | Conflicts: activemodel/lib/active_model/errors.rb
| * | update AR::FinderMethods#exists?(false) example [ci skip]Francesco Rodriguez2012-06-281-5/+7
| | |
| * | Mention effect of accepts_nested_attributes_for on association autosave ↵Chris Gunther2012-06-271-0/+8
| | | | | | | | | | | | option [ci skip]
* | | Fix collation database task to use begin..rescue..endCarlos Antonio da Silva2012-06-301-4/+6
| | |
* | | Extract collation tasks to database tasks.kennyj2012-07-014-8/+20
| | |
* | | Remove ActiveRelation#inspectBrian Cardarella2012-06-291-4/+0
| | |
* | | Remove unused responsibilities and add a few load definitions to enginesJosé Valim2012-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since plugins were removed, we can clean up a few methods in engines. We also use this opportunity to move `load_console`, `load_tasks` and `load_runner` to Rails::Engine. This means that, if someone wants to improve script/rails for engines to support console or runner commands, part of the work is already done.
* | | Require URIChris Bandy2012-06-281-0/+2
| | |
* | | Support collate and ctype on the PostgreSQL.kennyj2012-06-291-1/+20
| | |
* | | fixing typo in from documentationSubba Rao Pasupuleti2012-06-281-2/+2
| | |
* | | fix: limit of enum columns of mysqlYamada Masaki2012-06-281-0/+2
| | |
* | | Fixes #6825, adds tests covering cases and error possibilities, also changes ↵Mauricio Linhares2012-06-272-16/+25
| |/ |/| | | | | SQLite3 driver to correctly generate a time column instead of datetime
* | Merge pull request #6880 from kennyj/fix_20120628Carlos Antonio da Silva2012-06-271-1/+1
|\ \ | | | | | | Fix wrong testcase for db:test:prepare, and wrong environment in AR rake task.
| * | Fix wrong environment. env should be RAILS_ENV or test.kennyj2012-06-281-1/+1
| | |
* | | Merge pull request #6856 from lexmag/polymorphic_generatorsCarlos Antonio da Silva2012-06-271-1/+1
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | Add polymorphic option to model generator For instance, $ rails g model Product supplier:references{polymorphic} generate model with `belongs_to :supplier, polymorphic: true` association and appropriate migration.
| * | Add polymorphic option to model generatorAleksey Magusev2012-06-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For instance, $ rails g model Product supplier:references{polymorphic} generate model with `belongs_to :supplier, polymorphic: true` association and appropriate migration. Also fix model_generator_test.rb#L196 and #L201
* | | Use args.flatten! in query methods when applicableCarlos Antonio da Silva2012-06-251-7/+12
| | | | | | | | | | | | | | | Try to use more destructive methods on *args when applicable, to avoid creating new objects.
* | | Merge pull request #6544 from flexoid/issue-6431Piotr Sarnacki2012-06-251-6/+6
|\ \ \ | | | | | | | | exists?(false) returns false
| * | | exists?(false) returns falseEgor Lynko2012-06-251-6/+6
| |/ / | | | | | | | | | `FinderMethods#exists?` finder method now returns *false* with the *false* argument
* | | Ensure Arel columns are typecasted properly when grouping with calculationCarlos Antonio da Silva2012-06-251-6/+6
| | | | | | | | | | | | Fix build issue with postgresql.
* | | Move to db:structure namespace, because these methods are global.kennyj2012-06-261-8/+9
| | |
* | | Remove session_table_name method because this is global and used only once.kennyj2012-06-261-5/+1
| | |
* | | Add a description about ENV["SCOPE"]kennyj2012-06-261-1/+1
| | |
* | | Change the behavior of db:test:prepare task when schema_format is sql for ↵kennyj2012-06-261-1/+1
| | | | | | | | | | | | consistency.
* | | Change the behavior of db:test:clone task when schema_format is sql for ↵kennyj2012-06-261-1/+11
| | | | | | | | | | | | consistency.
* | | Change an order of methods for readbility.kennyj2012-06-261-7/+7
|/ /
* | Revert "Merge pull request #6344"Piotr Sarnacki2012-06-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit needs to be reverted because it introduces difficulties when using sqlite3 in development and other databases in production. This happens because when you create time column in sqlite3, it's dumped as datetime in schema.rb file. This reverts commit 57d534ee9e441d078fcc161c0c78ebaa5aacd736, reversing changes made to 20f049fb50daee0c5e5a69b55b529af5737e8e3f. Conflicts: activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
* | Stop assuming strings for grouped calculationsErnie Miller2012-06-241-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Execute_grouped_calculation is one of those places where ActiveRecord forgets that it has ARel underpinnings, and assumes that the values provided to group_values are strings. This artificially hobbles otherwise functional code. This patch stops assuming that incoming values respond to to_sym, stops using string interpolation for table aliases on objects that support aliasing, and stops unnecessarily joining group_values on the relation. Additionally, it calls to_sql, if available, on objects sent to column_alias_for, in order to get a more reasonable alias string than a non-string's default to_str method.