aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix destructive side effects from marshaling an association caused by ↵Jeremy Kemper2012-09-251-5/+2
| | | | 65843e1acc0c8d285ff79f8c9c49d4d1215440be
* make clear that expired db/schema_cache.dump are ignoredXavier Noria2012-09-241-1/+1
|
* start could be a stringSantiago Pastorino2012-09-211-1/+1
| | | | | Related to 761bc751d31c22e2c2fdae2b4cdd435b68b6d783 and eb876c4d07130f15be2cac7be968cc393f959c62
* Revert "Fix find_in_batches with customized primary_key"Santiago Pastorino2012-09-211-7/+6
| | | | | | | This reverts commit 761bc751d31c22e2c2fdae2b4cdd435b68b6d783. This commit wasn't fixing any issue just using the same table for different models with different primary keys.
* Correct default charset/collation for mysql dbsJeremy Kemper2012-09-211-6/+9
|
* Use default charset/collation only if *neither* is specified. Otherwise we ↵Jeremy Kemper2012-09-211-4/+7
| | | | set utf8_unicode_ci collation on latin1 table.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-09-212-8/+16
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/configurable.rb activesupport/lib/active_support/core_ext/module/deprecation.rb guides/source/action_controller_overview.md guides/source/active_support_core_extensions.md guides/source/ajax_on_rails.textile guides/source/association_basics.textile guides/source/upgrading_ruby_on_rails.md While resolving conflicts, I have chosen to ignore changes done in docrails at some places - these will be most likely 1.9 hash syntax changes.
| * Add extra note about :dependent => :destroy.Steve Klabnik2012-09-211-1/+4
| | | | | | | | Callbacks may interfere with each other.
| * fix :nodoc:s in AR::Timestamp [ci skip]Francesco Rodriguez2012-09-191-7/+7
| |
| * Doc typo: depenent -> dependent; trailing ws.Henrik N2012-09-161-2/+2
| |
| * Improve documentation about :dependent and callbacks.Steve Klabnik2012-09-151-0/+5
| | | | | | | | Fixes #3458.
* | Support for specifying transaction isolation levelJon Leighton2012-09-217-15/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If your database supports setting the isolation level for a transaction, you can set it like so: Post.transaction(isolation: :serializable) do # ... end Valid isolation levels are: * `:read_uncommitted` * `:read_committed` * `:repeatable_read` * `:serializable` You should consult the documentation for your database to understand the semantics of these different levels: * http://www.postgresql.org/docs/9.1/static/transaction-iso.html * https://dev.mysql.com/doc/refman/5.0/en/set-transaction.html An `ActiveRecord::TransactionIsolationError` will be raised if: * The adapter does not support setting the isolation level * You are joining an existing open transaction * You are creating a nested (savepoint) transaction The mysql, mysql2 and postgresql adapters support setting the transaction isolation level. However, support is disabled for mysql versions below 5, because they are affected by a bug (http://bugs.mysql.com/bug.php?id=39170) which means the isolation level gets persisted outside the transaction.
* | Merge pull request #5248 from ↵Jon Leighton2012-09-211-0/+1
|\ \ | | | | | | | | | | | | jcoleman/should-unset-association-when-an-existing-record-is-destroyed Unset association when existing record is destroyed.
| * | Unset association when existing record is destroyed.James Coleman2012-03-021-0/+1
| | | | | | | | | | | | To avoid foreign key errors (and invalid data) in the database, when a belongs_to association is destroyed, it should also be nil'd out on the parent object.
* | | rename AR::Model::Tag to AR::Tag - fixes #7714Francesco Rodriguez2012-09-204-12/+12
| | |
* | | Freeze columns only once per ResultSantiago Pastorino2012-09-201-6/+9
| | |
* | | Freeze columns just before using them as hash keysSantiago Pastorino2012-09-201-2/+5
| | |
* | | Merge pull request #7631 from jeremyevans/patch-1Aaron Patterson2012-09-191-1/+1
|\ \ \ | | | | | | | | Freeze columns before using them as hash keys
| * | | Freeze columns before using them as hash keysJeremy Evans2012-09-131-1/+1
| | | | | | | | | | | | This reduces the number of allocated strings from columns * (rows + 1) to just columns.
* | | | update AR::AttributeAssignment documentation [ci skip]Francesco Rodriguez2012-09-191-5/+5
| | | |
* | | | Merge pull request #7710 from guilleiguaran/refactor-ar-attributes-methodRafael Mendonça França2012-09-191-10/+4
|\ \ \ \ | | | | | | | | | | AR::Base#attributes= is just an alias for AR::Base#assign_attributes
| * | | | AR::Base#attributes= is just an alias for AR::Base#assign_attributesGuillermo Iguaran2012-09-191-10/+4
| | | | |
* | | | | Fix out-of-date URL.Alex Reisner2012-09-191-1/+1
| | | | |
* | | | | Load the environment after creating the databaseJeremy Kemper2012-09-191-2/+2
| | | | |
* | | | | Revert "Make sure :environment task is executed before db:schema:load or ↵Jeremy Kemper2012-09-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | db:structure:load " Breaks db:setup because it tries to load the environment before creating the database. This reverts commit 5ca11fefce6d83f5db399aa4412f1f1a0d42b2e6.
* | | | | fix querying with an empty hashDamien Mathieu2012-09-191-2/+6
| | | | | | | | | | | | | | | | | | | | Closes #6960
* | | | | Remove unused private method AR::NestedAttributes#unassignable_keys and ↵Guillermo Iguaran2012-09-191-5/+1
|/ / / / | | | | | | | | | | | | reference to mass_assignment options
* | | | Update AR::Base.create and AR:Base#update_attributes docs to remove ↵Guillermo Iguaran2012-09-181-11/+0
| | | | | | | | | | | | | | | | references to mass assignment options
* | | | Update docs for AR::Base#new to remove references to mass_assignment_optionsGuillermo Iguaran2012-09-181-10/+1
| | | |
* | | | Merge pull request #7251 from rails/integrate-strong_parametersDavid Heinemeier Hansson2012-09-1815-176/+74
|\ \ \ \ | | | | | | | | | | Integrate strong_parameters in Rails 4
| * | | | Set primary key with id= only if primary key existsGuillermo Iguaran2012-09-161-1/+1
| | | | |
| * | | | Remove mass_assignment_options from ActiveRecordGuillermo Iguaran2012-09-1612-79/+62
| | | | |
| * | | | attr_accessible and attr_protected raise an exception pointing to use plugin ↵Guillermo Iguaran2012-09-161-0/+2
| | | | | | | | | | | | | | | | | | | | or new protection model
| * | | | Rename ForbiddenAttributes exception to ForbiddenAttributesErrorGuillermo Iguaran2012-09-161-1/+1
| | | | |
| * | | | Remove mass assignment security from ActiveRecordGuillermo Iguaran2012-09-167-99/+12
| | | | |
* | | | | Merge pull request #7661 from ernie/build-join-records-on-unsaved-hmtRafael Mendonça França2012-09-171-0/+14
|\ \ \ \ \ | |/ / / / |/| | | | Fix collection= on hm:t join models when unsaved
| * | | | Fix collection= on hm:t join models when unsavedErnie Miller2012-09-171-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If assigning to a has_many :through collection against an unsaved object using the collection=[<array_of_items>] syntax, the join models were not properly created, previously.
* | | | | Merge pull request #7547 from danmcclain/pg-arraysRafael Mendonça França2012-09-168-44/+289
|\ \ \ \ \ | | | | | | | | | | | | Adds migration and type casting support for PostgreSQL Array datatype
| * | | | | Moves column dump specific code to a module included in AbstractAdapterDan McClain2012-09-148-44/+289
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having column related schema dumper code in the AbstractAdapter. The code remains the same, but by placing it in the AbstractAdapter, we can then overwrite it with Adapter specific methods that will help with Adapter specific data types. The goal of moving this code here is to create a new migration key for PostgreSQL's array type. Since any datatype can be an array, the goal is to have ':array => true' as a migration option, turning the datatype into an array. I've implemented this in postgres_ext, the syntax is shown here: https://github.com/dockyard/postgres_ext#arrays Adds array migration support Adds array_test.rb outlining the test cases for array data type Adds pg_array_parser to Gemfile for testing Adds pg_array_parser to postgresql_adapter (unused in this commit) Adds schema dump support for arrays Adds postgres array type casting support Updates changelog, adds note for inet and cidr support, which I forgot to add before Removing debugger, Adds pg_array_parser to JRuby platform Removes pg_array_parser requirement, creates ArrayParser module used by PostgreSQLAdapter
* | | | | Remove debug code :bomb:Rafael Mendonça França2012-09-161-1/+0
| | | | |
* | | | | Merge pull request #7651 from steveklabnik/issue_3956Rafael Mendonça França2012-09-161-1/+2
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | Don't preserve SELECT columns on COUNT Closes #7651
| * | | | Don't preserve SELECT columns on COUNTSteve Klabnik2012-09-161-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The COUNT clause of a finder_sql relationship is being rewritten from COUNT(*) to COUNT(table_name.*). This does not appear to be valid syntax in MySQL: ``` mysql> SELECT COUNT( table_name.* ) FROM `table_name`; ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '* ) FROM `table_name`' at line 1 ``` This fixes the bug, as well as adding tests so we don't re-introduce it in the future. Fixes #3956.
* | | | | Don't explain except normal CRUD sql.kennyj2012-09-171-1/+2
| | | | |
* | | | | Fix find_in_batches with customized primary_keyToshiyuki Kawanishi2012-09-161-6/+7
| | | | |
* | | | | Query for sequence info also should be markd as SCHEMA.kennyj2012-09-151-3/+3
| | | | |
* | | | | Query for loading index info should be marked as SCHEMA.kennyj2012-09-152-2/+2
| | | | |
* | | | | simplify rescueJon Leighton2012-09-151-3/+3
|/ / / /
* | | | Fix testJon Leighton2012-09-151-13/+19
| | | | | | | | | | | | | | | | Accidentally checked in commented test code. Fail. >_<
* | | | Ensure disconnecting or reconnecting resets the transaction stateJon Leighton2012-09-155-9/+19
| | | |
* | | | Remove our use of #outside_transaction?Jon Leighton2012-09-152-32/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method was first seen in 045713ee240fff815edb5962b25d668512649478, and subsequently reimplemented in fb2325e35855d62abd2c76ce03feaa3ca7992e4f. According to @jeremy, this is okay to remove. He thinks it was added because at the time we didn't have much transaction state to keep track of, and he viewed it as a hack for us to track it internally, thinking it was better to ask the connection for the transaction state. Over the years we have added more and more state to track, a lot of which is impossible to ask the connection for. So it seems that this is just a relic of the passed and we will just track the state internally only.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 05:56:22 +0000