| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | Possibly clearer way of getting rid of ` and " | Seamus Abshere | 2012-02-01 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Incidentally it's also faster... >> a = 'hello "id` world'; Benchmark.realtime { 500_000.times { a.tr('`"', "") } } => 0.7388770580291748 >> a = 'hello "id` world'; Benchmark.realtime { 500_000.times { a.gsub(/[`"]/, "") } } => 1.7843739986419678 | |||||
| * | | | much code can be deleted thanks to @tenderlove's refactoring | Jon Leighton | 2012-03-28 | 3 | -72/+6 | |
| | | | | ||||||
| * | | | Merge pull request #5616 from cbartlett/migration-indent | Santiago Pastorino | 2012-03-27 | 1 | -2/+2 | |
| |\ \ \ | | | | | | | | | Fix indenting in migration generator | |||||
| | * | | | Fix indenting in migration generator | Colin Bartlett | 2012-03-27 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | $ rails generate migration remove_foo_from_bars foo:string This currently generates: def up remove_column :bars, :foo end Fix it: def up remove_column :bars, :foo end | |||||
| * | | | | Remove Arel::Relation constant from PredicateBuilder. | Juanjo Bazán | 2012-03-27 | 1 | -2/+2 | |
| | | | | | ||||||
| * | | | | attributes are cached by string keys, so to_s to support symbols. fixes #5549 | Aaron Patterson | 2012-03-27 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-27 | 2 | -2/+2 | |
| |\ \ \ \ | |/ / / |/| | | | ||||||
| | * | | | Missing generated query for pluck method. | Juanjo Bazán | 2012-03-27 | 1 | -1/+1 | |
| | | | | | | | | | | | | | (and changed the use of true for a more database agnostic example). | |||||
| | * | | | Use one 'be'. | Waseem Ahmad | 2012-03-24 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Merge pull request #5582 from chendo/master | Xavier Noria | 2012-03-26 | 1 | -1/+1 | |
| |\ \ \ \ | | | | | | | | | | | Remove "needless boolean casting" | |||||
| | * | | | | Remove 'needless boolean casting'. | Jack Chen (chendo) | 2012-03-26 | 1 | -1/+1 | |
| | |/ / / | | | | | | | | | | | | | | | | | "Predicates in Rails rely on standard Ruby semantics for boolean values and guarantee no singletons whatsoever." - @fxn | |||||
| * | | | | Merge pull request #2621 from icco/master | Aaron Patterson | 2012-03-26 | 1 | -1/+1 | |
| |\ \ \ \ | | | | | | | | | | | Issue with schema dump | |||||
| | * | | | | Not checking for nil is apparently a lot faster. | Nat Welch | 2011-09-21 | 1 | -1/+1 | |
| | | | | | | ||||||
| | * | | | | Merge branch 'master' of git://github.com/rails/rails | Nat Welch | 2011-09-21 | 33 | -1616/+1554 | |
| | |\ \ \ \ | ||||||
| | * | | | | | From @dasch's recommendation. | Nat Welch | 2011-08-22 | 1 | -1/+1 | |
| | | | | | | | ||||||
| | * | | | | | Fixes bug with schema dumper when using with Padrino. | Nat Welch | 2011-08-21 | 1 | -1/+1 | |
| | | | | | | | ||||||
| * | | | | | | ActiveRecord::Coders::YAMLColumn#dump should raise an error | Guten | 2012-03-26 | 1 | -1/+7 | |
| | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | closes #2737 Conflicts: activerecord/lib/active_record/coders/yaml_column.rb | |||||
| * | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-24 | 2 | -1/+15 | |
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/ruby_on_rails_guides_guidelines.textile | |||||
| | * | | | | | Adding documentation for ActiveRecord::Base.abstract_class to clarify a ↵ | Joe Goggins | 2012-03-22 | 1 | -0/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | particular usecase for this feature (to allow you to use inheritance in ActiveRecord without using the STI table name | |||||
| | * | | | | | Correct description of ['migrated_at > ?', 1.week.ago] from "more than a ↵ | Dave Burt | 2012-03-20 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | week ago" to "more recently than a week ago." | |||||
| * | | | | | | properly namespace the fixture exception | Aaron Patterson | 2012-03-22 | 1 | -6/+2 | |
| | | | | | | | ||||||
| * | | | | | | Avoid another blank line in generated migration and remove assertion as per ↵ | Marcelo Silveira | 2012-03-21 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | @spastorino request | |||||
| * | | | | | | Deprecate eager-evaluated scopes. | Jon Leighton | 2012-03-21 | 2 | -12/+31 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions | |||||
| * | | | | | | Avoid obscure &Proc.new thing | Jon Leighton | 2012-03-21 | 1 | -2/+2 | |
| | | | | | | | ||||||
| * | | | | | | Remove valid_scope_name? check - use ruby | Jon Leighton | 2012-03-21 | 1 | -11/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods. | |||||
| * | | | | | | no need for cast | Jon Leighton | 2012-03-21 | 1 | -1/+0 | |
| | | | | | | | ||||||
| * | | | | | | no need for lvar | Jon Leighton | 2012-03-21 | 1 | -3/+1 | |
| | | | | | | | ||||||
| * | | | | | | Merge pull request #5532 from mhfs/migration_blank_line | José Valim | 2012-03-21 | 1 | -1/+1 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove blank line from generated migration | |||||
| | * | | | | | | Remove blank line from generated migration | Marcelo Silveira | 2012-03-20 | 1 | -1/+1 | |
| | |/ / / / / | ||||||
| * / / / / / | Generate Migration Thats Adds Removed Index | Travis Jeffery | 2012-03-21 | 1 | -0/+3 | |
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | When generating a migration that removes a field with an index, the down will add both the field and its index. | |||||
| * | | | | | Merge pull request #3329 from armstrjare/autosave_collection_new_record_bug | José Valim | 2012-03-18 | 1 | -1/+6 | |
| |\ \ \ \ \ | | | | | | | | | | | | | Autosave association doesn't save all records on a new record for a collection association if there are records marked for destruction | |||||
| | * | | | | | Fix bug with autosave collection association on new record with a marked for ↵ | Jared Armstrong | 2012-03-18 | 1 | -1/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | destroy record in autosave collection. | |||||
| * | | | | | | Merge pull request #5486 from kennyj/fix_5435 | Aaron Patterson | 2012-03-17 | 1 | -0/+1 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix GH #5435. db:structure:dump should be re-enable. | |||||
| | * | | | | | | Fix GH #5435. db:structure:dump should be reenable. | kennyj | 2012-03-17 | 1 | -0/+1 | |
| | | | | | | | | ||||||
| * | | | | | | | Updates 'modyfing' typo to 'modifying' | Jonathan R. Wallace | 2012-03-17 | 1 | -1/+1 | |
| | | | | | | | | ||||||
| * | | | | | | | Merge pull request #5321 from pfeiffer/uniqueness_validator_conditions | José Valim | 2012-03-17 | 1 | -2/+18 | |
| |\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | Add :conditions option to uniqueness validator | |||||
| | * | | | | | | Correct grammar in documentation | Mattias Pfeiffer | 2012-03-07 | 1 | -1/+1 | |
| | | | | | | | | ||||||
| | * | | | | | | Change syntax to accept an AR::Relation instead of old conditions hash/array. | Mattias Pfeiffer | 2012-03-07 | 1 | -3/+9 | |
| | | | | | | | | ||||||
| | * | | | | | | Add :conditions option to uniqueness validator | Mattias Pfeiffer | 2012-03-07 | 1 | -2/+12 | |
| | | | | | | | | ||||||
| * | | | | | | | Merge pull request #5467 from bogdan/initialize_callbacks | José Valim | 2012-03-16 | 1 | -1/+1 | |
| |\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | ActiveRecord::Core#initialize: improve performance | |||||
| | * | | | | | | ActiveRecord::Core#initialize: improve performance | Bogdan Gusiev | 2012-03-15 | 1 | -1/+1 | |
| | | | | | | | | ||||||
| * | | | | | | | Merge pull request #5461 from yakko/master | José Valim | 2012-03-16 | 1 | -0/+4 | |
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | relation .present? and .blank? should not query SELECT COUNT(DISTINCT id) | |||||
| | * | | | | | | | relation .present? and .blank? should not query SELECT COUNT(DISTINCT id) | Thiago Almeida | 2012-03-16 | 1 | -0/+4 | |
| | | | | | | | | | ||||||
| * | | | | | | | | Merge pull request #5327 from kennyj/fix_explicitly_inheraitance_column | Aaron Patterson | 2012-03-15 | 1 | -1/+2 | |
| |\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | Don't reset inheritance_column when setting explicitly. | |||||
| | * | | | | | | | Don't reset inheritance_column when setting explicitly. | kennyj | 2012-03-08 | 1 | -1/+2 | |
| | | | | | | | | | ||||||
| * | | | | | | | | errors should probably be logged as errors | Aaron Patterson | 2012-03-15 | 1 | -20/+19 | |
| | | | | | | | | | ||||||
| * | | | | | | | | Fix GH #5430. A Payload name for schema_search_path should be SCHEMA. | kennyj | 2012-03-15 | 1 | -1/+1 | |
| | |/ / / / / / |/| | | | | | | ||||||
| * | | | | | | | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 15 | -243/+10 | |
| | | | | | | | | ||||||
| * | | | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-13 | 1 | -1/+3 | |
| |\ \ \ \ \ \ \ | ||||||
| | * | | | | | | | added clarification stating the counter_cache attribute needs to be created ↵ | Michael de Silva | 2012-03-11 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | on the associate class via a migration | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |