Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Don't leave open dangling connections in development mode. [#1335 ↵ | Pratik Naik | 2008-11-08 | 1 | -2/+1 | |
| | | | | | | | | state:resolved] | |||||
| * | Simplify dispatcher callbacks to eliminate unnecessary stale thread purging. ↵ | Nick Sieger | 2008-11-08 | 1 | -4/+1 | |
| | | | | | | | | | | | | [Nick Sieger, Pratik Naik] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | Added :counter_sql as a valid key for habtm associations | Tekin Suleyman | 2008-11-07 | 1 | -1/+1 | |
| | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
| * | Revert commit which breaks all the tests. | Michael Koziarski | 2008-11-07 | 1 | -8/+4 | |
| | | | | | | | | | | | | | | | | This reverts commit 8adb79b9b5983cda8dbdd4ef401661fbd51d8844. Conflicts: activerecord/CHANGELOG | |||||
* | | undef abstract methods instead of raising NotImplementedError. Still need ↵ | Jeremy Kemper | 2008-11-07 | 1 | -4/+4 | |
| | | | | | | | | the definitions for rdoc though. | |||||
* | | Remove fixtures from Test::Unit::TestCase. Mix in AR::TestFixtures instead. | Jeremy Kemper | 2008-11-07 | 2 | -140/+147 | |
|/ | ||||||
* | Fix memory leak issue in ActiveRecord scoped_methods | Joshua Peek | 2008-11-06 | 1 | -2/+1 | |
| | ||||||
* | Stop logging SHOW FIELDS and SET SQL_AUTO_IS_NULL=0 for the MysqlAdapter as ↵ | David Heinemeier Hansson | 2008-11-06 | 1 | -4/+8 | |
| | | | | they only clutter up the log and offer no value [DHH] | |||||
* | Make sure ActiveRecord::Base.connected? doesn't raise an exception for ↵ | Pratik Naik | 2008-11-06 | 1 | -1/+2 | |
| | | | | defined connections | |||||
* | Ensure ActiveRecord::ConnectionPool.connected? handles undefined ↵ | Wes Oldenbeuving | 2008-11-06 | 1 | -1/+1 | |
| | | | | | | connections. [#936 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Merge docrails. Remove unnecessary files. | Pratik Naik | 2008-11-02 | 1 | -0/+8 | |
| | ||||||
* | Make sure habtm use class variable to list association valid keys | Luca Guidi | 2008-11-01 | 1 | -9/+12 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1310 state:committed] | |||||
* | It is not necessary to store QueryCache in a thread local since the cache is ↵ | Joshua Peek | 2008-10-30 | 1 | -27/+14 | |
| | | | | local to the connection object which is managed by the connection pool | |||||
* | Use database name in query cache thread local key [#1283 state:resolved] | Joshua Peek | 2008-10-30 | 1 | -3/+2 | |
| | ||||||
* | Ensure indices don't flip order in schema.rb [#1266 state:committed] | Jordi Bunster | 2008-10-30 | 1 | -6/+12 | |
| | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | |||||
* | Make #destroy write 1 line into log (instead of 3) (Dmitry Sokurenko) [#689 ↵ | David Heinemeier Hansson | 2008-10-29 | 1 | -4/+5 | |
| | | | | status:committed] | |||||
* | Fixed that serialized strings should never be type-casted (i.e. turning ↵ | David Heinemeier Hansson | 2008-10-27 | 1 | -1/+1 | |
| | | | | "Yes" to a boolean)(Andreas Korth) [#857 state:committed] | |||||
* | Remove reference to fformat to restore support for postgres gem. | Michael Koziarski | 2008-10-26 | 1 | -1/+1 | |
| | ||||||
* | Fix binary data corruption bug in PostgreSQL adaptor | Adam Majer | 2008-10-25 | 1 | -68/+79 | |
| | | | | | | | | | | | 1. Move the binary escape/unescape from column to the driver - we should store binary data AR just like most other adaptors 2. check to make sure we only unescape bytea data PGresult.ftype( column ) == 17 that is passed to us in escaped format PGresult.fformat( column ) == 0 Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1063 state:committed] | |||||
* | "raise NoMethodError" raises NoMethodError. Raise it with NoMethodError.new ↵ | Mike Gunderloy | 2008-10-25 | 1 | -1/+1 | |
| | | | | | | instead. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Fixed issue where block is not called on the very first invocation of a ↵ | Ken Miller | 2008-10-24 | 1 | -2/+2 | |
| | | | | | | find_or_create_by_ automatic finder. [#1224 state:committed] | |||||
* | Skip collection ids reader optimization if using :finder_sql | Jeremy Kemper | 2008-10-23 | 1 | -1/+1 | |
| | ||||||
* | Merge with docrails. Also add a rake task to generate guides in your rails ↵ | Pratik Naik | 2008-10-21 | 3 | -2/+10 | |
| | | | | | | | | application : rake doc:guides The rake task will generate guides inside doc/guides directory of your application. Open index.html to browse. | |||||
* | Ensure association proxy responds to private class methods defined in ↵ | Pratik Naik | 2008-10-16 | 1 | -2/+2 | |
| | | | | associated class. [#1083] | |||||
* | Merge docrails | Pratik Naik | 2008-10-16 | 2 | -3/+5 | |
| | ||||||
* | Allow class methods to be sent (via #send) to association proxy (fix for bug ↵ | Ian White | 2008-10-16 | 1 | -0/+4 | |
| | | | | | | introduced by 691aa20) [#1083] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Ensure methods called on association proxies respect access control. [#1083 ↵ | Pratik Naik | 2008-10-13 | 2 | -1/+12 | |
| | | | | state:resolved] [Adam Milligan, Pratik] | |||||
* | Remove the functionality introduce in 28d3390 | Michael Koziarski | 2008-10-10 | 1 | -12/+1 | |
| | | | | There are several situations it doesn't cater for, and the inconsistency isn't worth blocking 2.2. | |||||
* | explicitly including child associations that are also included in the parent ↵ | Will Bryant | 2008-10-10 | 2 | -0/+8 | |
| | | | | | | | association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed] | |||||
* | Add documentation for AbstractAdapter#sanitize_limit, and make its code more ↵ | Hongli Lai (Phusion) | 2008-10-09 | 1 | -4/+15 | |
| | | | | | | | readable. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1068 status:committed] | |||||
* | Merge docrails | Pratik Naik | 2008-10-05 | 10 | -79/+469 | |
| | ||||||
* | Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:resolved] | Pratik Naik | 2008-10-04 | 1 | -3/+7 | |
| | | | | | Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string. Model.avg always returns big decimal. | |||||
* | Remove HasManyAssociationStrategy and move the logic to ↵ | Pratik Naik | 2008-10-04 | 2 | -27/+21 | |
| | | | | ActiveRecord::Reflection::ThroughReflection. | |||||
* | Introduce ActiveRecord::Reflection::ThroughReflection to simplify hm:t ↵ | Pratik Naik | 2008-10-04 | 1 | -53/+66 | |
| | | | | reflection logic | |||||
* | Fix has_many :through when the source is a belongs_to association. [#323 ↵ | Zach Dennis | 2008-10-04 | 2 | -10/+45 | |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Try reloading model on class mismatch [#229 state:resolved] | Lawrence Pit | 2008-10-04 | 1 | -1/+1 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Fix performance bug in AttibuteMethods#respond_to? in handling of private ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+3 | |
| | | | | | | | | | | | methods We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1173 state:committed] | |||||
* | made ConnectionPool#checkout more robust by trying to loot dead threads when ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+5 | |
| | | | | | | | | pool is empty Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1169 state:committed] | |||||
* | Fix race in ConnectionPool#checkout | Aliaksey Kandratsenka | 2008-10-04 | 1 | -15/+14 | |
| | | | | | | | After releasing monitor some connection(s) may appear in pool before monitor is re-aquired. When this happens we'll wait for connection which is already available. Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | don't quote decimal values for mysql. It doesn't make sense and breaks in ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+1 | |
| | | | | | | | newer versions of mysql Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1168 state:committed] | |||||
* | Make sure recreate MySQL test database with the proper encoding and ↵ | Luca Guidi | 2008-10-03 | 1 | -2/+2 | |
| | | | | | | | collation [#1165 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1165 state:committed] | |||||
* | Remove AS for oracle compatibility | Michael Koziarski | 2008-10-03 | 1 | -1/+1 | |
| | ||||||
* | Dynamic finders should use the ActiveRecord::Base::find method instead of ↵ | Eloy Duran | 2008-10-03 | 2 | -8/+8 | |
| | | | | | | | | | | | | ::find_initial, :find_last, and ::find_all. This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders. Associations for instance do go through ::find, so this makes it more consistent. Also removed the unnecessary deprecation silence blocks. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1162 state:committed] | |||||
* | fix eager loading's :condition sanitizing expanding against the wrong table | Will Bryant | 2008-09-29 | 1 | -5/+5 | |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Ignore all exceptions for validates_acceptance_of columns fetch so it can ↵ | Tarmo Tänav | 2008-09-26 | 1 | -1/+1 | |
| | | | | | | run even without a database connection Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Changed ActiveRecord attributes to respect access control. | Adam Milligan | 2008-09-24 | 1 | -1/+7 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1084 state:committed] | |||||
* | Refactor configure_dependency_for_has_many to use a few more methods. | Hongli Lai (Phusion) | 2008-09-24 | 1 | -3/+34 | |
| | | | | | | | Add an additional conditions option to make it slightly easier for certain plugins. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1087 state:committed] | |||||
* | Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join ↵ | Pivotal Labs | 2008-09-24 | 1 | -13/+21 | |
| | | | | | | | strings to avoid table aliasing problems. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1077 state:committed] | |||||
* | Make AssociationCollection start transactions in the correct database. | Hongli Lai (Phusion) | 2008-09-23 | 2 | -6/+21 | |
| | | | | | | | | | | AssociationCollection now starts transactions by calling AssociationCollection#transaction instead of @owner.transaction or @reflection.klass.transaction. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1081 state:committed] | |||||
* | Merge branch 'patches' into multibyte | Michael Koziarski | 2008-09-22 | 4 | -6/+17 | |
|\ |