| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
fixes #1592
|
|
|
|
|
|
|
| |
This reverts commit 9d396ee8195e31f646e0b89158ed96f4db4ab38f, reversing
changes made to fa2bfd832c1d1e997d93c2269a485cc74782c86d.
Reason: the change broke the build.
|
| |
|
| |
|
|
|
|
| |
by association extensions to access information about the association. This replaces proxy_owner etc with proxy_association.owner.
|
| |
|
|
|
|
|
|
|
| |
This reverts commit 04cc446d178653d362510e79a22db5300d463161.
I reverted it because apparently we want to use: select([:a, :b])
instead of select(:a, :b), but there was no tests for that form.
|
|\
| |
| | |
allow select to have multiple arguments ie. Post.select(:id,:name,:author)
|
| | |
|
|\ \
| |/
|/| |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Fix after_initialize and Base.create edge case
|
| | |
| | |
| | |
| | | |
fix behavior when after_initialize is defined and a block is passed to Base.create
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Ordering with extra spaces was raising a SQL exception
|
| |/ |
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| | |
English to
American English(according to Weber)
|
|\ \
| | |
| | | |
lazy load ConnectionAdapters remove require.
|
| | | |
|
|\ \ \
| | | |
| | | | |
convert multiple Date parameters into a nil if any of its bits were blank
|
| | | | |
|
|\ \ \ \
| |_|_|/
|/| | | |
This conditions is required to work with database create task. 1.9.2 is h
|
| | | |
| | | |
| | | |
| | | | |
having a bug with "Calling return within begin still executes else".
|
|\ \ \ \ |
|
| | | | | |
|
| |_|_|/
|/| | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
1.9 [Closes #2106]
Children attributes can be either String's or Symbol's, so let's check if the object responds to to_i.
|
| |/ /
|/| | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes errors when using Active Record outside of Rails. In Rails,
these files are required by other classes that are always loaded, so
this error does not happen.
Without core_ext/module/delegation, a NoMethodError is raised because
`delegate` remains undefined.
Without core_ext/class/attribute_acessors, an ArgumentError is raised because
`delegate` does not receive a value for its :to option.
|
| | |
| | |
| | |
| | | |
generates valid SQL
|
|\ \ \
| | | |
| | | | |
ActiveModel support for the :include serialization option
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit moves support for the :include serialization option for
serializing associated objects out of ActiveRecord in into ActiveModel.
The following methods support the :include option:
* serializable_hash
* to_json
* to_xml
Instances must respond to methods named by the values of the :includes
array (or keys of the :includes hash). If an association method returns
an object that is_a?(Enumerable) (which AR has_many associations do), it
is assumed to be a collection association, and its elements must respond
to :serializable_hash. Otherwise it must respond to :serializable_hash
itself.
While here, fix #858, XmlSerializer should not singularize already
singular association names.
|
| | |/
| |/| |
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
dynamic finder
The previous behavior was unintentional, and some people was relying on it. Now the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.)
So if you were doing this and expecting the second argument to be nil:
User.find_by_username_and_group("sikachu")
You'll now get `ArgumentError: wrong number of arguments (1 for 2).` You'll then have to do this:
User.find_by_username_and_group("sikachu", nil)
|
|\ \
| | |
| | | |
Patch for https://github.com/rails/rails/issues/2059
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Cache key was incorrectly using timezone-dependent record#updated_at when it should be using a timezone-independent value to generate the cache key
Minor refactoring to cache_key timezone test
Closes #2059
Adds a test to validate the format of the cache_key for nil and present updated_at values
Correctly handles updated_at == nil
|
|\ \ \
| |/ /
|/| | |
Bugfix by stopping find_in_batches using the records after yielding.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Currently if the code that calls .find_in_batches modifies the yielded array in place then .find_in_batches can enter an infinite loop searching with ruby object ids in the database instead of the primary key of records in the database. This happens because it naively assumes the yielded array hasn't been modified before calling #id on the last object in the array. And ruby (1.8 at least) alias' #id to #object_id so an integer is still returned no matter what the last object is.
By moving finding the #id of the last object before yielding the array it means the calling code can do whatever it wants to the array in terms of modifying it in place, and .find_in_batches doesn't care.
|
|\ \ \
| | | |
| | | | |
Fix for SqlBypass session store (for master)
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Two issues fixed:
1) connection_pool is not defined - needed by SessionStore#drop_table!
and create_table! since c94651f
2) initialization of connection to the default of AR::Base.connection
only occurred at the singleton level - the instance level method defined
by cattr_accessor did not have this logic
|