Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2011-02-15 | 64 | -2162/+3057 |
|\ | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/examples/performance.rb activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/nested_attributes.rb activerecord/test/cases/relations_test.rb | ||||
| * | remove accidental raise! | Aaron Patterson | 2011-02-14 | 1 | -1/+0 |
| | | |||||
| * | removing irrelevant test | Aaron Patterson | 2011-02-14 | 1 | -0/+1 |
| | | |||||
| * | Merge branch 'fixtures' | Aaron Patterson | 2011-02-14 | 1 | -28/+28 |
| |\ | | | | | | | | | | | | | | | | | | | | | | * fixtures: remove unused methods extract database activity out of Fixtures instances extract rows that should be inserted to a method fixtures will return a list of tables that may be effected, delete existing fixtures will delete those tables | ||||
| | * | remove unused methods | Aaron Patterson | 2011-02-14 | 1 | -35/+0 |
| | | | |||||
| | * | extract database activity out of Fixtures instances | Aaron Patterson | 2011-02-14 | 1 | -7/+23 |
| | | | |||||
| | * | extract rows that should be inserted to a method | Aaron Patterson | 2011-02-14 | 1 | -12/+12 |
| | | | |||||
| | * | fixtures will return a list of tables that may be effected, delete existing ↵ | Aaron Patterson | 2011-02-14 | 1 | -6/+25 |
| | | | | | | | | | | | | fixtures will delete those tables | ||||
| * | | Merge remote branch 'jonleighton/association_fixes' | Aaron Patterson | 2011-02-14 | 11 | -90/+93 |
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * jonleighton/association_fixes: Add a transaction wrapper in add_to_target. This means that #build will now also use a transaction. IMO this is reasonable given that the before_add and after_add callbacks might do anything, and this great consistency allows us to abstract out the duplicate code from #build and #create. Inline ensure_owner_is_persisted! as it is only called from one place @target should always be an array Rename add_record_to_target_with_callbacks to add_to_target Don't pass the block through build_record Move create and create! next to build Get rid of create_record as it is not only used in one place Get rid of AssociationCollection#save_record Fix test/cases/connection_pool_test.rb for sqlite3 in-memory db Add interpolation of association conditions back in, in the form of proc { ... } rather than instance_eval-ing strings | ||||
| | * | Add a transaction wrapper in add_to_target. This means that #build will now ↵ | Jon Leighton | 2011-02-14 | 1 | -27/+27 |
| | | | | | | | | | | | | also use a transaction. IMO this is reasonable given that the before_add and after_add callbacks might do anything, and this great consistency allows us to abstract out the duplicate code from #build and #create. | ||||
| | * | Inline ensure_owner_is_persisted! as it is only called from one place | Jon Leighton | 2011-02-14 | 1 | -8/+4 |
| | | | |||||
| | * | @target should always be an array | Jon Leighton | 2011-02-14 | 1 | -1/+2 |
| | | | |||||
| | * | Rename add_record_to_target_with_callbacks to add_to_target | Jon Leighton | 2011-02-14 | 2 | -5/+5 |
| | | | |||||
| | * | Don't pass the block through build_record | Jon Leighton | 2011-02-14 | 1 | -10/+8 |
| | | | |||||
| | * | Move create and create! next to build | Jon Leighton | 2011-02-14 | 1 | -21/+21 |
| | | | |||||
| | * | Get rid of create_record as it is not only used in one place | Jon Leighton | 2011-02-14 | 1 | -8/+7 |
| | | | |||||
| | * | Get rid of AssociationCollection#save_record | Jon Leighton | 2011-02-14 | 5 | -26/+26 |
| | | | |||||
| | * | Add interpolation of association conditions back in, in the form of proc { ↵ | Jon Leighton | 2011-02-14 | 7 | -20/+29 |
| | | | | | | | | | | | | ... } rather than instance_eval-ing strings | ||||
| * | | HabtmFixtures class is no longer needed | Aaron Patterson | 2011-02-14 | 1 | -31/+22 |
| |/ | |||||
| * | Remove Relation#& alias for Relation#merge | Ernie Miller | 2011-02-12 | 3 | -4/+2 |
| | | |||||
| * | switch over to Mysql2::Client#ping for the mysql2 connection check | Brian Lopez | 2011-02-12 | 1 | -4/+1 |
| | | |||||
| * | Fix table name collision due to incorrect alias count on certain joins. | Ernie Miller | 2011-02-12 | 1 | -4/+4 |
| | | | | | | | | | | | | [#6423 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | key habtm fixtures off table name | Aaron Patterson | 2011-02-11 | 1 | -5/+5 |
| | | |||||
| * | Fixture class no longer needs a reference to the database connection | Aaron Patterson | 2011-02-11 | 1 | -16/+4 |
| | | |||||
| * | convert fixtures to a list of hashes to insert | Aaron Patterson | 2011-02-11 | 1 | -2/+6 |
| | | |||||
| * | fixture should quack like a hash | Aaron Patterson | 2011-02-11 | 1 | -1/+9 |
| | | |||||
| * | Fixtures class constantizes this value, so no need to do it twice | Aaron Patterson | 2011-02-11 | 1 | -3/+3 |
| | | |||||
| * | database quoting should take care of this, no need to gsub | Aaron Patterson | 2011-02-11 | 1 | -1/+1 |
| | | |||||
| * | calculate model class on construction | Aaron Patterson | 2011-02-11 | 1 | -16/+11 |
| | | |||||
| * | clear cache for all connections when resetting | Aaron Patterson | 2011-02-11 | 1 | -4/+3 |
| | | |||||
| * | avoid side effects from method calls, localize ivar assignment | Aaron Patterson | 2011-02-11 | 1 | -3/+4 |
| | | |||||
| * | create fixtures always returns a list, so build a hash from the list | Aaron Patterson | 2011-02-11 | 1 | -10/+2 |
| | | |||||
| * | create_fixtures() should always return a list | Aaron Patterson | 2011-02-11 | 1 | -4/+4 |
| | | |||||
| * | fixing variable names | Aaron Patterson | 2011-02-11 | 1 | -4/+10 |
| | | |||||
| * | use hash defaults to dry up ||= calls | Aaron Patterson | 2011-02-11 | 1 | -27/+22 |
| | | |||||
| * | refactor fixtures to do less work in the constructor | Aaron Patterson | 2011-02-11 | 1 | -10/+23 |
| | | |||||
| * | favor composition over inheritence. use AS::OrderedHash rather than omap | Aaron Patterson | 2011-02-11 | 1 | -19/+24 |
| | | |||||
| * | fixing tests on 1.8, using a list of lists because order is important | Aaron Patterson | 2011-02-10 | 1 | -1/+3 |
| | | |||||
| * | simplify bind parameter logging | Aaron Patterson | 2011-02-10 | 1 | -3/+1 |
| | | |||||
| * | bind parameters are logged to debug log | Aaron Patterson | 2011-02-10 | 1 | -4/+12 |
| | | |||||
| * | log method takes an option list of bind values | Aaron Patterson | 2011-02-09 | 4 | -8/+10 |
| | | |||||
| * | removed some duplication from LH issue 5505 regarding AR touch and ↵ | Josh Kalderimis | 2011-02-09 | 2 | -9/+11 |
| | | | | | | | | | | | | optimistic locking [#5505 state:resolved] Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com> | ||||
| * | The optimistic lock column should be increased when calling touch | Franck Verrot | 2011-02-09 | 1 | -0/+7 |
| | | | | | | | | Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com> | ||||
| * | bugfix for serialized_attributes to be class specific | Raimonds Simanovskis | 2011-02-09 | 1 | -1/+3 |
| | | | | | | | | previously serialized_attributes were kept as class attribute of ActiveRecord::Base - if some attribute was defined as serialized in one subclass then it was serialized in all other subclasses as well (if it had the same name) | ||||
| * | Allow limit values to accept an ARel SQL literal. | Ken Collins | 2011-02-09 | 1 | -3/+7 |
| | | |||||
| * | primary keys should not be cleared on cache clear, fixing oracle tests | Aaron Patterson | 2011-02-08 | 3 | -3/+9 |
| | | |||||
| * | limit() should sanitize limit values | Aaron Patterson | 2011-02-08 | 2 | -16/+16 |
| | | | | | | | | This fixes CVE-2011-0448 | ||||
| * | make set_table_name take effect immediately | Jan | 2011-02-08 | 1 | -0/+3 |
| | | |||||
| * | just return the record from insert_record, use truthiness for comparisons | Aaron Patterson | 2011-02-07 | 2 | -3/+5 |
| | | |||||
| * | Documentation for recent refinements to association deletion | Jon Leighton | 2011-02-07 | 1 | -3/+75 |
| | |