Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | pushing caching and visitors down to the connection | Aaron Patterson | 2011-11-19 | 7 | -93/+119 |
| | |||||
* | Perf fix | Jon Leighton | 2011-11-19 | 1 | -2/+6 |
| | | | | | | | If we're deleting all records in an association, don't add a IN(..) clause to the query. Fixes #3672. | ||||
* | Use `show index from`. We could fix `pk_and_sequence_for` method's ↵ | kennyj | 2011-11-19 | 2 | -21/+3 |
| | | | | performance problem (GH #3678) | ||||
* | Only used detailed schema introspection when doing a schema dump. | Christos Zisopoulos | 2011-11-18 | 2 | -1/+10 |
| | | | Fixes #3678 | ||||
* | Stop db:seed from performing a reload of the db | Sam Ruby | 2011-11-18 | 1 | -2/+2 |
| | | | | Fix regression introduced by 38d26b0cb56d82093889efa95992a35ba3bb9f29 | ||||
* | Merge pull request #3666 from oscardelben/databases_rake_cleanup | Vijay Dev | 2011-11-18 | 1 | -8/+9 |
|\ | | | | | Cleanup of databases.rake psql env variables | ||||
| * | Cleanup of databases.rake psql env variables | Oscar Del Ben | 2011-11-17 | 1 | -8/+9 |
| | | |||||
* | | Revert "Merge pull request #1163 from amatsuda/sexier_migration_31" | Aaron Patterson | 2011-11-17 | 3 | -22/+13 |
| | | | | | | | | | | | | | | | | | | | | This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72. Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/migration_test.rb | ||||
* | | Revert "Merge pull request #3603 from vijaydev/change_table_without_block_arg" | Aaron Patterson | 2011-11-17 | 1 | -12/+7 |
|/ | | | | | | | | | This reverts commit 81fad6a270ec3cbbb88553c9f2e8200c34fd4d13, reversing changes made to 23101de283de13517e30c4c3d1ecc65525264886. Conflicts: activerecord/test/cases/migration_test.rb | ||||
* | No need to `readlines` then `join`, just use `read` :heart: | Arun Agrawal | 2011-11-17 | 1 | -1/+1 |
| | | | same as 4c1a1933cbc5ab96efe340a3b31ac5fee12c99c8 | ||||
* | No need to `readlines` then `join`, just use `read` :heart: | Aaron Patterson | 2011-11-16 | 1 | -1/+1 |
| | |||||
* | Adding a deprecation warning for use of the schema_info table. | Aaron Patterson | 2011-11-16 | 1 | -0/+2 |
| | |||||
* | Join method uses empty string by default, so remove it | Aaron Patterson | 2011-11-16 | 1 | -2/+2 |
| | |||||
* | dbfile isn't supported anymore, so remove | Aaron Patterson | 2011-11-16 | 1 | -3/+3 |
| | |||||
* | Reduce schema format tests | Aaron Patterson | 2011-11-16 | 1 | -10/+14 |
| | |||||
* | Move conditionals to separate tasks so they can be reused. | Aaron Patterson | 2011-11-16 | 1 | -7/+11 |
| | |||||
* | `ActiveRecord::Base#becomes` should retain the errors of the original object. | James Adam | 2011-11-16 | 1 | -0/+1 |
| | | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance. | ||||
* | removing some useless conditionals | Aaron Patterson | 2011-11-16 | 1 | -10/+8 |
| | |||||
* | Merge pull request #2948 from atambo/master | Aaron Patterson | 2011-11-16 | 1 | -38/+66 |
|\ | | | | | schema_format :sql should behave like schema_format :ruby | ||||
| * | schema_format :sql should behave like schema_format :ruby | Alex Tambellini | 2011-11-04 | 1 | -38/+66 |
| | | | | | | | | | | | | | | This commit adds a db:structure:load task that is run instead of db:schema:load when schema_format is set to :sql. This patch also removes the prefixing of the structure.sql files to mimic the use of a single schema.rb file. The patch originates from github issue #715. | ||||
* | | Fixes issue #3483, regarding using a mixture of ranges and discrete values ↵ | Ryan Naughton | 2011-11-14 | 1 | -6/+8 |
| | | | | | | | | in find conditions. Paired with Joey Schoblaska. | ||||
* | | Speed up attribute invocation by checking if both name and calls are compilable. | José Valim | 2011-11-14 | 2 | -2/+2 |
| | | |||||
* | | Fix pull request #3609 | Noé Froidevaux | 2011-11-13 | 1 | -1/+1 |
| | | |||||
* | | Prevent multiple SHOW TABLES calls when a table don't exists in database. | Noé Froidevaux | 2011-11-11 | 1 | -3/+3 |
| | | |||||
* | | Modify change_table to remove the need for the block argument. | Vijay Dev | 2011-11-11 | 1 | -7/+12 |
| | | |||||
* | | Checking the arity of the block passed to create_table | Vijay Dev | 2011-11-10 | 1 | -1/+7 |
| | | | | | | | | | | | | A recent change made to create_table does away with the need for the block argument. Checking the arity will prevent the mixing up of the two syntaxes. | ||||
* | | exclude ORDER BY clause when querying Relation#exists? | Akira Matsuda | 2011-11-09 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-11-08 | 3 | -7/+6 |
|\ \ | | | | | | | | | | | | | Conflicts: railties/guides/source/active_record_querying.textile | ||||
| * | | document fix: remove_column takes multiple column_names | Akira Matsuda | 2011-11-07 | 1 | -2/+2 |
| | | | |||||
| * | | self.up, self.down => up, down | Akira Matsuda | 2011-11-07 | 2 | -5/+4 |
| | | | |||||
* | | | adds trailing +s to the output of EXPLAIN for MySQL | Xavier Noria | 2011-11-07 | 1 | -3/+2 |
| | | | |||||
* | | | Merge pull request #3521 from ↵ | Aaron Patterson | 2011-11-06 | 1 | -2/+1 |
|/ / | | | | | | | | | | | nulogy/fix_postgres_adapter_to_handle_spaces_between_schemas Fix postgres adapter to handle spaces between schemas | ||||
* | | Update ActiveRecord#attribute_present? to work as documented | Justin Mazzi | 2011-11-05 | 1 | -1/+2 |
| | | | | | | | | | | | | | | "Returns true if the specified attribute has been set by the user or by a database load and is neither nil nor empty?" Fixes #1613 | ||||
* | | implements AR::Relation#explain | Xavier Noria | 2011-11-05 | 4 | -1/+153 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a first implementation, EXPLAIN is highly dependent on the database and I have made some compromises. On one hand, the method allows you to run the most common EXPLAIN and that's it. If you want EXPLAIN ANALYZE in PostgreSQL you need to do it by hand. On the other hand, I've tried to construct a string as close as possible to the ones built by the respective shells. The rationale is that IMO the user should feel at home with the output and recognize it at first sight. Per database. I don't know whether this implementation is going to work well. Let's see whether people like it. | ||||
* | | Merge pull request #3525 from kennyj/fix_3440-1 | Jon Leighton | 2011-11-05 | 1 | -2/+11 |
|\ \ | | | | | | | Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440) | ||||
| * | | Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440) | kennyj | 2011-11-06 | 1 | -2/+11 |
| |/ | |||||
* | | Use uniq instead of manually putting a DISTINCT in the query | Jon Leighton | 2011-11-05 | 1 | -14/+2 |
| | | |||||
* | | Add ActiveRecord::Relation#uniq for toggling DISTINCT in the SQL query | Jon Leighton | 2011-11-05 | 3 | -8/+28 |
| | | |||||
* | | AR changes to support creating ordered (asc, desc) indexes | Vlad Jebelev | 2011-11-04 | 8 | -16/+85 |
|/ | |||||
* | Allow the :class_name option for associations to take a symbol. | Jon Leighton | 2011-11-04 | 1 | -1/+1 |
| | | | | | This is to avoid confusing newbies, and to be consistent with the fact that other options like :foreign_key already allow a symbol or a string. | ||||
* | Merge pull request #1163 from amatsuda/sexier_migration_31 | Aaron Patterson | 2011-11-04 | 3 | -13/+16 |
|\ | | | | | Sexier migrations | ||||
| * | No "t." for the migration DSL! | Akira Matsuda | 2011-05-20 | 3 | -13/+16 |
| | | | | | | | | | | Now you can omit |t| block parameter and all the t. from your migration code, that means, the syntax looks more Rails-3-ish, like the routes DSL and ActionMailer DSL. Also, this change won't break any of your existing migration files, since the traditional syntax is still available. | ||||
* | | Merge pull request #3507 from jmazzi/issue-3503 | Jeremy Kemper | 2011-11-03 | 1 | -2/+6 |
| | | | | | | | | Preserve SELECT columns on the COUNT for finder_sql when possible | ||||
* | | Fix #3271. | Jon Leighton | 2011-11-03 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | Building the conditions of a nested through association could potentially modify the conditions of the through and/or source association. This is a Bad Thing. | ||||
* | | Memoize through association | Jon Leighton | 2011-11-03 | 1 | -8/+11 |
| | | |||||
* | | Remove all revelant through records. | Jon Leighton | 2011-11-03 | 1 | -9/+9 |
| | | | | | | | | | | | | | | | | | | If a record is removed from a has_many :through, all of the join records relating to that record should also be removed from the through association's target. (Previously the records were removed in the database, but only one was removed from the in-memory target array.) | ||||
* | | Fix adding multiple instances of the same record to a has_many :through. | Jon Leighton | 2011-11-03 | 1 | -21/+43 |
| | | | | | | | | Fixes #3425. | ||||
* | | Fix #3247. | Jon Leighton | 2011-11-03 | 1 | -1/+1 |
| | | | | | | | | | | Fixes creating records in a through association with a polymorphic source type. | ||||
* | | dump_schema_information: explicitly order inserts into schema_migrations table | Laust Rud Jacobsen | 2011-10-31 | 1 | -1/+1 |
| | | | | | | | | | | | | | | This change reduces churn in the db/development_structure.sql file when using :sql as active_record.schema_format, and makes comparing diffs much easier. Test ensures the output SQL-statements are lexically ordered by version. | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-10-30 | 1 | -0/+3 |
|\ \ |