aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | remove nil checkAaron Patterson2013-12-122-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | calling replace_keys could possibly do a nil check twice, this commit reduces it to once.
* | | | | | remove the nil check from set_inverse_instanceAaron Patterson2013-12-124-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | methods that call set_inverse_instance with a record will not have to pay the cost of a nil check on every call
* | | | | | make sure cached table name is a string. fixes #12582Aaron Patterson2013-12-121-1/+1
| | | | | |
* | | | | | Merge pull request #13293 from akshay-vishnoi/typoCarlos Antonio da Silva2013-12-122-5/+5
|\| | | | | | | | | | | | | | | | | Spelling and Grammar checks [ci skip]
| * | | | | Spelling and Grammar checksAkshay Vishnoi2013-12-122-5/+5
| | | | | |
* | | | | | Merge pull request #13291 from strzibny/new_unique_constraintYves Senn2013-12-121-1/+5
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Translate new unique constraint error message for sqlite >= 3.8.2
| * | | | | Translate new unique constraint for sqlite >= 3.8.2Josef Stribny2013-12-121-1/+5
| | | | | |
* | | | | | Merge pull request #13264 from ↵Rafael Mendonça França2013-12-111-2/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | laurocaetano/fix_dynamic_finder_with_reserved_words Prevent invalid code when using dynamic finders with reserved ruby word.
| * | | | | | Prevent invalid code when using dynamic finders with Ruby's reserved words.Lauro Caetano2013-12-111-2/+7
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The dynamic finder was creating the method signature with the parameters name, which may have reserved words and this way creating invalid Ruby code. Closes: #13261 Example: # Before Dog.find_by_alias('dog name') # Was creating this method def self.find_by_alias(alias, options = {}) # After Dog.find_by_alias('dog name') # Will create this method def self.find_by_alias(_alias, options = {})
* | | | | | Move the parameter normalization to the initialize methodRafael Mendonça França2013-12-111-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | activerecord-deprecated_finders expects the parameters denormalized in its initialize method
* | | | | | Revert the whole refactoring in the association builder classes.Rafael Mendonça França2013-12-117-46/+62
| | | | | | | | | | | | | | | | | | | | | | | | This is to get activerecord-deprecated_finders work again
* | | | | | Mark the arguments needed by activerecord-deprecated_finders with a TODORafael Mendonça França2013-12-114-2/+20
| | | | | |
* | | | | | Revert "Merge pull request #12518 from vipulnsward/remove_count_options"Rafael Mendonça França2013-12-114-16/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is needed for activerecord-depecated_finders This reverts commit dcff027a5242b20c0c90eb062dddb22ccf51aed9, reversing changes made to 3a2093984ff49d86db1efeff0c7581e788ecfb9f.
* | | | | | Bring back the valid_options class accessorRafael Mendonça França2013-12-116-9/+14
|/ / / / / | | | | | | | | | | | | | | | It is need in activerecord-deprecated_finders
* | | | | Merge pull request #13236 from jetthoughts/13230_type_cast_bug_in_agr_functionsYves Senn2013-12-101-1/+3
|\ \ \ \ \ | | | | | | | | | | | | Fix type cast on group sum with custom expression
| * | | | | Fix type cast on group sum with custom expressionPaul Nikitochkin2013-12-101-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For PG adapters with custom expression and grouped result of aggregate functions have not found correct column type for it. Extract column type from query result. Closes: #13230
* | | | | | Remove `DEFAULT NULL` for primary key column to support MySQL 5.7.3Yasuo Honda2013-12-101-1/+1
|/ / / / / | | | | | | | | | | | | | | | Since MySQL 5.7.3 m13 does now allow primary key column is null.
* | | | | fix typo, "state_state" should be "stale_state" [ci skip]Scott M2013-12-071-1/+1
| | | | |
* | | | | Very tiny typo fix [ci skip]Robin Dupret2013-12-061-1/+1
| | | | |
* | | | | _enum_methods_module should be kept privateGodfrey Chan2013-12-051-6/+7
| | | | |
* | | | | Make clear that the enum array should not be changed once defined. [ci skip]Godfrey Chan2013-12-051-1/+12
| | | | |
* | | | | fix pg warnings on geometric typesAaron Patterson2013-12-051-10/+23
| | | | |
* | | | | Use the right type_mapRafael Mendonça França2013-12-052-5/+3
| | | | |
* | | | | polymorphic belongs_to association with touch: true updates old record correctlySeverin Schoepke2013-12-051-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: Given you have a comments model with a polymorphic commentable association (e.g. books and songs) with the touch option set. Every time you update a comment its commentable should be touched. This was working when you changed attributes on the comment or when you moved the comment from one book to another. However, it was not working when moving a comment from a book to a song. This is now fixed.
* | | | | make the type_map per connection. fixes #13182Aaron Patterson2013-12-042-12/+17
| | | | |
* | | | | Merge pull request #12403 from thedarkone/attr-method-missing-fixRafael Mendonça França2013-12-041-1/+18
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix AR#method_missing re-dispatching into overwritten attribute methods Conflicts: activerecord/lib/active_record/attribute_methods.rb
| * | | | | Fix AR#method_missing re-dispatching into overwritten attribute methods.thedarkone2013-09-291-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was happening when a `super` call in an overwritten attribute method was triggering a method_missing fallback, because attribute methods haven't been generated yet. class Topic < ActiveRecord::Base def title # `super` would re-invoke this method if define_attribute_methods # hasn't been called yet resulting in double '!' appending super + '!' end end
* | | | | | Merge pull request #12462 from jjb/improve_ar_exception_message_formattingCarlos Antonio da Silva2013-12-031-8/+15
|\ \ \ \ \ \ | | | | | | | | | | | | | | Improve formatting of ActiveRecord migration exception messages
| * | | | | | ActiveRecord migration exception message formattingJohn Joseph Bachir2013-12-031-8/+15
| | | | | | |
* | | | | | | Fix offset with last.Lauro Caetano2013-12-031-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | Closes #7441
* | | | | | `connection.type_to_sql` returns a `String` for unmapped types.Yves Senn2013-12-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #13146. This fixes an error when using: ``` change_colum :table, :column, :bigint, array: true ```
* | | | | | Fix ActiveRecord::Callbacks sample code [ci skip]joker10072013-12-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Callback caller class uses `after_initialize`, but Callback callee defines `after_find`. Current sample code causes following error. NoMethodError: undefined method `after_initialize' for #<EncryptionWrapper:0x007fe4931fa5c0>
* | | | | | Currently, we clear query_cache in cache block finish, even if we may ↵Vipul A M2013-12-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | already have cache true. This commit takes into account the last cache_enabled value, before clearing query_cache.
* | | | | | Introduce a context for rendering fixtures ERB.Victor Costan2013-12-032-1/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixture files are passed through an ERB renderer before being read as YAML. The rendering is currently done in the context of the main object, so method definitons leak into other fixtures, and there is no clean place to define fixture helpers. After this commit, the ERB renderer will use a new subclass of ActiveRecord::FixtureSet.context_class each time a fixture is rendered.
* | | | | | Remove deprecated cattr_* requiresGenadi Samokovarov2013-12-032-2/+2
| | | | | |
* | | | | | Cleanups in API docs: his => theirGuillermo Iguaran2013-12-021-2/+2
| | | | | |
* | | | | | Use genderless pronouns in API docsGuillermo Iguaran2013-12-011-1/+1
| | | | | |
* | | | | | Merge pull request #13111 from akshay-vishnoi/typoCarlos Antonio da Silva2013-11-301-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Typo fixes [ci skip]
| * | | | | | Typo fixes [ci skip]Akshay Vishnoi2013-11-301-1/+1
| | | | | | |
* | | | | | | Raise `ArgumentError` when `has_one` is used with `counter_cache`Godfrey Chan2013-11-292-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the `has_one` macro incorrectly accepts the `counter_cache` option due to a bug, although that options was never supported nor functional on `has_one` and `has_one ... through` relationships. It now correctly raises an `ArgumentError` when passed that option. For reference, this bug was introduced in 52f8e4b9.
* | | | | | | Remove unused variableRafael Mendonça França2013-11-291-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | This method is not using the block variable directly since it is calling yield
* | | | | | Merge pull request #13099 from kamipo/remove_case_sensitive_equality_operatorCarlos Antonio da Silva2013-11-291-4/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove `DatabaseStatements#case_sensitive_equality_operator`. It has been deprecated already.
| * | | | | | Remove `DatabaseStatements#case_sensitive_equality_operator`. It has been ↵Ryuta Kamizono2013-11-291-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | deprecated already.
* | | | | | | Merge pull request #13100 from akshay-vishnoi/f-refactorCarlos Antonio da Silva2013-11-291-3/+8
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | #type_cast - improve performance & readability
| * | | | | | #type_cast - improve performance & readabilityAkshay Vishnoi2013-11-291-3/+8
| | | | | | |
* | | | | | | fix mysql version check in rename_indexCody Cutrer2013-11-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | also clarify native rename_index support is >= 5.7, not > 5.7
* | | | | | | implement rename_index natively for MySQL > 5.7Cody Cutrer2013-11-281-0/+8
| | | | | | |
* | | | | | | [ci skip]removed obsolete information about `options` parameter in create methodKuldeep Aggarwal2013-11-271-3/+0
| | | | | | |
* | | | | | | [ci skip] used new syntax for scopesKuldeep Aggarwal2013-11-271-1/+1
| | | | | | |
* | | | | | | Merge pull request #13061 from ↵Rafael Mendonça França2013-11-261-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | laurocaetano/fix-uniqueness-validation-for-aliased-attribute Fix bug when validating the uniqueness of an aliased attribute. Conflicts: activerecord/CHANGELOG.md
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 19:21:44 +0000