aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* return early in case the left or right side lists are emptyAaron Patterson2011-01-141-5/+4
|
* only find_target can raise the exception, so isolate the rescue around that callAaron Patterson2011-01-141-5/+9
|
* we always have a target, so stop checkingAaron Patterson2011-01-141-1/+1
|
* we should use [] instead of Array.newAaron Patterson2011-01-141-1/+1
|
* @target is always a list, so stop doing is_a? checksAaron Patterson2011-01-141-1/+1
|
* move complex logic to it's own methodAaron Patterson2011-01-141-15/+19
|
* loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵Aaron Patterson2011-01-141-4/+4
| | | | inside the conditional
* reduce funcalls by using falsey objectsAaron Patterson2011-01-141-2/+2
|
* write the delegate method directly to avoid `delegate` callstack overheadAaron Patterson2011-01-141-1/+5
|
* reduce some lasignsAaron Patterson2011-01-141-2/+1
|
* Arel::Table.engine will be deprecated, so stop using itAaron Patterson2011-01-141-1/+1
|
* include_in_memory? should check against @target list in case of new records. ↵Aaron Patterson2011-01-121-2/+2
| | | | [#6257 state:resolved]
* use array maths rather than *argsAaron Patterson2011-01-121-2/+4
|
* just use return value of load_targetAaron Patterson2011-01-121-2/+1
|
* just call methods on return value of `load_target`Aaron Patterson2011-01-121-8/+3
|
* default return value is nilAaron Patterson2011-01-121-1/+0
|
* @loaded is defined in initialize, so we should not need thisAaron Patterson2011-01-121-2/+0
|
* just use respond_to? and super rather than aliasing around methodsAaron Patterson2011-01-122-5/+4
|
* adding a test for no method errorAaron Patterson2011-01-111-11/+5
|
* use underlying _read_attribute method rather than causing NoMethodErrorsAaron Patterson2011-01-111-1/+1
|
* kill unused variable warningsAaron Patterson2011-01-111-1/+1
|
* lazily instantiate AR objects in order to avoid NoMethodErrorsAaron Patterson2011-01-112-17/+24
|
* test_with_polymorphic_and_condition works without the conditions methods in ↵Jon Leighton2011-01-111-5/+0
| | | | BelongsToPolymorphicAssociation because the conditions are added straight to the association_scope as of a few days ago
* Support for create_association! for has_one associationsJon Leighton2011-01-112-1/+5
|
* Refactor the code for singular association constructors. This will allow me ↵Jon Leighton2011-01-111-8/+13
| | | | to define a create_association! method in a minute.
* It's not necessary to pass the association proxy class around nowJon Leighton2011-01-111-22/+15
|
* Get rid of set_association_target and association_loaded? as the parts of ↵Jon Leighton2011-01-114-20/+17
| | | | the code that need that can now just use association_proxy(:name).loaded?/target=
* We can use the association_proxy method directly in HasOneThroughAssociation nowJon Leighton2011-01-112-20/+20
|
* DRY up the code which instantiates the association proxyJon Leighton2011-01-112-35/+49
|
* find_target can be inheritedJon Leighton2011-01-111-4/+0
|
* Document the recent changes to association assignmentJon Leighton2011-01-111-4/+9
|
* Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵Jon Leighton2011-01-111-1/+5
| | | | replaced
* When assigning a has_one, if anything fails, the assignment should be rolled ↵Jon Leighton2011-01-111-19/+23
| | | | back entirely
* SQLite3 has supported savepoints since version 3.6.8, we should use this!Jon Leighton2011-01-112-2/+18
|
* When assigning a has_one, if the new record fails to save, raise an errorJon Leighton2011-01-111-3/+3
|
* When assigning a has_one, if the existing record fails to be removed from ↵Jon Leighton2011-01-111-5/+11
| | | | the association, raise an error
* has_one should always remove the old record (properly), even if not saving ↵Jon Leighton2011-01-111-1/+1
| | | | the new record, so we don't get the database into a pickle
* Return value is irrelevant here as the RHS of the assignment is always ↵Jon Leighton2011-01-111-1/+0
| | | | returned by methods ending in '='
* Remove incorrect documentation about build_assoc on has_one. This is proven, ↵Jon Leighton2011-01-111-2/+1
| | | | for example, by test_successful_build_association in has_one_associations_test.rb
* For a singular association, it should be build_association, rather than ↵Jon Leighton2011-01-111-1/+1
| | | | association.build (as association may be nil)
* Correctly indent the bullet points under 'One-to-one associations', so that ↵Jon Leighton2011-01-111-10/+10
| | | | the lines are not broken in the generated rdoc html
* avoid splatting arrays by using concatAaron Patterson2011-01-111-3/+3
|
* Fix polymorphic belongs_to associationproxy raising errors when loading target.Ernie Miller2011-01-111-0/+5
|
* only use one array when collecting split up queriesAaron Patterson2011-01-101-1/+1
|
* Always return decimal average of integer fieldsRaimonds Simanovskis2011-01-101-9/+5
| | | | In previous version if database adapter (e.g. SQLite and Oracle) returned non-String calculated values then type_cast_using_column converted decimal average value of intefer field to integer value. Now operation parameter is always checked to decide which conversion of calculated value should be done.
* Adding postgresql template option when executing db:test:clone_structureKatrina Owen2011-01-091-1/+1
| | | | | | | | | | Specify the template to use in config/database.yml, e.g. test: adapter: postgresql template: template_postgis If no template is specified, postgresql defaults to template1
* remove unused string substitutionAaron Patterson2011-01-081-6/+1
|
* use select_all because not all database adapters support bind valuesAaron Patterson2011-01-081-1/+1
|
* join the cult of cargo. reduce the number of NoMethodErrors in the systemAaron Patterson2011-01-071-1/+1
|
* stop creating intermediate AR objects, just construct AR objects from a list ↵Aaron Patterson2011-01-071-1/+2
| | | | of hashes
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-23 23:22:42 +0000