| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
| |
When scanning the Enum API page I found it easy to miss that scopes are generated. Adding an example clarifies use and has more... *pop*...
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rollback"
We are reverting these commits, because there are other caveats related
to dirty attributes not being restored when a transaction is rollback.
For instance, nested transactions cannot proper restore the dirty
attributes state after a rollback.
At the moment, the dirty attributes are scoped by the transaction.
When we call `.save` on a record, the dirty attributes will be reset even
if the transaction gets rollback.
[related #13166]
[related #15018]
[related #15016]
[closes #15019]
This reverts commits
* bab48f0a3d53a08bc23ea0887219e8deb963c3d9
* b0fa7cf3ff8432cc2eef3682b34763b7f8c93cc8.
* 73fb39b6faa9de593ae75ad4e3b8e065ea0e53af
* 37c238927fbed059de3f26a90d8923fb377568a5.
* 8d8d4f1560264cd1c74364d67fa0501f6dd2c4fa
Revert "Merge pull request #13166 from bogdan/transaction-magic"
|
|
|
|
|
| |
I wanted the middle model to be anonymous, but we have to give it a name
for marshal support. :'(
|
|
|
|
|
| |
HABTM should fall back to using the normal CollectionAssociation's size calculation if the collection is not cached or loaded.
This addresses both #14913 and #14914 for master.
|
| |
|
| |
|
|
|
|
| |
[related #13166]
|
|\
| |
| |
| | |
[Regression 3.2 -> 4.0] Fix bugs with changed attributes tracking when transaction gets rollback
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Rewrite to avoid 'we'/'you', add missing period, and keep lines at 80 chars. Cheers :)
Improve readability with help from @senny
[ci skip]
|
|\ \
| | |
| | | |
Refactored AssociationScope#get_bind_values
|
| | |
| | |
| | |
| | | |
Added #join_id_for(owner) to reflection to avoid accessing the source_macro
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Now that delete_all with destroy or delete_all dependency behave
the same we no longer need this conditional. This means we can remove
the new delete_all_with_dependency method I added and go straight
to delete_records from delete_all, passing :all and the dependent
directly.
|
|/ /
| |
| |
| |
| | |
This makes table_name_suffix work the same as table_name_prefix when
using namespaced models. Pretty much the same as 67d1cec.
|
| |
| |
| |
| |
| |
| |
| |
| | |
This is a regression 4.0 -> 4.1 fix.
In 4.1.0 Relation#join is delegated to Arel#SelectManager.
In 4.0 series it is delegated to Array#join
This patch puts back the behaviour of 4.0
|
| |
| |
| |
| | |
The case where the value is present is more common
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix exception when logging SQL w/ nil binary value.
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
column_for will raise in case column is not found for the given table,
so there is no need to handle that here.
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
make `db:structure:load` listed with `rake -T`
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a follow up to #14139.
/cc @carlosantoniodasilva
|
|\ \ \ \
| |/ / /
|/| | |
| | | | |
Fixed custom validation context bug for child associations
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
associations were not being saved.
Fixes #13854.
[Eric Chahin, Aaron Nelson, & Kevin Casey]
|
| |/ /
|/| |
| | |
| | |
| | | |
bind parameters we not being propogated to simple subquery calculation
calls. This fixes it
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Symbolize variables of mysql/mysql2 connection configuration
Conflicts:
activerecord/CHANGELOG.md
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
For mysql2/mysql adapters, `sql_mode` variable name set in `database.yml`
as string, was ignored and `sql_mode` was set to use strict mode.
Fixes #14895
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
SQLite3: Always close statements.
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
SQLite3 adapter must make sure to close statements after queries.
Fixes: #13631
|
| |/ /
|/| | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
eileencodes/fix-delete-all-with-nil-dependency-to-not-produce-in-statement
Fix delete all with nil (:nullify) dependency to not produce in statement
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Nullify (or nil dependency) was doing the same thing delete_all
was doing in issue #14546, creating a large IN statement if
the association was loaded. Loaded and not loaded associations
should behave the same. The IN statement is also not great because
it's inefficient.
|
|\ \ \ \
| |/ / /
|/| | | |
[ci skip] updating active_record/associations to demonstrate where conflict with eager loading.
|
| | | |
| | | |
| | | |
| | | | |
with eager loading.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
After reviewing this code I realized the conditional that was
there previously was basically saying if the dependency is not
delete all. This is a better, cleaner, and clearer way to write
this method.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Now that we have a new method delete_all_with_dependency this
coupled conditional is no longer needed.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The delete method is very coupled with delete all even
though only a portion of the conditionals apply. Decoupling
this will make the code easier to understand and manipulate.
|
|\ \ \ \
| | | | |
| | | | | |
Fix to use custom join table in habtm
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When used a custom join_table name on a habtm, rails was not saving it
on Reflections. This causes a problem when rails loads fixtures, because
it uses the reflections to set database with fixtures.
|
|\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* master: (28 commits)
move AR length validation tests into separate test-case.
No need for trailing slash on migration path.
reset `@arel` when modifying a Relation in place.
PostgreSQL Timestamps always map to `:datetime`.
[ci skip] Improve formatting and yml
Fix a typo in the doc of forty_two AR FinderMethod
Improve readability of contributing to rails guide. [ci skip]
Precompile the image we're referencing, too.
`ActiveRecord::Base.no_touching` no longer triggers callbacks or start empty transactions.
Fixed an issue with migrating legacy json cookies.
Correct comment [ci skip]
Perfer to define methods instead of calling test
Fix syntax error
Add CHANGELOG entry for #14757 [ci skip]
Fix run-on sentences and improve grammar [skip ci]
Add test for using ActionView::Helpers::FormHelper.label with block and html
select! renamed to avoid name collision Array#select!
Rearrange deck chairs on the titanic. Organize connection handling test cases.
Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon.
ActionController::Renderers documentation fix
...
|
| | | | |
| | | | |
| | | | |
| | | | | |
/cc @tenderlove
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The PG Adapter should use `:datetime` consistently instead of mapping
mispellings to `:timestamp`.
See #14513
|