aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #15071 from leafac/issues/11985Rafael Mendonça França2014-05-161-3/+13
|\ | | | | Fix `Relation#delete_all` inconsistency
| * Fix `Relation#delete_all` inconsistencyLeandro Facchinetti2014-05-161-3/+13
| | | | | | | | | | | | | | | | | | When relation scopes include one of `uniq`, `group`, `having` or `offset`, the generated query ignores them and that causes unintended records to be deleted. This solves the issue by restricting the deletion when those scopes are present. rails/rails#11985
* | Remove unecessary requireArthur Neves2014-05-161-2/+0
| |
* | Remove the assignment for real this time.Zachary Scott2014-05-161-2/+2
| | | | | | | | | | | | cc: https://github.com/rails/rails/commit/a11e2fcff8cdc9691b977d8330abe63024f8c732#commitcomment-6353614 and 0369dbf
* | prepend mutates the string so we can remove the assignmentRafael Mendonça França2014-05-161-1/+1
| |
* | Reuse the force_clear_transaction_record_stateRafael Mendonça França2014-05-161-1/+1
| |
* | Missed if :bomb:Rafael Mendonça França2014-05-161-1/+1
| |
* | Add a specific method to force the transaction record state clearRafael Mendonça França2014-05-161-5/+8
| | | | | | | | | | | | We are using that code path in only one place so we should not add a conditional to all the other cases. This will avoid performance regressions on the old paths.
* | Clear transaction state if callback raise rollbackArthur Neves2014-05-151-1/+1
| |
* | Small refactoring on clear_transaction_record_stateArthur Neves2014-05-151-3/+5
| | | | | | | | | | | | Make sure when we clean the `@_start_transaction_state` var we do it in the same code-path. Also this makes `clear_transaction_record_state`, more consistent with `restore_transaction_record_state`
* | Changed extract_limit in class Column to return correct mysql float and ↵Aaron Nelson2014-05-161-0/+2
| | | | | | | | double limits
* | :scissors:Rafael Mendonça França2014-05-143-4/+0
| |
* | Methods of these modules are internalRafael Mendonça França2014-05-142-14/+14
| | | | | | | | | | They should not be used on people application so they should not be present on the API documentation.
* | Merge pull request #15088 from kares/shareable-modulesRafael Mendonça França2014-05-149-48/+52
|\ \ | | | | | | | | | [postgres] remove (outer) sub-class declarations with nested modules/classes
| * | PostgreSQLAdapter::Utils seems to be only used from a single spot - quite ↵kares2014-05-142-20/+19
| | | | | | | | | | | | redundant
| * | move PostgreSQL's DatabaseStatements out of the PostgreSQLAdapter name-spacekares2014-05-142-7/+7
| | |
| * | PostgreSQL's SchemaStatements seems a could candidate for re-use (with AR-JDBC)kares2014-05-142-8/+7
| | |
| * | introduce AR::ConnectionAdapters::PostgreSQL for sharing modules (with AR-JDBC)kares2014-05-147-15/+21
| | | | | | | | | ... 'shared' OID, ArrayParser and Cast helpers, also re-arranged Column's dependencies
* | | Don't use Active Support where it is not needed.Rafael Mendonça França2014-05-141-1/+3
| | | | | | | | | | | | | | | parent_name is a string of nil, never a blank string so we don't need to use presence.
* | | Merge pull request #14871 from kassio/kb-fixes-namespaced-habtmRafael Mendonça França2014-05-141-1/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix how to compute class name on habtm namespaced. Conflicts: activerecord/CHANGELOG.md
| * | | Fix how to compute class name on habtm namespaced.Kassio Borges2014-05-131-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | Thank's for @laurocaetano for the help with tests. :smiley: Fixes #14709
* | | | Merge pull request #15078 from nbudin/fix_merger_filter_binds_comparison_masterRafael Mendonça França2014-05-141-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make filter_binds filter out symbols that are equal to strings Conflicts: activerecord/CHANGELOG.md
| * | | | Make filter_binds filter out symbols that are equal to stringsNat Budin2014-05-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Relation::Merger's filter_binds method does not filter out bind variables when one of the attribute nodes has a string name, but the other has a symbol name, even when those names are actually equal. This can result in there being more bind variables than placeholders in the generated SQL. This is particularly an issue for PostgreSQL, where this is treated as an error. This patch changes the filter_binds method to make it convert both attribute names to strings before comparing.
* | | | | [ci skip]add updated information, ref[#522c0fd]Kuldeep Aggarwal2014-05-141-0/+2
| | | | |
* | | | | Fix inheritance of stored_attributes (fixes #14672)Jessica Yao2014-05-141-5/+14
| |_|/ / |/| | | | | | | | | | | [Brad Bennett, Jessica Yao, & Lakshmi Parthasarathy]
* | | | remove count vareileencodes2014-05-131-4/+2
| | | | | | | | | | | | | | | | this change was unneccsary as nothing was gained from it
* | | | rename delete_all_records to delete_or_nullify_all_recordseileencodes2014-05-133-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename delete_all_records because this name better describes what the method is doing. We can then remove :all from the hm:t version and pull out the unoptimized call to load_target in delete_records and pass it directly.
* | | | remove need for :all symboleileencodes2014-05-131-13/+6
| | | | | | | | | | | | | | | | | | | | | | | | Refactor delete_count method to only handle delete_all or nullify/nil cases and not destroy and switch to if/else rather than case statement. This refactoring allows removal of :all symbol usage.
* | | | begin refactoring delete_records methodeileencodes2014-05-133-13/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor by creating two methods delete_all_records and delete_records to be called by delete_all and delete (or destroy) respectively. This reduces the number of conditionals required to handle _how_ records get deleted. The new delete_count method handles how scope is applied to which delete action. A delete_all_records method also has to be called in has_many_through association because of how the methods are chained. This will be refactored later on.
* | | | Merge pull request #15092 from kares/pg-array-parserRafael Mendonça França2014-05-132-27/+27
|\ \ \ \ | | | | | | | | | | [postgres] include PgArrayParser directly
| * | | | [postgres] include PgArrayParser directly and only load/include ArrayParser ↵kares2014-05-132-27/+27
| | |/ / | |/| | | | | | | | | | if not found
* / | | extract pg type map initialization process to `TypeMapInitializer`.Yves Senn2014-05-132-65/+74
|/ / /
* / / docs, explain usage of `count` + `select`. Closes #15065. [ci skip]Yves Senn2014-05-131-0/+8
|/ /
* | pg, `change_column_default` accepts `[]`. Closes #11586.Yves Senn2014-05-122-2/+3
| |
* | pg, map `char` and `name` types as string. [dark-panda & Yves Senn]Yves Senn2014-05-121-0/+1
| | | | | | | | Closes #10802.
* | pg, fix Infinity and NaN values conversion.Innokenty Mihailov2014-05-121-3/+8
|/ | | | Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
* Handle other pk types in PostgreSQL gracefully.Patrick Robertson2014-05-121-1/+1
| | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.
* Update attribute_methods.rbGuillermo Iguaran2014-05-111-1/+1
| | | Improve documentation
* Merge pull request #15063 from cbeer/correct-attribute_present-docsGuillermo Iguaran2014-05-111-7/+7
|\ | | | | correcting method documentation [ci skip]
| * correcting method documentation [ci skip]Chris Beer2014-05-111-7/+7
| |
* | docs, fix typo in docs added by ed56e596a04673. [ci skip]Yves Senn2014-05-101-2/+2
| |
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-05-103-0/+14
|\ \
| * | copy edits [ci skip]Vijay Dev2014-05-101-6/+5
| | |
| * | [ci skip] add example to AR#assign_attributesschneems2014-05-091-0/+10
| | |
| * | copy edits [ci skip]Vijay Dev2014-05-081-1/+1
| | |
| * | [ci skip] document type_cast_for_writeschneems2014-05-072-0/+5
| | |
* | | deprecate, join, preload, eager load of instance dependent associations.Yves Senn2014-05-104-0/+20
| | | | | | | | | | | | | | | | | | | | | Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior.
* | | Documentation, add examples of using an Enum scopeZac2014-05-091-2/+4
| | | | | | | | | When scanning the Enum API page I found it easy to miss that scopes are generated. Adding an example clarifies use and has more... *pop*...
* | | Reverts "Fix bugs with changed attributes tracking when transaction gets ↵Arthur Neves2014-05-091-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rollback" We are reverting these commits, because there are other caveats related to dirty attributes not being restored when a transaction is rollback. For instance, nested transactions cannot proper restore the dirty attributes state after a rollback. At the moment, the dirty attributes are scoped by the transaction. When we call `.save` on a record, the dirty attributes will be reset even if the transaction gets rollback. [related #13166] [related #15018] [related #15016] [closes #15019] This reverts commits * bab48f0a3d53a08bc23ea0887219e8deb963c3d9 * b0fa7cf3ff8432cc2eef3682b34763b7f8c93cc8. * 73fb39b6faa9de593ae75ad4e3b8e065ea0e53af * 37c238927fbed059de3f26a90d8923fb377568a5. * 8d8d4f1560264cd1c74364d67fa0501f6dd2c4fa Revert "Merge pull request #13166 from bogdan/transaction-magic"
* | | set a constant for the "anonymous" habtm model fixes #15022Aaron Patterson2014-05-081-0/+5
| | | | | | | | | | | | | | | I wanted the middle model to be anonymous, but we have to give it a name for marshal support. :'(
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 22:25:30 +0000