aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* push partion logic down and initialization logic upAaron Patterson2013-05-211-15/+11
|
* partition the where values so we can access the removed onesAaron Patterson2013-05-201-1/+6
|
* eliminate some conditionalsAaron Patterson2013-05-201-3/+3
|
* change method name to reflect what it actually does.Aaron Patterson2013-05-201-2/+2
|
* save the where values in variables so we don't need to look them up allAaron Patterson2013-05-201-4/+5
| | | | the time
* pass where values to the helper function rather than rely on internal stateAaron Patterson2013-05-201-4/+4
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-05-197-10/+42
|\
| * copy edits[ci skip]Vijay Dev2013-05-192-12/+9
| |
| * Added some more documentation for define_readers and define_writer of the ↵aditya-kapoor2013-05-153-0/+15
| | | | | | | | Association and its inherited classes
| * Added some more documentation for ↵aditya-kapoor2013-05-151-0/+11
| | | | | | | | ActiveRecord::Associations::Builder::Association class
| * Added documentation for ActiveRecord::Associations::Builder::Association classaditya-kapoor2013-05-151-0/+4
| |
| * improved doc for ActiveRecord#find_by_sql method (Refs #10599) [ci skip]Anton Kalyaev2013-05-141-3/+4
| |
| * Added documentation for model migration generationaditya-kapoor2013-05-141-0/+4
| |
| * emphasize that callbacks are called in destroy_allNeeraj Singh2013-05-132-7/+7
| | | | | | | | | | | | | | Cleaned up rdoc a bit emphasizing that callbacks are called. Also removed the stress on the fact that records are always removed. If callbacks return false then records will not be deleted.
* | stop swallowing exceptions in assert_queries. Methods that raise anAaron Patterson2013-05-171-2/+2
| | | | | | | | | | exception are unlikely to pass this assertion, but since the assertions raise an exception, the original exception is lost.
* | stop doing assingments in an iteratorAaron Patterson2013-05-171-2/+6
| |
* | include bind values from the default scopeAaron Patterson2013-05-171-2/+4
| |
* | let Ruby do the is_a check for usAaron Patterson2013-05-161-3/+4
| |
* | Add more data to AR::UnknownAttributeErrorBogdan Gusiev2013-05-162-1/+10
| | | | | | | | | | | | | | | | | | begin Topic.new("hello" => "world") rescue ActiveRecord::UnknownAttributeError => e e.record # => #<Topic ... > e.attribute # => "hello" end
* | Merge pull request #10619 from alno/top_level_array_in_postgres_jsonAaron Patterson2013-05-162-1/+3
|\ \ | | | | | | Support array as root element in Postgresql JSON columns
| * | Support array as root element in JSONAlexey Noskov2013-05-142-1/+3
| | |
* | | Check if APP_RAKEFILE is definedPiotr Sarnacki2013-05-161-1/+1
| | |
* | | Fix detection of engine in rake db:load_configJoel Cogen2013-05-161-1/+1
| | | | | | | | | | | | Broken by d1d7c86d0c8dcb7e75a87644b330c4e9e7d6c1c1
* | | tiny types should only be integers when the length is <= 1. fixes #10620Aaron Patterson2013-05-151-3/+9
| | |
* | | require things we needAaron Patterson2013-05-151-0/+1
| | |
* | | Also support extensions in PostgreSQL 9.1, because this has been supported ↵kennyj2013-05-151-4/+4
| | | | | | | | | | | | since 9.1.
* | | deprecating string based terminatorsAaron Patterson2013-05-141-1/+3
|/ /
* | Merge pull request #10556 from Empact/deprecate-schema-statements-distinctRafael Mendonça França2013-05-121-1/+2
| | | | | | | | | | | | Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc. Conflicts: activerecord/CHANGELOG.md
* | Some editorial changes on the documentation.Rafael Mendonça França2013-05-122-27/+27
|/ | | | | | | | * Remove some autolinks * Fix the rendered result * Change sql to SQL [ci skip]
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-05-124-4/+12
|\ | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb
| * copy edits [ci skip]Vijay Dev2013-05-121-5/+1
| |
| * Added documentation for ↵aditya-kapoor2013-05-101-0/+4
| | | | | | | | ActiveRecord::Generators::MigrationGenerator.next_migration_number
| * Added documentation for ActiveRecord::Base#next_migration_numberaditya-kapoor2013-05-091-0/+5
| |
| * minor rdoc cleanup for reflection methodsNeeraj Singh2013-05-091-4/+4
| |
| * added to rdoc for unscope that default_scope winsNeeraj Singh2013-05-031-0/+3
| |
* | Adding documentation to the automatic inverse_of finder.wangjohn2013-05-112-1/+22
| |
* | Call assume_migrated_upto_version on connectionKyle Stevens2013-05-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | Call assume_migrated_upto_version on connection to prevent it from first being picked up in method_missing. In the base class, Migration, method_missing expects the argument to be a table name, and calls proper_table_name on the arguments before sending to connection. If table_name_prefix or table_name_suffix is used, the schema version changes to prefix_version_suffix, breaking `rake test:prepare`. Fixes #10411.
* | Merge pull request #10567 from ↵Rafael Mendonça França2013-05-111-1/+2
|\ \ | | | | | | | | | | | | neerajdotname/read_attribute_before_type_cast_should_accept_symbol read_attribute_before_type_cast should accept symbol
| * | read_attribute_before_type_cast should accept symbolNeeraj Singh2013-05-111-1/+2
| | |
* | | Merge pull request #10572 from nertzy/dont-modify-options-hash-in-primary-keyRafael Mendonça França2013-05-111-2/+1
|/ / | | | | | | Don't modify args in TableDefinition#primary_key
* | Extract JoinDependency#join_relation to DRY the repeated application of the ↵Ben Woosley2013-05-103-7/+9
| | | | | | | | #join_associations.
* | In #apply_join_dependency, we can apply the #where in-place because relation ↵Ben Woosley2013-05-101-1/+1
| | | | | | | | | | | | is always a new object. Thanks to the #except we call at the top of the method.
* | DRY-up join dependency creation by extracting construct_join_depdencyBen Woosley2013-05-101-7/+5
| |
* | Pull the excepts into apply_join_dependency, for the sake of DRY.Ben Woosley2013-05-101-3/+4
| |
* | Simplify conditions within apply_join_dependencyBen Woosley2013-05-101-9/+5
| |
* | Move the except(:select) inside the construct_limited_ids_condition method ↵Ben Woosley2013-05-101-2/+2
| | | | | | | | to pair it closely with its motivation.
* | Reject blank order_values within #columns_for_distinct, as the orders aren't ↵Ben Woosley2013-05-102-3/+3
| | | | | | | | used at all on non-postgres adapters.
* | Move #proxy_association method to AssociationRelationJon Leighton2013-05-103-4/+6
| |
* | Merge pull request #6792 from Empact/postgres-distinctJon Leighton2013-05-103-12/+15
|\ \ | | | | | | Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT"
| * | Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT"Ben Woosley2013-05-103-12/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The combination of a :uniq => true association and the #distinct call in #construct_limited_ids_condition combine to create invalid SQL, because we're explicitly selecting DISTINCT, and also sending #distinct on to AREL, via the relation#distinct_value. Rather than build a select distinct clause in #construct_limited_ids_condition, I set #distinct! and pass just the columns into the select statement. This requires introducing a #columns_for_distinct method to return the select columns but not the statement itself.