aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | Avoid super; speeds up Model.new by about 12%Jon Leighton2011-12-141-1/+1
| |
* | Stop the build asploding on 1.8.7Jon Leighton2011-12-141-0/+2
| |
* | Use a separate module for 'external' attribute methods.Jon Leighton2011-12-143-17/+26
| |
* | Revert naive O(1) table_exists? implementation.Jon Leighton2011-12-133-12/+15
|/ | | | | | | | | | It was a bad idea to rescue exceptions here. This can interfere with transaction rollbacks which seems to be the cause of current CI failure. Instead, each adapter should implement its own DB-specific O(1) implementation, and we fall back on the generic, slower, implementation otherwise.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-12-141-1/+1
|\
| * changed :finder_sql example to select * clst2011-12-121-1/+1
| | | | | | because with select p.* you can no longer use count(). Using count will result in an SQL error message.
| * fixed example for :finder_sql clst2011-12-121-1/+1
| | | | | | people.* will not work when the alias is named p
* | FileUpdateChecker should be able to handle deleted files.José Valim2011-12-131-2/+1
| |
* | use the schema cache when asking for the primary keyAaron Patterson2011-12-121-1/+1
| |
* | Speed up development by only reloading classes if dependencies files changed.José Valim2011-12-121-0/+5
| | | | | | | | | | | | | | | | This can be turned off by setting `config.reload_classes_only_on_change` to false. Extensions like Active Record should add their respective files like db/schema.rb and db/structure.sql to `config.watchable_files` if they want their changes to affect classes reloading. Thanks to https://github.com/paneq/active_reload and Pastorino for the inspiration. <3
* | ensure @fixture_connections is initialized in case an exception happens ↵Aaron Patterson2011-12-101-0/+1
| | | | | | | | during setup
* | Errno::ENOENT error makes more sense when a file cannot be foundAaron Patterson2011-12-101-10/+0
| |
* | Allow to run migrations with given scope, with SCOPE=<scope>Piotr Sarnacki2011-12-091-1/+3
| | | | | | | | | | | | | | | | | | | | | | Scope in migrations can be defined by adding suffix in filename, like: 01_a_migration.blog.rb. Such migration have blog scope. Scope is automatically added while copying migrations from engine, so if you want to revert all of the migrations from given engine, you can just run db:migrate with SCOPE, like: rake db:migrate SCOPE=blog
* | Allow to filter migrations by passing a blockPiotr Sarnacki2011-12-091-9/+13
| | | | | | | | | | | | | | | | | | | | Example: ActiveRecord::Migrator.migrate(path) do |migration| migration.name =~ /User/ end The above example will migrate only migrations with User in the name
* | Use `table_exists?` from the schema cache.Aaron Patterson2011-12-092-5/+3
| |
* | don't need a begin / end.Aaron Patterson2011-12-091-6/+4
| |
* | squelch table exists? queries.Aaron Patterson2011-12-091-1/+1
| |
* | Compare migrations for copying only by name and scopePiotr Sarnacki2011-12-091-22/+6
| |
* | Add suffix for migrations copied from enginesPiotr Sarnacki2011-12-091-5/+5
| |
* | String#to_a is not available in 1.9Piotr Sarnacki2011-12-091-1/+1
| |
* | Run also migrations in subdirectories.Piotr Sarnacki2011-12-091-2/+3
| | | | | | | | | | With this commit, ActiveRecord will also look for migrations in db/migrate subdirectories.
* | Ignore origin comment when checking for duplicates on Migration.copyPiotr Sarnacki2011-12-091-2/+20
| | | | | | | | | | | | | | 49ebe51 fixed copying migrations, but existing migrations would still trigger warnings. The proper way to compare migrations is to ignore origin lines - if migration is identical it means that we can silently skip it, regardless where it comes from.
* | Fix copying migrations from enginesPiotr Sarnacki2011-12-091-3/+3
| | | | | | | | | | | | | | | | | | | | There was a bug in ActiveRecord::Migration.copy method, which prevented adding special comment about the origin of migration. Because of that, the check if migration is identical or if it's not and should be skipped was always saying that migration is skipped, which was causing additional useless warnings about skipped migrations.
* | Exceptions should read from the spec configuAaron Patterson2011-12-081-1/+1
| |
* | Fix #3890. (Calling proxy_association in scope chain.)Jon Leighton2011-12-081-2/+8
| |
* | fix nodocsVijay Dev2011-12-093-9/+9
| |
* | fix commentsVijay Dev2011-12-091-4/+2
| |
* | Remove NilClass whiners feature.José Valim2011-12-081-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removing this feature causes boost in performance when using Ruby 1.9. Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str` in some STDLIB methods (like Array#join). To do such implicit conversions, Ruby 1.9 always dispatches the method and rescues the NoMethodError exception in case one is raised. Therefore, since the whiners feature defined NilClass#method_missing, such implicit conversions for nil became much, much slower. In fact, just defining NilClass#method_missing (even without the whiners feature) already causes a massive slow down. Here is a snippet that shows such slow down: require "benchmark" Benchmark.realtime { 1_000.times { [nil,nil,nil].join } } class NilClass def method_missing(*args) raise NoMethodError end end Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
* | fixing eval'd line numbers.Aaron Patterson2011-12-081-2/+2
| |
* | Use a hash to look up column definitionsAaron Patterson2011-12-071-2/+3
| |
* | try to normalize the objects passed to column()Aaron Patterson2011-12-071-9/+11
| |
* | automatically add the column definition to the columns list if creating a ↵Aaron Patterson2011-12-071-12/+21
| | | | | | | | new one
* | stop calling String#to_s so frequentlyAaron Patterson2011-12-071-3/+4
| |
* | the required sqlite3 adapter responds to encoding, so stop checking.Aaron Patterson2011-12-071-5/+1
| |
* | reversible migration example had missing block parameterEvgeniy Kelyarsky2011-12-071-1/+1
| |
* | add prefix and suffix to renamed tables, closes #1510Vasiliy Ermolovich2011-12-061-0/+1
|/
* Quitoting the table name before querying.Aaron Patterson2011-12-051-1/+1
|
* Speed up table_exists? for databases with a large number of tablesJade Rubick2011-12-051-1/+6
| | | | | | At New Relic, we have hundreds of thousands of tables, and our migrations took 30 minutes without this similar patch. This cuts it down to a more reasonable amount of time. The rescue false part is ugly, but necessary as far as I can tell. I don't know of a cross-database statement you can make that will work without trapping errors.
* Merge pull request #3854 from exviva/validates_associated_marked_for_destructionJosé Valim2011-12-041-2/+3
|\ | | | | Do not validate associated records marked for destruction
| * Do not validate associated records marked for destructionOlek Janiszewski2011-12-051-2/+3
| | | | | | | | | | | | The main reason for this change is to fix a bug where `validates_associated` would prevent `accepts_nested_attributes_for` with `allow_destroy: true` from destroying invalid associated records.
* | Merge pull request #3851 from ebeigarts/fix_sequence_nameJon Leighton2011-12-041-2/+2
|\ \ | |/ |/| Fix sequence name with abstract classes.
| * Fix sequence name with abstract classes.Edgars Beigarts2011-12-041-2/+2
| |
* | moves some auto explain logic to the subscriber [José Valim & Xavier Noria]Xavier Noria2011-12-042-19/+12
| |
* | simplifies ActiveRecord::ExplainSubscriber [José Valim & Xavier Noria]Xavier Noria2011-12-041-8/+6
| |
* | Merge branch 'explain'Xavier Noria2011-12-045-55/+62
|\ \ | |/ |/|
| * implements a much faster auto EXPLAIN, closes #3843 [José Valim & Xavier Noria]Xavier Noria2011-12-045-55/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit vastly reduces the impact of auto explain logging when enabled, while keeping a negligible cost when disabled. The first implementation was based on the idea of subscribing to "sql.active_record" when needed, and unsubscribing once done. This is the idea behind AR::Relation#explain. Subscribe, collect, unsubscribe. But with the current implementation of notifications unsubscribing is costly, because it wipes an internal cache and that puts a penalty on the next event. So we are switching to an approach where a long-running subscriber is listening. Instead of collecting the queries with a closure in a dedicated subscriber, now we setup a thread local. If the feature is disabled by setting the threshold to nil, the subscriber will call a method that does nothing. That's totally cheap.
* | Refactor readonly attributes conditionalCarlos Antonio da Silva2011-12-041-1/+2
|/
* SQlite3 Bump Arun Agrawal2011-12-041-1/+1
|
* Fix #3837.Jon Leighton2011-12-031-11/+5
| | | | | We also need to time zone convert time zone aware attributes when accessed via read_attribute, not only when via direct access.
* removes the convenience instance version of AR::Base.silence_auto_explainXavier Noria2011-12-032-89/+79
| | | | | | | Rationale: As discussed with José and Jon, this convenience shortcut is not clearly justified and it could let the user thing the disabled EXPLAINs are related to the model instance rather than being globally disabled.