aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
| * Add simple case when DB calculations returns 0 instead of 0.0 [#1346 ↵Joshua Peek2008-11-101-1/+1
| | | | | | | | state:resolved]
* | lazy-initialize already loaded fixtures mapJeremy Kemper2008-11-081-1/+1
| |
* | Merge branch 'master' into testingJeremy Kemper2008-11-081-3/+11
|\|
| * Timeout the connection pool monitor on ruby 1.8 onlyJeremy Kemper2008-11-081-3/+11
| |
* | Merge branch 'master' into testingJeremy Kemper2008-11-071-1/+1
|\|
| * If average value from DB is 0, make sure to convert it to a 0.0 float before ↵Ken Collins2008-11-071-1/+1
| | | | | | | | | | | | calling #to_d on it [#1346 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* | Merge branch 'master' into testingJeremy Kemper2008-11-074-15/+7
|\|
| * Don't leave open dangling connections in development mode. [#1335 ↵Pratik Naik2008-11-081-2/+1
| | | | | | | | state:resolved]
| * Simplify dispatcher callbacks to eliminate unnecessary stale thread purging. ↵Nick Sieger2008-11-081-4/+1
| | | | | | | | | | | | [Nick Sieger, Pratik Naik] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Added :counter_sql as a valid key for habtm associationsTekin Suleyman2008-11-071-1/+1
| | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
| * Revert commit which breaks all the tests.Michael Koziarski2008-11-071-8/+4
| | | | | | | | | | | | | | | | This reverts commit 8adb79b9b5983cda8dbdd4ef401661fbd51d8844. Conflicts: activerecord/CHANGELOG
* | undef abstract methods instead of raising NotImplementedError. Still need ↵Jeremy Kemper2008-11-071-4/+4
| | | | | | | | the definitions for rdoc though.
* | Remove fixtures from Test::Unit::TestCase. Mix in AR::TestFixtures instead.Jeremy Kemper2008-11-072-140/+147
|/
* Fix memory leak issue in ActiveRecord scoped_methodsJoshua Peek2008-11-061-2/+1
|
* Stop logging SHOW FIELDS and SET SQL_AUTO_IS_NULL=0 for the MysqlAdapter as ↵David Heinemeier Hansson2008-11-061-4/+8
| | | | they only clutter up the log and offer no value [DHH]
* Make sure ActiveRecord::Base.connected? doesn't raise an exception for ↵Pratik Naik2008-11-061-1/+2
| | | | defined connections
* Ensure ActiveRecord::ConnectionPool.connected? handles undefined ↵Wes Oldenbeuving2008-11-061-1/+1
| | | | | | connections. [#936 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Merge docrails. Remove unnecessary files.Pratik Naik2008-11-021-0/+8
|
* Make sure habtm use class variable to list association valid keysLuca Guidi2008-11-011-9/+12
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1310 state:committed]
* It is not necessary to store QueryCache in a thread local since the cache is ↵Joshua Peek2008-10-301-27/+14
| | | | local to the connection object which is managed by the connection pool
* Use database name in query cache thread local key [#1283 state:resolved]Joshua Peek2008-10-301-3/+2
|
* Ensure indices don't flip order in schema.rb [#1266 state:committed]Jordi Bunster2008-10-301-6/+12
| | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
* Make #destroy write 1 line into log (instead of 3) (Dmitry Sokurenko) [#689 ↵David Heinemeier Hansson2008-10-291-4/+5
| | | | status:committed]
* Fixed that serialized strings should never be type-casted (i.e. turning ↵David Heinemeier Hansson2008-10-271-1/+1
| | | | "Yes" to a boolean)(Andreas Korth) [#857 state:committed]
* Remove reference to fformat to restore support for postgres gem.Michael Koziarski2008-10-261-1/+1
|
* Fix binary data corruption bug in PostgreSQL adaptorAdam Majer2008-10-251-68/+79
| | | | | | | | | | | 1. Move the binary escape/unescape from column to the driver - we should store binary data AR just like most other adaptors 2. check to make sure we only unescape bytea data PGresult.ftype( column ) == 17 that is passed to us in escaped format PGresult.fformat( column ) == 0 Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1063 state:committed]
* "raise NoMethodError" raises NoMethodError. Raise it with NoMethodError.new ↵Mike Gunderloy2008-10-251-1/+1
| | | | | | instead. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixed issue where block is not called on the very first invocation of a ↵Ken Miller2008-10-241-2/+2
| | | | | | find_or_create_by_ automatic finder. [#1224 state:committed]
* Skip collection ids reader optimization if using :finder_sqlJeremy Kemper2008-10-231-1/+1
|
* Merge with docrails. Also add a rake task to generate guides in your rails ↵Pratik Naik2008-10-213-2/+10
| | | | | | | | application : rake doc:guides The rake task will generate guides inside doc/guides directory of your application. Open index.html to browse.
* Ensure association proxy responds to private class methods defined in ↵Pratik Naik2008-10-161-2/+2
| | | | associated class. [#1083]
* Merge docrailsPratik Naik2008-10-162-3/+5
|
* Allow class methods to be sent (via #send) to association proxy (fix for bug ↵Ian White2008-10-161-0/+4
| | | | | | introduced by 691aa20) [#1083] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure methods called on association proxies respect access control. [#1083 ↵Pratik Naik2008-10-132-1/+12
| | | | state:resolved] [Adam Milligan, Pratik]
* Remove the functionality introduce in 28d3390Michael Koziarski2008-10-101-12/+1
| | | | There are several situations it doesn't cater for, and the inconsistency isn't worth blocking 2.2.
* explicitly including child associations that are also included in the parent ↵Will Bryant2008-10-102-0/+8
| | | | | | | association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed]
* Add documentation for AbstractAdapter#sanitize_limit, and make its code more ↵Hongli Lai (Phusion)2008-10-091-4/+15
| | | | | | | readable. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1068 status:committed]
* Merge docrailsPratik Naik2008-10-0510-79/+469
|
* Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:resolved]Pratik Naik2008-10-041-3/+7
| | | | | Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string. Model.avg always returns big decimal.
* Remove HasManyAssociationStrategy and move the logic to ↵Pratik Naik2008-10-042-27/+21
| | | | ActiveRecord::Reflection::ThroughReflection.
* Introduce ActiveRecord::Reflection::ThroughReflection to simplify hm:t ↵Pratik Naik2008-10-041-53/+66
| | | | reflection logic
* Fix has_many :through when the source is a belongs_to association. [#323 ↵Zach Dennis2008-10-042-10/+45
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Try reloading model on class mismatch [#229 state:resolved]Lawrence Pit2008-10-041-1/+1
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix performance bug in AttibuteMethods#respond_to? in handling of private ↵Aliaksey Kandratsenka2008-10-041-1/+3
| | | | | | | | | | | methods We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1173 state:committed]
* made ConnectionPool#checkout more robust by trying to loot dead threads when ↵Aliaksey Kandratsenka2008-10-041-1/+5
| | | | | | | | pool is empty Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1169 state:committed]
* Fix race in ConnectionPool#checkoutAliaksey Kandratsenka2008-10-041-15/+14
| | | | | | | After releasing monitor some connection(s) may appear in pool before monitor is re-aquired. When this happens we'll wait for connection which is already available. Signed-off-by: Michael Koziarski <michael@koziarski.com>
* don't quote decimal values for mysql. It doesn't make sense and breaks in ↵Aliaksey Kandratsenka2008-10-041-1/+1
| | | | | | | newer versions of mysql Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1168 state:committed]
* Make sure recreate MySQL test database with the proper encoding and ↵Luca Guidi2008-10-031-2/+2
| | | | | | | collation [#1165 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1165 state:committed]
* Remove AS for oracle compatibilityMichael Koziarski2008-10-031-1/+1
|
* Dynamic finders should use the ActiveRecord::Base::find method instead of ↵Eloy Duran2008-10-032-8/+8
| | | | | | | | | | | | ::find_initial, :find_last, and ::find_all. This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders. Associations for instance do go through ::find, so this makes it more consistent. Also removed the unnecessary deprecation silence blocks. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1162 state:committed]