aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #28726 from matthewd/transaction-lockingMatthew Draper2017-04-133-52/+70
|\ | | | | Add comprehensive locking around DB transactions
| * Add comprehensive locking around DB transactionsMatthew Draper2017-04-113-52/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Transactional-fixture using tests with racing threads and inter-thread synchronisation inside transaction blocks will now deadlock... but without this, they would just crash. In 5.0, the threads didn't share a connection at all, so it would've worked... but with the main thread inside the fixture transaction, they wouldn't've been able to see each other. So: as far as I can tell, the set of operations this "breaks" never had a compelling use case. Meanwhile, it provides an increased level of coherency to the operational feel of transactional fixtures. If this does cause anyone problems, they're probably best off disabling transactional fixtures on the affected tests, and managing transactions themselves.
* | Merge pull request #28712 from kamipo/tweaks_28678Andrew White2017-04-121-4/+5
|\ \ | | | | | | Tweaks #28678
| * | Tweaks #28678Ryuta Kamizono2017-04-091-4/+5
| | | | | | | | | | | | | | | | | | * Fix the comment on `formatted_version` * Extract `define_params` * Remove duplicated guard clause for `@version`
* | | Use a query that's compatible with PostgreSQL 9.2Matthew Draper2017-04-121-7/+11
| |/ |/| | | | | | | | | Also, explicitly apply the order: generate_subscripts is unlikely to start returning values out of order, but we should still be clear about what we want.
* | exclude ORDER BY clause for exists? (#28699)Boris Slobodin2017-04-101-1/+1
| |
* | Merge pull request #28713 from kamipo/expose_queries_for_association_queriesMatthew Draper2017-04-102-48/+44
|\ \ | |/ |/| Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue`
| * Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue`Ryuta Kamizono2017-04-092-21/+25
| |
| * Avoid to handle polymorphic association for `AssociationQueryHandler`Ryuta Kamizono2017-03-282-29/+21
| | | | | | | | It should be handled by `PolymorphicArrayHandler` if polymorphic association.
* | Merge pull request #28678 from hedgesky/use_formatted_number_as_schema_versionRafael França2017-04-081-1/+9
|\ \ | | | | | | use formatted number as schema version
| * | use formatted number as schema versionAnton Chuchkalov2017-04-051-1/+9
| | |
* | | Extract `construct_relation_for_exists` in `FinderMethods`Ryuta Kamizono2017-04-091-12/+15
| | | | | | | | | | | | To ease to customize a relation for `exists?`.
* | | Passing in no arguments to the dynamic fixture accessor method returns all ↵Kevin McPhillips2017-04-071-4/+25
|/ / | | | | | | fixtures, not an empty array.
* | Merge pull request #28057 from eugeneius/clear_active_connectionsMatthew Draper2017-04-041-0/+8
|\ \ | | | | | | Clear active connections after initialization
| * | Clear active connections after initializationEugene Kenny2017-02-171-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Any connections that were checked out during initialization should be checked back in before the first request is processed, for two reasons: - Returning the connection to the pool allows it to be health checked before it's used again. If the connection dies before the first request arrives, the health check will replace it with a new one. - If the thread that initialized Rails is not the same thread that will be performing work, checking in the connection will allow it to be reused instead of being stuck to the initialization thread forever.
* | | Revert "Merge pull request #28598 from wnadeau/patch-1"Rafael Mendonça França2017-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a680a5814184e2f37c4686aa53d0ad3c7fb6b1ee, reversing changes made to 842f67dd242e738419f27e752ea7dcd0bbe87b6d. Reason: I can't resist to the joke, so better to keep it there https://github.com/rails/rails/pull/28598#issuecomment-290945339.
* | | Add missing backtick to deprecation messageyuuji.yaginuma2017-03-311-1/+1
| | |
* | | Fix example usage of ActiveRecord::Base.establish_connectionSimon Dawson2017-03-301-1/+1
| | | | | | | | | `ActiveRecord::Base.establish_connection` accepts a single symbol argument to specify a named connection; a single string argument appears to be interpreted as a connection URI
* | | Merge pull request #28592 from ↵Rafael França2017-03-291-1/+3
|\ \ \ | | | | | | | | | | | | | | | | htanata/ar_relation_inspect_should_not_load_all_records Load only needed records on ActiveRecord::Relation#inspect
| * | | Load only needed records on ActiveRecord::Relation#inspectHendy Tanata2017-03-281-1/+3
| | |/ | |/| | | | | | | | | | | | | | | | Instead of loading all records and returning only a subset of those, just load the records as needed. Fixes #25537.
* | | FinderMethods#fourty_two docs cite proper sourceWinfred Nadeau2017-03-291-1/+1
| | | | | | | | | | | | | | | | | | | | | silly method gets a silly doc fix, or I'm missing an even sillier joke and I'm about to get schooled. BUT I'm pretty sure this is some serious Beaudrillard simulacrum, though. I'm just doing my part to spread the gospel of Douglas Adams.
* | | Merge pull request #28478 from kamipo/fix_primary_keys_across_multiple_schemasAndrew White2017-03-291-9/+7
|\ \ \ | | | | | | | | Fix `primary_keys` across multiple schemas
| * | | Fix `primary_keys` across multiple schemasRyuta Kamizono2017-03-201-9/+7
| | | | | | | | | | | | | | | | Fixes #28470.
* | | | Merge pull request #28052 from kamipo/make_internal_methods_to_privateRafael França2017-03-2811-184/+180
|\ \ \ \ | |_|/ / |/| | | Make internal methods to private
| * | | Make internal methods to privateRyuta Kamizono2017-03-2711-184/+180
| | | |
* | | | Merge pull request #28488 from kamipo/preprocess_association_query_handlingRafael França2017-03-271-13/+8
|\ \ \ \ | | | | | | | | | | Preprocess association query handling in predicate builder
| * | | | Always need to extract `value.bound_attributes` if `value.is_a?(Relation)`Ryuta Kamizono2017-03-251-3/+1
| | | | | | | | | | | | | | | | | | | | Because `RelationHandler` uses `value.arel`.
| * | | | Preprocess association query handling in predicate builderRyuta Kamizono2017-03-201-11/+8
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently association query is handled as a postprocess. This has two problems. 1. When `value` is a `Hash`, we need to skip the postprocess using `next`. 2. `can_be_bound?` should return false if `table.associated_with?(column_name)` is true (pass to the postprocess). These are unneeded if preprocessing association query handling.
* | | | Merge pull request #27636 from ↵Rafael França2017-03-272-4/+49
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | mtsmfm/disable-referential-integrity-without-superuser-privilege-take-2 Use `SET CONSTRAINTS` for `disable_referential_integrity` without superuser privileges (take 2)
| * | | | Use `SET CONSTRAINTS` for `disable_referential_integrity` without superuser ↵Fumiaki MATSUSHIMA2017-03-262-4/+49
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | privileges (take 2) Re-create https://github.com/rails/rails/pull/21233 eeac6151a5 was reverted (127509c071b4) because it breaks tests. ---------------- ref: 72c1557254 - We must use `authors` fixture with `author_addresses` because of its foreign key constraint. - Tests require PostgreSQL >= 9.4.2 because it had a bug about `ALTER CONSTRAINTS` and fixed in 9.4.2.
* / | | Fixes #28359Philippe Guay2017-03-262-3/+8
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add stronger assertions to rake migration tasks to make sure the user is providing a numeric VERSION An empty string was getting converted to version = 0. This would in turn pass the presence check. Address linting warning Add test for rake task and refactor code to meet expectations In particular passing VERSION=0 should not raise an error. Addressed Comments for PR #28485. Trimmed empty lines + change of wording for error message Adjust test for change of wording in error message Change condition to follow rails idioms
* | | Move comment to inside the method [ci skip]Fumiaki MATSUSHIMA2017-03-231-1/+1
| | | | | | | | | | | | | | | | | | Because this comment is not document for `supports_ranges?` ref: https://github.com/rails/rails/pull/27636#discussion_r107560081
* | | Remove `CollectionProxy#uniq`Ryuta Kamizono2017-03-231-4/+0
| | | | | | | | | | | | | | | Since #28473 `uniq` is delegated to `records`, so `CollectionProxy#uniq` is unnecessary.
* | | Merge pull request #28526 from kamipo/fix_log_subscriber_to_allow_legacy_bindsRafael França2017-03-222-19/+14
|\ \ \ | | | | | | | | Fix `LogSubscriber` to allow legacy `binds`
| * | | Fix `LogSubscriber` to allow legacy `binds`Ryuta Kamizono2017-03-232-19/+14
| | | | | | | | | | | | | | | | Follow up of #27939.
* | | | [PostgreSQL]: Replace deprecated PG constants.Lars Kanis2017-03-226-17/+17
|/ / / | | | | | | | | | | | | The old top level classes PGconn, PGresult and PGError were deprecated since pg-0.13.0: https://github.com/ged/ruby-pg/blob/master/History.rdoc#v0130-2012-02-09-michael-granger-gedfaeriemudorg
* | | Start Rails 5.2 developmentMatthew Draper2017-03-222-3/+6
| | |
* | | Fix where_clause#except with specific where valueJohn Hawthorn2017-03-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes a regression introduced in 22ca710f20c3c656811df006cbf1f4dbc359f7a6 where Relation#unscope with a specific where value (vs unscoping the entire where clause) could result in the wrong binds being left on the query. This was caused by an index variable not being incremented properly.
* | | Merge pull request #28474 from kamipo/fix_extension_with_darty_targetKasper Timm Hansen2017-03-201-2/+3
|\ \ \ | | | | | | | | Fix extension method with dirty target in has_many associations
| * | | Fix extension method with dirty target in has_many associationsRyuta Kamizono2017-03-201-2/+3
| |/ / | | | | | | | | | | | | | | | | | | Extension methods should not delegate to `scope` to respect dirty target on `CollectionProxy`. Fixes #28419.
* | | Merge pull request #28487 from kamipo/remove_duplicated_columns_definitionRafael França2017-03-202-11/+5
|\ \ \ | | | | | | | | Remove duplicated `columns` definition
| * | | Remove duplicated `columns` definitionRyuta Kamizono2017-03-202-11/+5
| |/ /
* | | Merge pull request #28473 from kamipo/delegate_uniq_to_recordsRafael França2017-03-201-1/+1
|\ \ \ | | | | | | | | Delegate `uniq` to `records`
| * | | Use `load` rather than `collect` for force loadingRyuta Kamizono2017-03-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since b644964b `ActiveRecord::Relation` includes `Enumerable` so delegating `collect`, `all?`, and `include?` are also unneeded. `collect` without block returns `Enumerable` without preloading by that. We should use `load` rather than `collect` for force loading.
* | | | Merge pull request #27939 from kamipo/fix_select_all_with_legacy_bindsRafael França2017-03-201-1/+5
|\ \ \ \ | |_|/ / |/| | | Fix `select_all` with legacy `binds`
| * | | Fix `select_all` with legacy `binds`Ryuta Kamizono2017-02-121-1/+5
| | | | | | | | | | | | | | | | Fixes #27923.
* | | | Evaluate the default block only when necessaryRyuta Kamizono2017-03-202-3/+3
| |/ / |/| | | | | | | | Follow up of #28453.
* | | Delegate `uniq` to `records`Ryuta Kamizono2017-03-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes CI failure due to 48f3be8c. `Enumerable#uniq` was introduced since Ruby 2.4. We should delegate `uniq` to `records` explicitly. And since b644964b `ActiveRecord::Relation` includes `Enumerable` so delegating `map` is unneeded.
* | | Merge pull request #28191 from eugeneius/string_assoc_orderRafael França2017-03-171-1/+6
|\ \ \ | | | | | | | | Allow order to be given expressions as hash keys
| * | | Allow order to be given expressions as hash keysEugene Kenny2017-02-271-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `order` is given a hash, the keys are currently assumed to be attribute names and are quoted as such in the query, which makes it impossible to pass an expression instead: Post.order("LENGTH(title)" => :asc).last # SELECT `posts`.* FROM `posts` ORDER BY `posts`.`LENGTH(title)` DESC LIMIT 1 If the key is an `Arel::Nodes::SqlLiteral`, we now use it directly in the query. This provides a way to build a relation with a complex order clause that can still be reversed with `reverse_order` or `last`.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 16:27:39 +0000