aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Support PostgreSQL specific column types when using `change_table`.Yves Senn2013-02-282-6/+22
| | | | | | | | Closes #9480. We use `TableDefinition` for `#create_table` and `Table` for `#change_table`. The PostgreSQL sepcifc types were only defined on `TableDefinition` so I also added them to `Table`.
* update docs, change_table does not use TableDefinition.Yves Senn2013-02-281-3/+3
|
* Revert "Merge pull request #9207 from dylanahsmith/mysql-quote-numeric"Steve Klabnik2013-02-273-13/+4
| | | | | This reverts commit 408227d9c5ed7de26310d72a1a99c1ee02311c63, reversing changes made to dca0b57d03deffc933763482e615c3cf0b9a1d97.
* Merge pull request #9218 from Fivell/masterCarlos Antonio da Silva2013-02-271-1/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | Fix calculation of db_runtime property in ActiveRecord::Railties::ControllerRuntime#cleanup_view_runtime. Previously, after raising ActionView::MissingTemplate, db_runtime was not populated. Closes #9218, Fixes #9215. Conflicts: activerecord/CHANGELOG.md
| * fix db_runtime attribute value after raising ActionView::MissingTemplate ↵Igor2013-02-271-1/+2
| | | | | | | | exception
* | Fix default output for postgres network address typesErik Peterson2013-02-261-0/+11
| |
* | Fix touching an invalid parent record for belongs_toOlek Janiszewski2013-02-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the parent of a `belongs_to` record fails to be saved due to validation errors, `touch` will be called on a new record, which causes an exception (see https://github.com/rails/rails/pull/9320). Example: class Owner < ActiveRecord::Base validates_presence_of :name end class Pet < ActiveRecord::Base belongs_to :owner, touch: true end pet = Pet.new(owner: Owner.new) # Before, this line would raise ActiveRecord::ActiveRecordError # "can not touch on a new record object" pet.save
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-02-262-2/+2
|\ \
| * | Typo fixCarson McDonald2013-02-251-1/+1
| | |
| * | BELONGS TO ASSOCIATION | Typo fixlibin2013-02-251-1/+1
| | |
* | | Merge pull request #9414 from senny/9275_order_with_symbol_and_joinRafael Mendonça França2013-02-261-0/+5
|\ \ \ | | | | | | | | Expand order(:symbol) to "table".symbol to prevent broken queries on PG.
| * | | Expand order(:symbol) to "table".symbol to prevent broken queries on PG.Yves Senn2013-02-251-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #9275. When `#order` is called with a Symbol this patch will prepend the quoted_table_name. Before the postgresql adapter failed to build queries containg a join and an order with a symbol. This expansion happens for all adapters.
* | | | No need to send public methodsAkira Matsuda2013-02-263-3/+3
| | | |
* | | | removes redundant requireXavier Noria2013-02-251-2/+0
| | | | | | | | | | | | | | | | It turns out this file is required in active_record.rb.
* | | | AR loads activerecord-deprecated_finders, no need to add it to the GemfileXavier Noria2013-02-251-0/+2
| | | |
* | | | Do not override attributes on `dup` by default scopesHiroshige Umino2013-02-261-1/+0
| | | |
* | | | Preparing for 4.0.0.beta1 releaseDavid Heinemeier Hansson2013-02-251-1/+1
| | | |
* | | | Merge pull request #9409 from wangjohn/adding_documentation_to_touchCarlos Antonio da Silva2013-02-251-0/+7
|\ \ \ \ | |/ / / |/| | | Added documentation to touch throwing an error
| * | | Added documentation about how touch now throws an error when one trieswangjohn2013-02-251-0/+7
| | | | | | | | | | | | | | | | to use it on an unpersisted object.
* | | | Merge pull request #9246 from Noemj/update_prepared_statementsAaron Patterson2013-02-241-3/+12
|\ \ \ \ | |/ / / |/| | | Changed update to use prepared statements
| * | | Changed update_record to use prepared statements.Noemj2013-02-111-3/+12
| | | |
* | | | Raising an ActiveRecordError when one tries to use .touch(name) on a newwangjohn2013-02-251-0/+2
| | | | | | | | | | | | | | | | | | | | object that has not yet been persisted. This behavior follows the precedent set by update_columns.
* | | | Make explicit the method will raise an exceptionRafael Mendonça França2013-02-241-10/+10
| | | | | | | | | | | | | | | | Taking the wise advice of @carlosantoniodasilva
* | | | don't apply invalid ordering when preloading hmt associations.Yves Senn2013-02-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | closes #8663. When preloading a hmt association there two possible scenarios: 1.) preload with 2 queries: first hm association, then hmt with id IN () 2.) preload with join: hmt association is loaded with a join on the hm association The bug was happening in scenario 1.) with a normal order clause on the hmt association. The ordering was also applied when loading the hm association, which resulted in the error. This patch only applies the ordering the the hm-relation if we are performing a join (2). Otherwise the order will only appear in the second query (1).
* | | | Merge pull request #9400 from senny/remove_auto_explain_threshold_in_secondsXavier Noria2013-02-245-87/+26
|\ \ \ \ | | | | | | | | | | remove config.auto_explain_threshold_in_seconds
| * | | | remove AR auto-explain (config.auto_explain_threshold_in_seconds)Yves Senn2013-02-245-87/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We discussed that the auto explain feature is rarely used. This PR removes only the automatic explain. You can still display the explain output for any given relation using `ActiveRecord::Relation#explain`. As a side-effect this should also fix the connection problem during asset compilation (#9385). The auto explain initializer in the `ActiveRecord::Railtie` forced a connection.
* | | | | Updated doc to clarify about update_all and delete_allNeeraj Singh2013-02-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | delete_all will call callbacks if depdent option is specified as :destroy. This behavior is not very clear from the documetation and hence issue #7832 was raised. closes #7832
* | | | | Do not type cast all the database url values.Rafael Mendonça França2013-02-246-32/+29
|/ / / / | | | | | | | | | | | | | | | | | | | | We should only type cast when we need to use. Related to 4b005fb371c2e7af80df7da63be94509b1db038c
* | | | Merge pull request #9356 from senny/988_multiple_actions_for_after_commitSteve Klabnik2013-02-241-14/+17
|\ \ \ \ | | | | | | | | | | multiple actions for :on option with `after_commit` and `after_rollback`
| * | | | multiple actions for :on option with `after_commit` and `after_rollback`Yves Senn2013-02-211-14/+17
| | | | | | | | | | | | | | | | | | | | Closes #988.
* | | | | adds a missing LIMIT 1 in #take docsXavier Noria2013-02-231-1/+1
|/ / / /
* | | | Indent comment block by two spaces.Marc Schütz2013-02-211-4/+4
| | | | | | | | | | | | | | | | | | | | As requested by @fxn https://github.com/schuetzm/rails/commit/743d15bba182df80d003d205690ead988970299c#commitcomment-2661417
* | | | Add more documentation for create_join_table.Marc Schütz2013-02-201-0/+8
| | | | | | | | | | | | | | | | | | | | Explain that it doesn't create indices by default and that it also has a block form.
* | | | Merge pull request #9345 from ↵Rafael Mendonça França2013-02-201-10/+10
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | wangjohn/change_name_of_query_method_argument_checker_for_clarity Renaming the check_empty_arguments method to something more descriptive.
| * | | | Renaming the check_empty_arguments method to something more descriptive.wangjohn2013-02-201-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | The function is now called has_arguments? so that it's easier to tell that it's just checking to see if the args are blank or not.
* | | | | removes some remaining relation bang methods documentation [ci skip]Xavier Noria2013-02-201-3/+0
| | | | |
* | | | | adds an example in the docs of #not with multiple conditions [ci skip]Xavier Noria2013-02-201-4/+8
| | | | |
* | | | | also rename indexes when a table or column is renamedYves Senn2013-02-204-5/+34
| | | | | | | | | | | | | | | | | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
* | | | | revises the documentation of AR::Base.cache_timestamp_format [ci skip]Xavier Noria2013-02-201-2/+4
|/ / / /
* | | | reserve less chars for internal sqlite3 operationsYves Senn2013-02-201-7/+7
| | | |
* | | | reserve index name chars for internal rails operationsYves Senn2013-02-203-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved.
* | | | Merge pull request #9332 from ↵Rafael Mendonça França2013-02-201-11/+27
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | wangjohn/adding_documentation_to_error_raising_in_query_methods Tests to make sure empty arguments in WhereChain raise errors
| * | | | Added comments about the check_empty_arguments method which is calledwangjohn2013-02-201-11/+27
| | | | | | | | | | | | | | | | | | | | | | | | | for query methods in a where_clause. Also, modified the CHANGELOG entry because it had false information and added tests.
* | | | | Merge pull request #9342 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-201-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest
| * | | | | make type_cast_value a class level methodTerence Lee2013-02-211-1/+1
| |/ / / /
* / / / / Reduced memory leak problem in transactions by lazily updating AR objects ↵wangjohn2013-02-204-4/+65
|/ / / / | | | | | | | | | | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
* | | | standardize database_configuration to a hashTerence Lee2013-02-212-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does
* | | | descriptive error message when AR adapter was not found. Closes #7313.Yves Senn2013-02-201-2/+5
| | | |
* | | | Raise an error when query methods have blank arguments, and when blank ↵John J Wang2013-02-191-9/+23
| | | | | | | | | | | | | | | | arguments are meaningless.
* | | | Gist URLs are now namespacedAkira Matsuda2013-02-182-5/+5
| | | | | | | | | | | | | | | | see: https://github.com/blog/1406-namespaced-gists
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 08:28:03 +0000