Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | PostgreSQLAdapter#select_raw fields and results are empty even if ntuples is 0 | Aaron Patterson | 2010-07-12 | 1 | -25/+21 |
| | |||||
* | refactor PostgreSQLAdapter#result_as_array to create fewer Range objects | Aaron Patterson | 2010-07-12 | 1 | -3/+3 |
| | |||||
* | cleaning up PostgreSQLAdapter#select | Aaron Patterson | 2010-07-12 | 1 | -8/+2 |
| | |||||
* | these strings do not need to be frozen | Aaron Patterson | 2010-07-12 | 1 | -2/+2 |
| | |||||
* | use Hash#each to avoid a second hash lookup | Aaron Patterson | 2010-07-12 | 1 | -4/+2 |
| | |||||
* | Just add connection management middleware if running in a concurrent ↵ | José Valim | 2010-07-12 | 1 | -5/+8 |
| | | | | environment. | ||||
* | Remove old rubygems require. | José Valim | 2010-07-12 | 1 | -7/+1 |
| | |||||
* | reducing funcalls, cleaning up primary key methods for sqlite adapter | Aaron Patterson | 2010-07-10 | 1 | -6/+11 |
| | |||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-07-09 | 1 | -2/+7 |
|\ | |||||
| * | copy-edits some docs | Xavier Noria | 2010-07-08 | 1 | -6/+5 |
| | | |||||
| * | Merge branch 'master' of github.com:lifo/docrails | Neeraj Singh | 2010-07-08 | 6 | -15/+28 |
| |\ | |||||
| * | | clarifying how to create non standard primary key | Neeraj Singh | 2010-07-08 | 1 | -1/+7 |
| | | | |||||
* | | | Refactor previous commits a bit. | José Valim | 2010-07-08 | 1 | -7/+10 |
| | | | |||||
* | | | Return from ActiveRecord::Base#attributes= unless value is a hash [#4070 ↵ | David Trasbo | 2010-07-08 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | reset_counter should work with non-traditional belongs_to and polymorphic ↵ | Neeraj Singh | 2010-07-08 | 1 | -3/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | belongs_to [#4984 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Improve a bit the code in latest commits. | José Valim | 2010-07-08 | 2 | -20/+16 |
| | | | |||||
* | | | This patch changes update_attribute implementatino so: | Neeraj Singh | 2010-07-08 | 2 | -7/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - it will only save the attribute it has been asked to save and not all dirty attributes - it does not invoke callbacks - it does change updated_at/on Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | consolidating updated_at and updated_on | Neeraj Singh | 2010-07-08 | 1 | -9/+16 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Eager loading :through associations will join the :source model if there are ↵ | Grant Ammons | 2010-07-08 | 1 | -1/+6 |
| | | | | | | | | | | | | | | | | | | :conditions. [#2362 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Fix the #using_limitable_reflections? helper to work correctly by not ↵ | Ken Collins | 2010-07-08 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | examining the length of an array which contains false/true, hence always passing. [#4869 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | removed an old unused method in AR which removed readonly attributes | Josh Kalderimis | 2010-07-08 | 1 | -9/+0 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | removing unused method | Neeraj Singh | 2010-07-08 | 1 | -5/+0 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | moving parse_sqlite_config to the sqlite3_connection method (where it ↵ | Aaron Patterson | 2010-07-08 | 2 | -20/+11 |
| | | | | | | | | | | | | | | | | | | belongs) [#5071 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | | removing useless code. [#5070 state:resolved] | Aaron Patterson | 2010-07-08 | 1 | -2/+1 |
| | | | | | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | | fix ActiveRecord `destroy_all` so it returns destroyed records | Mislav Marohnić | 2010-07-08 | 2 | -5/+5 |
| | | | | | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | | mass_assignment_security moved from AR to AMo, and minor test cleanup | Josh Kalderimis | 2010-07-08 | 5 | -214/+1 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | minor changes to mass assignment security patch to bring it in line with ↵ | Josh Kalderimis | 2010-07-08 | 4 | -118/+99 |
| | | | | | | | | | | | | | | | | | | rails standards Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Mass assignment security refactoring | Eric Chapweske | 2010-07-08 | 5 | -133/+243 |
| |/ |/| | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Merge remote branch 'docrails/master' | Xavier Noria | 2010-07-07 | 2 | -2/+8 |
|\| | |||||
| * | added more info about << operation in associations | Neeraj Singh | 2010-07-06 | 1 | -0/+4 |
| | | |||||
| * | clarifying the comments regarding base_class declaration | Neeraj Singh | 2010-07-01 | 1 | -2/+4 |
| | | |||||
* | | documents automatic management of join models in hmt associations, in ↵ | Xavier Noria | 2010-07-06 | 1 | -4/+11 |
| | | | | | | | | particular the gotcha that deletion is direct | ||||
* | | Define a convention for descendants and subclasses. | José Valim | 2010-07-05 | 1 | -3/+3 |
| | | | | | | | | | | | | The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children. By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts. | ||||
* | | Avoid calls to Rails::Application since this is not the official API. | José Valim | 2010-07-01 | 1 | -1/+1 |
| | | | | | | | | Your application should *always* reference your application const (as Blog::Application) and Rails.application should be used just internally. | ||||
* | | Don't remove scheduled destroys when loading an association. [#4642 ↵ | James Le Cuirot | 2010-07-01 | 1 | -1/+6 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Make relation a private method. | José Valim | 2010-07-01 | 2 | -6/+7 |
|/ | |||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-30 | 12 | -74/+165 |
|\ | |||||
| * | Support any mysql-like adapter | Jeremy Kemper | 2010-06-30 | 1 | -7/+7 |
| | | |||||
| * | AssociationCollection#create_by_*, find_or_create_by_* work properly now. ↵ | Aaron Patterson | 2010-06-29 | 1 | -0/+11 |
| | | | | | | | | | | | | [#1108 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | migrations.rb requires active_support/core_ext/module/aliasing [#5008 ↵ | Tekin | 2010-06-30 | 1 | -0/+1 |
| | | | | | | | | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
| * | Fixed error when removing an index from a table name values, which is a ↵ | J. Pablo Fernández | 2010-06-29 | 1 | -1/+1 |
| | | | | | | | | | | | | reserved word, with test. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | No need to check if the attribute exists (this is the same behavior as in ↵ | José Valim | 2010-06-29 | 1 | -3/+1 |
| | | | | | | | | 2.3) [#4994 state:resolved] and [#5003 state:resolved] | ||||
| * | array subtraction should be faster than iterating over all the elements | Neeraj Singh | 2010-06-29 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | splitting a really long line into multiple lines which is easy on eyes | Neeraj Singh | 2010-06-29 | 1 | -1/+5 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Remove ActiveRecord::Base#class_name [#379 state:committed] | David Trasbo | 2010-06-29 | 1 | -8/+0 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Tidy up deprecation message for with_exclusive_scope. | José Valim | 2010-06-29 | 2 | -11/+12 |
| | | |||||
| * | Add scoping and unscoped as the syntax to replace the old with_scope and ↵ | José Valim | 2010-06-29 | 5 | -44/+79 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with_exclusive_scope. A few examples: * with_scope now should be scoping: Before: Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end After: Comment.where(:post_id => 1).scoping do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end * with_exclusive_scope now should be unscoped: class Post < ActiveRecord::Base default_scope :published => true end Post.all #=> SELECT * FROM posts WHERE published = true Before: Post.with_exclusive_scope do Post.all #=> SELECT * FROM posts end After: Post.unscoped do Post.all #=> SELECT * FROM posts end Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values: Post.unscoped.all #=> SELECT * FROM posts | ||||
| * | Remove unneeded reject | Santiago Pastorino | 2010-06-28 | 1 | -8/+1 |
| | | |||||
| * | with_exclusive_scope does not work properly if ARel is passed. It does work ↵ | Neeraj Singh | 2010-06-29 | 1 | -0/+13 |
| | | | | | | | | | | | | | | | | nicely if hash is passed. Blow up if user is attempting it pass ARel to with_exclusive_scope. [#3838 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Avoid "no such table" exception when schema migrations table does not exist | Akira Matsuda | 2010-06-27 | 1 | -0/+5 |
| | | | | | | | | | | | | [#4990 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> |