aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* improve Active Record Store docs when using PG types. [ci skip].Yves Senn2013-11-091-3/+4
|
* type casted PG bytea values are represented as a Hash.Yves Senn2013-11-091-0/+2
| | | | | This is a follow up to: 97f0d9a0dd12e7ad634815eecfeff866f64aad92 This change is also related to: df0edafac9eb47cd971970a9e7b13a3eaddf214e
* Document the bind returnRafael Mendonça França2013-11-091-0/+3
|
* Avoid shot circuit return.Rafael Mendonça França2013-11-091-8/+20
| | | | This will make the conditional and to code clear
* Don't use Active Support where we don't need toRafael Mendonça França2013-11-093-3/+3
|
* Fix typo in AR store docs [ci skip]Carlos Antonio da Silva2013-11-091-1/+1
|
* log bind variables after they were type casted.Yves Senn2013-11-093-10/+16
| | | | | | | | | | | | | | | The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]]
* Merge pull request #12791 from jasonayre/ja/fix_autoload_errorRafael Mendonça França2013-11-071-0/+1
|\ | | | | add autoload :TransactionState to fix Marshal.load issues
| * add autoload :TransactionState to fix Marshal.load issuesJason Ayre2013-11-071-0/+1
| |
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-11-072-0/+7
|\ \ | |/ |/|
| * refine usage docs of `store` in combination with `hstore` and `json`.Yves Senn2013-11-061-3/+3
| | | | | | | | refs #11561 #12700
| * Hstore and JSON fields are not supported with storeRobin Dupret2013-10-301-0/+4
| | | | | | | | | | The use of `store` on Hstore fields (for instance) is not needed because serialization aimed to interact with Ruby objects and not with provided field types
| * warning about saving models with dirty attributesDamien Mathieu2013-10-231-0/+3
| | | | | | | | See #8328
* | Stop using method missing for singleton delegation.Aaron Patterson2013-11-061-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This saved about 46 array allocations per request on an extremely simple application. The delegation happened in the notification subsystem which is a hotspot, so this should result in even more savings with larger apps. Squashed commit of the following: commit 41eef0d1479526f7de25fd4391d98e61c126d9f5 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:32:31 2013 -0800 speed up notifications commit 586b4a18656f66fb2c518fb8e8fee66a016e8ae6 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:31:05 2013 -0800 speed up runtime registry methods commit b67d074cb4314df9a88438f785868cef77e583d7 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:28:12 2013 -0800 change method name and make it public
* | bring back constant to expose the enum mapping as HWIA.Yves Senn2013-11-061-4/+13
| |
* | update the AR enum docs to match the actual behavior. [ci skip]Yves Senn2013-11-061-5/+3
| |
* | store enum mapping using `Strings` instead of `Symbols`.Yves Senn2013-11-051-1/+2
| | | | | | | | | | This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem.
* | direct enum assignment rasies ArgumentError for unknown values.Yves Senn2013-11-051-1/+6
| |
* | define enum methods inside a `Module` to make them overwritable.Yves Senn2013-11-051-13/+24
| |
* | Merge pull request #12390 from kennyj/rename_to_association_methodsRafael Mendonça França2013-11-054-7/+7
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Renamed generated_feature_methods to generated_association_methods. Conflicts: activerecord/lib/active_record/associations/builder/association.rb activerecord/lib/active_record/associations/builder/singular_association.rb activerecord/test/cases/base_test.rb
| * | Renamed generated_feature_methods to generated_association_methods.kennyj2013-09-284-7/+7
| | |
* | | ask the fixture set for the sql statementsAaron Patterson2013-11-042-11/+17
| | |
* | | The enum value constant isn't used, so rm it for now.Aaron Patterson2013-11-041-17/+7
| | |
* | | stop doing the same calculation over and overAaron Patterson2013-11-041-4/+5
| | |
* | | Fix failures related to enum changesCarlos Antonio da Silva2013-11-041-6/+4
| | | | | | | | | | | | | | | | | | Commit 6e4a810f51b9ed2468b92247ef5568cc9d6dbcc0 changed the implementation from class_eval to define_method, but missed the access to the constant versus the access to the constant name.
* | | Refactor logic to grab the max time of the list of timestamp names in #cache_keyCarlos Antonio da Silva2013-11-042-4/+4
| | | | | | | | | | | | | | | Reuse the already existing logic used for grabbing this information from the updated columns.
* | | Respect cache timestamp format when giving timestamps to #cache_keyCarlos Antonio da Silva2013-11-041-1/+2
| | |
* | | :scissors: [ci skip]Carlos Antonio da Silva2013-11-041-2/+2
| | |
* | | Replace `class_eval` with `define_method` for enumVitaly Tatarintsev2013-11-041-4/+12
| | | | | | | | | | | | https://github.com/rails/rails/commit/db41eb8a6ea88b854bf5cd11070ea4245e1639c5#commitcomment-4502683
* | | Revert "ActiveRecord::Base#<=> has been removed. Primary keys may not be in ↵David Heinemeier Hansson2013-11-021-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | order," -- will be replaced with a check to ensure that the keys used for comparison are integers, and only fail if they are not. This reverts commit 6256734e2d0bdd89f4b5d11da259d40afa0c95c7. Conflicts: activerecord/CHANGELOG.md
* | | Delegate #rewhere to all on the class like all other relation methodsDavid Heinemeier Hansson2013-11-021-1/+1
| | |
* | | Move documentation around a bitDavid Heinemeier Hansson2013-11-021-4/+7
| | |
* | | Merge pull request #12747 from yury/explicit-enum-valuesDavid Heinemeier Hansson2013-11-021-1/+5
|\ \ \ | | | | | | | | Explicit mapping for enum
| * | | Explicit mapping for enumYury Korolev2013-11-021-1/+5
| | | |
* | | | Added ActiveRecord::QueryMethods#rewhere which will overwrite an existing, ↵David Heinemeier Hansson2013-11-021-0/+12
| | | | | | | | | | | | | | | | named where condition.
* | | | unscope now works on default_scope after ↵Rafael Mendonça França2013-11-021-3/+0
|/ / / | | | | | | | | | 94924dc32baf78f13e289172534c2e71c9c8cade
* | | Extend ActiveRecord::Base#cache_key to take an optional list of timestamp ↵David Heinemeier Hansson2013-11-021-1/+9
| | | | | | | | | | | | attributes of which the highest will be used.
* | | Fix to work on Ruby 1.9.3, example and changelog improvementsCarlos Antonio da Silva2013-11-021-5/+5
| | |
* | | Added ActiveRecord::Base#enum for declaring enum attributes where the values ↵David Heinemeier Hansson2013-11-023-0/+62
| | | | | | | | | | | | map to integers in the database, but can be queried by name
* | | Fix wrong behavior where associations with dependent: :destroy optionsRafael Mendonça França2013-11-011-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | was using nullify strategy This caused a regression in applications trying to upgrade. Also if the user set the dependent option as destroy he expects to get the records removed from the database.
* | | Warnings removed for ruby trunkArun Agrawal2013-11-013-3/+3
| | | | | | | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb
* | | fix code typo in `MysqlAdapter` .Closes #12647.Yves Senn2013-10-301-1/+1
| | |
* | | short arrays in inspectJan Bernacki2013-10-301-3/+10
| | |
* | | Merge pull request #10664 from aderyabin/docpatchYves Senn2013-10-291-1/+1
|\ \ \ | | | | | | | | Fix doc in Postgres database creation [ci skip]
| * | | Fix doc in Postgres database creationAndrey Deryabin2013-06-251-1/+1
| | | |
* | | | Remove confusing generated-code commentaryJeremy Kemper2013-10-281-4/+4
| | | |
* | | | Merge pull request #12578 from ↵Rafael Mendonça França2013-10-272-2/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | jeradphelps/configurable_schema_migrations_table_name Configurable name for schema_migrations table Conflicts: activerecord/CHANGELOG.md
| * | | | added schema_migrations_table_name to ActiveRecord::Base in order that the ↵Jerad Phelps2013-10-272-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | name of the schema migrations table can be configured. consolidated test_schema_migrations_table_name tests Added changelog entry edited changelog removed commented lines removed reader ensure the schema migrations table is reset at end of test added entry to configuration guide guides typo and changelog order
* | | | | Merge pull request #12664 from jetthoughts/12242_includes_in_through_associationRafael Mendonça França2013-10-271-2/+6
|\ \ \ \ \ | | | | | | | | | | | | Skip `include_values` from through associations chains for building association scope
| * | | | | Skip `include_values` from through associations chains for building target scopePaul Nikitochkin2013-10-271-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | Fixes: #12242, #9517, #10240