aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Make define_non_cyclic_method simplerArthur Neves2013-10-171-7/+7
|
* use the cached arel tableAaron Patterson2013-10-152-2/+2
|
* Don't remove the select values to add they back againRafael Mendonça França2013-10-151-1/+1
| | | | | Conflicts: activerecord/lib/active_record/relation/finder_methods.rb
* Pluck on NullRelation accepts a list of columnsDerek Prior2013-10-151-1/+1
| | | | | | `pluck` was updated to accept a list of columns, but the `NullRelation` was never updated to match that signature. As a result, calling `pluck` on a `NullRelation` results in an `ArgumentError`.
* read the association instead of sendingAaron Patterson2013-10-141-1/+3
|
* simplify populating the ordering hashAaron Patterson2013-10-141-10/+5
|
* the preloader for the RHS has all the preloaded records, so ask itAaron Patterson2013-10-141-3/+3
|
* only calculate offset index once. #12537Aaron Patterson2013-10-141-6/+10
|
* Merge pull request #10538 from neerajdotname/3882Rafael Mendonça França2013-10-141-1/+1
|\ | | | | scope_chain should not be mutated for other reflections
| * scope_chain should not be mutated for other reflectionsNeeraj Singh2013-10-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | Currently `scope_chain` uses same array for building different `scope_chain` for different associations. During processing these arrays are sometimes mutated and because of in-place mutation the changed `scope_chain` impacts other reflections. Fix is to dup the value before adding to the `scope_chain`. Fixes #3882.
* | Merge pull request #12527 from vipulnsward/sqlite_database_typesRafael Mendonça França2013-10-141-18/+16
|\ \ | |/ |/| SQLite3 Adapter datatypes cleanup
| * Remove `default_primary_key_type` and extract contains of ↵Vipul A M2013-10-141-18/+16
| | | | | | | | `native_database_types` to a constant since they aren't conditional now in SQLite3Adapter. Makes it more like other adapters.
* | Merge pull request #9499 from ↵Rafael Mendonça França2013-10-141-2/+6
|\ \ | |/ |/| | | | | | | | | | | | | dmitry/inverse_instance_should_not_be_reloaded_after_stale_state_change Inversed instance should not be reloaded after stale state was changed Conflicts: activerecord/CHANGELOG.md
| * add inversed accessor to association classDmitry Polushkin2013-10-131-2/+3
| |
| * inversed instance should not be reloaded after stale state was changedDmitry Polushkin2013-10-131-2/+5
| | | | | | check at association reader that record is inverted and should not be reloaded because of stale was changed at target record
* | Merge pull request #11833 from vipulnsward/remove_autoincrementRafael Mendonça França2013-10-141-10/+1
|\ \ | | | | | | Remove sqlite specific`supports_autoincrement?` which defaults to true
| * | Remove sqlite specific`supports_autoincrement?` which always defaults to trueVipul A M2013-08-101-10/+1
| | |
* | | Extract a function to determine if the default value is a functionRafael Mendonça França2013-10-141-1/+5
| | |
* | | Push default_function to superclass to avoid method checkRafael Mendonça França2013-10-143-15/+18
| | |
* | | Dump the default function when the primary key is uuidRafael Mendonça França2013-10-141-0/+1
| | | | | | | | | | | | Fixes #12489
* | | Merge pull request #12486 from cjolly/newline-eof-structure-sqlRafael Mendonça França2013-10-131-0/+1
|\ \ \ | |_|/ |/| | newline at end of structure.sql file
| * | newline at end of structure.sql fileChad Jolly2013-10-131-0/+1
| | |
* | | Merge pull request #12518 from vipulnsward/remove_count_optionsRafael Mendonça França2013-10-134-19/+16
|\ \ \ | | | | | | | | `Relation#count` doesn't use options anymore.
| * | | Stop accepting `options` for `Relation#average`, `Relation#minimum`, ↵Vipul A M2013-10-142-11/+11
| | | | | | | | | | | | | | | | `Relation#maximum`, `Relation#calculate`, `perform_calculation`, `NullRelation#calculate` as they isn't used anymore.
| * | | `Relation#count` doesn't use options anymore.Vipul A M2013-10-133-8/+5
| | | |
* | | | Add nodoc to methodRafael Mendonça França2013-10-131-1/+1
| | | |
* | | | Merge pull request #12508 from ↵Rafael Mendonça França2013-10-131-2/+12
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | jetthoughts/12415_generate_subqueries_for_relation_from_binding_params Generate subquery for Relation passed as array condition for where Conflicts: activerecord/CHANGELOG.md
| * | | | Generate subquery for Relation passed as array condition for wherePaul Nikitochkin2013-10-131-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of executing 2 queries for fetching records filtered by array condition with Relation, added generation of subquery to current query. This behaviour will be consistent when passes Relation as hash condition to where Closes: #12415
* | | | | Merge pull request #12511 from ↵Rafael Mendonça França2013-10-131-3/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | jetthoughts/informative_raise_message_for_incorrect_association Make missed association exception message more informative
| * | | | | Make missed association exception message more informativePaul Nikitochkin2013-10-131-3/+3
| |/ / / / | | | | | | | | | | | | | | | | | | | | Add target class name, which should have missed association on preload, into exception message to simplify detecting problem part.
* | / / / Drop unused iterator varVipul A M2013-10-131-1/+1
| |/ / / |/| | |
* | | | Merge pull request #11791 from versioncontrol/includes_with_persistent_selectRafael Mendonça França2013-10-121-1/+1
|\ \ \ \ | |/ / / |/| | | Includes with persistent select, fixes #11773
| * | | Fixes #11773 when using includes combined with select, the select statement ↵Edo Balvers2013-10-081-1/+1
| | | | | | | | | | | | | | | | was overwritten.
* | | | no reason to do this column addition and subtraction businessAaron Patterson2013-10-111-1/+1
| | | |
* | | | refactor a little so we can remove some methodsAaron Patterson2013-10-102-4/+1
| | | |
* | | | the parent node is on the stack, so use itAaron Patterson2013-10-101-4/+4
| | | | | | | | | | | | | | | | | | | | we don't need to walk back up the node's parents when we have the parent on the stack
* | | | pass the parent node to the construct methodAaron Patterson2013-10-101-7/+6
| | | |
* | | | nodes do not need to be sortedAaron Patterson2013-10-101-1/+1
| | | |
* | | | delete unused codeAaron Patterson2013-10-102-50/+0
| | | | | | | | | | | | | | | | | | | | Now that we merge trees from the top down, we don't need to search through the whole tree for particular nodes, just walk it and merge.
* | | | merge JoinDependency as outer joinsAaron Patterson2013-10-102-1/+31
| | | | | | | | | | | | | | | | Merge JoinDependency objects as outer joins
* | | | stuff the join dependency object in the "anything goes" hash.Aaron Patterson2013-10-104-6/+8
| | | |
* | | | stop splatting things back and forthAaron Patterson2013-10-102-2/+2
| | | |
* | | | simplify each method.Aaron Patterson2013-10-101-8/+2
| | | | | | | | | | | | | | | | Stop writing terrible code Aaron. This is Ruby, not Scheme
* | | | stop creating a bunch of relation objects when we can slap all the joins on ↵Aaron Patterson2013-10-092-8/+3
| | | | | | | | | | | | | | | | at once
* | | | Merge branch 'builder-instances'Rafael Mendonça França2013-10-097-57/+42
|\ \ \ \
| * | | | Method visibility will not make difference hereRafael Mendonça França2013-10-094-8/+0
| | | | |
| * | | | Remove builder instancesRafael Mendonça França2013-10-092-22/+10
| | | | | | | | | | | | | | | | | | | | | | | | | All the job can be done at class level so we can avoid some object allocation
| * | | | Extract the scope building to a class methodRafael Mendonça França2013-10-092-10/+17
| | | | |
| * | | | Remove unneeded readerRafael Mendonça França2013-10-091-2/+0
| | | | |
| * | | | Move wrap_scope to class levelRafael Mendonça França2013-10-091-2/+2
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 20:49:59 +0000