| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
|/ / / / / |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
calling replace_keys could possibly do a nil check twice, this commit
reduces it to once.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
methods that call set_inverse_instance with a record will not have to
pay the cost of a nil check on every call
|
| | | | | |
|
|\| | | |
| | | | |
| | | | | |
Spelling and Grammar checks [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Translate new unique constraint error message for sqlite >= 3.8.2
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
laurocaetano/fix_dynamic_finder_with_reserved_words
Prevent invalid code when using dynamic finders with reserved ruby word.
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The dynamic finder was creating the method signature with the parameters name,
which may have reserved words and this way creating invalid Ruby code.
Closes: #13261
Example:
# Before
Dog.find_by_alias('dog name')
# Was creating this method
def self.find_by_alias(alias, options = {})
# After
Dog.find_by_alias('dog name')
# Will create this method
def self.find_by_alias(_alias, options = {})
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
activerecord-deprecated_finders expects the parameters denormalized in
its initialize method
|
| | | | |
| | | | |
| | | | |
| | | | | |
This is to get activerecord-deprecated_finders work again
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It is needed for activerecord-depecated_finders
This reverts commit dcff027a5242b20c0c90eb062dddb22ccf51aed9, reversing
changes made to 3a2093984ff49d86db1efeff0c7581e788ecfb9f.
|
|/ / / /
| | | |
| | | |
| | | | |
It is need in activerecord-deprecated_finders
|
|\ \ \ \
| | | | |
| | | | | |
Fix type cast on group sum with custom expression
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
For PG adapters with custom expression and grouped result
of aggregate functions have not found correct column type
for it. Extract column type from query result.
Closes: #13230
|
|/ / / /
| | | |
| | | |
| | | | |
Since MySQL 5.7.3 m13 does now allow primary key column is null.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Example: Given you have a comments model with a polymorphic commentable
association (e.g. books and songs) with the touch option set.
Every time you update a comment its commentable should be touched.
This was working when you changed attributes on the comment or when you
moved the comment from one book to another. However, it was not working
when moving a comment from a book to a song. This is now fixed.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix AR#method_missing re-dispatching into overwritten attribute methods
Conflicts:
activerecord/lib/active_record/attribute_methods.rb
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This was happening when a `super` call in an overwritten attribute method
was triggering a method_missing fallback, because attribute methods
haven't been generated yet.
class Topic < ActiveRecord::Base
def title
# `super` would re-invoke this method if define_attribute_methods
# hasn't been called yet resulting in double '!' appending
super + '!'
end
end
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improve formatting of ActiveRecord migration exception messages
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Closes #7441
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #13146.
This fixes an error when using:
```
change_colum :table, :column, :bigint, array: true
```
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Callback caller class uses `after_initialize`,
but Callback callee defines `after_find`.
Current sample code causes following error.
NoMethodError: undefined method `after_initialize' for #<EncryptionWrapper:0x007fe4931fa5c0>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
already have cache true.
This commit takes into account the last cache_enabled value, before clearing query_cache.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixture files are passed through an ERB renderer before being read as
YAML. The rendering is currently done in the context of the main object,
so method definitons leak into other fixtures, and there is no clean
place to define fixture helpers.
After this commit, the ERB renderer will use a new subclass of
ActiveRecord::FixtureSet.context_class each time a fixture is rendered.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Typo fixes [ci skip]
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Previously, the `has_one` macro incorrectly accepts the `counter_cache` option
due to a bug, although that options was never supported nor functional on
`has_one` and `has_one ... through` relationships. It now correctly raises an
`ArgumentError` when passed that option.
For reference, this bug was introduced in 52f8e4b9.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
This method is not using the block variable directly since it is calling
yield
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove `DatabaseStatements#case_sensitive_equality_operator`. It has been deprecated already.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
deprecated already.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
#type_cast - improve performance & readability
|