| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ / / /
| | | | |
| | | | |
| | | | | |
Closes #9712.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reimplements the behaviour of Rails 3, as I couldn't see why we
shouldn't cache the object, and @alindeman had a good use case for
caching it:
https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
|
|\ \ \ \
| | | | |
| | | | | |
rename `Relation#uniq` to `Relation#distinct`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We moved more and more away from passing options to finder / calculation
methods. The `:distinct` option in `#count` was one of the remaining places.
Since we can now combine `Relation#distinct` with `Relation#count` the option
is no longer necessary and can be deprecated.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The similarity of `Relation#uniq` to `Array#uniq` is confusing. Since our
Relation API is close to SQL terms I renamed `#uniq` to `#distinct`.
There is no deprecation. `#uniq` and `#uniq!` are aliases and will continue
to work. I also updated the documentation to promote the use of `#distinct`.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Cast number to string in Postgres
|
| | | | |
| | | | |
| | | | |
| | | | | |
fixes #9170
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #9724.
Raise an `ArgumentError` when the name of the counter does not
match an association name.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit abba61e2bbe320894ba8449ebdf778a1d2af545b.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* adds password_digest attribute to the migration
* adds has_secure_password to the model
* adds password and password_confirmation password_fields to _form.html
* omits password entirely from index.html and show.html
* adds password and password_confirmation to the controller
* adds unencrypted password and password_confirmation to the controller test
* adds encrypted password_digest to the fixture
|
|/ / / /
| | | |
| | | | |
A patch was committed recently which quoted the extension name in the SQL for `enable_extension`. But the same wasn't done for `disable_extension`.
|
|\ \ \ \
| | | | |
| | | | | |
dependent: :destroy should call destroy_all
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Commit https://github.com/rails/rails/pull/9668 shows warning
when `delete_all` is invoked with `:dependent` option
`:destroy`.
Unfortunately invoking `Post.destroy_all` invokes
`post.comments.delete_all` as part of `has_many` callbacks.
This commit ensures that instead `post.comments.destroy_all` is
invoked and in the process no warning is generated.
See issue #9567 for details .
|
| | | |
| | | |
| | | |
| | | | |
To make quote escape binary data correctly it needs the column passed in.
|
|/ / / |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Show warning message if delete_all is firing callbacks
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`post.comments.delete_all` will fire callbacks if :dependent option is
:destroy . It will be fixed in Rails 4.1 . In the meantime display
a warning . Look at #9567 for details .
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Closes #9643.
The logic was introduced with 46492949
|
| | |
| | |
| | |
| | | |
Take the opportunity to showcase where.not.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
Uniqueness validation uses a proc to specify the `:conditions` option.
This is a follow up to #5321 and follows the general direction in
AR to make things lazy evaluated.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a follow up to #5321 and follows the general direction in
AR to make things lazy evaluated.
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | | |
Bugfix for enable_extension in postgresql_adapter.
The use of quotations is required to install extensions with certain
characters in them (e.g. uuid-ossp).
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The use of quotations is required to install extensions with certain
characters in them (e.g. uuid-ossp).
removes CHANGELOG entry
Deemed unnecessary.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This allows end-users to have a `connection` method on their models
without clashing with ActiveRecord internals.
|
|\ \ \ \
| |_|_|/
|/| | | |
Update documentation for collection<< to reflect behavior for new parent objects.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
collection<< does not automatically fire update sql unless the parent object
is not a new record (and thus has a primary key).
eg:
p = Post.new
p.comments << Comment.new
does not call update sql until:
p.save
at which point it saves the parent object and then the collection object.
changes that to the
|
|\ \ \ \
| |/ / /
|/| | | |
|
| | |/
| |/| |
|
| |/
|/|
| |
| |
| | |
During insertion of "# This migration comes from ... " comment at the beginning of
a migration, presence of magic comment was not considered.
|
| |
| |
| |
| | |
which make it clearer about what's going on.
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| | |
Thanks @neerajdotname for noticing this bug.
|
| | |
|