aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix bug in collection_singular_ids on has many through association with ↵Anatoliy Lysenko2011-07-061-1/+1
| | | | | | | | | | | | | | | | conditions and includes, when condtions references tables from includes. Test fail because of invalid sql: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id: SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id" WHERE "readers"."person_id" = 1 AND (comments.id is null) Bug described in github#925 This commit will revert fix from https://github.com/rails/rails/commit/3436fdfc12d58925e3d981e0afa61084ea34736c , but tests is ok. Bug described in #6569 ticket.
* Merge pull request #1273 from jeremyf/feature-association-proxy-sendSantiago Pastorino2011-07-062-1/+2
|\ | | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handl
| * Addresses an inconsistency in the ActiveRecord::Base.method_missing handling ↵Jeremy Friesen2011-05-242-1/+2
| | | | | | | | of dynamic finder methods and the passing of the &block parameter for :find_by_attributes.
* | Merge pull request #1979 from bogdan/association_sum_array_compatibilityJon Leighton2011-07-061-2/+6
|\ \ | | | | | | Fixed AR::Relation#sum compatibility with Array#sum
| * | Fixed AR::Relation#sum compatibility with Array#sumBogdan Gusiev2011-07-051-2/+6
| | | | | | | | | | | | | | | In order make Relation behavior closer to Array Made Relation#sum to accept block and delegate it to Array#sum
* | | Merge pull request #1968 from bogdan/associations_find_array_compatibility2Santiago Pastorino2011-07-051-3/+7
|\ \ \ | |/ / |/| | Fixed CollectionAssociation#find to be compatible with Array#find
| * | Fixed CollectionAssociation#find to be compatible with Array#findBogdan Gusiev2011-07-051-3/+7
| | | | | | | | | | | | | | | In order to make CollectionAssociation behave closer to Array Add the ability to pass block to #find method just like Array#find does.
* | | Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-07-052-6/+6
|\ \ \
| * | | minor changesVijay Dev2011-06-271-2/+2
| | | |
| * | | replace find(all) with allVijay Dev2011-06-261-3/+3
| | | |
| * | | fix typo in method nameVijay Dev2011-06-251-1/+1
| | | |
| * | | Revert "add missing methods supported by reversible migrations using the ↵Vijay Dev2011-06-251-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change method" This reverts commit 7f91eebae361f2f3a1558f6d899b372524509a2d. Reason: Incorrect documenting. The newly added methods to the list are not actually supported by reversible migrations.
| * | | add missing methods supported by reversible migrations using the change methodVijay Dev2011-06-241-1/+4
| | | |
* | | | Only call set_owner_attributes for has_one association if target exists.Dieter Komendera2011-07-041-1/+1
| |/ / |/| |
* | | Use an instance variable to store the current masss assignment optionsAndrew White2011-07-042-13/+18
| | |
* | | Reversing the changes done in c278a2c while still resolving #1857.Vijay Dev2011-07-021-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | The changes broke bulk migration tests and were fixed in 4d256bc6; however that brought back the issue of #1857 and so this commit goes back to the original scenario and just adds change_table to the list of methods which are to be recorded in the CommandRecorder. The method_missing now delegates all calls to the underlying connection as before.
* | | a few minor performance improvements: fewer strings, fewer range objects, ↵Aaron Patterson2011-07-012-22/+13
| | | | | | | | | | | | fewer method calls
* | | calling super is super. if the other object is exactly equal, we can return ↵Aaron Patterson2011-07-011-1/+5
| | | | | | | | | | | | early
* | | remove unused codesAaron Patterson2011-07-011-4/+0
| | |
* | | reduce calls to owners_by_key and to read_attribute, respond_to? etcAaron Patterson2011-07-011-2/+3
| | |
* | | Remove AssociationReflection#create_association and ↵Jon Leighton2011-06-301-17/+0
| | | | | | | | | | | | AssociationReflection#create_association! - they are not called from anywhere.
* | | Assign the association attributes to the associated record before the ↵Jon Leighton2011-06-304-10/+12
| | | | | | | | | | | | before_initialize callback of the record runs. Fixes #1842.
* | | match method signature of the superclassAaron Patterson2011-06-302-4/+4
| | |
* | | call super rather than delegating to the other objects equal? methodAaron Patterson2011-06-301-1/+1
| | |
* | | just alias eql? to == for frewer method callsAaron Patterson2011-06-301-5/+1
| | |
* | | only calculate method name onceAaron Patterson2011-06-301-2/+3
| | |
* | | cache the plural name on the reflection so we do not pay pluralize costs on ↵Aaron Patterson2011-06-302-7/+14
| | | | | | | | | | | | joins
* | | Master version is 3.2.0.betaSantiago Pastorino2011-06-301-2/+2
| | |
* | | CommandRecorder should delegate in method_missing where possible. Fixes some ↵Jon Leighton2011-06-301-1/+5
| | | | | | | | | | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce.
* | | Define to_ary on ActiveRecord::Base to return nil. Improve performance of ↵Jon Leighton2011-06-301-0/+12
| | | | | | | | | | | | Array#flatten under 1.9, see comment for details.
* | | Fix caseOriol Gual2011-06-281-2/+1
| | |
* | | Update reverse order with new Arel NodesOriol Gual2011-06-281-1/+2
| | |
* | | Merge pull request #1857 from vijaydev/irreversible-migrationAaron Patterson2011-06-281-4/+4
|\ \ \ | | | | | | | | IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration
| * | | record unsupported methods in CommandRecorder instead of letting the ↵Vijay Dev2011-06-251-4/+4
| | | | | | | | | | | | | | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations
* | | | Merge pull request #1860 from dmathieu/comparisonAaron Patterson2011-06-281-0/+9
|\ \ \ \ | | | | | | | | | | Allow comparison on model objects - Closes #1858
| * | | | comparing different classes returns nilDamien Mathieu2011-06-261-1/+5
| | | | |
| * | | | allow comparison on model objects - Closes #1858Damien Mathieu2011-06-261-0/+5
| |/ / /
* | | | remove useless assignmentAaron Patterson2011-06-281-2/+1
| | | |
* | | | lock_optimistically is typically true, so evaluate the common failure case firstAaron Patterson2011-06-281-1/+1
| | | |
* | | | reduce object allocation during AR instantiationAaron Patterson2011-06-282-3/+8
| | | |
* | | | remove the check for needs_type_condition? because ensure_proper_type will ↵Aaron Patterson2011-06-272-3/+4
| | | | | | | | | | | | | | | | pick up the type column
* | | | stop using && for the short circuit side effectAaron Patterson2011-06-271-1/+1
| | | |
* | | | let strings be converted to symbols inside the interpreterAaron Patterson2011-06-271-2/+2
| | | |
* | | | avoice paying hash cost if there are no serialized attributesAaron Patterson2011-06-271-3/+4
| | | |
* | | | cache column defaults for AR object instantiationAaron Patterson2011-06-273-3/+16
| | | |
* | | | AR object instantiation is ~30% faster in the simple caseAaron Patterson2011-06-272-1/+17
| | | |
* | | | initialize instance variablesAaron Patterson2011-06-271-0/+2
| | | |
* | | | default create_with_value to a hash so we can eliminate conditionals, add ↵Aaron Patterson2011-06-273-4/+5
|/ / / | | | | | | | | | test surrounding create_with(nil) behavior
* | | Merge pull request #1848 from raviolicode/postgresql_order_multiple_paramsSantiago Pastorino2011-06-241-1/+1
|\ \ \ | | | | | | | | Fix for complex ordering of multiple columns on postgresql
| * | | Improve ordering of multiple columns on postgresqlLucia Escanellas2011-06-241-1/+1
| | | | | | | | | | | | | | | | | | | | * Only on postgresql, order("first asc, second asc") was invalid * Closes #1720
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-18 17:37:14 +0000