Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | `#count` in conjunction with `#uniq` performs distinct count. | Yves Senn | 2013-01-26 | 1 | -1/+2 |
| | | | | closes #6865 | ||||
* | reduce the number of queries on IN clauses, fix relation queries in `where` | Aaron Patterson | 2013-01-24 | 2 | -1/+6 |
| | |||||
* | stop converting strings to symbols | Aaron Patterson | 2013-01-24 | 1 | -1/+1 |
| | |||||
* | Default dead_connection_timeout to 5 | Akira Matsuda | 2013-01-24 | 1 | -1/+1 |
| | | | | or the ConnectionPool silently fails to close connections inside the Thread | ||||
* | Fix PostgreSQL tests on Travis | Andrew White | 2013-01-24 | 1 | -0/+5 |
| | | | | Travis only has PostgreSQL 9.1.x but 9.2 is required for range datatypes. | ||||
* | Add postgresql range types support | bUg | 2013-01-23 | 7 | -71/+117 |
| | |||||
* | Revert "Round usec when writing timestamp attribute." | Andrew White | 2013-01-22 | 1 | -13/+5 |
| | | | | | | | | | | This reverts commit e9d2ad395ec2ef929d74752f3d71c80674044fbe. Closes #8460 Conflicts: activerecord/lib/active_record/attribute_methods/time_zone_conversion.rb activerecord/test/cases/dirty_test.rb | ||||
* | Whitespaces :scissors: | Rafael Mendonça França | 2013-01-22 | 1 | -12/+12 |
| | | | | [ci skip] | ||||
* | Just ignore all PRAGMA queries | Akira Matsuda | 2013-01-22 | 1 | -1/+1 |
| | |||||
* | Ignore schema queries on SQLite 3 as well | Akira Matsuda | 2013-01-22 | 1 | -1/+2 |
| | |||||
* | Ignore "SHOW search_path" when counting PostgreSQL queries | Akira Matsuda | 2013-01-22 | 1 | -1/+1 |
| | |||||
* | Refactored transaction state into its own object. Each transaction creates a ↵ | wangjohn | 2013-01-21 | 1 | -5/+24 |
| | | | | new transaction state object upon initialization. | ||||
* | Removed reflects_transaction_state. | wangjohn | 2013-01-20 | 1 | -1/+0 |
| | |||||
* | Created state for a transaction and added tests. | wangjohn | 2013-01-20 | 2 | -11/+25 |
| | |||||
* | fix anonymous class issue | David | 2013-01-20 | 1 | -0/+1 |
| | |||||
* | Improve relation docs about to_sql and where_values_hash | Carlos Antonio da Silva | 2013-01-19 | 1 | -4/+4 |
| | | | | | | | | * User class instead of Users. * #where_values_hash does not change the value to downcase as the example was showing. [ci skip] | ||||
* | Merge pull request #8994 from Springest/fix_default_scope_update_all_delete_all | Jon Leighton | 2013-01-18 | 1 | -2/+2 |
|\ | | | | | Fix .update_all and .delete_all when using a condition on a joined table in a default_scope | ||||
| * | Fix .update_all and .delete_all when using a condition on a joined table | Derek Kraan | 2013-01-11 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | in a default_scope. `Model.joins(...).where(condition_on_joined_table).update_all` / `delete_all` worked, but the same operation implemented with a default_scope generated a SQL error because ActiveRecord ignored the join but implemented the where condition anyways. | ||||
* | | Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by" | Guillermo Iguaran | 2013-01-18 | 4 | -8/+8 |
| | | | | | | | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1. | ||||
* | | Merge pull request #8989 from robertomiranda/use-rails-4-find-by | Guillermo Iguaran | 2013-01-18 | 4 | -8/+8 |
|\ \ | | | | | | | Replace deprecated find_by_* with find_by | ||||
| * | | User Rails 4 find_by | robertomiranda | 2013-01-18 | 4 | -8/+8 |
| | | | |||||
* | | | Undeprecate the :extend option | Jon Leighton | 2013-01-18 | 2 | -1/+3 |
| | | | | | | | | | | | | | | | | | | | | | Suggested by @dhh. It doesn't affect the generated SQL, so seems reasonable to continue to allow it as an association option. | ||||
* | | | CollectionProxy should be default scoped | Jon Leighton | 2013-01-18 | 1 | -0/+1 |
| | | | | | | | | | | | | Fixes #8795 | ||||
* | | | Merge pull request #8912 from senny/8879_association_empty_method | Jon Leighton | 2013-01-18 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | `CollectionAssociation#empty?` respects newly builded records | ||||
| * | | | `CollectionAssociation#empty?` respects newly builded records | Yves Senn | 2013-01-13 | 1 | -1/+1 |
| | | | | |||||
* | | | | iterates the RDoc of update_column(s) | Xavier Noria | 2013-01-18 | 1 | -13/+13 |
| |/ / |/| | | | | | | | | | | | | | | | | | | | | This revision makes crystal clear that the methods go straight to the database and update the receiver. It also adds and example, and removes the duplication in the singular and plural forms by referring one to the other. | ||||
* | | | Refactor predicate builder when receiving empty hash | Carlos Antonio da Silva | 2013-01-17 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | There's no need to create a new arel table or reflect on the column association if the value is empty, these attributes are not used. Also no need to concat a new array, just append the query value. | ||||
* | | | Don't rely on Hash key's ordering | Vitor Baptista | 2013-01-16 | 2 | -3/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we set encoding latin1 for a PostgreSQL database, it calls PostgreSQLAdapter::create_database with options that have, among other things: { 'encoding' => 'latin1' } Then, we use reverse_merge(:encoding => "utf8") to setup the default encoding. In the end, the hash looks like: { :encoding => 'utf8', 'encoding' => 'latin1' } The call to options.symbolize_keys calls to_sym on each_key of this Hash. It usually means that the encoding passed overwrites the default utf8, but it's not guaranteed. So, we shouldn't rely on it. The same was happening in ActiveRecord::ConnectionHandling. | ||||
* | | | Revert "Merge pull request #8930 from cordawyn/ordered_railties" | Carlos Antonio da Silva | 2013-01-15 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8348f9ea72c9b50fc4d4462fd9ebe3bba932c783, reversing changes made to 9dfe2d6f9fabddf9a451a995678a9648c8aaf401. Reason: this broke railties tests as explained in the issue, and the author is going to review and report back. https://github.com/rails/rails/pull/8930#issuecomment-12272671 | ||||
* | | | Merge pull request #8930 from cordawyn/ordered_railties | Carlos Antonio da Silva | 2013-01-15 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | rake railties:install:migrations respects the order of railties | ||||
| * | | | rake railties:install:migrations respects the order of railties | Slava Kravchenko | 2013-01-14 | 1 | -1/+1 |
| |/ / | |||||
* / / | Improve mysql database tasks handling to ensure we always rescue from an ↵ | Carlos Antonio da Silva | 2013-01-15 | 1 | -9/+13 |
|/ / | | | | | | | | | | | | | | | | | | | exception We were previously rescuing "nil" when no exception class was found. This does work in 1.9.3, but does not in 2.0, raising an exception asking for a class or module to be given to the rescue clause. Thanks @yahonda for catching this. | ||||
* | | Fix AR tests due to Mysql constant not being defined | Carlos Antonio da Silva | 2013-01-12 | 3 | -7/+5 |
| | | |||||
* | | Bring back "database already exists" messages when running rake tasks | Carlos Antonio da Silva | 2013-01-12 | 4 | -13/+20 |
|/ | | | | | | | | | | When running tasks such "rake db:setup", instead of showing messages like "db_development already exists", it was showing a big stack trace and a message "Couldn't create database for ..." with the configuration options, a very confusing message with a big trace. This brings back the functionality present in 3-2, showing the same message. | ||||
* | Merge pull request #8568 from inossidabile/fix-in_clause_length | Jon Leighton | 2013-01-11 | 1 | -1/+1 |
|\ | | | | | Correct source for in_clause_length for eager loading (Fix for #8474) | ||||
| * | Eager loading made to use relation's in_clause_length instead of host's one ↵ | Boris Staal | 2012-12-20 | 1 | -1/+1 |
| | | | | | | | | (fixes #8474) | ||||
* | | Merge pull request #8823 from acapilleri/target_reflection_has_associated_record | Carlos Antonio da Silva | 2013-01-08 | 1 | -5/+1 |
|\ \ | | | | | | | Refactor target_reflection_has_associated_record? | ||||
| * | | target_reflection_has_associated_record? refactoring | Angelo Capilleri | 2013-01-08 | 1 | -5/+1 |
| | | | |||||
* | | | Merge pull request #8826 from acapilleri/different_target | Carlos Antonio da Silva | 2013-01-08 | 1 | -2/+5 |
|\ \ \ | | | | | | | | | Improved different_target conditions | ||||
| * | | | improved different_target conditions | Angelo Capilleri | 2013-01-08 | 1 | -2/+5 |
| |/ / | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-01-09 | 5 | -58/+16 |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: guides/source/getting_started.md | ||||
| * | | | prefer american spelling of 'behavior' | Gosha Arinich | 2013-01-07 | 2 | -3/+3 |
| | | | | |||||
| * | | | remove meaningless use of Relation#all | Akira Matsuda | 2013-01-03 | 3 | -4/+4 |
| | | | | | | | | | | | | | | | | particularly, `all(options)` would warn | ||||
| * | | | wrong model name | Akira Matsuda | 2013-01-02 | 1 | -1/+1 |
| | | | | |||||
| * | | | find + conditions is deprecated in AR 4 | Akira Matsuda | 2013-01-02 | 1 | -3/+3 |
| | | | | |||||
| * | | | find_or_initialize_by is deprecated in AR 4 | Akira Matsuda | 2013-01-02 | 1 | -7/+0 |
| | | | | |||||
| * | | | find_or_create_by is deprecated in AR 4 | Akira Matsuda | 2013-01-02 | 2 | -27/+2 |
| | | | | |||||
| * | | | find_last_by is deprecated in AR 4 | Akira Matsuda | 2013-01-02 | 1 | -4/+3 |
| | | | | |||||
| * | | | find_all_by is deprecated in AR 4 | Akira Matsuda | 2013-01-02 | 1 | -6/+3 |
| | | | | |||||
| * | | | scoped_by is deprecated in AR 4 | Akira Matsuda | 2013-01-02 | 1 | -6/+0 |
| | | | |