aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* Changed behavior of touch and added touch! Originally implemented by Obie ↵Nathaniel Bibler2010-03-271-8/+18
| | | | | Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved] Signed-off-by: wycats <wycats@gmail.com>
* In PostgreSQLAdapter, switch tables query to use current_schemas function ↵Kris Selden2010-03-261-3/+1
| | | | | | [#918 state:resolved] Signed-off-by: wycats <wycats@gmail.com>
* Merge branch 'master' into docrailswycats2010-03-2627-94/+110
|\
| * Move application configuration to the application configuration object, ↵José Valim2010-03-261-3/+2
| | | | | | | | remove railtie_name and engine_name and allow to set the configuration object.
| * Better MySQL Error message. [#3775 state:resolved]Rizwan Reza2010-03-261-1/+1
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
| * Remove unused attributes_with_quotes method.Emilio Tagua2010-03-251-20/+0
| |
| * Move methods from association to relation finder methods.Emilio Tagua2010-03-252-11/+11
| |
| * Refactor relation merging to create just one relation and then assign ↵Emilio Tagua2010-03-251-22/+14
| | | | | | | | values, instead of creating multiple relation objects.
| * Add add_limit_offset! to adapters.Emilio Tagua2010-03-252-0/+35
| |
| * expand migration paths before requiring them. [#4240 state:resolved]Aaron Patterson2010-03-231-1/+1
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
| * rake tasks should use the new app generator path [#4257 state:resolved]Sebastian Martinez2010-03-231-1/+1
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
| * Load generators from both lib/rails/generators and lib/generators. Using the ↵José Valim2010-03-2310-4/+4
| | | | | | | | former since it's less obstrusive.
| * From and lock should be defined to be consistent with other ivars. Limit and ↵Emilio Tagua2010-03-222-19/+6
| | | | | | | | | | | | | | | | offset are always defined, no need to test that. [#4253 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
| * switching migrations to use require cleans up many warnings [#4234 ↵Aaron Patterson2010-03-191-1/+1
| | | | | | | | | | | | state:resolved] Signed-off-by: wycats <wycats@gmail.com>
| * kill where / having method redefine warnings. [#4225 state:resolved]Aaron Patterson2010-03-181-0/+1
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
| * squelching more warnings in the AR tests. [#4218 state:resolved]Aaron Patterson2010-03-181-1/+6
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
| * cleaning up a bunch of method already defined warnings [#4209 state:resolved]Aaron Patterson2010-03-171-0/+3
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
| * Move require closer to homeJeremy Kemper2010-03-171-1/+0
| |
| * fixing activerecord tests [#4205 state:resolved]Aaron Patterson2010-03-171-0/+1
| | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
| * fisting uninitialized ivar warnings. [#4198 state:resolved]Aaron Patterson2010-03-163-8/+14
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
| * clean up more warnings, remove unnecessary methods, fix eval line numbers. ↵Aaron Patterson2010-03-164-3/+11
| | | | | | | | | | | | [#4193 state:resolved] Signed-off-by: wycats <wycats@gmail.com>
* | Add debugging documentation for _callback_chain to ActiveRecord::Callbackchrisfinne2010-03-261-0/+10
| | | | | | | | Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
* | fix habtm documentation to correct typoJeremy Roman2010-03-261-1/+1
|/ | | | Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
* cleaning up many more warnings in activerecord [#4180 state:resolved]Aaron Patterson2010-03-154-3/+17
| | | | Signed-off-by: wycats <wycats@gmail.com>
* speeding up clone_attributes, changing readonly to be initialized in def ↵Aaron Patterson2010-03-141-8/+9
| | | | | | initialize Signed-off-by: wycats <wycats@gmail.com>
* cleaning up some test warningsAaron Patterson2010-03-144-5/+16
| | | | Signed-off-by: wycats <wycats@gmail.com>
* keep AssociationProxy#to_a to avoid warning in Array(post.author), and ↵Xavier Noria2010-03-122-1/+2
| | | | | | | | delegate it to @target in association collections [#4165 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Arel now fallback to using Arel::Attribute if the table/column doesn't exists.Emilio Tagua2010-03-101-3/+1
| | | | | | [#4142 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* removing spawn from SpawnMethodsAaron Patterson2010-03-104-13/+13
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Fix scope loading issue when the table doesn't existPratik Naik2010-03-101-1/+3
|
* Fix associations to call :destroy or :delete based on the right :dependent ↵Carlos Antonio da Silva2010-03-091-3/+3
| | | | | | option Signed-off-by: José Valim <jose.valim@gmail.com>
* Make many parts of Rails lazy. In order to facilitate this,wycats2010-03-074-185/+205
| | | | | | | | | | | | add lazy_load_hooks.rb, which allows us to declare code that should be run at some later time. For instance, this allows us to defer requiring ActiveRecord::Base at boot time purely to apply configuration. Instead, we register a hook that should apply configuration once ActiveRecord::Base is loaded. With these changes, brings down total boot time of a new app to 300ms in production and 400ms in dev. TODO: rename base_hook
* drying up more code in associations.rbAaron Patterson2010-03-061-17/+11
| | | | Signed-off-by: wycats <wycats@gmail.com>
* deleting repeated codeAaron Patterson2010-03-061-17/+7
| | | | Signed-off-by: wycats <wycats@gmail.com>
* converting inject to each and mapAaron Patterson2010-03-061-5/+4
| | | | | | [#4119 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* refactoring build_whereAaron Patterson2010-03-061-7/+7
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Update versions of all components to normalize them to new formatBryan Helmkamp2010-03-021-2/+3
|
* ActiveRecord should raise an error on invalid migration types.José Valim2010-02-281-4/+7
|
* Print database.rake errors to stderr.S. Christoffer Eliesen2010-02-271-5/+5
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* no more warning interpreted as argument prefix on association_preload.rbSantiago Pastorino2010-02-261-1/+1
|
* fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't ↵Tobias Bielohlawek2010-02-261-1/+1
| | | | | | | | met the default_scope conditions, added test [#3166 status:resolved] The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example. Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix a bug where default_scope was overriding attributes given on model ↵Henry Hsu2010-02-261-1/+1
| | | | | | initialization [#3218 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice.Jeremy Kemper2010-02-253-5/+5
|
* Revert "Fix test load paths for those not using bundler"Carlhuda2010-02-231-0/+1
| | | | | | This reverts commit eec2d301d4ce9df9c71c1a5aa63053eb970b6818. This commit broke tests. You cannot have a file called "bundler" on the load path.
* avoid @lock_value not initialized warningSantiago Pastorino2010-02-221-1/+1
|
* avoid @transaction_joinable not initialized warningSantiago Pastorino2010-02-221-1/+1
|
* avoid active not initialized warningSantiago Pastorino2010-02-221-0/+1
|
* Require persisted? in ActiveModel::Lint and remove new_record? and ↵José Valim2010-02-211-4/+9
| | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
* Add to_key and to_param methods to ActiveModel::Conversion.José Valim2010-02-211-1/+1
|
* AMo #key is now #to_key and CI is probably happysnusnu2010-02-201-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch.
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-24 05:32:40 +0000