aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate locking of dirty recordsMarc Schütz2017-02-071-1/+10
|
* Revert "Remove useless `column_alias` in `subquery_for_count`"Ryuta Kamizono2017-02-071-2/+3
| | | | This reverts commit 28977f1fa3d7b15c1608174a165e60b71ddf3995.
* Merge pull request #27334 from ↵Jeremy Daer2017-02-075-9/+51
|\ | | | | | | | | kamipo/pk_and_ref_columns_should_be_identical_type `primary_key` and `references` columns should be identical type
| * `primary_key` and `references` columns should be identical typeRyuta Kamizono2017-02-075-9/+51
| | | | | | | | | | | | | | | | Follow up to #26266. The default type of `primary_key` and `references` were changed to `bigint` since #26266. But legacy migration and sqlite3 adapter should keep its previous behavior.
* | Merge pull request #26378 from ↵Jeremy Daer2017-02-064-41/+51
|\ \ | | | | | | | | | | | | kamipo/decouple_building_arel_ast_for_uniqueness_validator Decouple the building Arel ASTs for uniqueness validator
| * | Add `:nodoc:` to `case_sensitive_comparison` and `case_insensitive_comparison`Ryuta Kamizono2017-01-202-3/+3
| | | | | | | | | | | | These methods are obviously for internal use.
| * | Decouple the building Arel ASTs for uniqueness validatorRyuta Kamizono2016-12-254-38/+48
| | | | | | | | | | | | | | | | | | Currently uniqueness validator is coupled with building Arel ASTs. This commit extracts `WhereClauseFactory#build_for_case_sensitive` for decouple the building Arel ASTs.
* | | Remove useless `column_alias` in `subquery_for_count`Ryuta Kamizono2017-02-061-3/+2
| |/ |/| | | | | | | | | | | | | | | If select clause is specified and last column has a column alias, additional column alias causes a statement invalid. Add test coverage for counting a single column with NULL values. Fixes #27676, #27682, and #27705.
* | Merge pull request #27389 from kamipo/fix_mysql_pk_dumping_correctlyJeremy Daer2017-02-066-18/+25
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Restore the behaviour of the compatibility layer for integer-like PKs * kamipo/fix_mysql_pk_dumping_correctly: Restore custom primary key tests lost at #26266 Restore the behaviour of the compatibility layer for integer-like PKs Correctly dump integer-like primary key with default nil
| * | Restore the behaviour of the compatibility layer for integer-like PKsRyuta Kamizono2017-02-042-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The PR #27384 changed migration compatibility behaviour. ```ruby class CreateMasterData < ActiveRecord::Migration[5.0] def change create_table :master_data, id: :integer do |t| t.string :name end end end ``` Previously this migration created non-autoincremental primary key expected. But after the PR, the primary key changed to autoincremental, it is unexpected. This change restores the behaviour of the compatibility layer.
| * | Correctly dump integer-like primary key with default nilRyuta Kamizono2017-02-044-20/+21
| | | | | | | | | | | | | | | | | | | | | The PR #27384 changed integer-like primary key to be autoincrement unless an explicit default. This means that integer-like primary key is restored as autoincrement unless dumping the default nil explicitly. We should dump integer-like primary key with default nil correctly.
* | | Deprecate `ColumnDumper#migration_keys`Ryuta Kamizono2017-02-075-6/+10
| | | | | | | | | | | | | | | | | | `ColumnDumper#migration_keys` was extracted to customize keys for standardized column arguments widths. But the feature was removed in df84e98. The internal method is no longer used for that.
* | | Indicate action that failed in YamlColumnKir Shatrov2017-02-052-5/+5
|/ /
* | Fix collection_singular_ids= bugDaniel Colson2017-02-021-2/+2
| | | | | | | | | | | | | | | | | | When the association's primary key is manually set as a symbol and called with an array of strings, CollectionAssociation#ids_writer fails to cast the ids to integers. This is because AssociationReflection#association_primary_key_type and ThroughReflection#association_primary_key_type return the incorrect type, since ModelSchema.type_for_attribute only accepts a string. The result is an ActiveRecord::RecordNotFound error.
* | Virtual/generated column support for MySQL 5.7.5+ and MariaDB 5.2.0+Ryuta Kamizono2017-02-019-14/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MySQL generated columns: https://dev.mysql.com/doc/refman/5.7/en/create-table-generated-columns.html MariaDB virtual columns: https://mariadb.com/kb/en/mariadb/virtual-computed-columns/ Declare virtual columns with `t.virtual name, type: …, as: "expression"`. Pass `stored: true` to persist the generated value (false by default). Example: create_table :generated_columns do |t| t.string :name t.virtual :upper_name, type: :string, as: "UPPER(name)" t.virtual :name_length, type: :integer, as: "LENGTH(name)", stored: true t.index :name_length # May be indexed, too! end Closes #22589
* | Chain scope constraints should respect own table aliasRyuta Kamizono2017-02-011-5/+6
| | | | | | | | Fixes #27666.
* | Merge pull request #27767 from benoittgt/freeze_sql_type_with_get_oid_typeArthur Nogueira Neves2017-01-311-1/+1
|\ \ | | | | | | Freeze default empty string for sql_type in get_oid_type
| * | Freeze default empty string for sql_type in get_oid_typeBenoit Tigeot2017-01-221-1/+1
| | | | | | | | | | | | One empty string allocation per column per row.
* | | Merge pull request #27855 from kevinzwhuang/finder-methods-typo-fixEileen M. Uchitelle2017-01-311-2/+2
|\ \ \ | | | | | | | | Fix typo about sort in finder_methods.rb
| * | | Fix grammar typo about sort in finder_methods.rbKevin Huang2017-01-301-2/+2
| | | |
* | | | Merge pull request #27838 from kamipo/reload_destroyed_through_recordRafael França2017-01-311-0/+4
|\ \ \ \ | |/ / / |/| | | Reload `through_record` that has been destroyed in `create_through_record`
| * | | Reload `through_record` that has been destroyed in `create_through_record`Ryuta Kamizono2017-01-291-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an alternative of #27714. If `has_one :through` association has set `nil`, `through_record` is destroyed but still remain loaded target in `through_proxy` until `reload` or `reset` explicitly. If `through_proxy` is not reset (remain destroyed (frozen) target), setting new record causes `RuntimeError: Can't modify frozen hash`. To prevent `RuntimeError`, should reload `through_record` that has been destroyed in `create_through_record`.
* | | | Merge pull request #27849 from joevandyk/patch-2Rafael França2017-01-311-1/+2
| | | | | | | | | | | | Specify complete path to AR::LegacyYamlAdapter
* | | | Avoid lambda scopes when possibleAaron Patterson2017-01-301-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Lambda scopes require a bunch more work. Ideally the `scope` list would be a homogeneous collection. In this case, the reflection knows how to construct the right reflection for this join, so lets just construct that relation rather than instance execing to figure it out later.
* | | | deprecate `scope_chain`Aaron Patterson2017-01-301-0/+2
| | | |
* | | | update comments and call `super`Aaron Patterson2017-01-301-24/+3
| | | |
* | | | remove caching until we prove it is requiredAaron Patterson2017-01-301-7/+3
| | | |
* | | | Fix `scopes` implementation on `PolymorphicReflection`Aaron Patterson2017-01-303-54/+15
| | | | | | | | | | | | | | | | `PolymorphicReflection` needs to be custom for handling scope lambdas
* | | | Implement `scopes` method on each Reflectioneileencodes2017-01-301-5/+47
| | | | | | | | | | | | | | | | | | | | Each reflection should be responsible for returning the scopes needed to query against the db.
* | | | Merge pull request #27787 from y-yagi/show_correct_class_name_in_migration_errorRafael França2017-01-301-1/+1
|\ \ \ \ | | | | | | | | | | show correct class name in migration inherited directly error
| * | | | show correct class name in migration inherited directly erroryuuji.yaginuma2017-01-241-1/+1
| | | | | | | | | | | | | | | | | | | | Follow up to 249f71a
* | | | | Merge pull request #27847 from jaredbeck/patch-6Rafael França2017-01-301-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Docs: Specify return value of `save!`
| * | | | | Docs: Specify return value of `save!`Jared Beck2017-01-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I can never remember if it returns `self` or `true` (seems to be `true`) [ci skip]
* | | | | | Merge pull request #27743 from jordanlewis/simplify-postgres-column-definitionsRafael França2017-01-301-5/+5
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Simplify query in column_definitions() for Postgres
| * | | | | Simplify Postgres query for column_definitions()Jordan Lewis2017-01-301-5/+5
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | column_definitions() needs to fetch the collation for every column, if present. Previously, it did so using a correlated subquery - a subquery that references results from the outer scope. This patch updates the query to remove the subquery in favor of a simpler and more efficient JOIN clause. Running the two queries through EXPLAIN against Postgres additionally shows that the original form with a correlated subquery requires a Nested Loop Left Join, while the new form with a simple JOIN can use a more efficient Merge Left Join.
* | | | | Merge pull request #27773 from kirs/serialized-error-attributeRafael França2017-01-303-6/+7
|\ \ \ \ \ | |/ / / / |/| | | | Report the attribute on ActiveRecord::SerializationTypeMismatch
| * | | | Report the attribute on ActiveRecord::SerializationTypeMismatchKir Shatrov2017-01-293-6/+7
| |/ / /
* / / / Missing require "active_support/multibyte/chars"Akira Matsuda2017-01-271-0/+1
|/ / / | | | | | | | | | this probably fixes #25840
* / / move `db_migrate_path` method to `Migration` moduleyuuji.yaginuma2017-01-223-16/+8
|/ / | | | | | | | | Since `Migration` module is included in both `MigrationGenerator` and `ModelGenerator`, no need to define a common method for each class.
* | Deprecate `initialize_schema_migrations_table` and ↵Ryuta Kamizono2017-01-203-7/+7
| | | | | | | | | | | | `initialize_internal_metadata_table` These internal initialize methods are no longer used internally.
* | Revert "Merge pull request #27718 from kamipo/remove_internal_public_methods"Matthew Draper2017-01-203-3/+13
| | | | | | | | | | This reverts commit 39c77eb1843f79925c7195e8869afc7cb7323682, reversing changes made to 9f6f51be78f8807e18fc6562c57af2fdbf8ccb56.
* | Merge pull request #27384 from matthewd/bigint-pk-tweaksMatthew Draper2017-01-205-9/+7
|\ \ | | | | | | Tweak bigint PK handling
| * | Tweak bigint PK handlingMatthew Draper2017-01-185-9/+7
| | | | | | | | | | | | | | | | | | * Don't force PKs on tables that have explicitly opted out * All integer-like PKs are autoincrement unless they have an explicit default
* | | Remove `initialize_schema_migrations_table` and ↵Ryuta Kamizono2017-01-183-13/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | `initialize_internal_metadata_table` internal public methods These internal methods accidentally appeared in the doc, and so almost useless. It is enough to create these internal tables directly, and indeed do so in several places. https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/schema.rb#L55 https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/railties/databases.rake#L6 https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/tasks/database_tasks.rb#L230
* | Merge pull request #27674 from kjg/migration_generator_honor_path_configAndrew White2017-01-172-2/+18
|\ \ | | | | | | Generate migrations at path set by `config.paths["db/migrate"]`
| * | Generate migrations at path set by `config.paths["db/migrate"]`Kevin Glowacz2017-01-162-2/+18
| | |
* | | SQLite: Foreign Key SupportRyuta Kamizono2017-01-173-3/+34
|/ / | | | | | | https://www.sqlite.org/foreignkeys.html
* | Translate Foreign Key violation to the specific exception for SQLite3 adapterRyuta Kamizono2017-01-161-0/+21
| | | | | | | | | | | | Raise `ActiveRecord::InvalidForeignKey` when a record cannot be inserted or updated because it references a non-existent record for SQLite3 adapter.
* | Revert "Don't guard against `touch: []`."Kasper Timm Hansen2017-01-151-1/+2
| | | | | | | | | | | | | | | | | | | | `timestamp_attributes_for_updates_in_model` returns an empty array when a model has no `updated_at` or `updated_on`. So my previously thought uncommon case is a lot more likely now. This reverts commit a0a1ede8c2eb6436571eae8778033162d1f9dcc3.
* | Merge pull request #27618 from kamipo/fix_uuid_default_nilKasper Timm Hansen2017-01-151-1/+1
|\ \ | | | | | | Fix UUID primary key with default nil in legacy migration
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-08 08:42:32 +0000