Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | change method name to reflect what it actually does. | Aaron Patterson | 2013-05-20 | 1 | -2/+2 |
| | |||||
* | save the where values in variables so we don't need to look them up all | Aaron Patterson | 2013-05-20 | 1 | -4/+5 |
| | | | | the time | ||||
* | pass where values to the helper function rather than rely on internal state | Aaron Patterson | 2013-05-20 | 1 | -4/+4 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-05-19 | 7 | -10/+42 |
|\ | |||||
| * | copy edits[ci skip] | Vijay Dev | 2013-05-19 | 2 | -12/+9 |
| | | |||||
| * | Added some more documentation for define_readers and define_writer of the ↵ | aditya-kapoor | 2013-05-15 | 3 | -0/+15 |
| | | | | | | | | Association and its inherited classes | ||||
| * | Added some more documentation for ↵ | aditya-kapoor | 2013-05-15 | 1 | -0/+11 |
| | | | | | | | | ActiveRecord::Associations::Builder::Association class | ||||
| * | Added documentation for ActiveRecord::Associations::Builder::Association class | aditya-kapoor | 2013-05-15 | 1 | -0/+4 |
| | | |||||
| * | improved doc for ActiveRecord#find_by_sql method (Refs #10599) [ci skip] | Anton Kalyaev | 2013-05-14 | 1 | -3/+4 |
| | | |||||
| * | Added documentation for model migration generation | aditya-kapoor | 2013-05-14 | 1 | -0/+4 |
| | | |||||
| * | emphasize that callbacks are called in destroy_all | Neeraj Singh | 2013-05-13 | 2 | -7/+7 |
| | | | | | | | | | | | | | | Cleaned up rdoc a bit emphasizing that callbacks are called. Also removed the stress on the fact that records are always removed. If callbacks return false then records will not be deleted. | ||||
* | | stop swallowing exceptions in assert_queries. Methods that raise an | Aaron Patterson | 2013-05-17 | 1 | -2/+2 |
| | | | | | | | | | | exception are unlikely to pass this assertion, but since the assertions raise an exception, the original exception is lost. | ||||
* | | stop doing assingments in an iterator | Aaron Patterson | 2013-05-17 | 1 | -2/+6 |
| | | |||||
* | | include bind values from the default scope | Aaron Patterson | 2013-05-17 | 1 | -2/+4 |
| | | |||||
* | | let Ruby do the is_a check for us | Aaron Patterson | 2013-05-16 | 1 | -3/+4 |
| | | |||||
* | | Add more data to AR::UnknownAttributeError | Bogdan Gusiev | 2013-05-16 | 2 | -1/+10 |
| | | | | | | | | | | | | | | | | | | begin Topic.new("hello" => "world") rescue ActiveRecord::UnknownAttributeError => e e.record # => #<Topic ... > e.attribute # => "hello" end | ||||
* | | Merge pull request #10619 from alno/top_level_array_in_postgres_json | Aaron Patterson | 2013-05-16 | 2 | -1/+3 |
|\ \ | | | | | | | Support array as root element in Postgresql JSON columns | ||||
| * | | Support array as root element in JSON | Alexey Noskov | 2013-05-14 | 2 | -1/+3 |
| | | | |||||
* | | | Check if APP_RAKEFILE is defined | Piotr Sarnacki | 2013-05-16 | 1 | -1/+1 |
| | | | |||||
* | | | Fix detection of engine in rake db:load_config | Joel Cogen | 2013-05-16 | 1 | -1/+1 |
| | | | | | | | | | | | | Broken by d1d7c86d0c8dcb7e75a87644b330c4e9e7d6c1c1 | ||||
* | | | tiny types should only be integers when the length is <= 1. fixes #10620 | Aaron Patterson | 2013-05-15 | 1 | -3/+9 |
| | | | |||||
* | | | require things we need | Aaron Patterson | 2013-05-15 | 1 | -0/+1 |
| | | | |||||
* | | | Also support extensions in PostgreSQL 9.1, because this has been supported ↵ | kennyj | 2013-05-15 | 1 | -4/+4 |
| | | | | | | | | | | | | since 9.1. | ||||
* | | | deprecating string based terminators | Aaron Patterson | 2013-05-14 | 1 | -1/+3 |
|/ / | |||||
* | | Merge pull request #10556 from Empact/deprecate-schema-statements-distinct | Rafael Mendonça França | 2013-05-12 | 1 | -1/+2 |
| | | | | | | | | | | | | Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc. Conflicts: activerecord/CHANGELOG.md | ||||
* | | Some editorial changes on the documentation. | Rafael Mendonça França | 2013-05-12 | 2 | -27/+27 |
|/ | | | | | | | | * Remove some autolinks * Fix the rendered result * Change sql to SQL [ci skip] | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-05-12 | 4 | -4/+12 |
|\ | | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb | ||||
| * | copy edits [ci skip] | Vijay Dev | 2013-05-12 | 1 | -5/+1 |
| | | |||||
| * | Added documentation for ↵ | aditya-kapoor | 2013-05-10 | 1 | -0/+4 |
| | | | | | | | | ActiveRecord::Generators::MigrationGenerator.next_migration_number | ||||
| * | Added documentation for ActiveRecord::Base#next_migration_number | aditya-kapoor | 2013-05-09 | 1 | -0/+5 |
| | | |||||
| * | minor rdoc cleanup for reflection methods | Neeraj Singh | 2013-05-09 | 1 | -4/+4 |
| | | |||||
| * | added to rdoc for unscope that default_scope wins | Neeraj Singh | 2013-05-03 | 1 | -0/+3 |
| | | |||||
* | | Adding documentation to the automatic inverse_of finder. | wangjohn | 2013-05-11 | 2 | -1/+22 |
| | | |||||
* | | Call assume_migrated_upto_version on connection | Kyle Stevens | 2013-05-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | Call assume_migrated_upto_version on connection to prevent it from first being picked up in method_missing. In the base class, Migration, method_missing expects the argument to be a table name, and calls proper_table_name on the arguments before sending to connection. If table_name_prefix or table_name_suffix is used, the schema version changes to prefix_version_suffix, breaking `rake test:prepare`. Fixes #10411. | ||||
* | | Merge pull request #10567 from ↵ | Rafael Mendonça França | 2013-05-11 | 1 | -1/+2 |
|\ \ | | | | | | | | | | | | | neerajdotname/read_attribute_before_type_cast_should_accept_symbol read_attribute_before_type_cast should accept symbol | ||||
| * | | read_attribute_before_type_cast should accept symbol | Neeraj Singh | 2013-05-11 | 1 | -1/+2 |
| | | | |||||
* | | | Merge pull request #10572 from nertzy/dont-modify-options-hash-in-primary-key | Rafael Mendonça França | 2013-05-11 | 1 | -2/+1 |
|/ / | | | | | | | Don't modify args in TableDefinition#primary_key | ||||
* | | Extract JoinDependency#join_relation to DRY the repeated application of the ↵ | Ben Woosley | 2013-05-10 | 3 | -7/+9 |
| | | | | | | | | #join_associations. | ||||
* | | In #apply_join_dependency, we can apply the #where in-place because relation ↵ | Ben Woosley | 2013-05-10 | 1 | -1/+1 |
| | | | | | | | | | | | | is always a new object. Thanks to the #except we call at the top of the method. | ||||
* | | DRY-up join dependency creation by extracting construct_join_depdency | Ben Woosley | 2013-05-10 | 1 | -7/+5 |
| | | |||||
* | | Pull the excepts into apply_join_dependency, for the sake of DRY. | Ben Woosley | 2013-05-10 | 1 | -3/+4 |
| | | |||||
* | | Simplify conditions within apply_join_dependency | Ben Woosley | 2013-05-10 | 1 | -9/+5 |
| | | |||||
* | | Move the except(:select) inside the construct_limited_ids_condition method ↵ | Ben Woosley | 2013-05-10 | 1 | -2/+2 |
| | | | | | | | | to pair it closely with its motivation. | ||||
* | | Reject blank order_values within #columns_for_distinct, as the orders aren't ↵ | Ben Woosley | 2013-05-10 | 2 | -3/+3 |
| | | | | | | | | used at all on non-postgres adapters. | ||||
* | | Move #proxy_association method to AssociationRelation | Jon Leighton | 2013-05-10 | 3 | -4/+6 |
| | | |||||
* | | Merge pull request #6792 from Empact/postgres-distinct | Jon Leighton | 2013-05-10 | 3 | -12/+15 |
|\ \ | | | | | | | Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT" | ||||
| * | | Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT" | Ben Woosley | 2013-05-10 | 3 | -12/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The combination of a :uniq => true association and the #distinct call in #construct_limited_ids_condition combine to create invalid SQL, because we're explicitly selecting DISTINCT, and also sending #distinct on to AREL, via the relation#distinct_value. Rather than build a select distinct clause in #construct_limited_ids_condition, I set #distinct! and pass just the columns into the select statement. This requires introducing a #columns_for_distinct method to return the select columns but not the statement itself. | ||||
* | | | Don't try to EXPLAIN select_db calls | Daniel Schierbeck | 2013-05-10 | 1 | -1/+1 |
| | | | |||||
* | | | Set the inverse when association queries are refined | Jon Leighton | 2013-05-10 | 3 | -1/+20 |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Suppose Man has_many interests, and inverse_of is used. Man.first.interests.first.man will correctly execute two queries, avoiding the need for a third query when Interest#man is called. This is because CollectionAssociation#first calls set_inverse_instance. However Man.first.interests.where("1=1").first.man will execute three queries, even though this is obviously a subset of the records in the association. This is because calling where("1=1") spawns a new Relation object from the CollectionProxy object, and the Relation has no knowledge of the association, so it cannot set the inverse instance. This commit solves the problem by making relations spawned from CollectionProxies return a new Relation subclass called AssociationRelation, which does know about associations. Records loaded from this class will get the inverse instance set properly. Fixes #5717. Live commit from La Conf! :sparkles: | ||||
* | | extracted piece of code into a method | Neeraj Singh | 2013-05-08 | 1 | -13/+12 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to fix #10421 I need to enable merge to take an option so that relations could be merged without making the last where condition to win. That fix would forever reside in 4-0-stable branch and would not be merged to master since using scope without lambda has been deprecated. In this commit I have extracted code into a method and I think it makes code look better. Hence the request to merge it in both master and 4-0-stable. If there is any concern then this code can be merged only in 4-0-stable and that would be fine too. |