aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Started implementing nested :through associations by using the existing ↵Jon Leighton2010-10-013-19/+47
| | | | structure of ThroughAssociationScope rather than layering a module over the top
* Merge branch 'master' into nested_has_many_through_2Jon Leighton2010-09-3019-166/+139
|\
| * Fix 'rake db:create' is ignore encoding when using postgres [#5717 ↵yalab2010-09-301-1/+1
| | | | | | | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * Added config.app_generators to allow configuring application's generators ↵Piotr Sarnacki2010-09-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from railties. With config.generators becomes a way to configure generators for current instance only. For example: module Blog class Engine < Rails::Engine config.generators do |g| g.orm :active_record end config.app_generators do |g| g.test_framework :rspec end end end such definition sets :active_record as orm for engine and :rspec as test_framework for application. The values set with app_generators can be overwritten in application using config.generators as you would normally do: module MyApp class Application < Rails::Application config.generators do |g| g.test_framework :test_unit end end end
| * double negative is not goodNeeraj Singh2010-09-301-1/+1
| |
| * no need of nil checkNeeraj Singh2010-09-291-1/+1
| |
| * eliminating method_missing on TableDefinitionAaron Patterson2010-09-291-14/+6
| |
| * DRY up postgresql quote logicAaron Patterson2010-09-291-11/+14
| |
| * fixing where clause indentationAaron Patterson2010-09-291-4/+4
| |
| * use consistent method calls for column inspectionAaron Patterson2010-09-291-1/+1
| |
| * require pg when this adapter is loadedAaron Patterson2010-09-291-5/+4
| |
| * only reopen ConnectionAdapters onceAaron Patterson2010-09-291-2/+0
| |
| * use inheritence to deal with custom methodsAaron Patterson2010-09-292-10/+20
| |
| * just use if rather than nil?Aaron Patterson2010-09-291-1/+1
| |
| * just require sqlite3 when the database adapter is requiredAaron Patterson2010-09-291-4/+1
| |
| * removing more useless code! yay!Aaron Patterson2010-09-281-6/+2
| |
| * SqlLiteral is a string, so we can dry up these conditionalsAaron Patterson2010-09-281-4/+3
| |
| * shorten up or sql literal creation statementsAaron Patterson2010-09-281-4/+2
| |
| * we only care about arrays and stringsAaron Patterson2010-09-281-1/+1
| |
| * dry up calls to arel.join()Aaron Patterson2010-09-281-5/+4
| |
| * removing unused lasgnsAaron Patterson2010-09-281-4/+4
| |
| * refactoring to remove crazy logicAaron Patterson2010-09-282-9/+6
| |
| * where_values_hash always returns a hashAaron Patterson2010-09-281-1/+1
| |
| * performance improvement based on discussion at ↵Neeraj Singh2010-09-281-9/+3
| | | | | | | | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion
| * Revert "porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks ↵Aaron Patterson2010-09-281-1/+1
| | | | | | | | | | | | Marcelo Giorgi" This reverts commit 9eca11a4a564f44675cca951216e917b8f610eab.
| * removing a conditional that is not usedAaron Patterson2010-09-281-2/+0
| |
| * fisting the postgresql testsAaron Patterson2010-09-281-1/+2
| |
| * Set attributes properly for model built from association with conditions ↵Marcelo Giorgi2010-09-282-9/+14
| | | | | | | | | | | | [#5562 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * each works well tooAaron Patterson2010-09-281-1/+1
| |
| * no need for splat and flattenAaron Patterson2010-09-281-1/+1
| |
| * avoid calling to_sql when we canAaron Patterson2010-09-282-4/+4
| |
| * removing an inject + merge in favor of Hash#[]Aaron Patterson2010-09-281-1/+1
| |
| * Test add_index and remove_index with a symbol name #4891Étienne Barrié2010-09-281-4/+3
| |
| * porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks Marcelo ↵Aaron Patterson2010-09-281-1/+1
| | | | | | | | Giorgi
| * use new skool Ruby instead of Ruby Classic™Aaron Patterson2010-09-271-5/+3
| |
| * be kind to the garbage collector: only instantiate objects when absolutely ↵Aaron Patterson2010-09-271-14/+17
| | | | | | | | necessary
| * constructor should not do so much work; avoid allocating object if possibleAaron Patterson2010-09-271-10/+5
| |
| * @klass also uses DynamicFinderMatch, so no need for it on the relationAaron Patterson2010-09-271-9/+0
| |
| * no need for a case / when statementAaron Patterson2010-09-271-11/+7
| |
| * do not need intermediate variable, avoid lasgnAaron Patterson2010-09-271-2/+3
| |
| * DRY up our regular expressionAaron Patterson2010-09-271-3/+3
| |
| * reduce method calls in the dynamic finder matcherAaron Patterson2010-09-271-4/+4
| |
| * make sure we use the engine assigned to the table when quotingAaron Patterson2010-09-271-1/+1
| |
| * Fix for nested_attributes with has_many association fails when a single ↵Neeraj Singh2010-09-271-1/+6
| | | | | | | | | | | | | | | | record is being updated. [#5705 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Merge remote branch 'miloops/warnings'José Valim2010-09-271-3/+3
| |\ | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb
| | * Prevent shadowing outer local variable.Emilio Tagua2010-09-271-3/+3
| | |
| * | Three performance improvements:Neeraj Singh2010-09-271-10/+9
| |/ | | | | | | | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation
| * third parameter is not usedAaron Patterson2010-09-261-1/+1
| |
| * db:structure:dump should list current Rails.env adapter in errors, not ↵Nic Benders2010-09-261-1/+1
| | | | | | | | | | | | | | | | always the test adapter [#5710 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * Fix remove_index issue when provided :name is a symbolTim Connor2010-09-261-1/+1
| | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>