aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | :counter_cache option for to support custom named counter caches. Closes #7993Yves Senn2012-11-043-2/+5
| | | |
* | | | Delegate all calculations to the scope.Jon Leighton2012-11-092-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | So that the scope may be a NullRelation and return a result without executing a query. Fixes #7928
* | | | CollectionProxy#pluck issues no query for a new_record? ownerJon Leighton2012-11-091-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #8102. I couldn't find a nicer way to deal with this than delegate the call to #scope, which will be a NullRelation when we want it to be.
* | | | Nullify the relation at a more general level.Jon Leighton2012-11-093-7/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to avoid hacks like the "return 0 if owner.new_record?" in #count (which this commit removes). Also, the relevant foreign key may actually be present even on a new owner record, in which case we *don't* want a null relation. This logic is encapsulated in the #null_scope? method. We also need to make sure that the CollectionProxy is not 'infected' with the NullRelation module, or else the methods from there will override the definitions in CollectionProxy, leading to incorrect results. Hence the nullify: false option to CollectionAssociation#scope. (This feels a bit nasty but I can't think of a better way.)
* | | | Relations built off collection associations with an unsaved owner should be ↵Jon Leighton2012-11-091-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | null relations For example, the following should not run any query on the database: Post.new.comments.where(body: 'omg').to_a # => [] Fixes #5215.
* | | | Remove not used indifferent_access requires from Base and FinderMethodsCarlos Antonio da Silva2012-11-072-3/+0
| | | |
* | | | Use cached quoted_table_name instead of going through the connectionCarlos Antonio da Silva2012-11-071-1/+1
| | | |
* | | | Remove block given check from private find_with_idsCarlos Antonio da Silva2012-11-071-2/+0
| | | | | | | | | | | | | | | | | | | | This is already handled by #find, it's a duplicate check, since find_with_ids is not called from anywhere else.
* | | | stop raising so many exceptionsAaron Patterson2012-11-071-1/+5
| | | |
* | | | adding requires for constant dependenciesAaron Patterson2012-11-072-0/+6
| | | |
* | | | Use flat_map when building AR orderCarlos Antonio da Silva2012-11-041-6/+4
|/ / /
* | | Check if the options value is present before to send the deprecationRafael Mendonça França2012-11-031-4/+6
| | | | | | | | | | | | message
* | | Remove old commentRafael Mendonça França2012-11-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This comment is not valid since that `if` is there to make possible to do: remove_index :users, :name Instead of: remove_index :users, column: :name What is a valid use case. [ci skip]
* | | Deprecate passing a string as third argument of `add_index`Rafael Mendonça França2012-11-021-0/+6
| | | | | | | | | | | | | | | | | | | | | This was there due historical reasons since 7dc45818dc43c163700efc9896a0f3feafa31138 to give the user the possibility to create unique indexes passing "UNIQUE" as the third argument
* | | Raise an ArgumentError when passing an invalid option to add_indexRafael Mendonça França2012-11-021-1/+4
| | | | | | | | | | | | Closes #8104
* | | Merge pull request #8106 from steveklabnik/fix_grammarCarlos Antonio da Silva2012-11-021-1/+1
|\ \ \ | |/ / |/| | Fixed grammar in migration pending error.
| * | Fixed grammar in migration pending error.Steve Klabnik2012-11-021-1/+1
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-11-0319-103/+161
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md
| * | copy edits [ci skip]Vijay Dev2012-11-031-6/+3
| | |
| * | This is comment for singular association.kennyj2012-11-021-1/+1
| | |
| * | update AR::ImmutableRelation documentation [ci skip]Francesco Rodriguez2012-10-261-0/+14
| | |
| * | fix a typo in comments to ActiveRecord::Associations::Association.stale_stateAndrii Dovgaliuk2012-10-241-1/+1
| | |
| * | Migration of docs to 1.9 hash syntaxAvnerCohen2012-10-238-54/+54
| | |
| * | Another batch of hash syntax changes to comment, this time around, I tried ↵AvnerCohen2012-10-233-26/+26
| | | | | | | | | | | | to keep 'output' messages untouched.
| * | Fixed typo on ActiveRecord nested_attributes.Luis M2012-10-231-3/+3
| | |
| * | Fix code example in AR::AttributeMethods::BeforeTypeCast.Hendy Tanata2012-10-221-1/+1
| | |
| * | Merge branch 'master' of https://github.com/lifo/docrailsPablo Ifran2012-10-2231-188/+414
| |\ \ | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/callbacks.rb
| | * | read_attribute is public [ci skip]Francesco Rodriguez2012-10-211-1/+1
| | | |
| | * | add docs to AR::AttributeMethods::BeforeTypeCast [ci skip]Francesco Rodriguez2012-10-211-0/+23
| | | |
| | * | improve AR::AttributeMethods documentation [ci skip]Francesco Rodriguez2012-10-211-6/+10
| | | |
| | * | fix typo and improve example [ci skip]Francesco Rodriguez2012-10-211-1/+3
| | | |
| | * | update AR::AttributeMethods::BeforeTypeCast docs [ci skip]Francesco Rodriguez2012-10-211-0/+18
| | | |
| | * | Fix AR::AttributeMethods#[] example [ci skip]Francesco Rodriguez2012-10-211-1/+1
| | | |
| | * | nodoc deprecated AR::Fixtures constant [ci skip]Francesco Rodriguez2012-10-211-0/+1
| | | |
| * | | Changeing some code-styles of the examples & fix a typo on dependent optionPablo Ifran2012-10-221-18/+12
| | | |
* | | | Fix issue with collection associations and first(n)/last(n)Carlos Antonio da Silva2012-11-011-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When calling first(n) or last(n) in a collection, Active Record was improperly trying to set the inverse of instance in case that option existed. This change was introduced by fdf4eae506fa9895e831f569bed3c4aa6a999a22. In such cases we don't need to do that "manually", since the way collection will be loaded will already handle that, so we just skip setting the inverse association when any argument is given to first(n)/last(n). The test included ensures that these scenarios will have the inverse of instance set properly. Fixes #8087, Closes #8094. Squashed cherry-pick from d37d40b and c368b66. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/associations/collection_association.rb
* | | | Revert "Don't allocate new strings in compiled attribute methods"David Heinemeier Hansson2012-10-312-39/+20
| | | | | | | | | | | | | | | | This reverts commit f1765019ce9b6292f2264b4601dad5daaffe3a89.
* | | | Fix find_in_batches against string IDs when start option is not specified.Alexis Bernard2012-10-311-2/+2
| | | |
* | | | Fix `attributes_before_type_cast` for serialised attributes.Nikita Afanasenko2012-10-311-0/+10
| | | | | | | | | | | | | | | | Public method `attributes_before_type_cast` used to return internal AR structure (ActiveRecord::AttributeMethods::Serialization::Attribute), patch fixes this. Now behaves like `read_attribute_before_type_cast` and returns unserialised values.
* | | | Fix #6951. Use query cache/uncache, when using not only database.yml but ↵kennyj2012-10-311-6/+6
| | | | | | | | | | | | | | | | also DATABASE_URL.
* | | | include_root_in_json allows inheritance.kennyj2012-10-311-1/+0
| | | |
* | | | Make caller attribute in deprecation methods optionalAlexey Gaziev2012-10-309-14/+12
| | | |
* | | | Fix bug when Column is trying to type cast boolean values to integer.Rafael Mendonça França2012-10-291-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This can occur if the user is using :integer columns to store boolean values. Now we are handling the boolean values but it still raises if the value can't type cast to integer and is not a boolean. See #7509. Fixes #8067. Conflicts: activerecord/CHANGELOG.md
* | | | Provide a call stack for deprecation warnings where needed.Nikita Afanasenko2012-10-299-17/+21
| | | | | | | | | | | | | | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
* | | | SQLite3Adapter#type_cast should not mutate argumentsStefan Rusterholz2012-10-281-1/+1
| | | |
* | | | ActiveRecord::Relation#none! method.Juanjo Bazán2012-10-281-0/+5
| | | |
* | | | Enable update_column(s) for the primary key attribute.Henrik N2012-10-281-1/+3
| | | | | | | | | | | | | | | | Didn't work before because it updated the model-in-memory first, so the DB query couldn't find the record.
* | | | raise `ArgumentError` when redefining the primary key column. Closes #6378Yves Senn2012-10-281-0/+9
| | | |
* | | | refactor `SQLite3Adapter#copy_table` to prevent primary key redefinitions. #6378Yves Senn2012-10-281-5/+3
| | | |
* | | | AR::AttributeMethods#[] raises AM::AttributeMissingError for missing attributes.Francesco Rodriguez2012-10-281-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following behaviour: class Person < ActiveRecord::Base belongs_to :company end # Before: person = Person.select('id').first person[:name] # => nil person.name # => ActiveModel::MissingAttributeError: missing_attribute: name person[:company_id] # => nil person.company # => nil # After: person = Person.select('id').first person[:name] # => ActiveModel::MissingAttributeError: missing_attribute: name person.name # => ActiveModel::MissingAttributeError: missing_attribute: name person[:company_id] # => ActiveModel::MissingAttributeError: missing_attribute: company_id person.company # => ActiveModel::MissingAttributeError: missing_attribute: company_id Fixes #5433.
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 08:00:22 +0000