aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | | | | | | | use a hash to store relation valuesJon Leighton2012-04-134-45/+67
|/ / / / / / / / / / / / / / /
* | | | | | | | | | | | | | | doesn't make sense for select! to take a blockJon Leighton2012-04-131-8/+3
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | remove apply_finder_options call from AssociationScopeJon Leighton2012-04-133-9/+10
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Make Relation#extending work like other value methodsJon Leighton2012-04-134-19/+13
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Add Relation#merge!Jon Leighton2012-04-131-9/+12
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | assert valid keysJon Leighton2012-04-132-0/+7
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Allow Relation#merge to take a hashJon Leighton2012-04-133-47/+75
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | we have no need for the ASSOCIATION_METHODS constantJon Leighton2012-04-133-7/+10
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | refactoringJon Leighton2012-04-131-36/+45
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Extract clusterfuck method for surgeryJon Leighton2012-04-132-71/+92
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | mention that coercion only happens when the primary key is an integer and ↵Reg Braithwaite2012-04-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use +to_i+ formatting
* | | | | | | | | | | | | | | Documents that ActiveRecord's find by id uses to_i to coerce its arguments ↵Reg Braithwaite2012-04-121-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to integers
* | | | | | | | | | | | | | | Add bang versions of relation query methods.Jon Leighton2012-04-121-84/+135
|/ / / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The main reason for this is that I want to separate the code that does the mutating from the code that does the cloning.
* | | | | | | | | | | | | | Some refactor for association.kennyj2012-04-123-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove unused association_class method. * Remove a unnecessary assignment. * Move @updated to BelongsToAssociation that only reference this instance variable. * Reset @stale_state at the reset method. I think this place is right place.
* | | | | | | | | | | | | | move apply_finder_options to active_record_deprecated_findersJon Leighton2012-04-121-22/+0
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | add active_record_deprecated_finders as a depJon Leighton2012-04-121-0/+1
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge pull request #5720 from kennyj/should_use_klass_methodJon Leighton2012-04-111-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Get a properly aliased_table_name, when we use a polymorphic association.
| * | | | | | | | | | | | | | Get a properly aliased_table_name, when we use a polymorphic association.kennyj2012-04-041-1/+1
| | |/ / / / / / / / / / / / | |/| | | | | | | | | | | |
* | | | | | | | | | | | | | Override AR::Relation methods in NullRelation.Juanjo Bazán2012-04-111-0/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So a NullRelation (Relation#none) is chainable with database methods.
* | | | | | | | | | | | | | Corrected grammatical errors in schema_dumper and scoping/defaultdcurtis2012-04-102-2/+2
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Fix delete_all when chained with joins.Rafael Mendonça França2012-04-103-16/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #5202 and #919
* | | | | | | | | | | | | | Merge pull request #5718 from benedikt/masterJeremy Kemper2012-04-082-6/+5
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes caching from ActiveRecord::Core::ClassMethods#relation
| * | | | | | | | | | | | | | Removes caching from ActiveRecord::Core::ClassMethods#relationBenedikt Deicke2012-04-032-6/+5
| |/ / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The #relation method gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone was ActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place. The four places with calls to relations are: activerecord/lib/active_record/scoping/default.rb:110:in `block in build_default_scope'" activerecord/lib/active_record/scoping/default.rb:42:in `unscoped'" activerecord/lib/active_record/scoping/named.rb:38:in `scoped'" activerecord/lib/active_record/scoping/named.rb:52:in `scope_attributes'"
* | / / / / / / / / / / / / fix markup error [ci skip]Vijay Dev2012-04-081-1/+1
| |/ / / / / / / / / / / / |/| | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #5716 from jurriaan/tr-gsub-cleanupSantiago Pastorino2012-04-042-3/+3
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated/changed unneeded tr/gsubs
| * | | | | | | | | | | | | Updated/changed useless tr/gsubsJurriaan Pruis2012-04-032-3/+3
| |/ / / / / / / / / / / /
* | | | | | | | | | | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-04-041-3/+3
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/engines.textile
| * | | | | | | | | | | | | Remove unnecessary articles.Waseem Ahmad2012-04-031-3/+3
| |/ / / / / / / / / / / /
* | | | | | | | | | | | | DATABASE_URL allows omission of database.ymlTim Pope2012-04-031-1/+3
| | | | | | | | | | | | |
* | | | | | | | | | | | | use File.binread to pull in the schema cacheAaron Patterson2012-04-031-1/+1
|/ / / / / / / / / / / /
* | | | | | | | | | | | Fix #5667. Preloading should ignore scoping.Jon Leighton2012-03-301-2/+3
| | | | | | | | | | | |
* | | | | | | | | | | | clear up duplication between Persistence#destroy and Locking#destroyJon Leighton2012-03-302-27/+34
| | | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #5334 from courtland/masterJon Leighton2012-03-301-0/+2
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Fix deleting from a HABTM join table upon destroying an object of a model with optimistic locking enabled.
| * | | | | | | | | | | | Fix deleting from a HABTM join table upon destroying an object of a model ↵Nick Rogers2012-03-071-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with optimistic locking enabled. Issue #5332.
* | | | | | | | | | | | | Add Relation#find_by and Relation#find_by!Jon Leighton2012-03-302-0/+20
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #2945 from Casecommons/nested_attributes_moduleJon Leighton2012-03-301-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nested attribute setters can be overridden.
| * | | | | | | | | | | | | Nested attribute setters can be overridden.Jonathan Mukai & Peter Jaros2012-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Overriding implementation can call super.
* | | | | | | | | | | | | | recurse in read_attribute we get caching / don't duplicate codeJon Leighton2012-03-301-3/+2
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Deprecate Column#type_cast_codeCarlos Antonio da Silva2012-03-291-0/+4
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Properly typecast id attribute when using custom primary keyCarlos Antonio da Silva2012-03-291-1/+4
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Add ActiveRecord::Base#slice to slice method callsGuillermo Iguaran2012-03-291-0/+6
| |_|/ / / / / / / / / / / |/| | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #4843 from seamusabshere/patch-1Xavier Noria2012-03-281-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | | | | | | | | | | | Possibly clearer way of getting rid of ` and "
| * | | | | | | | | | | | thanks to @jurriaanSeamus Abshere2012-02-141-1/+1
| | | | | | | | | | | | |
| * | | | | | | | | | | | Possibly clearer way of getting rid of ` and " Seamus Abshere2012-02-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Incidentally it's also faster... >> a = 'hello "id` world'; Benchmark.realtime { 500_000.times { a.tr('`"', "") } } => 0.7388770580291748 >> a = 'hello "id` world'; Benchmark.realtime { 500_000.times { a.gsub(/[`"]/, "") } } => 1.7843739986419678
* | | | | | | | | | | | | much code can be deleted thanks to @tenderlove's refactoringJon Leighton2012-03-283-72/+6
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #5616 from cbartlett/migration-indentSantiago Pastorino2012-03-271-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix indenting in migration generator
| * | | | | | | | | | | | | Fix indenting in migration generatorColin Bartlett2012-03-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | $ rails generate migration remove_foo_from_bars foo:string This currently generates: def up remove_column :bars, :foo end Fix it: def up remove_column :bars, :foo end
* | | | | | | | | | | | | | Remove Arel::Relation constant from PredicateBuilder.Juanjo Bazán2012-03-271-2/+2
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | attributes are cached by string keys, so to_s to support symbols. fixes #5549Aaron Patterson2012-03-271-1/+1
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-03-272-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / / |/| | | | | | | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-11 07:04:48 +0000