aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | only cache the primary key column in one placeAaron Patterson2013-06-131-1/+1
| | | | |
| * | | | these methods are never called, so remove themAaron Patterson2013-06-131-8/+0
| | | | |
| * | | | This test does not test anything that happens in the real world. If youAaron Patterson2013-06-131-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recreate the models without mucking with internal caches of the relation objects, then the test fails. For example: class Man < ActiveRecord::Base has_many :interests end class Interest < ActiveRecord::Base belongs_to :man end Then do this test: def test_validate_presence_of_parent_fails_without_inverse_of repair_validations(Interest) do Interest.validates_presence_of(:man) assert_no_difference ['Man.count', 'Interest.count'] do man = Man.create(:name => 'John', :interests_attributes => [{:topic=>'Cars'}, {:topic=>'Sports'}]) assert_not_predicate man.errors[:"interests.man"], :empty? end end end The test will fail. This is a bad test, so I am removing it.
| * | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-06-145-29/+94
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md
| | * | | | copy edits [ci skip]Vijay Dev2013-06-141-19/+15
| | | | | |
| | * | | | doc: renaming table name to follow the file's standardsThiago Pinto2013-06-081-2/+2
| | | | | |
| | * | | | instructions for variations and alternatives for ActiveRecord#findThiago Pinto2013-06-081-1/+35
| | | | | |
| | * | | | explaining ActiveRecord#first in rails 3 and 4Thiago Pinto2013-06-081-0/+13
| | | | | |
| | * | | | lists the options for find_each and find_in_batchesThiago Pinto2013-06-071-17/+37
| | | | | |
| | * | | | using Model.all.find_each in rails 3 raises an error and should not be ↵Thiago Pinto2013-06-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | recommended
| | * | | | minor comments cleanupNeeraj Singh2013-05-271-3/+4
| | | | | |
| | * | | | enhanced comments for foreign_key_present? methodNeeraj Singh2013-05-231-3/+4
| | | | | |
| | * | | | update_counters accepts a hash, not an array of hashesMichael Kozono2013-05-211-1/+1
| | | | | |
| * | | | | oops. step away from the keyboard aaron. :cry:Aaron Patterson2013-06-131-1/+1
| | | | | |
| * | | | | fix caching of automatic inverse of. :bomb:Aaron Patterson2013-06-131-1/+3
| | | | | |
| * | | | | let the object stay in charge of internal cache invalidationAaron Patterson2013-06-132-13/+6
| | | | | |
| * | | | | reduce automatic_inverse_of caching logicAaron Patterson2013-06-131-30/+16
| | | | | |
| * | | | | active_record should always be set. Do or do not, there is no tryAaron Patterson2013-06-131-1/+1
| | | | | |
| * | | | | push ambiguous reflection warning down to reflection name calculationAaron Patterson2013-06-131-23/+28
| | | | | |
| * | | | | clean up ivar assignmentAaron Patterson2013-06-131-3/+2
| | | | | |
| * | | | | Ambiguous reflections are on :through relationships are no longer supported.Aaron Patterson2013-06-131-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example, you need to change this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end To this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts, :source => :tagging end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end
| * | | | | Merge pull request #10425 from ↵Rafael Mendonça França2013-06-134-38/+47
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation
| | * | | | | Moving add_column_options! up to SchemaCreationjeran2013-06-124-38/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax.
| * | | | | | sometimes singularize does not work, so we get a list of two strings. just ↵Aaron Patterson2013-06-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | uniq them
| * | | | | | no need to cache hash lookupsAaron Patterson2013-06-121-1/+1
| | | | | | |
| * | | | | | split aggregates from association reflections to avoid is_a checks laterAaron Patterson2013-06-121-5/+11
| | | | | | |
| * | | | | | remove unnecessary is_a checkAaron Patterson2013-06-121-2/+1
| | | | | | |
| * | | | | | we should apply the default scope before queryingAaron Patterson2013-06-121-1/+2
| | | | | | |
| * | | | | | bind values should not be merged between scopesAaron Patterson2013-06-111-1/+1
| | | | | | |
| * | | | | | stop adding a new method for touch callbacksAaron Patterson2013-06-111-29/+21
| | | | | | |
| * | | | | | push the touch method outside the evalAaron Patterson2013-06-111-13/+34
| | | | | | |
| * | | | | | remove unused variableAaron Patterson2013-06-111-1/+0
| | | | | | |
| * | | | | | check whether the association is constructible rather than checking constantsAaron Patterson2013-06-111-3/+3
| | | | | | |
| * | | | | | use attribute methods for finding key values rather than generating method namesAaron Patterson2013-06-111-3/+3
| | | | | | |
| * | | | | | push belongs_to counter cache method to a single methodAaron Patterson2013-06-111-17/+18
| | | | | | |
| * | | | | | push before_destroy counter cache method to a single methodAaron Patterson2013-06-111-12/+17
| | | | | | |
| * | | | | | remove evaled belongs_to counter cache methodAaron Patterson2013-06-111-8/+22
| | | | | | |
| * | | | | | adding callbacks should be privateAaron Patterson2013-06-111-4/+6
| | | | | | |
| * | | | | | remove evals from the associationAaron Patterson2013-06-111-8/+2
| | | | | | |
| * | | | | | reduce evals in depdendent associationsAaron Patterson2013-06-111-1/+2
| | | | | | |
| * | | | | | Remove fall back and column restrictions for `count`.Yves Senn2013-06-091-10/+6
| | | | | | |
| * | | | | | cleanup whitespace in relation.rbYves Senn2013-06-091-1/+1
| | | | | | |
| * | | | | | Getting rid of the +automatic_inverse_of: false+ option in associations in favorwangjohn2013-06-085-14/+19
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | of using +inverse_of: false+ option. Changing the documentation and adding a CHANGELOG entry for the automatic inverse detection feature.
| * | | | | Revert "Merge pull request #10539 from davidcelis/ar-sql-improvements"Jon Leighton2013-06-071-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 257fa6897d9c85da16b7c9fcb4ae3008198d320e, reversing changes made to 94725b81f5588e4b0f43222c4f142c3135941b4b. The build failed https://travis-ci.org/rails/rails/builds/7883546
| * | | | | ActiveRecord::Relation#blank? should `LIMIT 1`David Celis2013-06-071-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an SQL improvement to ActiveRecord::Relation#blank?. Currently, it calls `to_a` on the Relation, which loads all records in the association, and calls `blank?` on the loaded Array. There are other ways, however, to check the emptiness of an association that are far more performant. `#empty?`, `#exists?` and `#any?` all attach a `LIMIT 1` to the SQL query before firing it off, which is a nice query improvement. `#blank?` should do the same! Bonus performance improvements will also happen for `#present?`, which merely calls the negation of `#blank?` Signed-off-by: David Celis <me@davidcel.is>
| * | | | | Merge pull request #10561 from Empact/nix-throwresultJon Leighton2013-06-074-21/+21
| |\ \ \ \ \ | | |_|_|_|/ | |/| | | | Rather than raising ThrowResult when construct_limited_ids_conditions comes up empty, set the relation to NullRelation and rely on its results.
| | * | | | Rather than raising ThrowResult when construct_limited_ids_conditions comes ↵Ben Woosley2013-05-103-21/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | up empty, set the relation to NullRelation and rely on its results. This will help avoid errors like 2fcafee250ee2, because in most cases NullRelation will do the right thing. Minor bonus is avoiding the use of exceptions for flow control.
| | * | | | Make NullRelation a bit more like a real relation by returning 0 for ↵Ben Woosley2013-05-101-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | #calculate(:count)
| | * | | | No point in memoizing a simple literal string.Ben Woosley2013-05-101-1/+1
| | | | | |
| | * | | | Fix that #pluck wasn't rescuing ThrowResult, meaning it would blow up when ↵Ben Woosley2013-05-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | failing to construct_limited_ids_condition.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 05:14:54 +0000