aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Merge pull request #14513 from senny/pg/responsible_oidRafael Mendonça França2014-04-012-101/+91
| |\ \ | | | | | | | | PostgreSQL determine `Column#type` through corresponding OID. #7814
| | * | PostgreSQL determine `Column#type` through corresponding OID. #7814Yves Senn2014-04-012-101/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I ran the whole test suite and compared the old to the new types. Following is the list of types that did change with this patch: ``` DIFFERENT TYPE FOR mood: NEW: enum, BEFORE: DIFFERENT TYPE FOR floatrange: NEW: floatrange, BEFORE: float ``` The `floatrange` is a custom type. The old type `float` was simply a coincidence form the name `floatrange` and our type-guessing.
| * | | Merge pull request #14546 from ↵Aaron Patterson2014-03-311-1/+1
| |\ \ \ | | | | | | | | | | | | | | | | | | | | eileencodes/fix_delete_all_to_not_use_IN_statement Fix delete all to not produce sql in statement
| | * | | fix delete_all to remove records directlyeileencodes2014-03-311-1/+1
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When delete_all is run on a CollectionProxy and has a dependency of delete_all the SQL that is produced has an IN statement. (DELETE FROM `associated_model` where `associated_model` .`parent_id` = 1 AND `associated_model`.`id` IN (1, 2, 3...)). This only happens if the association is not loaded (both loaded and non-loaded delete_all should behave the same. This is a huge problem when it comes to deleting many records because the query becomes very slow. Instead the SQL produced should be (DELETE FROM `assoicated_model` where `associated_model`.`parent_model_id`=1). I fixed this by making sure the check for loaded and destroy also makes sure that the dependent is not delete_all, so the conditional goes to the else and deletes the records directly without the IN statement.
| * | | Merge pull request #14532 from thedarkone/polymorphic-preload-fixAaron Patterson2014-03-312-30/+13
| |\ \ \ | | |/ / | |/| | Fix polymorphic preloads on NOT NULL _type columns
| | * | Simplify Preloader#grouped_records code.thedarkone2014-03-302-21/+13
| | | | | | | | | | | | | | | | | | | | | | | | The new method relies on AR::Associations::Association knowing about both reflection and a model class. AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
| | * | Fix polymorphic preloads on NOT NULL _type columns.thedarkone2014-03-301-10/+1
| | | | | | | | | | | | | | | | Defer to Association#klass instead of having a custom/duplicate code.
| * | | refactor, put `PostgreSQLColumn` into `column.rb`.Yves Senn2014-03-312-218/+222
| | | | | | | | | | | | | | | | | | | | We have `connection_adapters/column.rb` so it's easier to remember that the column in in a separate file.
| * | | fix mysql buildsLuke Steensen2014-03-301-1/+1
| | | |
| * | | fix bug on non empty defaults for pg array columnsLuke Steensen2014-03-302-2/+8
| | | | | | | | | | | | | | | | fixes #10613
| * | | No need to call to_symRafael Mendonça França2014-03-301-2/+2
| |/ / | | | | | | | | | It is already called inside type_to_sql method.
| * | Merge pull request #14526 from chancancode/fix_ar_equalityXavier Noria2014-03-292-2/+2
| |\ \ | | | | | | | | Ensure we are returning either `true` or `false` for `#==`
| | * | Ensure we are returning either `true` or `false` for `#==`Godfrey Chan2014-03-292-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | 460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
| * | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-03-291-1/+5
| |\ \ \ | | |/ / | |/| |
| | * | Update documentation on group method to indicate it takes an arrayEarl St Sauver2014-03-171-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The group method also takes an array, however this isn't immediately clear by reading the source since it delegates this method. If you trace it back to the AREL building you can see that it does support an array. Shoutout to @betovelandia for pointing this out.
| | * | Fix misspelling in references docsSteven Harman2014-03-141-1/+1
| | | |
| * | | Replace trivial regexp with string or index, twice as fastKelley Reynolds2014-03-282-2/+2
| | | |
| * | | Merge pull request #14154 from al2o3cr/issue12770Aaron Patterson2014-03-272-4/+4
| |\ \ \ | | | | | | | | | | Pass a base relation to build_default_scope when joining
| | * | | Pass a base relation to build_default_scope when joiningMatt Jones2014-02-212-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | This allows the default scope to be built using the current table alias. Resolves #12770
| * | | | Merge pull request #14469 from tiegz/timestamp_inheritance_fixRafael Mendonça França2014-03-271-1/+1
| | | | | | | | | | | | | | | | | | | | Swap Timestamp/Callbacks order in ActiveRecord::Base
| * | | | AR .persisted? throws SystemStackError for an unsaved model with achrisfinne2014-03-271-1/+1
| | | | | | | | | | | | | | | | | | | | custom primary_key that didn't save due to validation error
| * | | | ActiveRecord/ActiveModel '#validate' alias for 'valid?'Henrik Nyh2014-03-271-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
| * | | | Remove unused methodRafael Mendonça França2014-03-261-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This method is not being called anywhere in our code and a GitHub search show it is not being used in any project.
| * | | | No need to gsub the stringRafael Mendonça França2014-03-261-1/+1
| | | | |
| * | | | Don't use send when we own the methodRafael Mendonça França2014-03-262-35/+35
| | | | |
| * | | | Make method privateRafael Mendonça França2014-03-261-5/+6
| | | | |
| * | | | Improve the methodRafael Mendonça França2014-03-261-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call
| * | | | Remove unneeded comments about feature support on the adaptersRafael Mendonça França2014-03-261-20/+9
| | | | | | | | | | | | | | | | | | | | | | | | | These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters
| * | | | Invert the conditionals to make easier to readRafael Mendonça França2014-03-261-4/+4
| | | | | | | | | | | | | | | | | | | | Also improve some of the code conventions
| * | | | Fixes bugs for using indexes in CREATE TABLE by adding checks for table ↵Steve Rice2014-03-252-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | existence Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
| * | | | create indexes inline in CREATE TABLE for MySQLCody Cutrer2014-03-253-11/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
| * | | | Merge pull request #14390 from huoxito/true-touchRafael Mendonça França2014-03-251-0/+2
| |\ \ \ \ | | | | | | | | | | | | | | | | | | Still touch associations when theres no timestamp
| | * | | | Still touch associations when theres no timestampWashington Luiz2014-03-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to Rails 4.0.4 when touching a object which doesn't have timestamp attributes (updated_at / updated_on) rails would still touch all associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates associations but rollsback because `touch` would return nil since there's no timestamp attribute
| * | | | | Revert "Merge pull request #8313 from alan/only_save_changed_has_one_objects"Rafael Mendonça França2014-03-251-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
* | | | | | Merge branch 'master' into adequaterecordAaron Patterson2014-03-2514-78/+80
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (96 commits) clarify CHANGELOG [ci skip]. Fix Generation of proper migration when ActiveRecord::Base.pluralize_table_names = false. update comments to reflect that options support is not available synchronize changelogs and 4.1 release notes. [ci skip] do not rely on method_missing hitting arel use ARel factory methods for building AST nodes Fix date_select option overwriting html classes - Rename `increment_or_decrement` to an apt `set_cache_value` since it actually doesn't increment/decrement in localstore. Check if any sqlite files are not included in the gitignore Remove sqlite3 lines from .gitignore if the application is not using sqlite3. Adding active_model in Rails::Info Clean up tables after each test. Swapped parameters of assert_equal in assert_select Update test helper to use latest Digestor API Digestor should just rely on the finder to know about the format and the variant -- trying to pass it back in makes a mess of things (oh, and doesnt work) Log the full path, including variant, that the digestor is trying to find Fix for digestor to consider variants for partials -- this still needs more testing!! fix log_tags request object grammar Extract with_example_table into helper method. test for structure:dump without schema information table. refs eafec46 ... Conflicts: activerecord/test/cases/relation/where_chain_test.rb
| * | | | | Fix Generation of proper migration whenKuldeep Aggarwal2014-03-251-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Base.pluralize_table_names = false. Previously, generation a migration like this: rails g migration add_column_name_to_user name would not generating the correct table name. Fixes #13426.
| * | | | | Merge pull request #12955 from joshwilliams/masterYves Senn2014-03-201-0/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | Postgres schema: Constrain sequence search classid
| | * | | | | Postgres schema: Constrain sequence search classidJosh Williams2014-03-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pk_an_sequence_for query previously joined against pg_class's oid for rows in pg_depend, but pg_depend's objid may point to other system tables, such as pg_attrdef. If a row in one of those other tables coincidentally has the same oid as an (unrelated) sequence, that sequence name may be returned instead of the real one. This ensures that only the pg_depend entries pointing to pg_class are considered.
| * | | | | | Improve touch docs with extra attributes passed in [ci skip]Carlos Antonio da Silva2014-03-201-5/+7
| | | | | | |
| * | | | | | Merge pull request #14423 from yakko/persistence-touches-manyCarlos Antonio da Silva2014-03-201-2/+3
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord#touch should accept multiple attributes Conflicts: activerecord/CHANGELOG.md
| | * | | | | | ActiveRecord#touch should accept multiple attributes #14423Thiago Pinto2014-03-191-2/+3
| | |/ / / / /
| * / / / / / only dump schema information if migration table exists. Closes #14217Yves Senn2014-03-201-1/+2
| |/ / / / /
| * | | | | Reap connections based on owning-thread deathMatthew Draper2014-03-183-46/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. not a general timeout. Now, if a thread checks out a connection then dies, we can immediately recover that connection and re-use it. This should alleviate the pool exhaustion discussed in #12867. More importantly, it entirely avoids the potential issues of the reaper attempting to check whether connections are still active: as long as the owning thread is alive, the connection is its business alone. As a no-op reap is now trivial (only entails checking a thread status per connection), we can also perform one in-line any time we decide to sleep for a connection.
| * | | | | Teach PostgreSQLAdapter#reset! to actually resetMatthew Draper2014-03-181-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | It wasn't doing anything beyond clearing the statement cache.
| * | | | | `where.not` adds `references` for `includes`.Yves Senn2014-03-171-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Closes #14406.
| * | | | | Extend fixture label replacement to allow string interpolationEric Steele2014-03-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows fixtures to use their $LABEL as part of a string instead of limiting use to the entire value. mark: first_name: $LABEL username: $LABEL1973 email: $LABEL@$LABELmail.com users(:mark).first_name # => mark users(:mark).username # => mark1973 users(:mark).email # => mark@markmail.com
| * | | | | Obey `validate: false` option for habtmCarlos Antonio da Silva2014-03-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #14383.
| * | | | | Merge pull request #14387 from huoxito/touch-api-docArthur Nogueira Neves2014-03-141-2/+2
| |\ \ \ \ \ | | | | | | | | | | | | | | Update callbacks executed on AR::Base#touch [skip ci]
| | * | | | | Update callbacks executed on AR::Base#touch [skip ci]Washington Luiz2014-03-141-2/+2
| | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | As of https://github.com/rails/rails/pull/12031 after_commit and after_rollback are also executed
| * / / / / Allow custom JDBC urlsschneems2014-03-141-2/+2
| |/ / / / | | | | | | | | | | | | | | | mitigates #14323
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 14:42:59 +0000