Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't double assign attributes - closes #1467. | Andrew White | 2011-06-03 | 1 | -1/+0 |
| | |||||
* | Fix issue #1272 | Brian Mathiyakom | 2011-06-01 | 2 | -9/+8 |
| | | | | | Set reverse_order_value when asked to reverse_order(). Do the actual reversal in build_arel. | ||||
* | Raise NameError instead of ArgumentError in ActiveSupport::Dependencies | Andrew White | 2011-06-01 | 1 | -1/+0 |
| | | | | | | | | ActiveSupport::Dependencies now raises NameError if it finds an existing constant in load_missing_constant. This better reflects the nature of the error which is usually caused by calling constantize on a nested constant. Closes #1423 | ||||
* | added an alias for new to build to the AR collection proxy, this corrects an ↵ | Josh Kalderimis | 2011-06-01 | 2 | -10/+2 |
| | | | | issue where the collection proxies were not consistent | ||||
* | Revert "[activerecord][postgresql] verify if table has a schema(not ↵ | Jon Leighton | 2011-05-31 | 1 | -5/+6 |
| | | | | | | public)". This caused a test breakage. See #1410 for details. This reverts commit c44418ea4e09cc81da47edbc9ac5f31c7e32c1b4. | ||||
* | Ensure that calculations properly override the select value even if it's set ↵ | Jon Leighton | 2011-05-31 | 1 | -2/+2 |
| | | | | in the default scope. Fixes #1395. | ||||
* | Only save the record once when calling create! on a collection association. ↵ | Jon Leighton | 2011-05-31 | 4 | -25/+45 |
| | | | | Fixes #1360. | ||||
* | Implementing @dmathieu's cleaner fix from #1425. Unfortunately he deleted ↵ | Jon Leighton | 2011-05-31 | 1 | -8/+5 |
| | | | | the branch so I cannot just merge it. | ||||
* | Adding comment to work with 1.8.7. Nested Attribute fix. | Arun Agrawal | 2011-05-31 | 1 | -0/+3 |
| | |||||
* | Fix nested attribute for memory record. | Arun Agrawal | 2011-05-31 | 1 | -1/+5 |
| | |||||
* | Merge pull request #1410 from lucasts/pg_schema | Aaron Patterson | 2011-05-30 | 1 | -5/+11 |
|\ | | | | | a little step to better postgresql schema support in rails | ||||
| * | [activerecord][postgresql] verify if table has a schema(not public) | Lucas Stephanou | 2011-05-27 | 1 | -6/+5 |
| | | |||||
| * | find sequences with pg schemas properly | Lucas Stephanou | 2011-05-27 | 1 | -4/+11 |
| | | |||||
* | | Corrected some typos and American vs. Queen's English issues | Lee Reilly | 2011-05-29 | 3 | -3/+3 |
| | | |||||
* | | Merge pull request #1384 from amatsuda/simplify_drop_table | Aaron Patterson | 2011-05-28 | 3 | -10/+2 |
|\ \ | | | | | | | Remove unused options from drop_table | ||||
| * | | No need to pass options which is never used | Akira Matsuda | 2011-05-29 | 1 | -2/+2 |
| | | | |||||
| * | | No need to override for just calling super | Akira Matsuda | 2011-05-29 | 2 | -8/+0 |
| | | | |||||
* | | | Use change in place of up and down in sessions table migration | Vijay Dev | 2011-05-28 | 1 | -5/+1 |
|/ / | |||||
* | | stop using boolean expressions because of the side effects | Aaron Patterson | 2011-05-27 | 1 | -1/+4 |
| | | |||||
* | | Merge pull request #1365 from gnufied/sqlite3 | Aaron Patterson | 2011-05-27 | 2 | -2/+2 |
|\ \ | | | | | | | close statment only if its not closed | ||||
| * | | delegate connection and column_hash calls directly to model | Hemant Kumar | 2011-05-28 | 1 | -1/+1 |
| | | | |||||
| * | | close statment only if its not closed | Hemant Kumar | 2011-05-28 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #1229 from workmad3/master | Aaron Patterson | 2011-05-27 | 1 | -2/+4 |
|\ \ \ | |/ / |/| | | Fix for Issue #1205 | ||||
| * | | Using .try to test for the existence of a method option in a nil-resistent ↵ | David Workman | 2011-05-23 | 1 | -5/+2 |
| | | | | | | | | | | | | manner. Inlined the determination of the options hash for reversing using a ternary operator. Shortens the method in a way that keeps the code neat | ||||
| * | | Neatened up the invert_add_index method as per suggeston | David Workman | 2011-05-23 | 1 | -2/+3 |
| | | | |||||
| * | | Simple fix for correctly inverting an add_index migration when a name has ↵ | David Workman | 2011-05-23 | 1 | -2/+6 |
| | | | | | | | | | | | | been provided | ||||
* | | | work around bug in the sqlite3 bindings. fixes #1289 | Aaron Patterson | 2011-05-27 | 1 | -0/+1 |
| |/ |/| | |||||
* | | Merge pull request #1323 from fx/association_primary_key | Jon Leighton | 2011-05-26 | 1 | -1/+1 |
|\ \ | | | | | | | use association_primary_key in AssociationScope#add_constraints | ||||
| * | | use association_primary_key in AssociationScope#add_constraints | Marian Rudzynski | 2011-05-26 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #1318 from TheEmpty/master | Jon Leighton | 2011-05-26 | 2 | -10/+0 |
|\ \ \ | | | | | | | | | Resolve issue #534 | ||||
| * | | | Removes the restriction on primary key when joining in a habtm && test that ↵ | Mohammad El-Abid | 2011-05-26 | 2 | -10/+0 |
| |/ / | | | | | | | | | | it was properly removed | ||||
* / / | Don't merge base opts into includes when serializing ARs | John Mileham | 2011-05-26 | 1 | -6/+2 |
|/ / | | | | | | | | | | | Conflicts: activerecord/lib/active_record/serialization.rb | ||||
* | | Merge branch 'master' of github.com:rails/rails | Xavier Noria | 2011-05-25 | 8 | -127/+4 |
|\ \ | |||||
| * \ | Merge pull request #1285 from joshk/remove_active_record_deprecations | Aaron Patterson | 2011-05-25 | 8 | -127/+4 |
| |\ \ | | | | | | | | | removed deprecated methods, and related tests, from ActiveRecord | ||||
| | * | | removed deprecated methods, and related tests, from ActiveRecord | Josh Kalderimis | 2011-05-25 | 8 | -127/+4 |
| | | | | |||||
* | | | | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-05-25 | 28 | -82/+86 |
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/core_ext/kernel/requires.rb | ||||
| * | | | Remove extra white spaces on ActiveRecord docs. | Sebastian Martinez | 2011-05-23 | 25 | -51/+51 |
| | | | | |||||
| * | | | has_many :dependent => :restrict raises an exception but is not documented ↵ | Aditya Sanghi | 2011-05-22 | 1 | -2/+4 |
| | | | | | | | | | | | | | | | | appropriately. has_one also has :dependent => :restrict but is not documented at all. | ||||
| * | | | Add more doc to #update_column. | Sebastian Martinez | 2011-05-20 | 1 | -0/+2 |
| | | | | |||||
| * | | | Changing examples: use 'each' instead of 'for in' | Guillermo Iguaran | 2011-05-19 | 1 | -4/+4 |
| | | | | |||||
| * | | | Remove extra white-spaces. | Sebastian Martinez | 2011-05-19 | 1 | -24/+24 |
| | | | | |||||
| * | | | Closes GH #1032 | John Paul Ashenfelter | 2011-05-19 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | Fixed what looks like minor cut/paste error in documentation for ActiveRecord::Locking:Pessimistic | ||||
* | | | | Fix the AR::Base#inspect method [closes #1294] | Franck Verrot | 2011-05-25 | 1 | -6/+10 |
| | | | | |||||
* | | | | Database.rake file fixed for load_generators | Arun Agrawal | 2011-05-25 | 1 | -2/+1 |
| |/ / |/| | | |||||
* | | | Everyone receives app as argument for consistency. | José Valim | 2011-05-25 | 1 | -2/+2 |
| | | | |||||
* | | | Fix infinite recursion where a lazy default scope references a scope. Fixes ↵ | Jon Leighton | 2011-05-25 | 2 | -4/+13 |
| | | | | | | | | | | | | #1264. | ||||
* | | | Merge pull request #1254 from pixeltrix/ignore-includes-in-through-scope | Jon Leighton | 2011-05-24 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Ignore :includes on through associations | ||||
| * | | | Ignore :includes on through associations | Andrew White | 2011-05-24 | 1 | -1/+1 |
| | | | | |||||
* | | | | Ensure that the surrounding code in Relation#to_a respects the default_scope ↵ | Jon Leighton | 2011-05-24 | 1 | -17/+24 |
| | | | | | | | | | | | | | | | | (as well as having Relation#arel respect the default scope). Fixes #1233. | ||||
* | | | | rescue record invalid exceptions and return false from the save method. ↵ | Aaron Patterson | 2011-05-24 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | fixes #796 |