Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Refactor to use flat_map | Carlos Antonio da Silva | 2013-07-23 | 1 | -3/+3 |
| | |||||
* | oops! | Aaron Patterson | 2013-07-23 | 1 | -1/+1 |
| | |||||
* | eliminate conditional in JoinHelper | Aaron Patterson | 2013-07-23 | 2 | -2/+2 |
| | |||||
* | acually get the actual source reflection :cry::gun: | Aaron Patterson | 2013-07-23 | 1 | -7/+14 |
| | |||||
* | stop relying on side effects of const_missing | Aaron Patterson | 2013-07-23 | 1 | -7/+7 |
| | |||||
* | add a specific factory method rather than using new | Aaron Patterson | 2013-07-23 | 9 | -13/+11 |
| | |||||
* | factory methods should not have side effects. | Aaron Patterson | 2013-07-23 | 3 | -8/+11 |
| | | | | Move model mutation to the methods that are called on the model. | ||||
* | extract mutation from generation method | Aaron Patterson | 2013-07-23 | 2 | -4/+6 |
| | |||||
* | habtm can only ever be an association reflection | Aaron Patterson | 2013-07-22 | 1 | -2/+4 |
| | |||||
* | use the predicate method | Aaron Patterson | 2013-07-22 | 1 | -1/+1 |
| | |||||
* | AR::Base does not need to know how to create reflection objects | Aaron Patterson | 2013-07-22 | 3 | -21/+21 |
| | |||||
* | remove unnecessary reader | Aaron Patterson | 2013-07-22 | 1 | -4/+4 |
| | |||||
* | only flatten one side | Aaron Patterson | 2013-07-22 | 1 | -1/+1 |
| | |||||
* | extend by adding relationships rather than monkey patching | Aaron Patterson | 2013-07-22 | 2 | -11/+13 |
| | |||||
* | decouple extensions from association object state | Aaron Patterson | 2013-07-22 | 2 | -3/+3 |
| | |||||
* | Uses mysql2 0.3.13 or later | kennyj | 2013-07-23 | 1 | -1/+1 |
| | |||||
* | Added some usage about ActiveRecord::Result [ci skip] | kennyj | 2013-07-23 | 1 | -2/+26 |
| | |||||
* | Defines the return type of select / select_all method. | kennyj | 2013-07-23 | 2 | -6/+3 |
| | |||||
* | Don't allow `quote_value` to be called without a column | Ben Woosley | 2013-07-22 | 1 | -2/+2 |
| | | | | | | | Some adapters require column information to do their job properly. By enforcing the provision of the column for this internal method we ensure that those using adapters that require column information will always get the proper behavior. | ||||
* | Tidy up the "Specified column type for quote_value" changes | Ben Woosley | 2013-07-22 | 1 | -1/+1 |
| | | | | | | This includes fixing typos in changelog, removing a deprecated mocha/setup test require, and preferring the `column_for_attribute` accessor over direct access to the columns_hash in the new code. | ||||
* | Specified column type for quote_value | Alfred Wong | 2013-07-22 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | When calling quote_value the underlying connection sometimes requires more information about the column to properly return the correct quoted value. I ran into this issue when using optimistic locking in JRuby and the activerecord-jdbcmssql-adapter. In SQLSever 2000, we aren't allowed to insert a integer into a NVARCHAR column type so we need to format it as N'3' if we want to insert into the NVARCHAR type. Unfortuantely, without the column type being passed the connection adapter cannot properly return the correct quote value because it doesn't know to return N'3' or '3'. This patch is fairly straight forward where it just passes in the column type into the quote_value, as it already has the ability to take in the column, so it can properly handle at the connection level. I've added the tests required to make sure that the quote_value method is being passed the column type so that the underlying connection can determine how to quote the value. | ||||
* | Merge pull request #11538 from vipulnsward/rescue-exp | Piotr Sarnacki | 2013-07-22 | 1 | -1/+1 |
|\ | | | | | rescue from all exceptions in `ConnectionManagement#call` | ||||
| * | rescue from all exceptions in `ConnectionManagement#call` | Vipul A M | 2013-07-22 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | Fixes #11497 As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError), the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other. Recueing from all exceptions and not just StandardError, fixes this behaviour. | ||||
* | | Revert "Merge pull request #11416 from tigrish/master" | Yves Senn | 2013-07-22 | 3 | -4/+4 |
|/ | | | | | This reverts commit 9dc8aef084fc5ae7e3a396dd098d89da93d06fda, reversing changes made to 02e8dae6279ea25312293a3eca777faf35139c4c. | ||||
* | Merge pull request #11416 from tigrish/master | Yves Senn | 2013-07-21 | 3 | -4/+4 |
|\ | | | | | Rename the I18n keys for associations' restrict_dependent_destroy errors | ||||
| * | Remove ambiguity with pluralizations and I18n keys used for association ↵ | Christopher Dell | 2013-07-13 | 3 | -4/+4 |
| | | | | | | | | restrict_dependent_destroy errors | ||||
* | | use the superclass implementation | Aaron Patterson | 2013-07-18 | 2 | -2/+4 |
| | | |||||
* | | Improve ActiveRecord::QueryMethods#includes docs | Henrik Hodne | 2013-07-17 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | It's not immediately clear whether you can pass in multiple relations or not. After going through the code a bit, I saw that the arguments are just appended to an array. Also, added nested relations example. [ci skip] | ||||
* | | Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting" | Yves Senn | 2013-07-17 | 2 | -6/+6 |
| | | | | | | | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366. | ||||
* | | parent_table is only used internally | Aaron Patterson | 2013-07-16 | 1 | -4/+4 |
| | | |||||
* | | decouple the manager class from building join constraints | Aaron Patterson | 2013-07-16 | 2 | -10/+11 |
| | | |||||
* | | cache the klass member of the reflection | Aaron Patterson | 2013-07-16 | 1 | -8/+10 |
| | | |||||
* | | cache the scope chain on the stack and eliminate `i` | Aaron Patterson | 2013-07-16 | 1 | -7/+4 |
| | | |||||
* | | just push on to the scope chain items. Oops! (thanks @carlosantoniodasilva) | Aaron Patterson | 2013-07-16 | 1 | -2/+1 |
| | | |||||
* | | use Relation#merge to combine scope chain items | Aaron Patterson | 2013-07-16 | 1 | -6/+6 |
| | | |||||
* | | make sure scope_chain_items has consistent types | Aaron Patterson | 2013-07-16 | 1 | -7/+9 |
| | | |||||
* | | removes the obsolete private method column_methods_hash [Closes #11406] | Xavier Noria | 2013-07-16 | 1 | -13/+0 |
| | | |||||
* | | Move initializing process for query cache to ↵ | kennyj | 2013-07-16 | 2 | -2/+6 |
| | | | | | | | | ActiveRecord::ConnectionAdapters::QueryCache module. | ||||
* | | Unifies mysql and mysql2 casting of booleans | awilliams | 2013-07-16 | 2 | -6/+6 |
| | | | | | | | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0. | ||||
* | | `change_column` for PG adapter respects `:array` option. | Yves Senn | 2013-07-16 | 1 | -2/+3 |
| | | |||||
* | | save another array allocation | Aaron Patterson | 2013-07-15 | 1 | -1/+1 |
| | | |||||
* | | removing useless assingment | Aaron Patterson | 2013-07-15 | 1 | -1/+1 |
| | | |||||
* | | reorder bind parameters when merging relations | Aaron Patterson | 2013-07-15 | 1 | -2/+18 |
| | | |||||
* | | use arel rather than slapping together SQL strings | Aaron Patterson | 2013-07-15 | 1 | -2/+4 |
| | | |||||
* | | Merge pull request #11451 from ↵ | Yves Senn | 2013-07-15 | 1 | -0/+1 |
|\ \ | | | | | | | | | | | | | jetthoughts/11450_do_not_resave_destroyed_association Do not re-save destroyed association on saving parent object | ||||
| * | | Do not re-save destroyed association on saving parent object | Paul Nikitochkin | 2013-07-15 | 1 | -0/+1 |
| | | | | | | | | | | | | Closes #11450 | ||||
* | | | Remove deprecation warning from attribute_missing | Arun Agrawal | 2013-07-15 | 1 | -14/+0 |
|/ / | | | | | for attributes that are columns. | ||||
* | | Merge pull request #11434 from jetthoughts/new_save_transaction_bugfix | Santiago Pastorino | 2013-07-14 | 1 | -3/+3 |
|\ \ | | | | | | | Remove extra decrement of transaction level | ||||
| * | | #4566: Remove extra decrement of transaction level | Paul Nikitochkin | 2013-07-14 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `rollback_active_record_state!` tries to restore model state on `Exception` by invoking `restore_transaction_record_state` it decrement deep level by `1`. After restoring it ensure that states to be cleared and level decremented by invoking `clear_transaction_record_state`, which cause the bug: because state already reduced in `restore_transaction_record_state`. Removed double derement of transaction level and removed duplicated code which clear transaction state for top level. | ||||
* | | | Merge pull request #11439 from ernie/only-scan-strings-for-nodes | Yves Senn | 2013-07-14 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Blacklist->whitelist for reference scans in order! |