aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Refactor configure_dependency_for_has_many to use ↵Jon Leighton2010-12-311-38/+20
| | | | AssociationCollection#delete_all. It was necessary to change test_before_destroy in lifecycle_test.rb so that it checks topic.replies.size *before* doing the destroy, as afterwards it will now (correctly) be 0.
* Make sure Model#touch doesn't try to update non existing columnsPratik Naik2010-12-301-1/+1
|
* Make serialized fixtures work againPratik Naik2010-12-291-1/+2
|
* Do not use primary key on insertion when it's nilSantiago Pastorino2010-12-291-2/+2
|
* Simplify inspect implementationSantiago Pastorino2010-12-281-1/+1
| | | | | After 304d38c0536dc32a8a1595ba34370ebf69a0d50d we don't need the new_record? check anymore.
* Allow primary_key to be an attribute when the model is a new recordSantiago Pastorino2010-12-282-3/+3
|
* I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2.Aaron Patterson2010-12-273-15/+3
|
* No need to symbolize these.José Valim2010-12-271-2/+4
|
* try not to make so many funcallsAaron Patterson2010-12-261-3/+6
|
* make our hash of klasses and ids actually have classes for keysAaron Patterson2010-12-261-8/+6
|
* Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵Jon Leighton2010-12-2610-52/+41
| | | | other things
* Add a HasAssociation module for common code for has_* associationsJon Leighton2010-12-268-61/+69
|
* Remove AssociationProxy#dependent? - it's badly named and only used in one placeJon Leighton2010-12-262-6/+1
|
* Associations: DRY up the code which is generating conditions, and make it ↵Jon Leighton2010-12-266-64/+50
| | | | all use arel rather than SQL strings
* Remove custom_select param from construct_select, as it isn't usedJon Leighton2010-12-261-3/+3
|
* Remove construct_from from ThroughAssociationScope - it's not called from ↵Jon Leighton2010-12-261-4/+0
| | | | anywhere
* Set the create scope to an empty hash in ThroughAssociationScope. For ↵Jon Leighton2010-12-261-1/+5
| | | | reasoning please see the inline code comments.
* Use conditionals and implicit returns rather than explicit returns and ↵Jon Leighton2010-12-261-3/+7
| | | | postfix ifs (it's easier to read)
* Remove has_cached_counter? and cached_counter_attribute_name from ↵Jon Leighton2010-12-261-8/+0
| | | | HasManyThroughAssociation, as the exact same methods are inherited from HasManyAssociation
* Remove pointless use of 'private'Jon Leighton2010-12-261-1/+0
|
* Use the through association proxy for operations on the through record, so ↵Jon Leighton2010-12-263-17/+17
| | | | that those operations are automatically scoped and therefore construct_join_attributes does not need to use construct_owner_attributes.
* Remove target_obsolete? which is not called from anywhereJon Leighton2010-12-261-4/+0
|
* scoped.where_values_hash is never nilJon Leighton2010-12-261-1/+1
|
* refactor to use group_byAaron Patterson2010-12-251-3/+3
|
* arel will deal with casting the ids, so we can delete thisAaron Patterson2010-12-251-13/+1
|
* use arel to determine selection columnAaron Patterson2010-12-251-2/+1
|
* refactoring method selectionAaron Patterson2010-12-251-10/+5
|
* using arel to compile sql statementsAaron Patterson2010-12-252-9/+19
|
* use sql literal factory methodAaron Patterson2010-12-251-1/+1
|
* take more advantage of arel sql compilerAaron Patterson2010-12-251-12/+20
|
* refactoring AST buildingAaron Patterson2010-12-251-5/+3
|
* use arel to compile SQL statementsAaron Patterson2010-12-251-6/+15
|
* stop redifining methods on every call to set_primary_keyAaron Patterson2010-12-241-4/+11
|
* use the sql literal factory methodAaron Patterson2010-12-241-1/+1
|
* stop the recursive insanityAaron Patterson2010-12-241-5/+10
|
* setting the primary key on the update managerAaron Patterson2010-12-241-0/+1
|
* Raise an error for associations which try to go :through a polymorphic ↵Jon Leighton2010-12-232-2/+12
| | | | association [#6212 state:resolved]
* If a has_many goes :through a belongs_to, and the foreign key of the ↵Jon Leighton2010-12-236-4/+36
| | | | belongs_to changes, then the has_many should be considered stale.
* Improved strategy for updating a belongs_to association when the foreign key ↵Jon Leighton2010-12-235-43/+32
| | | | changes. Rather than resetting each affected association when the foreign key changes, we should lazily check for 'staleness' (where fk does not match target id) when the association is accessed.
* Revert "Optimize <association>_ids for hm:t with belongs_to source". The ↵Jon Leighton2010-12-231-8/+1
| | | | | | | | | | optimisation has too many edge cases, such as when the reflection, source reflection, or through reflection has conditions, orders, etc. [#6153 state:resolved] This reverts commit 373b053dc8b99dac1abc3879a17a2bf8c30302b5. Conflicts: activerecord/lib/active_record/associations.rb
* When a has_many association is not :uniq, appending the same record multiple ↵Jon Leighton2010-12-232-3/+14
| | | | times should append it to the @target multiple times [#5964 state:resolved]
* Fix behaviour of foo.has_many_through_association.select('custom select') ↵Michał Łomnicki2010-12-231-2/+2
| | | | [#6089 state:resolved]
* Fix creation of has_many through records with custom primary_key option on ↵Szymon Nowak2010-12-231-1/+6
| | | | belongs_to [#2990 state:resolved]
* Don't allow a has_one association to go :through a collection association ↵Jon Leighton2010-12-232-0/+10
| | | | [#2976 state:resolved]
* avoid duping and new objectsAaron Patterson2010-12-231-2/+3
|
* fixed retrieval of primary key value in Ralation#insert methodRaimonds Simanovskis2010-12-231-1/+1
| | | | previously primary key value was always assigned nil which caused Oracle enhanced adapter failing tests
* arel can escape the id, so avoid using the database connectionAaron Patterson2010-12-221-1/+1
|
* Arel::Table#[] always returns an attribute, so no need for ||Aaron Patterson2010-12-221-1/+1
|
* probably should use the some_ids variable here. o_OAaron Patterson2010-12-221-1/+1
|
* removing SQL interpolation, please use scoping and attribute conditionals as ↵Aaron Patterson2010-12-221-6/+1
| | | | a replacement
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 14:37:48 +0000