aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix the indentationRafael Mendonça França2013-10-081-12/+13
|
* join parts in `build` are *always* new, so don't bother checkingAaron Patterson2013-10-081-1/+2
|
* stop looking up the reflection multiple timesAaron Patterson2013-10-081-6/+5
|
* cache join associations and join base on the stackAaron Patterson2013-10-081-4/+11
| | | | No reason to decompose the join objects on every iteration
* use the API rather than accessing underlying data structuresAaron Patterson2013-10-081-1/+1
|
* associations is always a hashAaron Patterson2013-10-081-19/+13
|
* keys are always symbolsAaron Patterson2013-10-081-2/+4
|
* we can get a list of reflections from the join parts, so let's removeAaron Patterson2013-10-081-3/+5
| | | | the @reflections ivar.
* transform the association input so we can avoid type checks later.Aaron Patterson2013-10-081-17/+31
| | | | | We should consider moving the input munging outside the class instantiation
* we know the keys are scalars, so avoid some typecheckingAaron Patterson2013-10-081-8/+12
|
* this method is only ever called with a reflectionAaron Patterson2013-10-081-6/+2
| | | | Stop typechecking the parameter. We know the type.
* don't access the reflections hashAaron Patterson2013-10-082-3/+7
| | | | The reflections hash is supposed to be private, so let's use the API.
* build association tree thing on demand.Aaron Patterson2013-10-081-6/+11
| | | | | `instantiate` is only called once, so there is no reason to cache the data structure on the instance and mutate itself.
* hide join_parts internals from other classesAaron Patterson2013-10-082-17/+17
|
* decouple JoinAssociation from JoinDependencyAaron Patterson2013-10-082-10/+5
|
* @associations can never have an array, so remove the dead codeAaron Patterson2013-10-081-4/+0
|
* typecast records returned from the db rather than to_sing everythingAaron Patterson2013-10-082-12/+21
|
* extract the string handling part to a method.Aaron Patterson2013-10-071-15/+15
| | | | | | We know the structure passed in to the `construct` method will be a hash, so we don't need to test it all the time. The key value will be a symbol or string, so handle it with the special method
* remove more dead codeAaron Patterson2013-10-071-2/+0
| | | | | We control the inputs to `construct`, so the wrong type shouldn't be passed in ever.
* this code is never used, remove itAaron Patterson2013-10-071-4/+0
|
* log the statement name along with the SQLAaron Patterson2013-10-042-6/+7
|
* log every sql statement, even when they errorAaron Patterson2013-10-041-25/+25
|
* prepare the statement inside the begin / rescue blockAaron Patterson2013-10-041-4/+4
|
* wrap logging around the actual query call itself.Aaron Patterson2013-10-042-50/+50
| | | | This is to be consistent with the way the mysql2 adapter times queries
* inject down the hash cacheAaron Patterson2013-10-031-3/+2
|
* hashes are ordered, so we do not need to sortAaron Patterson2013-10-031-3/+3
|
* Always pass parameters to `build`Aaron Patterson2013-10-031-2/+2
| | | | | We always know the parameters in advance, so we don't need to build it in to the method signature
* Set the join type on constructionAaron Patterson2013-10-032-6/+5
| | | | | We always set the join type immediately after construction, just make it part of the constructor and we can skip that step
* simplify the JoinAssociation constructor, check validity *before*Aaron Patterson2013-10-032-6/+6
|
* parent is always passed in, so make it non-optionalAaron Patterson2013-10-031-1/+1
|
* require the files we need so the classes are stand-aloneAaron Patterson2013-10-033-1/+4
|
* map the association chain to table namesAaron Patterson2013-10-031-4/+2
|
* fix the variable nameAaron Patterson2013-10-021-7/+7
|
* remove some duplicate codeAaron Patterson2013-10-021-8/+1
|
* remove HABTM associationsAaron Patterson2013-10-025-66/+0
|
* remove HABTM special cases from reflectionsAaron Patterson2013-10-021-14/+2
|
* remove the HABTM preloaderAaron Patterson2013-10-022-74/+0
|
* remove HABTM special cases from associations classesAaron Patterson2013-10-024-31/+1
|
* remove HABTM special cases from the fixturesAaron Patterson2013-10-021-12/+0
|
* repurpose the HABTM builder classAaron Patterson2013-10-022-29/+3
|
* goodbye has_and_belongs_to_many1, we will miss you!Aaron Patterson2013-10-021-4/+0
|
* keep track of the left and right reflections and expose thoseAaron Patterson2013-10-022-6/+6
|
* have the builder create the middle reflectionAaron Patterson2013-10-022-13/+15
|
* call the class method to define the callbacksAaron Patterson2013-10-021-1/+1
|
* Merge branch 'master' into habtmAaron Patterson2013-10-029-53/+71
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: we can define callbacks without a builder instance push methods that don't depend on the instance to the class get the name from the reflection cache the name and options on the stack decouple belongs_to callback definition from the builder instance. add_before_destroy_callbacks doesn't depend on the instance, so push it to the class. valid_options doesn't depend on the instance, so push it to the class use the information on the reflection to determine whether callbacks should be added Running all isolated test for actionview association builder is no longer needed for counter cache, so remove it push constructable? on to the reflection Adds the Rails maintenance policy to the Guides name is on the reflection, so just use the reflection decouple define_callback from the instance Added activemodel as a explicit dependency unify `Fixes` notes in AR changelog. [ci skip]. improving `reload` doc wording. #12418 [ci skip] Update AR reload doc for the case of manually set primary key attribute [ci skip]
| * we can define callbacks without a builder instanceAaron Patterson2013-10-024-9/+9
| |
| * push methods that don't depend on the instance to the classAaron Patterson2013-10-022-6/+6
| |
| * get the name from the reflectionAaron Patterson2013-10-021-1/+1
| |
| * cache the name and options on the stackAaron Patterson2013-10-021-1/+3
| |
| * decouple belongs_to callback definition from the builder instance.Aaron Patterson2013-10-021-4/+4
| | | | | | | | All the information is on the reflection, so just get it there.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 00:08:18 +0000