Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | document ActiveRecord's except and only | Jordi Romero | 2011-01-15 | 1 | -0/+14 | |
| | | | | | | | | Document methods that allow easily override arel queries | |||||
| * | Fix documentation for validates_uniqueness_of to NOT have a :scope argument ↵ | Ryan Bigg | 2011-01-06 | 1 | -3/+8 | |
| | | | | | | | | as the prime example. Show scope examples after prime example. | |||||
* | | we have a method for setting preloaded records, so use it | Aaron Patterson | 2011-01-18 | 1 | -6/+2 | |
| | | ||||||
* | | reduce objects, reduce loops and function calls while building the conditional | Aaron Patterson | 2011-01-18 | 1 | -4/+2 | |
| | | ||||||
* | | keys will always be strings in the id => record map | Aaron Patterson | 2011-01-18 | 1 | -1/+1 | |
| | | ||||||
* | | reduce method calls and loops when dealing with custom conditions | Aaron Patterson | 2011-01-18 | 1 | -4/+3 | |
| | | ||||||
* | | ony bother with record map keys when we need them | Aaron Patterson | 2011-01-18 | 1 | -9/+9 | |
| | | ||||||
* | | refactor elaborate group_by in to a normal group_by | Aaron Patterson | 2011-01-18 | 1 | -8/+3 | |
| | | ||||||
* | | remove unnecessary module_eval | Aaron Patterson | 2011-01-18 | 1 | -25/+20 | |
| | | ||||||
* | | remove useless conditional | Aaron Patterson | 2011-01-17 | 1 | -10/+8 | |
| | | ||||||
* | | Removed support for accessing attributes on a has_and_belongs_to_many join ↵ | Jon Leighton | 2011-01-16 | 2 | -68/+6 | |
| | | | | | | | | table. This has been documented as deprecated behaviour since April 2006. Please use has_many :through instead. A deprecation warning will be added to the 3-0-stable branch for the 3.0.4 release. | |||||
* | | Rename some variables | Jon Leighton | 2011-01-16 | 1 | -11/+11 | |
| | | ||||||
* | | Use self.target= in HasOneThroughAssociation too | Jon Leighton | 2011-01-16 | 1 | -4/+3 | |
| | | ||||||
* | | find_target can also go into SingularAssociation | Jon Leighton | 2011-01-16 | 3 | -8/+4 | |
| | | ||||||
* | | Abstract a bit more into SingularAssociation | Jon Leighton | 2011-01-16 | 3 | -4/+8 | |
| | | ||||||
* | | Use self.target= rather than @target= as the former automatically sets loaded | Jon Leighton | 2011-01-16 | 2 | -5/+2 | |
| | | ||||||
* | | Abstract common code from BelongsToAssociation and HasOneAssociation into ↵ | Jon Leighton | 2011-01-16 | 5 | -41/+43 | |
| | | | | | | | | SingularAssociation | |||||
* | | belongs_to records should be initialized within the association scope | Jon Leighton | 2011-01-16 | 1 | -2/+8 | |
| | | ||||||
* | | Document the new create_association! method on one-to-one associations | Jon Leighton | 2011-01-16 | 1 | -1/+9 | |
| | | ||||||
* | | Add create_association! for belongs_to | Jon Leighton | 2011-01-16 | 2 | -3/+7 | |
| | | ||||||
* | | push !loaded? conditional up | Aaron Patterson | 2011-01-14 | 1 | -10/+8 | |
| | | ||||||
* | | return early in case the left or right side lists are empty | Aaron Patterson | 2011-01-14 | 1 | -5/+4 | |
| | | ||||||
* | | only find_target can raise the exception, so isolate the rescue around that call | Aaron Patterson | 2011-01-14 | 1 | -5/+9 | |
| | | ||||||
* | | we always have a target, so stop checking | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | ||||||
* | | we should use [] instead of Array.new | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | ||||||
* | | @target is always a list, so stop doing is_a? checks | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | ||||||
* | | move complex logic to it's own method | Aaron Patterson | 2011-01-14 | 1 | -15/+19 | |
| | | ||||||
* | | loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵ | Aaron Patterson | 2011-01-14 | 1 | -4/+4 | |
| | | | | | | | | inside the conditional | |||||
* | | reduce funcalls by using falsey objects | Aaron Patterson | 2011-01-14 | 1 | -2/+2 | |
| | | ||||||
* | | write the delegate method directly to avoid `delegate` callstack overhead | Aaron Patterson | 2011-01-14 | 1 | -1/+5 | |
| | | ||||||
* | | reduce some lasigns | Aaron Patterson | 2011-01-14 | 1 | -2/+1 | |
| | | ||||||
* | | Arel::Table.engine will be deprecated, so stop using it | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | ||||||
* | | include_in_memory? should check against @target list in case of new records. ↵ | Aaron Patterson | 2011-01-12 | 1 | -2/+2 | |
| | | | | | | | | [#6257 state:resolved] | |||||
* | | use array maths rather than *args | Aaron Patterson | 2011-01-12 | 1 | -2/+4 | |
| | | ||||||
* | | just use return value of load_target | Aaron Patterson | 2011-01-12 | 1 | -2/+1 | |
| | | ||||||
* | | just call methods on return value of `load_target` | Aaron Patterson | 2011-01-12 | 1 | -8/+3 | |
| | | ||||||
* | | default return value is nil | Aaron Patterson | 2011-01-12 | 1 | -1/+0 | |
| | | ||||||
* | | @loaded is defined in initialize, so we should not need this | Aaron Patterson | 2011-01-12 | 1 | -2/+0 | |
| | | ||||||
* | | just use respond_to? and super rather than aliasing around methods | Aaron Patterson | 2011-01-12 | 2 | -5/+4 | |
| | | ||||||
* | | adding a test for no method error | Aaron Patterson | 2011-01-11 | 1 | -11/+5 | |
| | | ||||||
* | | use underlying _read_attribute method rather than causing NoMethodErrors | Aaron Patterson | 2011-01-11 | 1 | -1/+1 | |
| | | ||||||
* | | kill unused variable warnings | Aaron Patterson | 2011-01-11 | 1 | -1/+1 | |
| | | ||||||
* | | lazily instantiate AR objects in order to avoid NoMethodErrors | Aaron Patterson | 2011-01-11 | 2 | -17/+24 | |
| | | ||||||
* | | test_with_polymorphic_and_condition works without the conditions methods in ↵ | Jon Leighton | 2011-01-11 | 1 | -5/+0 | |
| | | | | | | | | BelongsToPolymorphicAssociation because the conditions are added straight to the association_scope as of a few days ago | |||||
* | | Support for create_association! for has_one associations | Jon Leighton | 2011-01-11 | 2 | -1/+5 | |
| | | ||||||
* | | Refactor the code for singular association constructors. This will allow me ↵ | Jon Leighton | 2011-01-11 | 1 | -8/+13 | |
| | | | | | | | | to define a create_association! method in a minute. | |||||
* | | It's not necessary to pass the association proxy class around now | Jon Leighton | 2011-01-11 | 1 | -22/+15 | |
| | | ||||||
* | | Get rid of set_association_target and association_loaded? as the parts of ↵ | Jon Leighton | 2011-01-11 | 4 | -20/+17 | |
| | | | | | | | | the code that need that can now just use association_proxy(:name).loaded?/target= | |||||
* | | We can use the association_proxy method directly in HasOneThroughAssociation now | Jon Leighton | 2011-01-11 | 2 | -20/+20 | |
| | | ||||||
* | | DRY up the code which instantiates the association proxy | Jon Leighton | 2011-01-11 | 2 | -35/+49 | |
| | |