| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | | | Don't require a DB connection when setting primary key. | Jon Leighton | 2011-09-26 | 2 | -1/+4 | |
| | | | | | | | | | | | | | | | | | Closes #2807. | |||||
| * | | | | Merge pull request #3030 from htanata/fix_habtm_select_query_method | Jon Leighton | 2011-09-26 | 1 | -4/+0 | |
| | | | | | | | | | | | | | | | | | Fix: habtm doesn't respect select query method | |||||
| * | | | | Fix belongs_to polymorphic with custom primary key on target. | Jon Leighton | 2011-09-26 | 3 | -17/+22 | |
| | | | | | | | | | | | | | | | | | Closes #3104. | |||||
| * | | | | CollectionProxy#replace should change the DB records rather than just ↵ | Jon Leighton | 2011-09-26 | 1 | -1/+1 | |
| |/ / / | | | | | | | | | | mutating the array. Fixes #3020. | |||||
| * | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-09-21 | 1 | -0/+29 | |
| |\ \ \ | ||||||
| | * | | | copy edits 908f2616 | Vijay Dev | 2011-09-20 | 1 | -4/+4 | |
| | | | | | ||||||
| | * | | | Document ActiveRecord::QueryMethods#select | Ryan Bigg | 2011-09-17 | 1 | -0/+29 | |
| | | | | | ||||||
| * | | | | to_xml should also rely on serializable hash. | José Valim | 2011-09-18 | 1 | -1/+1 | |
| |/ / / | ||||||
| * | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-09-15 | 2 | -1/+37 | |
| |\ \ \ | ||||||
| | * | | | minor edit | Vijay Dev | 2011-09-14 | 1 | -1/+1 | |
| | | | | | ||||||
| | * | | | Add documentation for the extending method in ActiveRecord:QueryMethods | Ryan Bigg | 2011-09-14 | 1 | -0/+36 | |
| | | | | | ||||||
| | * | | | [:class_name] option in belongs_to should mention belongs_to and not has_one | Erik Behrends | 2011-09-13 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Stop trying to be clever about when to define attribute methods. | Jon Leighton | 2011-09-14 | 1 | -10/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no meaningful performance penalty in defining attribute methods, since it only happens once. There is also no reason *not* to define them, since they get thrown in an included module, so they will not 'overwrite' anything. In fact, this is desirable, since it allows us to call super. | |||||
| * | | | | We don't need to build a set for DangerousAttributeError. | Jon Leighton | 2011-09-14 | 1 | -7/+13 | |
| | | | | | | | | | | | | | | | | | We can just use method_defined? and private_method_defined? | |||||
| * | | | | Rename first_or_new to first_or_initialize. | Jon Leighton | 2011-09-13 | 2 | -3/+2 | |
| |/ / / | | | | | | | | | | | | | For consistency with find_or_initialize_by. Also remove first_or_build alias. | |||||
| * | | | Deprecate using method_missing for attributes that are columns. | Jon Leighton | 2011-09-13 | 1 | -0/+15 | |
| | | | | | | | | | | | | | | | | | | | This shouldn't ever happen unless people are doing something particularly weird, but adding a deprecation in case there are bugs not caught by our tests. | |||||
| * | | | Let Ruby deal with method visibility. | Jon Leighton | 2011-09-13 | 1 | -7/+10 | |
| | | | | | | | | | | | | | | | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary. | |||||
| * | | | Always generate attribute methods on the base class. | Jon Leighton | 2011-09-13 | 2 | -6/+19 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class. | |||||
| * | | | Raise error when using write_attribute with a non-existent attribute. | Jon Leighton | 2011-09-13 | 4 | -6/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing. | |||||
| * | | | Fix warnings. | Jon Leighton | 2011-09-13 | 1 | -1/+1 | |
| | | | | | | | | | | | | | Make sure we don't redefine an already-defined attribute method. | |||||
| * | | | Add deprecation for doing `attribute_method_suffix ''` | Jon Leighton | 2011-09-13 | 1 | -2/+0 | |
| | | | | ||||||
| * | | | Alias id= if necessary, rather than relying on method_missing | Jon Leighton | 2011-09-13 | 1 | -0/+4 | |
| | | | | ||||||
| * | | | Merge pull request #2936 from joelmoss/migration_status | Santiago Pastorino | 2011-09-11 | 1 | -5/+7 | |
| | | | | | | | | | | | | | db:migrate:status not looking at all migration paths | |||||
| * | | | Merge pull request #2757 from andmej/first_or_create_pull_request | Jon Leighton | 2011-09-08 | 2 | -0/+44 | |
| |\ \ \ | | | | | | | | | Add first_or_create family of methods to Active Record | |||||
| | * | | | Using more precise method signatures for AR::Relation#first_or_create family ↵ | Andrés Mejía | 2011-09-06 | 1 | -6/+6 | |
| | | | | | | | | | | | | | | | | | of methods. | |||||
| | * | | | Adding first example with no arguments to AR::Relation#first_or_create and ↵ | Andrés Mejía | 2011-09-06 | 1 | -15/+15 | |
| | | | | | | | | | | | | | | | | | removing examples that create several users at the same time (this is confusing and not really helpful). | |||||
| | * | | | Adding first_or_create, first_or_create!, first_or_new and first_or_build to ↵ | Andrés Mejía | 2011-08-30 | 2 | -0/+44 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Record. This let's you write things like: User.where(:first_name => "Scarlett").first_or_create!(:last_name => "Johansson", :hot => true) Related to #2420. | |||||
| * | | | | LRU cache in mysql and sqlite are now per-process caches. | Aaron Patterson | 2011-09-07 | 2 | -21/+30 | |
| | | | | | ||||||
| * | | | | LRU should cache per process in postgresql. fixes #1339 | Aaron Patterson | 2011-09-07 | 1 | -10/+14 | |
| | | | | | ||||||
| * | | | | fixing view queries | Aaron Patterson | 2011-09-07 | 1 | -3/+5 | |
| | | | | | ||||||
| * | | | | use the supplied bind values | Aaron Patterson | 2011-09-07 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Merge commit 'refs/pull/2909/head' of https://github.com/rails/rails into rawr | Aaron Patterson | 2011-09-07 | 1 | -6/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | * https://github.com/rails/rails: Postgresql adapter: added current_schema check for table_exists? Postgresql adapter: added current_schema check for table_exists? | |||||
| * | | | | Don't include any of includes, preload, joins, eager_load in the through ↵ | Jon Leighton | 2011-09-07 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | association scope. | |||||
| * | | | | Merge pull request #2485 from akaspick/exists_fix | Jon Leighton | 2011-09-07 | 1 | -1/+3 | |
| |\ \ \ \ | | | | | | | | | | | fix exists? to return false if passed nil (which may come from a missing | |||||
| | * | | | | fix exists? to return false if passed nil (which may come from a missing URL ↵ | Andrew Kaspick | 2011-08-10 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | param) | |||||
| * | | | | | Merge pull request #2897 from rsutphin/ar31-remove_connection | Aaron Patterson | 2011-09-06 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | Patch for issue #2820 | |||||
| * | | | | | Database adapters use a statement pool. | Aaron Patterson | 2011-09-06 | 3 | -8/+46 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Database adapters use a statement pool for limiting the number of open prepared statments on the database. The limit defaults to 1000, but can be adjusted in your database config by changing 'statement_limit'. | |||||
| * | | | | | adding a statement pool for mysql and sqlite3 | Aaron Patterson | 2011-09-06 | 3 | -9/+102 | |
| | | | | | | ||||||
| * | | | | | Nested through associations: preloads from the default scope of a through ↵ | Jon Leighton | 2011-09-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | model should not be included in the association scope. (We're already excluding includes.) Fixes #2834. | |||||
| * | | | | | Ensure we are not comparing a string with a symbol in ↵ | Jon Leighton | 2011-09-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be. | |||||
| * | | | | | Make the logic easier to read | Jon Leighton | 2011-09-06 | 1 | -4/+7 | |
| | | | | | | ||||||
| * | | | | | Merge pull request #2716 from jbbarth/fix_invert_rename_index | Aaron Patterson | 2011-09-05 | 1 | -1/+1 | |
| |\ \ \ \ \ | | | | | | | | | | | | | Fix bad options order in AR::Migration::CommandRecorder#invert_rename_index | |||||
| | * | | | | | Fixed bad options order in ↵ | jbbarth | 2011-08-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Migration::CommandRecorder#invert_rename_index | |||||
| * | | | | | | Don't find belongs_to target when the foreign_key is NULL. Fixes #2828 | Georg Friedrich | 2011-09-05 | 1 | -0/+4 | |
| | | | | | | | ||||||
| * | | | | | | Use LIMIT sql word in last when it's possible | Damien Mathieu | 2011-09-05 | 1 | -1/+5 | |
| | | | | | | | ||||||
| * | | | | | | use LIMIT SQL word in first - Closes #2783 | Damien Mathieu | 2011-09-05 | 1 | -1/+1 | |
| | | | | | | | ||||||
| * | | | | | | We need to recorder here. Need to drop the order from default scope. | Arun Agrawal | 2011-09-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | Fixes #2832 | |||||
| * | | | | | | Revert "Fixes bug in ActiveRecord::QueryMethods, #1697" | Jon Leighton | 2011-09-04 | 1 | -2/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0df27c98d982ec87d2fb48cfda82694eb267993e. Reverted due to failing test, see #2845. | |||||
| * | | | | | | restores the API docs of AR::Fixtures, made a quick pass over them, revises ↵ | Xavier Noria | 2011-09-03 | 1 | -368/+361 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | link in fixture template [closes #2840] | |||||
| * | | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-09-02 | 1 | -1/+1 | |
| |\ \ \ \ \ \ | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |